From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7271C433EF for ; Tue, 12 Apr 2022 07:00:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 153526B0078; Tue, 12 Apr 2022 03:00:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 102D66B007B; Tue, 12 Apr 2022 03:00:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE57F6B007D; Tue, 12 Apr 2022 03:00:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id DC6426B0078 for ; Tue, 12 Apr 2022 03:00:39 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AAD452160B for ; Tue, 12 Apr 2022 07:00:39 +0000 (UTC) X-FDA: 79347328998.06.FF7DE3E Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf20.hostedemail.com (Postfix) with ESMTP id 70D5F1C0002 for ; Tue, 12 Apr 2022 07:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649746838; x=1681282838; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=7ylCwKVWNSXBLS3JnfvV528nX7gUEq87FZmfPhU2/a8=; b=B1Ttb5BJmUHedTDMGhvV6Q3qB/5xixOaHErOaLolk+OheSnxX4aeDpoe UNkKZN4o2VL0dJF6aw/XpJwtlOkW8+RlDBJ3hzyP9pMQLFZQthHWo5YO+ D/2iI6xyfcIH487W1sHT5duKAmIOHu/GlxMkvvxFk/dKTHTVPZ+SS66Y5 4l13K4I5zA05g9y8zdup4gUqGP0zwZ+8NGwo0rNsdg47uCqRJ3H4U4o6D fA1LIis0SLE0b+uGnL3xLyQ6crMS/goEmk/keFctSl7cLBcxNQx+IzK6Y pP9cqVrAfrtRzXOJOgynRWIm/Ak4VFjvnWB438+Ob5XFOcPJLxLsGUkOm A==; X-IronPort-AV: E=McAfee;i="6400,9594,10314"; a="244177113" X-IronPort-AV: E=Sophos;i="5.90,253,1643702400"; d="scan'208";a="244177113" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2022 00:00:35 -0700 X-IronPort-AV: E=Sophos;i="5.90,253,1643702400"; d="scan'208";a="572619329" Received: from joliu-mobl2.ccr.corp.intel.com ([10.254.214.243]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2022 00:00:25 -0700 Message-ID: Subject: Re: [PATCH 0/4] A few cleanup and fixup patches for migration From: "ying.huang@intel.com" To: Miaohe Lin Cc: mike.kravetz@oracle.com, shy828301@gmail.com, willy@infradead.org, ziy@nvidia.com, minchan@kernel.org, apopple@nvidia.com, dave.hansen@linux.intel.com, o451686892@gmail.com, jhubbard@nvidia.com, peterx@redhat.com, naoya.horiguchi@nec.com, mhocko@suse.com, riel@redhat.com, osalvador@suse.de, david@redhat.com, sfr@canb.auug.org.au, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Date: Tue, 12 Apr 2022 15:00:22 +0800 In-Reply-To: <880376f0-f480-979b-261f-72cf9475474c@huawei.com> References: <20220409073846.22286-1-linmiaohe@huawei.com> <880376f0-f480-979b-261f-72cf9475474c@huawei.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: pskfptfhw5sh59mnuhiqcrt36gh3wcax Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=B1Ttb5BJ; spf=none (imf20.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 70D5F1C0002 X-HE-Tag: 1649746837-272359 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2022-04-12 at 11:29 +0800, Miaohe Lin wrote: > On 2022/4/12 10:25, ying.huang@intel.com wrote: > > On Sat, 2022-04-09 at 15:38 +0800, Miaohe Lin wrote: > > > Hi everyone, > > > This series contains a few patches to remove unneeded lock page and > > > PageMovable check, reduce the rcu lock duration. Also we fix potential > > > pte_unmap on an not mapped pte. More details can be found in the > > > respective changelogs. Thanks! > > > > It appears that you ignored my comments for the previous version. Can > > you check it? > > I do remember [1] and I tried to make isolate_huge_page consistent with isolate_lru_page. > But their return value conventions are different. isolate_huge_page return 0 when > success while isolate_huge_page returns true in this case. So make them consistent > would lead to many code change. I should have added this in my changelog. I found that there are only 7 callers of isolate_huge_page(). It sounds like something that is still doable. Best Regards, Huang, Ying > Thanks. > > [1] https://lore.kernel.org/linux-mm/8735jsgctq.fsf@yhuang6-desk2.ccr.corp.intel.com/ > > > > > > Best Regards, > > Huang, Ying > > > > > --- > > > v1: > > >   rebase [1] on mainline. > > > > > > [1] https://lore.kernel.org/lkml/20220304093409.25829-2-linmiaohe@huawei.com/T/ > > > --- > > > Miaohe Lin (4): > > >   mm/migration: reduce the rcu lock duration > > >   mm/migration: remove unneeded lock page and PageMovable check > > >   mm/migration: return errno when isolate_huge_page failed > > >   mm/migration: fix potential pte_unmap on an not mapped pte > > > > > >  include/linux/migrate.h | 2 +- > > >  include/linux/swapops.h | 4 ++-- > > >  mm/filemap.c | 10 +++++----- > > >  mm/hugetlb.c | 2 +- > > >  mm/migrate.c | 31 +++++++++++++------------------ > > >  5 files changed, 22 insertions(+), 27 deletions(-) > > > > > > > > > > > . > > >