From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 928D4CD37BB for ; Wed, 4 Sep 2024 01:28:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CF6B8D020C; Tue, 3 Sep 2024 21:28:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 256D08D018A; Tue, 3 Sep 2024 21:28:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A9FA8D020C; Tue, 3 Sep 2024 21:28:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DE6398D018A for ; Tue, 3 Sep 2024 21:28:30 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9720080C38 for ; Wed, 4 Sep 2024 01:28:30 +0000 (UTC) X-FDA: 82525320780.25.16353DD Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf18.hostedemail.com (Postfix) with ESMTP id 851F41C0010 for ; Wed, 4 Sep 2024 01:28:28 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iyipobyh; spf=pass (imf18.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725413284; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZKcGcLiluE4oplvfFGxfWezTU3/P7wua4OuY0w4lgrQ=; b=ibKAn4uvIA1S4GS29irSiXQpYJXiRB5FuwBrz5C4s/t7aQmFIVaa/6l2V8xUJMp3AR+9IF EtDmM4B0bysGlF8N2ShP9Mi+jK1dK5+H7O8vVuKxhL0vO1G8msmAlSRf+7L06XZyYbO5RI U5S/YQpEE22xXWTC12ugIm2Mz5EQTDo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iyipobyh; spf=pass (imf18.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725413284; a=rsa-sha256; cv=none; b=h+SFqj764+6wqHAmbS4S9QMiDaABT/H3JcNXc+6lZko47mLHPxe2piDVUglzn2ht1Tn14I BN5KRaU2R9I/a9eZTX6PeM63bVZOhYQyaYHwFlZCqw9QqvMmsTmZf+C3TSGMJALJY0lkcr XQ4Y5W/iDwEFVLoUmpfsztSQ864gTfc= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-20688fbaeafso17138545ad.0 for ; Tue, 03 Sep 2024 18:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725413307; x=1726018107; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=ZKcGcLiluE4oplvfFGxfWezTU3/P7wua4OuY0w4lgrQ=; b=iyipobyhpZol5dP2FBBLli0bpcL2b3MSXg/i5w5WJzUlkq0WVBTe8pgiJ36JR4oRFH qh8J5TIUVclUkYTgBhjfbNrzD/86YLrqcG1ipor+vF6qJxnl+9yr+wKmrxRVbiz7nsiT Tp+wXYVg2dSuM9+x59UqeR6TuwPNrKIxYQLqBzBepx9BNueIl9C7BvUXdpKMI1l6zL65 6Lo+xQS7/PCTKrpo07zLVDcHlKeVAQOCfYvo55ZpTD7yB48EuuuhSBfsMVt57pGvfxgg lR7C+l22msORkBs2ayCHO2J3QLlpPPCWMv6Izix1PvmkohYa44tJ4FWRQ8IR/fuvPEg2 P/RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725413307; x=1726018107; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZKcGcLiluE4oplvfFGxfWezTU3/P7wua4OuY0w4lgrQ=; b=gsGnWHRWsAu0ec52dJiYmVmQ+Jpzx4fEviBwyVBhFkj5lrZocayWRvo+ewg1JEvRn9 z9OkvSsIII+M0AH5dJYxCgoFd12XPtykLPBycl2knuqpT3uDyFIi5ZmcllsJ/RtoXM7R 4kzDad1jXSzLyBimRmiAyVmZGawLk9yfcpOuJOPA8RZZoKlL51hUPBHqE7kp0pB/aEWz fT1JfKkNJiLVjb6sw1kORqxAUNsH+nHxD7jeWO+VBC17wzsZ75sKBR9s8hx4tf2Zf4kQ ndHoQZr0Xe9xeWcnvMTTSzxrQfKnPq2t3MU0wAZlrQZ7G5aMR40Sx1hWyApTWZKd3801 fTKQ== X-Forwarded-Encrypted: i=1; AJvYcCUa0tyFx/pK7QZsBxWm1sO+2Q/XUJ4ehJ96QdWIu4f4aN7H9/M9FsMr+klVWg98zdkiM4jDc5ypUA==@kvack.org X-Gm-Message-State: AOJu0YwNoGKw/yh6SUT7gBZoEqmwyEJ825dKNllXbCdFnHqaPW5n7lI8 N5mKJh2+uSf4WE1HgqLVJlfBNGre0FEdPqPup9Fhd7RlhwvH114T X-Google-Smtp-Source: AGHT+IGkiZVGShX0cNi+6EQ+b3HmkSKFDA5Zw7fxes8vn2v7cYypiVQFXqAdhtgXUN2x/ewlPt0doA== X-Received: by 2002:a17:902:e752:b0:1fb:701b:7298 with SMTP id d9443c01a7336-205841ba17emr96382505ad.32.1725413307103; Tue, 03 Sep 2024 18:28:27 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-206ae95a51csm4067425ad.117.2024.09.03.18.28.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Sep 2024 18:28:26 -0700 (PDT) Message-ID: Date: Tue, 3 Sep 2024 18:28:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/damon/tests/vaddr-kunit: don't use mas_lock for MM_MT_FLAGS-initialized maple tree To: SeongJae Park , "Liam R. Howlett" Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , Brendan Higgins , David Gow , damon@lists.linux.dev, linux-mm@kvack.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240904005815.1388-1-sj@kernel.org> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20240904005815.1388-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 3tt5611wuw65y5huwuemus1z5n9ia856 X-Rspamd-Queue-Id: 851F41C0010 X-Rspamd-Server: rspam11 X-HE-Tag: 1725413308-30265 X-HE-Meta: U2FsdGVkX1/5hV6NqrfZ/QVfX3NksEYoKwi8AJKJ7UeD2qljQ8TWvdR9CSVnW93a4oOuA+ivnwGYzSyVYFiqreofJ0lYX+kvDiF/Cb+r9UzOm2utZ2016QyhGARPOvfPtik8omawlcH9ZJVfKNLhsR1KrHEtuyJ3jxQ9fpI8g9C5FHQwgPjDyEUg80cAWU87xDXk+CngqehW5keaMlf2HwichtM0OFzckgLaQBU+KR4IgpcCGNTCG9kd+U8ez5TuDQ/GakMluuFGa4VFyuzu8Kv5ZriVd394YYFbHXYDROvIwlAndzgZr/vWVDmbIkci1teHkqbZMGbwBtD6jEwCF+JYA4mDpk9GbgLMq2GlC26U9FHUzA9pbL0LusW9rpZ+sljQicspkp1rSjRGbmKqOitYHTkRGnw0ql/wW9HWAPa7FHSgKUa6dtxEmMxd2ETpIZEn6DSLCyd/zMPBTJ8NygG61oEQj8WS3iEq5Eu68nBWx7gPzDiejqHvAw4yNMjoQgp1UTDXOylS9GVHCYEZUK27i5qBrOLeXf1RR+kStmzJ3NVk/bz+GlVALL3DAjaBx1n9zhX6P+1YQ/D8oH83XyPDWcExx4+hgNOEN1mR0DSbzqZ6bkwnptUxlYK8F1AeQnqJK7+aGPCmZ35qQp7GBm7PTn7+4/fBYGALvFaE3MnuHDmZD+w2hBdtPZiTGoYyvNI/Rf/i0EElconFnTpp45MAddXUtZowcAVfGXbgQIafSa+t2d0U/F6vHg20mCRl34AeZ5gqOnxjUba3vkq6I99OThmw7wTxmuPtr8yYqogIig/qIxSP1auA4eUUUAfFF1D323IKbOIVjKkqpaPnPaHMPPF1bcT6+k+MnS9+uML+XMXj17PqwrFfzvJ78FMIgnKdff9rbvv2c1OgRCJh6kpb/TzCH7mQ2lbgPh9hRAiPrmkEv8agqydoBR0ASyY5BoAG/cGLi0TXj5tsAfZ zUHBsKnG tLu0Dw5WnxkVeV+FgBetPx3+WJyrIWcXw8/0tmiucGCn9Ty7S1qWe2hLaFzulctQDRkL4vfneZs07nSibN3CENp4yqtEwbuY3iFDVPo7gZPdIAvV530OH/Qpfzy+mWB/NvEGMljV2qB6yrTBZEp+FQpGN1MK5sa6j2WkPzpLViTmgwPTaV5UCq5xTA/79EyofGtuFpvgwdpXWmNg+EYsaiqJMANRPhiAA3z1AbBopP4+GVvBvKeX0xI9HQJKvRDIfCt6tRxg1EQ9SoK1JYA6+m2AvIOQqGQMGwZ7B6aPPB0RhkIc+V68X4sY4siUocApRQ+4Dvn4yiTHbMyf0kRBgd0VyBxh6umbVojybZU6T1Hh3ZpepwwnB902RlEGpB76kRDtFRGlMkiTTWkN3draIzBZUuW0CigG4xmQpYC5Qp9ugWct0Es5TdYLf3tNXlL1LlEqEVmOtGfq5MjIHKgviNMfv8DO/BP8IrOK3ChHE/TmBK9o3xXMv6aOKVA/hQ19meNyIJuj3EGZIQhGKTY7RPF4hvWLUP1SDBswXg+OxDi5s5ZDktQcVpl0x0LZ2zOVH9s2SEVtnewAHr5B7MsQWhaEpNygEOJSpq2HWerU4Sie9gQL/715SiImx1R91rDXiuDV1qCPw2jComBM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/3/24 17:58, SeongJae Park wrote: > On Tue, 3 Sep 2024 20:48:53 -0400 "Liam R. Howlett" wrote: > >> * SeongJae Park [240903 20:45]: >>> damon_test_three_regions_in_vmas() initializes a maple tree with >>> MM_MT_FLAGS. The flags contains MT_FLAGS_LOCK_EXTERN, which means >>> mt_lock of the maple tree will not be used. And therefore the maple >>> tree initialization code skips initialization of the mt_lock. However, >>> __link_vmas(), which adds vmas for test to the maple tree, uses the >>> mt_lock. In other words, the uninitialized spinlock is used. The >>> problem becomes celar when spinlock debugging is turned on, since it Just in case you need to resend: s/celar/clear/ >>> reports spinlock bad magic bug. Fix the issue by not using the mt_lock >>> as promised. >> >> You can't do this, lockdep will tell you this is wrong. > > Hmm, but lockdep was silence on my setup? > >> We need a lock and to use the lock for writes. > > This code is executed by a single-thread test code. Do we still need the lock? > >> >> I'd suggest using different flags so the spinlock is used. > > The reporter mentioned simply dropping MT_FLAGS_LOCK_EXTERN from the flags > causes suspicious RCU usage message. May I ask if you have a suggestion of > better flags? > Correct. I don't see those messages with your patch. From my perspective, this is Tested-by: Guenter Roeck Thanks, Guenter