From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 730A5C4345F for ; Tue, 30 Apr 2024 12:41:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CC256B0092; Tue, 30 Apr 2024 08:41:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0789D6B0093; Tue, 30 Apr 2024 08:41:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5A4B6B0095; Tue, 30 Apr 2024 08:41:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C81DE6B0092 for ; Tue, 30 Apr 2024 08:41:31 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 526D4802BA for ; Tue, 30 Apr 2024 12:41:31 +0000 (UTC) X-FDA: 82066159182.06.D2A44B4 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf23.hostedemail.com (Postfix) with ESMTP id 3B11C140002 for ; Tue, 30 Apr 2024 12:41:28 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="G/I4phJu"; spf=pass (imf23.hostedemail.com: domain of philmd@linaro.org designates 209.85.167.53 as permitted sender) smtp.mailfrom=philmd@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714480889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z1zoRl9JNX91wxTFZ95WC2aOVdcvQqQ9ebO1YgbX9Wg=; b=5y8K4zmRAb8T9zl4I4F8JGmr2V+zV8lHeJn2nm22A2xqsU4x/zo/eW3bvdH2eCRSf6UBFp eDVjvJYSntRYuJi38IOW6EoiKfibIHEmLslIYPFQZ1auAJbP3sVA6T9gxMOnpORwyOdHa+ 4O1iUbPEhba4iRw7MqeQ3O+WVrk/Xog= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="G/I4phJu"; spf=pass (imf23.hostedemail.com: domain of philmd@linaro.org designates 209.85.167.53 as permitted sender) smtp.mailfrom=philmd@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714480889; a=rsa-sha256; cv=none; b=4NfcBRHW/Zdd9XH4K58bwk6GAY3QI+Za1TyW52hLN4d1yLT0C234hI627wDVa6LEuHDFcC 3BqEX569et+zId89c5QBEPRh8ROpu8xOnQa1ceuV/tCkeafXcJD7MXyXvlnvicMJdtvWh5 h4MJaFhdPMiC4aTeElxp46SYTYR1arA= Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-51abd9fcbf6so9422497e87.1 for ; Tue, 30 Apr 2024 05:41:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714480887; x=1715085687; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z1zoRl9JNX91wxTFZ95WC2aOVdcvQqQ9ebO1YgbX9Wg=; b=G/I4phJu30XBo566UvTdtNo6ne/NwwmSHsl96bF+m/J4TAgqmooXy3WkQz9BiYjNp2 UmgmAn/ll2Oc9jtbu/6RvAc/q724DHd4us1GDnPvkqzTxqWvUlFjUMkRWJBz68Sxk/Bj G/lpyAKhmXk0OskMJsSu3Y2WSSeI79UwdQyWZcOC25bD2Nu9rr5Ib+PoBadXEZ4CKAYt ygHFazN4NQiqjGE7eKJ0ae5Zouu/s6O/ZzihulgkaPNgQu9DnYGxvSzqcU9M6Jtg8CwM k/TToowJIRbulHssZF6dorBXmM/z4ePd3D6cAQoa5GETcPxCT9CehxDF0FQszsJ7fxFS 1E9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714480887; x=1715085687; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z1zoRl9JNX91wxTFZ95WC2aOVdcvQqQ9ebO1YgbX9Wg=; b=nboE7InVVEUbz5JXeo+U5slpqRAK3wq952oHoG3xdGXgo+a6wr2lvwJnkpN+ipwjw7 1M7VwxKR6G/VElnBt+ruNuFsFEdyJxb0ns1wa/Pe9EXvDYvIdm+wDXJF6hIHHsFtAfQn Vfjhj7L6xct7x2npSJ2CW71V5u0T0E29KctfaQh0iYUfAdgsyY1IIHyPMKWAuEn0NFwN BLAsSDf2p0EIXX2vCcSuhFV63zqlpxkQSi4MEl3rZ1QNADxDdnWtcTHqUNb8pxPLrp0p UgvW9zn5v/rrSvVb7o/nmT0ibCqtFMRXC01in6ZrKtfjcKUJewNsbUw82WYn1IjF5Tte O4Zg== X-Forwarded-Encrypted: i=1; AJvYcCX/J11METe4cG1hLsTFz0O7511xp0RUYFNMgLw/3kJrcRPG494lEzN1ipSEBFxhaPVlH7zA93DF8HnLGTbvt2EOaHw= X-Gm-Message-State: AOJu0Yy8291slX3PKnxa2VVwPXE+pJ/sCABLafVqHzp1diHhAoq6MMmC t0Dip/1wjqD8SdA0knXEVx4RjRwpNtGNNoo8GH/N2xiOQ7uYD0dLr5g0uonQwZs= X-Google-Smtp-Source: AGHT+IE/W9/dkxBso0irV5VrVX3LkNO5o5h+kLfYM+38G90SJ9h02blz/dj31DJFXSXcVMXms6NQew== X-Received: by 2002:a05:6512:45c:b0:51c:2c7e:ac92 with SMTP id y28-20020a056512045c00b0051c2c7eac92mr11527071lfk.23.1714480887229; Tue, 30 Apr 2024 05:41:27 -0700 (PDT) Received: from [192.168.69.100] (mab78-h01-176-184-55-179.dsl.sta.abo.bbox.fr. [176.184.55.179]) by smtp.gmail.com with ESMTPSA id i27-20020a17090639db00b00a58eab2bf0fsm3928326eje.179.2024.04.30.05.41.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Apr 2024 05:41:26 -0700 (PDT) Message-ID: Date: Tue, 30 Apr 2024 14:41:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 05/16] module: make module_memory_{alloc,free} more self-contained To: Mike Rapoport , linux-kernel@vger.kernel.org Cc: Alexandre Ghiti , Andrew Morton , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Peter Zijlstra , Rick Edgecombe , Russell King , Sam Ravnborg , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org References: <20240429121620.1186447-1-rppt@kernel.org> <20240429121620.1186447-6-rppt@kernel.org> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20240429121620.1186447-6-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 3B11C140002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 7tf987ipc7toj3qf8c5ngaw9k8wjtbr9 X-HE-Tag: 1714480888-658894 X-HE-Meta: U2FsdGVkX1+jH0aKxm3vVFoiEwwX35IMkF38pDhlzDg0QFyo3zpSV/ZHlU7jDnhwSNL5LD1OqHdy2dhAHpHJ9Q5oQlQtzsyPi9QRZIvODG/FVZePOuPbz/iXc7a+YUjxwfcWD1RUjS4zgSdrNf8Wd8qjEEsoIOk/BHL1xY2+DwMhLMmSiQY2vZYcj5FSd4uAuQP0KoYPvK5darEoDajdZqVQifLBUUsB8Uj4A92AK3Z7kKhVlHOZ+NyQY7Jyruzr44CP5q6Lp8rm0UH3sHuFnYDcFf6wERsjTRtTKZb6J5R+UzRrDrLSnZkV8v0DlU2qsURkoaSx1v2bA26mZu++f1wKxwhuohQrMQiMhI9EmGXtkiteY6aPalaGaG0Cbg1oiaD4bZBW4BOll8RHrYCMCjb14whmVD0/60UP1pyf8LL9SKJZ5zh4oyTkvYLS9vA+TSpkEJeCSUs3O4PzDal9+lhJorcd3uhekOzk4ldPbLOtxQFoQ/QoTd74pcSwHb9ZD3topr4e90PuzmTYYHGqWciIcGn7JvWANVYFyn+6i7HRirE5/tD772LE92u4YbSebMb6Y0FVcKBWDAtOAgtdf0jD8J/0DnjDA7AlQiugTwmbBeWXJ17yuLoAUbZSRbYAe6w2Xe7jDjHVvFstbT0nZGO5uHtAi1bVjl9ATFJ++WGqvW5znl9uBn8NoU4Y6bXSGElbUFQt0KCFVi6Ba/WU3VdAB+fdJWCGpqXxlTStfRXWfwKCOuiOWJF4vI9/csNi4s8aqqs/kXdXi3l8MY9EOLGPezX6UFJ3lUI4PRo19qXdVjRUjweDF48ypLDgMOIT3vCaA3U1/grn0tRuSm5XrxUPRXGcqLtZP5x67N9Rkhly3r8GzcZS8gZqXHuuSQWbVT0+aNPlfC99dr/zQoB/34mFEP56e1AzHXqv3aIBmQbkuHbgLtIcpa22N5jvDwhEiiiEoyyFlDaJ36IE8PX 0ijQB8px iCXyf7jEe87eM+Bmp4MNVliJZzgH52huW4fA3GUcFo39/udvutERpBHalaf+1DxiRyv2yY21+ubpMWW7XPmqOGbql2J5QK//ybTiRU7BKcKTS06wKDIZNrNHN8X+PUOwMZOmccIWg3kGL1xas9ORrPc5yBdBcGCdFo/4cXzAxPFa8Mr2c/VAbSpoPmmV6vtxiIhc9AFNM5M8r9FWVu6n1Bkg6Vclz3ZBBAUpatahsoDaXmeF/Rxp+SafUxiYBZxEPgSajeL3D90DSxPn9PPLuZdPhWG3G+7JEIM/dqHGAhGlh7/x6a8jQxJTTKC1RKQ7bfNwxZLECWkM5+1KMHFOa62wy+7Yu+ECy3gZVyc00VBCl2vwDni9axoIv/z7rezih3+g15yczVrpOux0NA3CIZMnBVXRza/kPl68Fe6FHm28jzThYBUFqUr6uYFiP+dMpGviNXDjbUkR5OaBvqIngXxlnBhMtFqHUg/EF8jGCpDVV5CWLDC1cUUOEJLNKqBNb4gL42B8Q1KQM0RIaAZvNbL3NHnQPwwhNww164sn3iIeWENPAgsbTGcm44mTUGQ85E/KflI99e9nCyE+sf/v9ANiBA7+waFQEHTJUEeZCBE+uNUkz+oYyq0x4iUJnBpMn9HGsNuVoS9hWCok= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29/4/24 14:16, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Move the logic related to the memory allocation and freeing into > module_memory_alloc() and module_memory_free(). > > Signed-off-by: Mike Rapoport (IBM) > --- > kernel/module/main.c | 64 +++++++++++++++++++++++++++----------------- > 1 file changed, 39 insertions(+), 25 deletions(-) Nice code simplification. Reviewed-by: Philippe Mathieu-Daudé