From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 491CDC54E71 for ; Fri, 22 Mar 2024 15:41:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3EEC6B0085; Fri, 22 Mar 2024 11:41:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEDFB6B0087; Fri, 22 Mar 2024 11:41:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A67956B0088; Fri, 22 Mar 2024 11:41:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 981976B0085 for ; Fri, 22 Mar 2024 11:41:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3A8141606B8 for ; Fri, 22 Mar 2024 15:41:26 +0000 (UTC) X-FDA: 81925089372.19.BA11F82 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id E5479C0020 for ; Fri, 22 Mar 2024 15:41:23 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hkCXWGee; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711122084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lzS+64/Z+z0FZAVLEztU47CybRWXv4MUKpFPGMTiPTs=; b=f/kJvQxHubMKb7CUYmRw6fsAqZEagzU2L+fZzo7Czra43GeHczKixRj7hO8swr35g+Gu8L +DuH9QYbMxRmSD66vB6AlW+ljt0w+wgr4k+RMdCk1SZBS5I336sWF05t5vLOQ97G9wvQPu n8HZCY/cPeqFPLq20yPtGK7OutU4vLk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711122084; a=rsa-sha256; cv=none; b=B1iEpuFNxOemPI6r2QzL4I7/aTGsxJX27Ac6OppjxodDVePAYvDcbv9NxWLGp7mz5Vdll/ D8zmY4iurpB90ufD1/eCd2cOZSDe83IJXc2T4dCFntd/NOeHHlpr0OL2TsFQlnckx8LxA4 ORE3z1IjocgcDg93//3T7/MCxGfHXoc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hkCXWGee; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711122083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lzS+64/Z+z0FZAVLEztU47CybRWXv4MUKpFPGMTiPTs=; b=hkCXWGee7Svyt6xx06PCyk0iOJDV01i1KVWvIhcWtysrWwgJxOyQblZm/b7FGtq57P5V9N KjIbvs/sofANGxPXOIQ68qgA7GQh1sB3aXhkXvJ3oeAWgzD2dFRDej/+KI+iJrewC5djSz Ql8GmLmwAOjo1+qdfpa+TqJAhnncJT4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-328-IWJG82bYO0mC8q9WFowrVA-1; Fri, 22 Mar 2024 11:41:21 -0400 X-MC-Unique: IWJG82bYO0mC8q9WFowrVA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4147a9bc467so6340305e9.2 for ; Fri, 22 Mar 2024 08:41:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711122079; x=1711726879; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lzS+64/Z+z0FZAVLEztU47CybRWXv4MUKpFPGMTiPTs=; b=XUMsX2H5hL7HLGMUF2dFvku8Y/wgsYQD2JbQCX21Y464S5F6o+Ghl95G0uLXdW7WoS 0xwZ+KS/s8SFsaWb1EHH32HgBNjrqXLdF6eQjJ3bzSA7ol0mffTU/OzRmPUOP4Xan02Z VJWDqwqtDZelveulxCpHrBPntAOzeSYahLIDg+geHnLX14Hzl3swMoIYcOvf4BUM4h25 8SGBt6IPxSiLeGfaHA+B+EENdNgnZXXo3WQDTzxLImav5gS37VISmnCxTpeKf3lSN8mp CVb5qX8CjPXDUV58Sfvs0tgmDPYyRNPU8iEwJfyTwRLm+dWGGASy3NOM1QgqkNR6MnUq b9tw== X-Forwarded-Encrypted: i=1; AJvYcCV4ik2o6CUBJlnr+qyt5bqTy8WubD7azxK+ZQPsk0yA9dginkQEtHAtU6O4EAPpVcdg6YP1HCw7xz6UMhf+CJOQqLg= X-Gm-Message-State: AOJu0YzZHxjQATiWnWup9aVT9XtdQMnC7y6k35M6WaQqX5gRojjTCt5d HTRHAWCQ90asmcSGMTUxZYJXDgcP4P/SfUMVOI7OMeNg1Jf5HNUc1i2D/yew1rX87cctotRfTBv S6Mdhp47T4lhZVvSatViZ+d5h3zqJM+rW+k41XZOU9Mo3KOv762yO6ttJ X-Received: by 2002:a05:600c:458e:b0:414:e72:63b1 with SMTP id r14-20020a05600c458e00b004140e7263b1mr2379793wmo.3.1711122079488; Fri, 22 Mar 2024 08:41:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEXOLZtKDEsBtChWDKIGyOSkyUFxGexBUunkAhaBF4wHd60YlS7SUyfnMOUyNbAZMW6SJYoYg== X-Received: by 2002:a05:600c:458e:b0:414:e72:63b1 with SMTP id r14-20020a05600c458e00b004140e7263b1mr2379773wmo.3.1711122079081; Fri, 22 Mar 2024 08:41:19 -0700 (PDT) Received: from ?IPV6:2003:cb:c71b:7e00:9339:4017:7111:82d0? (p200300cbc71b7e0093394017711182d0.dip0.t-ipconnect.de. [2003:cb:c71b:7e00:9339:4017:7111:82d0]) by smtp.gmail.com with ESMTPSA id c20-20020a05600c0a5400b004147db8a91asm1563396wmq.40.2024.03.22.08.41.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Mar 2024 08:41:18 -0700 (PDT) Message-ID: Date: Fri, 22 Mar 2024 16:41:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: BUG: unable to handle kernel paging request in fuse_copy_do To: Miklos Szeredi , xingwei lee Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, samsun1006219@gmail.com, syzkaller-bugs@googlegroups.com, linux-mm , Mike Rapoport References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E5479C0020 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: mdknrkokjra9yjo4f7wqa3ey3hahywiq X-HE-Tag: 1711122083-49799 X-HE-Meta: U2FsdGVkX18+HGnruskHi3aeOaOT9eksdDfwOQeNgcgwkEXfr0IjeYnK8L1it6R+3U7+my905UiS9u/06S9UF9siCyXtpSZCeav/YR1DfnaN3qDBJWWVfYl2jtnO2mW3vVo+0cX7kFcliaSI/1X0Maa9JqWbaVo+CSWdu6lAPuZDksPTjX3P+0wS2js5whrtseWvOU727YfRV+P8HWB+szb/OyxYRRULbcmO7f2D3DhgQ4ed0wYwEa21B0B+TjlBMKbvNRjK+n35Hd9wqUxxOgX4oERJP5XdMmhnASOqOkSLbZMgOGAflQO6dCm8vx47AxG3657D9jMguTCFSxOErSZaPVD6jjl20IUk0iG7Ja3b1sxPlYPjI/K0sAtEyZIh0TLcJ1T3FI9F1vgw13IS7dnwI1wNcKFK5bLti6A0uOAtx004wiojVYFe8lFGQlaucTpdfdNPiD8Bs9334vxE1QJB4k5Ip2bj3V4ctQPhDYZIUyUcH0E1WEM5wkl5ZUInxqaq855CIuN+KUhWQ+iy4eLa0ZHCxQZVOgN3mo3rLy1Lphq4J35c/UwQ6RanCawXdsuEPZXfGyebIBoEgWPN2/apUbWUKMvOo6OlNyQdcyGg9mr0m3pmv9A+nkEUV4oJNjXFeJTOBr+G/FaVhlzHpUWR/9bdmB49LKAqE0qdNRTDSUbYAGn+C3m2Eidn7CWczEevgptW5jtVn43PUKY959I0y72IZJq+HDb/1pejDe+MLMGZIRvEjG2331mLB14sLNqzz72xbkkE9KrBW79hz1v8FIZpveP0Tzq518LmlDYfYKYkljPt9wyyXRemMrXKukhxHYnStDfdICzn7RXAJaE6ljCHcHTx+fQeFW23REwDrN+V2ZaYxAIuV1mkG1gXhi8k/95SiJyOJ1AyjvjZ5hLh6b5a4gq77f7PTzb8AeiqA3soDNev0ZlwS0HlbXgFFfNVV1QsmZAId8DmvXX a9DrUDRY 5K0RgTXEh0xszgNKR+GA1oQllYHwJdUChUUnCnVQL12a5E+Ua13xeW1v9xg7mYRT6aYRHgZ1nuPe46xyeRDPP2rr5x27R+cj/rcJSZEtR232fiCj99rW6X2tDH8dokBwLnLsdXdGF6FhDnmShjm7PolkSUOJO8LuSEP8sVf4pQKJzrA3GZV0447f1sQ6Rjwkg/s086xXzVyBIdvUy6YKjRDloai/27PvpQ16osbSg4pZhZ30lvjtygy/54Cvp4jyJrqlVgZBhOj2Uv/4JLp3QLhDPzdXHPefDTs/KE5TIDWlrf5jVBXRMxsdfU5eqCvE5aEmMbkR0HwSRry9IehAiGBX+sfVsEoEjWf+fAvn2iKNoAxf3j3E8ldqrI01tNW9B4IjQWSU7lNX69PXaMi9XRWmKjDuRYCTwvnfb1C6/w6cc+UAaCTy3fwZ7UjlnxII3qTMuNOVlSBxNN3gEUet1W2KyAXsqCGmwgthEOEHyDMG/eIsxds/tXpRSrANfxcg0Tc+p5gnukcVPJWfDKFZ1vvNbCj/GCpF38ckJHBg2iN88awY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.03.24 14:50, Miklos Szeredi wrote: > [MM list + secretmem author CC-d] > > On Thu, 21 Mar 2024 at 08:52, xingwei lee wrote: >> >> Hello I found a bug titled "BUG: unable to handle kernel paging >> request in fuse_copy_do” with modified syzkaller, and maybe it is >> related to fs/fuse. >> I also confirmed in the latest upstream. >> >> If you fix this issue, please add the following tag to the commit: >> Reported-by: xingwei lee >> Reported-by: yue sun > > Thanks for the report. This looks like a secretmem vs get_user_pages issue. > > I reduced the syz reproducer to a minimal one that isn't dependent on fuse: > > === repro.c === > #define _GNU_SOURCE > > #include > #include > #include > #include > #include > > int main(void) > { > int fd1, fd2, fd3; > int pip[2]; > struct iovec iov; > void *addr; > > fd1 = syscall(__NR_memfd_secret, 0); > addr = mmap(NULL, 4096, PROT_READ, MAP_SHARED, fd1, 0); > ftruncate(fd1, 7); > fd2 = socket(AF_INET, SOCK_DGRAM, 0); > getsockopt(fd2, 0, 0, NULL, addr); > > pipe(pip); > iov.iov_base = addr; > iov.iov_len = 0x50; > vmsplice(pip[1], &iov, 1, 0); pip[1] should be the write end. So it will be used as the source. I assume we go the ITER_SOURCE path in vmsplice, and call vmsplice_to_pipe(). Then we call iter_to_pipe(). I would expect iov_iter_get_pages2() -> get_user_pages_fast() to fail on secretmem pages? But at least the vmsplice() just seems to work. Which is weird, because GUP-fast should not apply (page not faulted in?) and check_vma_flags() bails out early on vma_is_secretmem(vma). So something is not quite right. > > fd3 = open("/tmp/repro-secretmem.test", O_RDWR | O_CREAT, 0x600); > splice(pip[0], NULL, fd3, NULL, 0x50, 0); > > return 0; > } -- Cheers, David / dhildenb