From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E8C1C433FE for ; Mon, 7 Nov 2022 19:27:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D58208E0001; Mon, 7 Nov 2022 14:27:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE0026B0072; Mon, 7 Nov 2022 14:27:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B33468E0001; Mon, 7 Nov 2022 14:27:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A3A956B0071 for ; Mon, 7 Nov 2022 14:27:18 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7980F804CE for ; Mon, 7 Nov 2022 19:27:18 +0000 (UTC) X-FDA: 80107629756.11.67A1990 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 7CB5EC000A for ; Mon, 7 Nov 2022 19:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667849236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=patZqZFG+VP3DSfi5ljEiY21OGL00v17le5HXIzu3EI=; b=BwMu2tWdBGA5tjCZgobedg37WlxxzCvSTjUe3Hzs/uaRtTVoT9k0NsIJt/IBWzKXe4oLn8 NH//jsFVswE7o7PlIjpueoUMemInTztHA9LI8q0uNZRM2wBlBwnQlC4fWoJG809wmHtCLP uK5yodhgh/N8Jc+a6hPzejkyFoK5AOs= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-647-Sz0ZdoZuNuK-1OtzyOBbIA-1; Mon, 07 Nov 2022 14:27:13 -0500 X-MC-Unique: Sz0ZdoZuNuK-1OtzyOBbIA-1 Received: by mail-wr1-f71.google.com with SMTP id h26-20020adfaa9a000000b002364ad63bbcso3175602wrc.10 for ; Mon, 07 Nov 2022 11:27:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=patZqZFG+VP3DSfi5ljEiY21OGL00v17le5HXIzu3EI=; b=hA1m+DjU0YtSYd4TjOJzxbYIISGeNpVNMH1TBrIZZygAZMiD/VC0E1Xw07l3AfVax5 JkX4r/fegbW4ieJhFvf1sJJzJOiLz2OQIyjXdMfzhLpNzj8X8MPlwZ/xGk/sUUwL1Lpt +dzsF53b2vEcRRHkG21mscF99qIu/Q0mchrxHimBcDXvDpReswi30LmdaS4M+1kKCOqf YQFs31M3ZYfRrtsouXt/OMhACAvG1IeCmFdKNkOebdj71gWm2ygAN1UkEjB3+d/3wp/q SGmj6DwosiP89vh8QnlpkaftuXGASeWIYAQsrN434hyiYrKp+sZKQ8gSMg4maQYsaWsH oBaA== X-Gm-Message-State: ACrzQf2QtmfoEGsMkQNNMNx1dU/0n3WBhH0nNRqAbLBb5T/KzucyFPCF 6loCyoS0MNJScJUjLvhkURxL/wQoTU4ptLvep/Xm3wi4QAtp9A8tHVlDLb0HlReSuH5nIjGMZxq 4wjJbLaEsj/o= X-Received: by 2002:a5d:4487:0:b0:22e:3292:75ab with SMTP id j7-20020a5d4487000000b0022e329275abmr614286wrq.166.1667849232533; Mon, 07 Nov 2022 11:27:12 -0800 (PST) X-Google-Smtp-Source: AMsMyM7WA0QO9a9aE/aCsv95kc1/GI2mA1rxsv3w8NpMMhNZXKsgaEBfixEFS4BMiXoamohO6ncLKQ== X-Received: by 2002:a5d:4487:0:b0:22e:3292:75ab with SMTP id j7-20020a5d4487000000b0022e329275abmr614274wrq.166.1667849232188; Mon, 07 Nov 2022 11:27:12 -0800 (PST) Received: from ?IPV6:2003:cb:c704:7800:3f13:77ac:9360:5e22? (p200300cbc70478003f1377ac93605e22.dip0.t-ipconnect.de. [2003:cb:c704:7800:3f13:77ac:9360:5e22]) by smtp.gmail.com with ESMTPSA id t20-20020a05600c199400b003cf9bf5208esm10877851wmq.19.2022.11.07.11.27.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Nov 2022 11:27:11 -0800 (PST) Message-ID: Date: Mon, 7 Nov 2022 20:27:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH RFC 05/19] mm: add early FAULT_FLAG_WRITE consistency checks To: Nadav Amit Cc: kernel list , Linux-MM , "etnaviv@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-media@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , Linus Torvalds , Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann References: <20221107161740.144456-1-david@redhat.com> <20221107161740.144456-6-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667849238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=patZqZFG+VP3DSfi5ljEiY21OGL00v17le5HXIzu3EI=; b=KIBmVQRmNIRHflGAcC48uqgpVwUA/vSFOkpYeUf2H6OO5riU67w03iU4YcsG7Ncvp975+D O74tzOfFN96ywdayIzqTc2Q82lI5T2JZTKpuzoYrfziQtIFiUqYGQIjJwFzyKIj+MH4MLA 1QRQCMZILEZKFIpJeZhgThgdzozU5QI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BwMu2tWd; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667849238; a=rsa-sha256; cv=none; b=n37n46JZA7uNbl/XFe6NVEzfTAwyZpnY6TrkSTCe0Gc8SC4i5xm9h3v58FBanCtT1uX0FE r72+D9Z5gpwHfsklqfgyRGlGVpC8IX3zggeIZbZZ5OcNFy0vCZuPBKDT9ohCTRJb1zfG0D CZqJ0iaf/FMPRPZkoGSlELKr5lYuvyc= X-Rspamd-Queue-Id: 7CB5EC000A Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BwMu2tWd; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: j56w4azd81tdcdng8zqayuhne6goec39 X-HE-Tag: 1667849237-559758 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.11.22 20:03, Nadav Amit wrote: > On Nov 7, 2022, at 8:17 AM, David Hildenbrand wrote: > >> !! External Email >> >> Let's catch abuse of FAULT_FLAG_WRITE early, such that we don't have to >> care in all other handlers and might get "surprises" if we forget to do >> so. >> >> Write faults without VM_MAYWRITE don't make any sense, and our >> maybe_mkwrite() logic could have hidden such abuse for now. >> >> Write faults without VM_WRITE on something that is not a COW mapping is >> similarly broken, and e.g., do_wp_page() could end up placing an >> anonymous page into a shared mapping, which would be bad. >> >> This is a preparation for reliable R/O long-term pinning of pages in >> private mappings, whereby we want to make sure that we will never break >> COW in a read-only private mapping. >> >> Signed-off-by: David Hildenbrand >> --- >> mm/memory.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/mm/memory.c b/mm/memory.c >> index fe131273217a..826353da7b23 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -5159,6 +5159,14 @@ static vm_fault_t sanitize_fault_flags(struct vm_area_struct *vma, >> */ >> if (!is_cow_mapping(vma->vm_flags)) >> *flags &= ~FAULT_FLAG_UNSHARE; >> + } else if (*flags & FAULT_FLAG_WRITE) { >> + /* Write faults on read-only mappings are impossible ... */ >> + if (WARN_ON_ONCE(!(vma->vm_flags & VM_MAYWRITE))) >> + return VM_FAULT_SIGSEGV; >> + /* ... and FOLL_FORCE only applies to COW mappings. */ >> + if (WARN_ON_ONCE(!(vma->vm_flags & VM_WRITE) && >> + !is_cow_mapping(vma->vm_flags))) >> + return VM_FAULT_SIGSEGV; > > Not sure about the WARN_*(). Seems as if it might trigger in benign even if > rare scenarios, e.g., mprotect() racing with page-fault. > We most certainly would want to catch any such broken/racy cases. There are no benign cases I could possibly think of. Page faults need the mmap lock in read. mprotect() / VMA changes need the mmap lock in write. Whoever calls handle_mm_fault() is supposed to properly check VMA permissions. -- Thanks, David / dhildenb