From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C163CD5BB8 for ; Sat, 23 May 2026 18:45:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 889266B0092; Sat, 23 May 2026 14:45:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 860B76B0095; Sat, 23 May 2026 14:45:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 728546B0096; Sat, 23 May 2026 14:45:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5DC156B0092 for ; Sat, 23 May 2026 14:45:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0055C1C21B5 for ; Sat, 23 May 2026 18:45:08 +0000 (UTC) X-FDA: 84799561938.10.1925606 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf28.hostedemail.com (Postfix) with ESMTP id 50642C0009 for ; Sat, 23 May 2026 18:45:07 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=nE2vwrlP; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of jlayton@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1779561907; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4dh8K34LhG53aOEAOW/tsKAjsIUkIq+EMsW/9iJuH2I=; b=yzk16wRfxPoht6zy5nn1uq//KMKn6ex6MTBt3WDk9Yv5mdzs1/buTGrdlg/Tnl99W8mLuV kzEHaY8bAb3O+7LZkO5L/g2QZ5LGCF0SKJVjgePj4++z9ZsIw1LbMs9ntOJ+JRXWyqsZtS y6Xg8Tm1R6B3VJ8OrdIgw/63yzIS/GM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=nE2vwrlP; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of jlayton@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1779561907; a=rsa-sha256; cv=none; b=WMxbTQABVFeoaK7+W/jOr0AxDAtGQRqTGIlxHRNJI4KHukmPytsqIzyBDjWxmRLLRfeTU+ xtzESc2/9sVn27tSC32wByUc84Ht0zTtpV3dpvBSUkwxpFWLmS+TMzD2k06nyc9gAnUYxX dBDrbQ6rZ8EWySrDVSrFpnevmkgUvVo= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id A4FF060055; Sat, 23 May 2026 18:45:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1F701F000E9; Sat, 23 May 2026 18:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779561906; bh=4dh8K34LhG53aOEAOW/tsKAjsIUkIq+EMsW/9iJuH2I=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=nE2vwrlPxRNPg5A8eCpfSlphnLWQfLvCcucuioz9piqQBl3LijnUwavPZbdK0byIH CA+rkdXQ00jMwFvj5DNVq4BTmhp+N+LiDCEoABq/qeiNoAIVmbw+n98zbOrj1XiEiW loO+oVYZWDN2VNsvW/pPG9LyaRLDOcYuKOzTpAJ8IKzKcfgO9YC1JhX1omhBja3Xuk jbH0qshIgnqFaDMhYBbEP/OMyD3MlTKR954P4ijq5QEJgfafK88HrcHwc9qqSLyBn/ dTmbzhU2gR6KNo+FbHpuAGQ/l7Z9BpcJJ1KVMMJl5b19QHl/TDy5etWsTdKdEwUOdE EujK2bIZeShXQ== Message-ID: Subject: Re: [PATCH 07/17] NFSD: replace __get_free_page() with kmalloc() in nfsd_buffered_readdir() From: Jeff Layton To: "Mike Rapoport (Microsoft)" , Jan Kara , Mark Fasheh , Joel Becker , Joseph Qi , Ryusuke Konishi , Viacheslav Dubeyko , Trond Myklebust , Anna Schumaker , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Alexander Viro , Christian Brauner , Jan Kara , Dave Kleikamp , Theodore Ts'o , Miklos Szeredi , Andreas Hindborg , Breno Leitao , Kees Cook , "Tigran A. Aivazian" Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@lists.linux.dev, linux-nilfs@vger.kernel.org, linux-nfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-ext4@vger.kernel.org, linux-mm@kvack.org Date: Sat, 23 May 2026 14:45:01 -0400 In-Reply-To: <20260523-b4-fs-v1-7-275e36a83f0e@kernel.org> References: <20260523-b4-fs-v1-0-275e36a83f0e@kernel.org> <20260523-b4-fs-v1-7-275e36a83f0e@kernel.org> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.1 (3.60.1-1.fc44) MIME-Version: 1.0 X-Stat-Signature: 7knykezww1ab7qoyd3434fm8fyzcggfc X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 50642C0009 X-Rspam-User: X-HE-Tag: 1779561907-362419 X-HE-Meta: U2FsdGVkX19ulph30ZPUmKit1zGGCqSTSufFg8xPY1QNmvxRb8AaFuA9eurlzVPGB6MrJJsIW9ssVIWLqS4rdETPQwiUN/Z5KQbkj1cE+FhoSLJ2tImBL2BICp9Wbzyqyzw0APiUUZsovqaUmqwoyJTy9He44zemXYgPoVl8Xoyt+ZAcWcGSY8U9G7nfKI8FiKVVBcDxSXL1fecy3HvUCYA8vtJLCsr9Z6T++nDYGyiX7EKxiYVNlFNI3x26wIA98gAsP8VlpG623w4ctWYr+R/DBtydxs4Si3y+JADHXHxvrh1UGQvxsIySiv2Klt4FaqshPD9RICOefxOPEBqA2euPc7D10z5higKU505s0dPj48Hx29ILo6cuQjE1mabSz9XuGQQYqmPdyJgC2m+ltFIABXgnlp7z+iUtqJinkKN+YmFwlv42hlBRoYBR2xhm12oo+mc7ntPKy632PdGnkA4k9MSS5MeouGcl6Mmx7aazu5s0kYihFF9xHba2w7yIFPMCl0aEqWhkLWw33AgOZgHZnoswWnKdFa2bTenTIEekPBmwSswmYin+h8LDWV0KRPA+dVyl6oCe8bQRdLqr8WO3guA2TWAoHSAl8YrF1bMJkvEC+x94kUNPw35dOzZjYSPMGOgY10ebyTJfzYJ9p8FPgnQfqZeKL+neMZ3kjNPJd3OSuD4EoDI12pzAqlppBq6FPHk7faPPatktIZnLWbGvn9sNrI0kypWUz535R9lWhYxvV+FgXxohsL3AmNMmSzm5T5jxCTLOd8FeTwsJ38Lu6QOjrLZaMyO1XxrtyZUSLDURa+1Go5Mbb/yxX1SHWcCKQPM1lQ9/evm+ePJf9A6orG6XafM0JcjWFe9WXhvt+x1RXzwv1JqI8YBT42qOU5fheX7AGCQhnK4ok07au54nwYxSzrAho5NweJa+EF4EM85ei1oFOBeCd1yB3YFzvu0wvRVpBLfqGz3/qGc sjzYAH98 RnODb1+YU8lop6Z3tCqVRBTbDCQ4KM7TWB7OqrtkYv7RyBowUJudTO3x6OqBmEP+eyMzKc7MVNHZEEdV1kUW6fWSvfAYIdiDt9MC5E/w3UJm/NZ0DCkU0DMyIb5imWuMC7Y2J8ON2B+UW//Hf0Y+5EqIwxLW9OBvHIJQIC2hNI+Y+qaG53+/JwcXpMAi+SmPp5wmeb2qdyyS9kIZ3DAIgjO8IDvCEIp6Le0G0cGYrbwe4mE2E4b7+64nbPWN7CeC/A6KTTP914AYvhEHqlC0yP6XZVHHl1PAVhLsif1uH4tdbkLLTDyPEYUO6wKO2SGPtzSOK3sWJLP5pB0DanF95bhbo2MSFJh/ND6iX4WBvnBGnLAg= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 2026-05-23 at 20:54 +0300, Mike Rapoport (Microsoft) wrote: > nfsd_buffered_readdir() allocates a staging buffer with __get_free_page()= . >=20 > kmalloc() is a better API for such use and it also provides better > scalability and more debugging possibilities. >=20 > Replace use of __get_free_page() with kmalloc(). >=20 > Signed-off-by: Mike Rapoport (Microsoft) > --- > fs/nfsd/vfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c > index eafdf7b7890f..c99e54b23cd9 100644 > --- a/fs/nfsd/vfs.c > +++ b/fs/nfsd/vfs.c > @@ -2407,7 +2407,7 @@ static __be32 nfsd_buffered_readdir(struct file *fi= le, struct svc_fh *fhp, > loff_t offset; > struct readdir_data buf =3D { > .ctx.actor =3D nfsd_buffered_filldir, > - .dirent =3D (void *)__get_free_page(GFP_KERNEL) > + .dirent =3D kmalloc(PAGE_SIZE, GFP_KERNEL) > }; > =20 > if (!buf.dirent) > @@ -2458,7 +2458,7 @@ static __be32 nfsd_buffered_readdir(struct file *fi= le, struct svc_fh *fhp, > offset =3D vfs_llseek(file, 0, SEEK_CUR); > } > =20 > - free_page((unsigned long)(buf.dirent)); > + kfree((buf.dirent)); nit: Don't need double parenthesis here > =20 > if (host_err) > return nfserrno(host_err); The rest seems ok though. Acked-by: Jeff Layton