From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 026CEC3DA7F for ; Wed, 31 Jul 2024 04:14:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 619A86B008C; Wed, 31 Jul 2024 00:14:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C93D6B0092; Wed, 31 Jul 2024 00:14:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 490E06B0093; Wed, 31 Jul 2024 00:14:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 291D96B008C for ; Wed, 31 Jul 2024 00:14:51 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A4729801E8 for ; Wed, 31 Jul 2024 04:14:50 +0000 (UTC) X-FDA: 82398731940.11.42937A5 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by imf27.hostedemail.com (Postfix) with ESMTP id BB82E40016 for ; Wed, 31 Jul 2024 04:14:48 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VN6JfPzZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.46 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722399247; a=rsa-sha256; cv=none; b=7+lx44o5NPBbJZTWWSln7IzrKQujwQz1jyUcsoHxg7EijYz/aNf8wPLPbs3wOxlplcjD9p 6CbsVRyFiF6NEh50PqJRF7hKPParQhUqB+vexYt0+DEOF5LCSYSlcxhur8JiEiO9ZuW7P9 MJPB1/mriTin+GENqC/JiAW20p+r/Y8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VN6JfPzZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.46 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722399247; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DNL7NFkFF5FUxcfpExxj2V2R2UfPEnaSrY2fTx/MR1s=; b=lQ5lzLrXMRvlgMM1AcQEk1ImWZulWwsHcapaF7oyYEnu1iiwcXuTUz06JE6eMfw3C1pRI1 pMwe1bN1xKGuJ3bfz2qftE4eIThSGoY+QMMRAShhALN4Ze7SUOfoH9ZmvsV9BWAe1s05BF w0ripymf9hddmoWUKlc5i2iC9iPzWeM= Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-70942ebcc29so2940862a34.0 for ; Tue, 30 Jul 2024 21:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722399288; x=1723004088; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DNL7NFkFF5FUxcfpExxj2V2R2UfPEnaSrY2fTx/MR1s=; b=VN6JfPzZzCJIg5YSv19OGPh3TtkHxmCNtAJiGYoDyaQWa1MvAgvSVXUJM+XNnUrEEX SsdBBSkcFkQlcKQIttpOBbD7V1noW+HK27QbXzUacpGV05U94ohwTtMVhuLpB4GCuMwk m25mb1sI06l+BkQAU7EzhvMa/bvqlWYS8Wxds0W3sGKUwjGwMHcoNObCYyir9+7NwYCG c7G7MEfZMZ1qaZq4UL+0AqVVxhFql6yEOAPLpPznjj0ESChCFndL/L9J3/NT2bZKJnUB jNFudl9liI3+mCRi2r7wRv1Hz05NyXQqNZfQe1ixIVQCb22yMyukfk74ggw0pUAeYbGG tOog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722399288; x=1723004088; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DNL7NFkFF5FUxcfpExxj2V2R2UfPEnaSrY2fTx/MR1s=; b=jaS/0FGcjeS20hhCDyQdm/8lr4/jKlb2WhVxU+RMGrlpEpHHTZLguMokmNY9QAN6+g ogwlShSPm806f0g9KLRqpMRa5s71PxD2ghOniYyjSxbyqNui0BgrPV985sdvhMycv22k KPd8WmnyW5fVs0H3BANIpEZQlhQ3+AfIZ1pzP3tHfxBJOUsCGbIzxluC1Z10NG37qcK0 VQBUpmnChvXFwsgwLkN4LHCmjBDoSVZ6a8/ZXTeAElhocSavnM6a/W4D7LQLVp5YzUwr 7LwS8SKaznoLNavCXcy9Ja6WJWqGF62sxIU9oGuFkjnYGxqY4OXVjQbQkDUMszp2JNPr OBfw== X-Forwarded-Encrypted: i=1; AJvYcCWRDgmcKRxd4lRj/QDaVxGe6DXengITD0u/Z7u+m896g93NFs9rjh4+YBVhUtfWOE1HCnFJVlmXn8ZxDkB/RevArE4= X-Gm-Message-State: AOJu0YwnfTwSCCq7YlCc7qPZXNJRVVhBO0WybjIU+XdDfy3orYleYvqO b7hlHgCYcUvycqy2jmVb/LJqzaM3hSmLHlEkUQznRv4ssvPsshAF X-Google-Smtp-Source: AGHT+IEX1prPmIFIeqrORL9JH3Dud7a2tNptrr6Vggd45C+iXglyBbfvs5ramvLw9JlVo4nqcrEEtw== X-Received: by 2002:a9d:5f09:0:b0:703:fdda:fe2b with SMTP id 46e09a7af769-70940c0e09amr14129305a34.11.1722399287720; Tue, 30 Jul 2024 21:14:47 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.21]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead8aa702sm9107977b3a.215.2024.07.30.21.14.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jul 2024 21:14:47 -0700 (PDT) Message-ID: Date: Wed, 31 Jul 2024 12:14:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 22/22] mm/zsmalloc: update comments for page->zpdesc changes To: Sergey Senozhatsky Cc: alexs@kernel.org, Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, david@redhat.com, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com References: <20240729112534.3416707-1-alexs@kernel.org> <20240729112534.3416707-23-alexs@kernel.org> <20240730093726.GB16599@google.com> <8fc7939b-416a-4328-9df2-488f17783543@gmail.com> <20240731021619.GD16599@google.com> Content-Language: en-US From: Alex Shi In-Reply-To: <20240731021619.GD16599@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BB82E40016 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wamf1idrgx1yrob6h4x45qg1sg7y7omi X-HE-Tag: 1722399288-463942 X-HE-Meta: U2FsdGVkX18XBGDUbYGbt0Flp2dfM6a46GXDd0YCAMWFk/+Im8b3heD8wi4w0XLpcTDksLRKHrSVIBR7qZDs9Y5IfOE/W3NzfuxYjM/noz5p9e8qRxT1RkpVWqwhZra7+netcuVoYOmpDpSFAhMV/64jz12kkS2xhngjXk3yGG6kirNF72/7xkfk5nytZ5rcJ5e4gTYeFw9KMpe0sA7q01auqH0xj+kno7P0BEVDkIfkle58M6/SK2H7R7iC+8cFpeRXsYprbXNTC4q/HtqzahFMCfPxFdHSJL9LrNkhcXRlGKyvRYM1cZ58VxB1XjA1IBi96bymJLkvhCgnHUAf8jeZPF4dvYd6HqrItzP+HK6PKWNqHf2MK3fyqrzQpUuauDoAJJ2fgQkOeSn9949HX7cYem15vvNMkByaNNpv/nBDlZK+sqk1U/69eDR+Ci9IeHgMRdjg0wIeOJ0gWRasH9vaBOKLGlnbFndSche+w+1jK1Q11GrVHe5vJ/jCx3L2dkP+mMx+jgIA5ElW8kcPm44Jz1NdMgMgD3ErYgQYyfrBpK+D5JUZk9uqMw1jxjGC0lUkgsrILCFGA4bihtkd6Y6GSyTi9ez9W6fw2UKO+42nutiXB4QbRPrtD38Cof4HHN458ji4NzhntQEDnY96ad3DzWLXYMKayp1eBDOFSl1OcmXA20xKHCTmCLsAfSv/igbt+VVijUTSH0GFLEFCWdHgcuku/52Rx6vUfz88Jt8q66/WCaC0SOcxhASoY3cg3nYd2Nj3Nqm9uPQreNO4E2cUQ9RXvn8WYyE4DoHCsg4fMw/tNG35Fm1kbbwQUTE+bIy1lGbAt9R6N1yRpj2L8ctIc2vf3JhVJyjZpCvpY2tw6vVa2z8ArecbQrXayOUlWRqUOfuF2DCxWcwOukZ+/M4mZP1u3vkniSzNTtGjKcxOF7mMSjrIefOTBesQcyd7+MDHmstEDWrAyS9NpOJ DIKeFsZ7 uT8i04c/exBlb9xMJ7QtuVsE31xCYFrbTgdhBWI+Mx/CTU08pyIk/jOPch9tYlE5WNr16oajkrH/PtjBZrDV+2BcQaJ6Ev2unWF+zS//CICBr/PwZh6G+8xOKSXW9TgPTUZJPP1S8QSmTNUyXG8gdQNgDTh+Dzmuh/dIt4CA3RlZU6Bvcz000JeWJQwG6Owfk0WdNPH6a9aCi7oLUr6XNdAtNfvbJsqr3kY31f8oZfs9vbXxF0COIAbRxU18V6GuIzGdVpVG9oC5tinMIY8aAjIUfIvEJI8V6Zx0lF66yAuBELMX2FAwsp5JsQgUjaM5REOzYG8spOT60pv+O0lKszw3ZyXFu4wck9n95fU0TSdAv7PuArEBsYgsnge7zY28NQd2W5M7OqqnYcNNO9aWazu9SfhmKOQWyHzNGh/22ygAINTLQ7hRgiVcxSIFqWH329Tr58O/QVXYB4pOS4RZD3vVgDqvAeRpWRXqp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/31/24 10:16 AM, Sergey Senozhatsky wrote: > On (24/07/30 19:45), Alex Shi wrote: >> On 7/30/24 5:37 PM, Sergey Senozhatsky wrote: >>> On (24/07/29 19:25), alexs@kernel.org wrote: >>>> >>>> From: Alex Shi >>>> >>> >>> Usually some simple commit message is still expected. >> >> Uh, my fault. Just forgive this part, is the following log fine? >> >> After the page to zpdesc conversion, there still left few comments or >> function named with page not zpdesc, let's update the comments and >> rename function create_page_chain() as create_zpdesc_chain(). > > A bit of a different thing, still documentation related tho: do > we want to do something about comments that mention page_lock in > zsmalloc.c? Good question! There are some comments mentioned about the page_lock in the file, but missed in the header of file, so how about the following adding: diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 731055ccef23..eac110edbff0 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -25,6 +25,8 @@ * * Usage of struct zpdesc(page) flags: * PG_private: identifies the first component page + * PG_lock: lock all component pages for a zspage free, serialize with + * migration */ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt Thanks a lot!