From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
will.deacon@arm.com, mark.rutland@arm.com, mhocko@suse.com,
ira.weiny@intel.com, david@redhat.com, cai@lca.pw,
logang@deltatee.com, james.morse@arm.com, cpandya@codeaurora.org,
arunks@codeaurora.org, dan.j.williams@intel.com,
mgorman@techsingularity.net, osalvador@suse.de,
ard.biesheuvel@arm.com
Subject: Re: [PATCH V5 0/3] arm64/mm: Enable memory hot remove
Date: Thu, 30 May 2019 09:53:43 +0530 [thread overview]
Message-ID: <c6e3af6e-27f4-ec3e-5ced-af4f62a9cdff@arm.com> (raw)
In-Reply-To: <20190529150611.fc27dee202b4fd1646210361@linux-foundation.org>
On 05/30/2019 03:36 AM, Andrew Morton wrote:
> On Wed, 29 May 2019 14:46:24 +0530 Anshuman Khandual <anshuman.khandual@arm.com> wrote:
>
>> This series enables memory hot remove on arm64 after fixing a memblock
>> removal ordering problem in generic __remove_memory() and one possible
>> arm64 platform specific kernel page table race condition. This series
>> is based on latest v5.2-rc2 tag.
>
> Unfortunately this series clashes syntactically and semantically with
> David Hildenbrand's series "mm/memory_hotplug: Factor out memory block
> devicehandling". Could you and David please figure out what we should
> do here?
>
Hello Andrew,
I was able to apply the above mentioned V3 series [1] from David with some changes
listed below which tests positively on arm64. These changes assume that the arm64
hot-remove series (current V5) gets applied first.
Changes to David's series
A) Please drop (https://patchwork.kernel.org/patch/10962565/) [v3,04/11]
- arch_remove_memory() is already being added through hot-remove series
B) Rebase (https://patchwork.kernel.org/patch/10962575/) [v3, 06/11]
- arm64 hot-remove series adds CONFIG_MEMORY_HOTREMOVE wrapper around
arch_remove_memory() which can be dropped in the rebased patch
C) Rebase (https://patchwork.kernel.org/patch/10962589/) [v3, 09/11]
- hot-remove series moves arch_remove_memory() before memblock_[free|remove]()
- So remove_memory_block_devices() should be moved before arch_remove_memory()
in it's new position
David,
Please do let me know if the plan sounds good or you have some other suggestions.
- Anshuman
[1] https://patchwork.kernel.org/project/linux-mm/list/?series=123133
next prev parent reply other threads:[~2019-05-30 4:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 9:16 [PATCH V5 0/3] arm64/mm: Enable memory hot remove Anshuman Khandual
2019-05-29 9:16 ` [PATCH V5 1/3] mm/hotplug: Reorder arch_remove_memory() call in __remove_memory() Anshuman Khandual
2019-05-30 10:37 ` Mark Rutland
2019-06-07 2:28 ` Anshuman Khandual
2019-06-07 7:43 ` David Hildenbrand
2019-06-11 11:26 ` [PATCH V5 - Rebased] mm/hotplug: Reorder memblock_[free|remove]() calls in try_remove_memory() Anshuman Khandual
2019-06-11 22:19 ` Andrew Morton
2019-06-12 4:02 ` Anshuman Khandual
2019-06-12 6:53 ` David Hildenbrand
2019-06-13 1:54 ` Andrew Morton
2019-06-13 5:37 ` Anshuman Khandual
2019-06-13 6:14 ` David Hildenbrand
2019-05-29 9:16 ` [PATCH V5 2/3] arm64/mm: Hold memory hotplug lock while walking for kernel page table dump Anshuman Khandual
2019-05-30 10:42 ` Mark Rutland
2019-05-29 9:16 ` [PATCH V5 3/3] arm64/mm: Enable memory hot remove Anshuman Khandual
2019-05-30 15:12 ` Mark Rutland
2019-06-11 14:43 ` Anshuman Khandual
2019-05-29 22:06 ` [PATCH V5 0/3] " Andrew Morton
2019-05-30 4:23 ` Anshuman Khandual [this message]
2019-05-30 7:23 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6e3af6e-27f4-ec3e-5ced-af4f62a9cdff@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@arm.com \
--cc=arunks@codeaurora.org \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=cpandya@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=ira.weiny@intel.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=mark.rutland@arm.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).