Re: [PATCH v3 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one

David Hildenbrand
2021-01-12T14:41:11Z

On 12.01.21 15:23, Michal Hocko wrote:
> On Tue 12-01-21 13:16:45, Michal Hocko wrote:
> [...]
>> Well, currently pool pages are not migrateable but you are right that
>> this is likely something that we will need to look into in the future
>> and this optimization would stand in the way.
>
> After some more thinking I believe I was wrong in my last statement.
> This optimization shouldn't have any effect on pages on the pool as
> those stay at reference count 0 and they cannot be isolated either
> (clear_page_huge_active before it is enqueued).
>
> That being said, the migration code would still have to learn about
> about this pages but that is out of scope of this discussion.
>
> Sorry about the confusion from my side.
>

At this point I am fairly confused what's working at what's not :D

I think this will require more thought, on how to teach
alloc_contig_range() (and eventually in some cases offline_pages()?) to
do the right thing.

--
Thanks,

David / dhildenb