From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D4FC433FE for ; Thu, 12 May 2022 13:30:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8C596B0078; Thu, 12 May 2022 09:30:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E11906B007B; Thu, 12 May 2022 09:30:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C65696B007D; Thu, 12 May 2022 09:30:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B1A8D6B0078 for ; Thu, 12 May 2022 09:30:28 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8915431C16 for ; Thu, 12 May 2022 13:30:28 +0000 (UTC) X-FDA: 79457175336.27.8D857C6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id BFBB0200AA for ; Thu, 12 May 2022 13:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652362224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mhgzQ0sYOrkkd/icNMNnVcPCn+/prPaIhVzGXVb8GiY=; b=UCi3IjF9XeeL5oCCnXuVhrNj1WG4Tygz/EArcb2U/kkIfS7BzT3jDcjRVM5PipEpv7BoQ6 O//U6jTibHtWOivKE0MmcdqD/dXr+H2XMhkmKB6qT+Jtql2RTujBLb4Wg5f9Hm00LDmmWp H/cPvBaXsq5gZHF0TUSDV2hirrj00qM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-464-hCoBSy8kPZq-AYVzL1NSUA-1; Thu, 12 May 2022 09:30:23 -0400 X-MC-Unique: hCoBSy8kPZq-AYVzL1NSUA-1 Received: by mail-wr1-f69.google.com with SMTP id j21-20020adfa555000000b0020adb9ac14fso2066343wrb.13 for ; Thu, 12 May 2022 06:30:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=mhgzQ0sYOrkkd/icNMNnVcPCn+/prPaIhVzGXVb8GiY=; b=NILRkRo4ur0/NML9Yv9SkI4LhvI9Oq+Puh+YyDmAzhUoGLxfdlT5ZDmal9BP2+iODC J0Ts23NbyeN4ouu7rlHDHxcwUbzsFkzItmAG95BZP/KzdDBX3g79MMglqAYc50+o9ykA DAwc/qyl5YNpChwuQ9BScOyOB+PUIGpHFxszdA7C3AeZYDo/YipkwLFjqeIETAsiiPtl RyFo7k+MsIbmz8DvLZqi9FbRaITw1mFSub6F0NUhLfJZPTVX8qd4BmG9peA1s92dj1sL llHFEb1MvCct6fYO0wR9mjg4ridmu831rkw8g2bsQvjjZbNPUpCqSo0QYO1rTJQPOC1Z Nz9Q== X-Gm-Message-State: AOAM530Bjf4XzfrbJsgAkTqIwppt6NguHMGOvdgP9gWt7XjzvMaoTz7V tyPciFimfwrp6+cfe+VYI0LssDzrUDAaM92oXroiqPnjdvO8CAbcr/il11s1Ogoeh9SNqT9Zcmj i1CLVOmVYeM0= X-Received: by 2002:a05:600c:19c8:b0:394:7cb0:717b with SMTP id u8-20020a05600c19c800b003947cb0717bmr10336798wmq.136.1652362221788; Thu, 12 May 2022 06:30:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwverS5Puo2YeeGw5pQo/ZdVqDE+SwXK3m37sixe0PYqzGfxHuFJSC81mVsBxlHyxPIsbs3AQ== X-Received: by 2002:a05:600c:19c8:b0:394:7cb0:717b with SMTP id u8-20020a05600c19c800b003947cb0717bmr10336771wmq.136.1652362221596; Thu, 12 May 2022 06:30:21 -0700 (PDT) Received: from ?IPV6:2003:cb:c701:d200:ee5d:1275:f171:136d? (p200300cbc701d200ee5d1275f171136d.dip0.t-ipconnect.de. [2003:cb:c701:d200:ee5d:1275:f171:136d]) by smtp.gmail.com with ESMTPSA id s19-20020a1cf213000000b003942a244edfsm2697674wmc.36.2022.05.12.06.30.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 May 2022 06:30:20 -0700 (PDT) Message-ID: Date: Thu, 12 May 2022 15:30:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 04/15] mm/swap: remove unneeded return value of free_swap_slot To: Miaohe Lin , akpm@linux-foundation.org Cc: willy@infradead.org, vbabka@suse.cz, dhowells@redhat.com, neilb@suse.de, apopple@nvidia.com, surenb@google.com, peterx@redhat.com, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220509131416.17553-1-linmiaohe@huawei.com> <20220509131416.17553-5-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220509131416.17553-5-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BFBB0200AA X-Stat-Signature: aejy975tw6ahjzccghrx4i16mj4csy6x X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UCi3IjF9; spf=none (imf13.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1652362206-632126 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.05.22 15:14, Miaohe Lin wrote: > The return value of free_swap_slot is always 0 and also ignored now. > Remove it to clean up the code. > > Signed-off-by: Miaohe Lin Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb