From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93FB3C4167B for ; Mon, 27 Nov 2023 15:16:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03B2A6B0279; Mon, 27 Nov 2023 10:16:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F2AD06B0281; Mon, 27 Nov 2023 10:16:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA45D6B0292; Mon, 27 Nov 2023 10:16:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CB4CE6B0279 for ; Mon, 27 Nov 2023 10:16:26 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 96DC18032B for ; Mon, 27 Nov 2023 15:16:26 +0000 (UTC) X-FDA: 81504085572.29.93B60AC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 3311510002F for ; Mon, 27 Nov 2023 15:16:23 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=irhneUDB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701098184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o1OXRXgH1rWrRktsR3slBjqAkr3OAo4k1a/STq0C0Qs=; b=U7YLjpHJfiPYUSlslKxZK5UiRJnd69w1aPu+Ws+E2ReZ5vXoQKQXuicaxbxoyAG++2AlIo qvXUufbeTK5jLAWe1zduI7WSvsCqnY8/+EqnxmsHUg+x4H/YOCRewSUeStX69Iu92gdlua TnuRZPrfaZFe/OS/V37wBXM6bbhBGb4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=irhneUDB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701098184; a=rsa-sha256; cv=none; b=bi//ert5t4WMbaIcPkcbn1BzDMpAVfd7Ff4ObWC/58g3OjzKPumLr9Uyi2G6vQjy9IQImd wLT60/ZAk1O3brnCzAangzf7NI3ZRY/7es8vOYyl4+84Ik0trcXMH3UFjZiEQKr/nAIYFy dTAJDr46A7scKvXZwH0S7Wg6NqWTFf0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701098183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=o1OXRXgH1rWrRktsR3slBjqAkr3OAo4k1a/STq0C0Qs=; b=irhneUDBWJKuvCo30x/d4ehgw27sC28ICppmwKj7AEVVQG0mcf/oEa5cIn7lOSHhDuF8B6 LUh2yPs6zR7FyJFqhYJzAvKgcQmkOpdZ4vRlMnUcUxrx4lxuBx3PvDvLLbUCC0tS3It1B1 WFgY8dS4Wkcv0a4s4wqDfJsOxc8L8MA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-38-pQboJ3XBNFqIhViZPpaOXQ-1; Mon, 27 Nov 2023 10:16:21 -0500 X-MC-Unique: pQboJ3XBNFqIhViZPpaOXQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-333063a304fso451997f8f.3 for ; Mon, 27 Nov 2023 07:16:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701098180; x=1701702980; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o1OXRXgH1rWrRktsR3slBjqAkr3OAo4k1a/STq0C0Qs=; b=YbCJlxIW5aWUOidIv72NFZHQMyUjqjjpZarxzwl8WgXZ+s6wocf1PIV6yGcX1dymDd Dae7aasgJOFkGLJvBRHTNJHuF9vb7qvAvTNs9qaE1lkehCD0aLLalyQJO9m/EItd8s0o zy54wIN161B+NdGCKOq3ebZKM3P3lqzbgBslXfYUA9V62AzkdmkKiTfxZw2TOQZWhsE3 05jm6OLsg3RYTvg+E+GeJ5NAIHlCsp/RAKKxFoqwPyVhFJ+CxDwZPa9b5Fne2IKgB3QT vzXICqIR+qgB+Bgrk2w626fbhlZ+mfCdBd/8hjKyl2asMVlDS/Cg6HsIpDKLZmXSza6W rLkQ== X-Gm-Message-State: AOJu0YwqqYkaBs3REgyxa3l47IXe87mNrmaPaOjopjtRVQQR1n/N1JBP oqhqD3s6LpjBxOKc9UZcXzG3hWIsVpzAmUt0qEtfhi2eZ60SSJYR0A0qkQX3ZCjzBx+3ffpm94V Ty82JMkr2ShM= X-Received: by 2002:a5d:4c44:0:b0:332:eb19:9520 with SMTP id n4-20020a5d4c44000000b00332eb199520mr7667126wrt.20.1701098180022; Mon, 27 Nov 2023 07:16:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGzQsFhBN5+Rm7TrL4q2+K20IuTilKu8zrGTb/WG4m6sixc1+hiVZv4o7JOJ3sxL3PitYzrAA== X-Received: by 2002:a5d:4c44:0:b0:332:eb19:9520 with SMTP id n4-20020a5d4c44000000b00332eb199520mr7667094wrt.20.1701098179584; Mon, 27 Nov 2023 07:16:19 -0800 (PST) Received: from ?IPV6:2003:cb:c745:2a00:d74a:a8c5:20b6:3ec3? (p200300cbc7452a00d74aa8c520b63ec3.dip0.t-ipconnect.de. [2003:cb:c745:2a00:d74a:a8c5:20b6:3ec3]) by smtp.gmail.com with ESMTPSA id h4-20020adfa4c4000000b0032d8eecf901sm12397781wrb.3.2023.11.27.07.16.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Nov 2023 07:16:19 -0800 (PST) Message-ID: Date: Mon, 27 Nov 2023 16:16:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/5] mm/memory_hotplug: introduce MEM_PREPARE_ONLINE/MEM_FINISH_OFFLINE notifiers To: Sumanth Korikkar , linux-mm , Andrew Morton Cc: Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML References: <20231127082023.2079810-1-sumanthk@linux.ibm.com> <20231127082023.2079810-2-sumanthk@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231127082023.2079810-2-sumanthk@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: z5h3wtfsgkm6ez85tthtbqkajykmopx8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3311510002F X-HE-Tag: 1701098183-3855 X-HE-Meta: U2FsdGVkX181MVRBvK4dpqWsHoNYGfvWeemLLEhRL4ogGG5HyeyWlNAl5H8Lk+H1SwSQu6oxKf2ogCEOF20G5RuJNcSku+keM7CvbZjGE16OGEwLQO4YlzRiYedrctuidZtYN9EvHELtOzdMb9RydPpL2hQY8X3X97yYUFN158U9j453nKwf8Inup2IksuVKNnNFTD/yfLiutFHCza8LMqCTQ0m/2LZdeYLVLFJ+zLwHgYnI1cUywpXSyaqvEuMs+1xE9jzm+07mujPORgu2dVTy3pZVNe+AbVWv8fCua57lIhH9uq5sskHcbf382gPwG5Eo9TFB9FPXLnhPD6hEUhH07plRri3CH88KEfapkRDxf72U8A2y2l91+pgOb2209fOceHyCPVUNRASFSOwvNgjzTNsnjyShPr7MkrBx/rbKyWkhoarmeh532jC2Rq5GRqwaWszWBjPHofE0Abho1TxQkzma3kVFdLMbXTKRPKc7p/N/z5eE6OKDKHmgt3pK/low6J/oYe9kHaFv9xy6pT3iVfmb2nuOVGWoXm/mJ/QQXlK6eJ8NlbcKuBCX3wx2mR4PVZ78bbX46LqNlQxHNhe93yH4W/E0xNrm70BAUQm8AnyGQDfNOIw5DlgI73KqsXrhZ0g7T8M4HSs7cBusA9Lz+oVzbB69o2xN9StyYH9sCv9H81A+0zYvh2F5xFSBE+JmQAlXLrtZq0aCxQpak7dbAVQHngHujLo08UyMl0N/xzCwWg20gBuLWwvw5QcL1i7PxkkyK4/pkXgmComj8b6D94xNyTnv1J8Hf/qjHJXwl0pYDszrJT77Of4ayrOQ1URkDvVbFw+sSDm0KpTmNQtanDEcQ+PhFLCAyQwL8l+Q1ZWE3TVjNbqXJPOwBN6qWROWNRfqR+8mNVItUMUniU+/A2LWc4Hh4YZG1OFRDbQPDh61Eepcem/tR546zm+gYUuG3S5HJHgXBs3QnS9 GzFPU9rS TUWE/Zt+KaJCUFzj2Buv7OoteloQ8VUBK6nLPltEu008pztTuB9kgG7TROudMOJy/pZa/37ZN7bpl8/LR8ShTkNFZ76sgtaDbVKtfipGr8qBoQVAFdxJltU0nT61qUXs4h+QF6oqu2fP0dWuUIJe25pxB1Ia4dswjNZOdy8WEkoAX0disalcEkc0uVmAlwGUAZHcDtV1NWqC/3rwnM3UMdMvj/BLVmw9pVOC9olr8BEctrGxCDaRSKh7WKXFk1D2z3dAqaWawDBIyeLVghjXAjWwb0bPz7AS6PPmuen/Z9k6gKB0/qKgOCcLMOGDzPLs/+PuNyevuNbIlCXfR+cOYQbmtttHhthdaKoavb87fABrX5Xa6zrOVWvCJU0kdORttlp7LABkO9C3UrwQQqrp7NXZjs5bbLtDY7PJVMJbVDjb6Abo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.11.23 09:20, Sumanth Korikkar wrote: > Introduce MEM_PREPARE_ONLINE/MEM_FINISH_OFFLINE memory notifiers to > prepare the transition of memory to and from a physically accessible > state. This enhancement is crucial for implementing the "memmap on > memory" feature for s390 in a subsequent patch. > > Platforms such as x86 can support physical memory hotplug via ACPI. When > there is physical memory hotplug, ACPI event leads to the memory > addition with the following callchain: > acpi_memory_device_add() > -> acpi_memory_enable_device() > -> __add_memory() > > After this, the hotplugged memory is physically accessible, and altmap > support prepared, before the "memmap on memory" initialization in > memory_block_online() is called. > > On s390, memory hotplug works in a different way. The available hotplug > memory has to be defined upfront in the hypervisor, but it is made > physically accessible only when the user sets it online via sysfs, > currently in the MEM_GOING_ONLINE notifier. This is too late and "memmap > on memory" initialization is performed before calling MEM_GOING_ONLINE > notifier. > > During the memory hotplug addition phase, altmap support is prepared and > during the memory onlining phase s390 requires memory to be physically > accessible and then subsequently initiate the "memmap on memory" > initialization process. > > The memory provider will handle new MEM_PREPARE_ONLINE / > MEM_FINISH_OFFLINE notifications and make the memory accessible. > > The mhp_flag MHP_OFFLINE_INACCESSIBLE is introduced and is relevant when > used along with MHP_MEMMAP_ON_MEMORY, because the altmap cannot be > written (e.g., poisoned) when adding memory -- before it is set online. > This allows for adding memory with an altmap that is not currently made > available by a hypervisor. When onlining that memory, the hypervisor can > be instructed to make that memory accessible via the new notifiers and > the onlining phase will not require any memory allocations, which is > helpful in low-memory situations. > > All architectures ignore unknown memory notifiers. Therefore, the > introduction of these new notifiers does not result in any functional > modifications across architectures. > > Suggested-by: Gerald Schaefer > Suggested-by: David Hildenbrand > Signed-off-by: Sumanth Korikkar > --- [...] > }; > > /* > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 7a5fc89a8652..ac7cfc09502d 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1083,8 +1083,25 @@ void adjust_present_page_count(struct page *page, struct memory_group *group, > group->present_kernel_pages += nr_pages; > } > > +static void page_init_poison_with_resched(unsigned long start_pfn, unsigned long nr_pages) > +{ > + const unsigned long end_pfn = start_pfn + nr_pages; > + unsigned long pfn, cur_nr_pages; > + > + /* Poison struct pages because they are now uninitialized again. */ > + for (pfn = start_pfn; pfn < end_pfn; pfn += cur_nr_pages) { > + cond_resched(); > + > + /* Select all remaining pages up to the next section boundary */ > + cur_nr_pages = > + min(end_pfn - pfn, SECTION_ALIGN_UP(pfn + 1) - pfn); > + page_init_poison(pfn_to_page(pfn), > + sizeof(struct page) * cur_nr_pages); > + } > +} > + > int mhp_init_memmap_on_memory(unsigned long pfn, unsigned long nr_pages, > - struct zone *zone) > + struct zone *zone, bool mhp_off_inaccessible) > { > unsigned long end_pfn = pfn + nr_pages; > int ret, i; > @@ -1092,7 +1109,14 @@ int mhp_init_memmap_on_memory(unsigned long pfn, unsigned long nr_pages, > ret = kasan_add_zero_shadow(__va(PFN_PHYS(pfn)), PFN_PHYS(nr_pages)); > if (ret) > return ret; > - > + /* > + * Memory block is accessible at this stage and hence poison the struct > + * pages now. If the memory block is accessible during memory hotplug > + * addition phase, then page poisining is already performed in > + * sparse_add_section(). > + */ > + if (mhp_off_inaccessible) > + page_init_poison_with_resched(pfn, nr_pages); Can you elaborate why a simple page_init_poison() as for sparse_add_section() is insufficient? Apart from that looks good. Ideally, we'd be updating altmap->inaccessible as we online/offline memory. But then, we'd have to remember MHP_OFFLINE_INACCESSIBLE somehow differently. -- Cheers, David / dhildenb