From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 711C1C0015E for ; Tue, 15 Aug 2023 15:00:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3A438D000D; Tue, 15 Aug 2023 11:00:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEA968D0001; Tue, 15 Aug 2023 11:00:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB2548D000D; Tue, 15 Aug 2023 11:00:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9C36A8D0001 for ; Tue, 15 Aug 2023 11:00:46 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 51EFBA0DEC for ; Tue, 15 Aug 2023 15:00:46 +0000 (UTC) X-FDA: 81126650892.16.D2B8BD5 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 82C022002A for ; Tue, 15 Aug 2023 15:00:27 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=IjwLxs1i; dmarc=none; spf=pass (imf03.hostedemail.com: domain of axboe@kernel.dk designates 209.85.214.172 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692111628; a=rsa-sha256; cv=none; b=7mxLDqH29flu69DasXQcGJdtnR+EZGdWHGB6Jp3qY6vwjgGxzT1C7VE+iDqXrlW7sWAskG XImSnCa4spL2SbpQrgbaDoyqGjniiIOab5afAdVuCG3FoNDw/qUuKFPHXpkHTu2bmZ8xQl o7yiptflAQDqPTOB/xZKrXxXI8j6SH0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=IjwLxs1i; dmarc=none; spf=pass (imf03.hostedemail.com: domain of axboe@kernel.dk designates 209.85.214.172 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692111628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xvqxlqxzsVAJ46UIRkOeQ1JiGfSUv1oeEKgluy2xoMM=; b=Njbq/RBOQq9HE/mIPMWM76terW32VuLoM/5wiOxClhyyeRXx2hIxItdrjv9IKzKF2GFNdV KnGrTtW1V46tXQdM4IlCL9GIUMH0JtnT1wCcK5syKmS9HLdlq2FdR2r/sndogrm2McEtLA bBWTJqkQCLAKmNSX+QenAKi1vC0kzgw= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1bba9539a23so9669025ad.1 for ; Tue, 15 Aug 2023 08:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1692111626; x=1692716426; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xvqxlqxzsVAJ46UIRkOeQ1JiGfSUv1oeEKgluy2xoMM=; b=IjwLxs1i2cRXFErJCc3RVVRoQhhpeM+vTnR3TVX0SPIqpZ96YFqSFVeO0u+ReI97xN HwQyEOI+rEvFGWFpDurMX4cudGmheQmaUlsW5njwqByLnOa+oLxfr8yLgdAMY78VN4iF Lhw7Qd+mGTmcca73r06X58eSZxIM2RwHDDfjCgtL0ZEiBrILcsw7mPpUCvDPwuuIQePJ cAC+I1QGh3IC/kCtbzsnfewZnONR0qRT1qolthuQUJ5VEMaEeS5ptUJaqldkphXu9CTC cO9WnRAMNC2zBkKXDAvgeTcc10j7zKRnU6VZQVfibMyxoqYZmd4U+HJxgLKJOtUKhfCL 0U3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692111626; x=1692716426; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xvqxlqxzsVAJ46UIRkOeQ1JiGfSUv1oeEKgluy2xoMM=; b=Q9phuPGtCFPq71O8GyoBuurgr/nn0oUTLHQabV7RrPOMzFH2C5RVYp/F9YtOA3Vxw1 3HvF/VaceM9J1eTJ6oXykCheYwp+t9JCxnWUK7Md2eo3CZJ2IR8/aWFQNPKPuCVlR01J +EuEi3zXAHFnDz4ZiPUxTBYJDE/kZnjDzYRVMI1NQv7VOlbRZhEfttblKZuvc7s2XOBy y85fMW9dUlLtEIRloubZT0eybDdsxHgm305eik88xU9TD0f852OC8h7exSEb1T2UsYwN jiq3pcfICB84pSVCmNt0u/HTRAaynC5FIAI5/rRq33KkJyBW+6MvJ8J80ixRBcKsR5HB w3sA== X-Gm-Message-State: AOJu0YxOoxwjsA+dQRlyG3rSGtlLnpf/+HsujegAiGrRreGWDh709PTu 2UAaFrYVV/qiyqgw4LN6PV1FAw== X-Google-Smtp-Source: AGHT+IHTcfCAouoFt9jaHxx++mKI4f8nYXgerY0VSo0LZQWeVWuAeFftHJLdexQX+pBgCDDk6N0j7A== X-Received: by 2002:a17:902:cec1:b0:1b8:9fc4:2733 with SMTP id d1-20020a170902cec100b001b89fc42733mr15493619plg.3.1692111626540; Tue, 15 Aug 2023 08:00:26 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id t12-20020a1709028c8c00b001b8b4730355sm11167033plo.287.2023.08.15.08.00.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 08:00:25 -0700 (PDT) Message-ID: Date: Tue, 15 Aug 2023 09:00:24 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/9] io_uring: Stop calling free_compound_page() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: io-uring@vger.kernel.org, linux-mm@kvack.org References: <20230815032645.1393700-1-willy@infradead.org> <20230815032645.1393700-2-willy@infradead.org> From: Jens Axboe In-Reply-To: <20230815032645.1393700-2-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 82C022002A X-Stat-Signature: je936xcpzyg5qooggu8apchx3ih51ciy X-HE-Tag: 1692111627-460095 X-HE-Meta: U2FsdGVkX191RzjPsrBMpguJLwFrhXhr9A6Lhvsm50/VBbduEV9uVdVHAvUm8aLf0RFoWjQS6AZWOlQYu49eEtx0pchO84GuCCgl68xQhpzQ5gWRe89mDusjqJEBWL6cc9JNR+VJo9LHWoa7C8WZc3bvDdTaiU/cAClQqu5Jpb67AdoiKGJy5nTpV+jFOHfD+4VJipYZKuSF3ZQ2pGUCpsBgExmDrx9KCT2J+SZudPkziluPBSr6mEyYJqdnN/VagVACw7HJncAZBp/4ZR45A9HU30x3V3SjVGTObXQQQ4SejAm/qYLug2aInanEhtPGTimb97YCQ5qhs1W1smC+rW6IkG8WDyqQbiNQV+zDDJtG6W/9OUEFcwFl3P/Hda4p6R7nTKzj4sIGDMPm9rAYqtyaxbrbON7LjALrJT0z6wn2ZBn6asme3mnMbxb5h0znTH4vBuMo4op2ybUGi5VFTpZwlIDvTKAuwvhGCRcDkHWrnyCDMAmfhLAeuiVL+T+laxxjFG8U4Vqfn+f3xKl4jYtyjXgLji5G4/gtTiuFBTdOugl9rcPREzZmtg1ggaUyl2iLEeR++HYJXDTU3RdzqTP51OeSkFzfsouOVcr2NWyR2Es76Ws1K7lnwKpVCYodtcwd0QxC3ndAQP0fko4ktLU78wWBhyDvkT+aTB2OseVVq64v67Q1YN3L2qwJXt/hQjlBJwgeyI8qvky9V+oOVGM9+85VnWbvOgcMmX1ddvAta/RXLuYsu7xgQRm3cAJqovw/LDaWPQlLYU4acRP+DmS8+R099dgax8rbu/vQ4G+RMcm94w9EduTIuUsqkuJ6K361nKqVXQB8OMYCO1yXCUtgXZOfosWPTNu1h7sxIGy8k9h8pKtUkAQZkBaDKunud9MbRarLTsFtyU+Ely9722V2oa5lVAxAb8ku6nNdux0+rZ6M772OfW96zofjB08QuW/OLFNKD2P5MvIEIPr HgvCr3QN lBjY/LbNCh5oNUWyuqBQyyQSQy+1/IADFFg6JlNkDtmo69RroCoR5uBwr703LjRQ95yMqyJo1FrLaFU513MUQyhB0JWA4Wf4Q+q0aBVwCRCK8jFSSYp7vFWXK7DJzw1kaGn6hFBg1o+RSR4dhO0bKkcorZ7Om1xl6h2FkVabBSJH2Qyynq3RWr+6hKnjWLRJeyGlfitHGGGpy/ouayU2uLsY0/ncDYhVr9m9YU7u5ZP6he8aF4Dvdh4n14rHx1TWYByOB/6+aQP+idfeMdIruIVWndQFzFvMESXZPuzIc3fafbuRKfDsCzZopg4Hay2bMkCTpFgzp/nUooovnNRo9ETlVGcCwLiYQw8Ie1YAmJDbJ2o7t85eLRbCQcdDF+wKdZjACCqh9lQSetNuESbvFwmM3ALTcBEea1bd5wVkxkb/hn1+4RCsjyg6xSXoisEbQuTrU2PLU34BkRjIfDOiFMDc/DYp3m6VgnfWf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/14/23 9:26 PM, Matthew Wilcox (Oracle) wrote: > folio_put() is the standard way to write this, and it's not > appreciably slower. This is an enabling patch for removing > free_compound_page() entirely. Looks fine to me, nice cleanup too. Please use 72-74 char line breaks though in the commit message, this looks like ~60? With that fixed: Reviewed-by: Jens Axboe -- Jens Axboe