From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2935FC433E0 for ; Tue, 9 Feb 2021 04:03:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A005164EB8 for ; Tue, 9 Feb 2021 04:03:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A005164EB8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0A1A56B0005; Mon, 8 Feb 2021 23:03:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 052126B006C; Mon, 8 Feb 2021 23:03:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED1C86B006E; Mon, 8 Feb 2021 23:03:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id D44606B0005 for ; Mon, 8 Feb 2021 23:03:23 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 90A23B7A4 for ; Tue, 9 Feb 2021 04:03:23 +0000 (UTC) X-FDA: 77797384686.08.man94_1e0b58527604 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 655C81819E637 for ; Tue, 9 Feb 2021 04:03:23 +0000 (UTC) X-HE-Tag: man94_1e0b58527604 X-Filterd-Recvd-Size: 4757 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Feb 2021 04:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=bMQrY5xxsyDu8SQKzHqPdOnXD4jQMrGQMm3kjadDQRg=; b=h8azyEwsxshv+2rXTvkoXaEOel lvrShDE2SrJmZUpDB4xlX60rrU8yrEUB3ABc6E7NpyWJK0r8xeZbWak3N1/yiW5hoRmFQErLB+OcW GLn92E1W00bgpx4W11hCXw2aicT/wso3KTDCJbQVjzVzBHUfmsXwA+bXYjlhlIVrnsb5YWjq3g+gu 3rWejYtMXGdZZMJwaKFzQTdGYhmzjooANexaXIjiW23Aa2AngBmklT37UuFOT/59/FNoQIj0Mka/V nRZeWcqrjCffYuvKUqpiU5C7afVAbX0YWpx6HYxzSvOoPARSThCmJAmyx+R0ltqb2bdpvZGiCLxY5 vJtFbdaQ==; Received: from [2601:1c0:6280:3f0::cf3b] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9KF8-0002fr-Gv; Tue, 09 Feb 2021 04:03:14 +0000 Subject: Re: mmotm 2021-02-08-15-44 uploaded (mm-cma-print-region-name-on-failure.patch) To: akpm@linux-foundation.org, broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, Patrick Daly References: <20210208234508.iCc6kmL1z%akpm@linux-foundation.org> From: Randy Dunlap Message-ID: Date: Mon, 8 Feb 2021 20:03:09 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210208234508.iCc6kmL1z%akpm@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/8/21 3:45 PM, akpm@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2021-02-08-15-44 has been uploaded to >=20 > https://www.ozlabs.org/~akpm/mmotm/ >=20 > mmotm-readme.txt says >=20 > README for mm-of-the-moment: >=20 > https://www.ozlabs.org/~akpm/mmotm/ >=20 > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > more than once a week. >=20 > You will need quilt to apply these patches to the latest Linus release = (5.x > or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated= in > https://ozlabs.org/~akpm/mmotm/series >=20 > The file broken-out.tar.gz contains two datestamp files: .DATE and > .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm-ss= , > followed by the base kernel version against which this patch series is = to > be applied. >=20 > This tree is partially included in linux-next. To see which patches ar= e > included in linux-next, consult the `series' file. Only the patches > within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included i= n > linux-next. mm-cma-print-region-name-on-failure.patch: This causes a printk format warning on i386 (these used to be readable): In file included from ../include/linux/printk.h:7:0, from ../include/linux/kernel.h:16, from ../include/asm-generic/bug.h:20, from ../arch/x86/include/asm/bug.h:93, from ../include/linux/bug.h:5, from ../include/linux/mmdebug.h:5, from ../include/linux/mm.h:9, from ../include/linux/memblock.h:13, from ../mm/cma.c:24: ../mm/cma.c: In function =E2=80=98cma_alloc=E2=80=99: ../include/linux/kern_levels.h:5:18: warning: format =E2=80=98%zu=E2=80=99= expects argument of type =E2=80=98size_t=E2=80=99, but argument 4 has ty= pe =E2=80=98long unsigned int=E2=80=99 [-Wformat=3D] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ ../include/linux/kern_levels.h:11:18: note: in expansion of macro =E2=80=98= KERN_SOH=E2=80=99 #define KERN_ERR KERN_SOH "3" /* error conditions */ ^~~~~~~~ ../include/linux/printk.h:343:9: note: in expansion of macro =E2=80=98KER= N_ERR=E2=80=99 printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~ ../mm/cma.c:503:3: note: in expansion of macro =E2=80=98pr_err=E2=80=99 pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n", ^~~~~~ ../mm/cma.c:503:45: note: format string is defined here pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n", ~~^ %lu because the type of count is not the same as the type of cma->count. Furthermore, are you sure that cma->count is the same value as count? I'm not. (also s/convienience/convenience/ in the patch description) thanks. --=20 ~Randy