RE: [PATCH v17 05/18] cxl: Add Get Supported Features command for kernel usage

Shiju Jose
2024-12-11T17:58:46Z

>-----Original Message-----
>From: Shiju Jose <shiju.jose@huawei.com>
>Sent: 09 December 2024 14:28
>To: Dan Williams <dan.j.williams@intel.com>; linux-edac@vger.kernel.org;
>linux-cxl@vger.kernel.org; linux-acpi@vger.kernel.org; linux-mm@kvack.org;
>linux-kernel@vger.kernel.org
>Cc: bp@alien8.de; tony.luck@intel.com; rafael@kernel.org; lenb@kernel.org;
>mchehab@kernel.org; dave@stgolabs.net; Jonathan Cameron
><jonathan.cameron@huawei.com>; dave.jiang@intel.com;
>alison.schofield@intel.com; vishal.l.verma@intel.com; ira.weiny@intel.com;
>david@redhat.com; Vilas.Sridharan@amd.com; leo.duran@amd.com;
>Yazen.Ghannam@amd.com; rientjes@google.com; jiaqiyan@google.com;
>Jon.Grimm@amd.com; dave.hansen@linux.intel.com;
>naoya.horiguchi@nec.com; james.morse@arm.com; jthoughton@google.com;
>somasundaram.a@hpe.com; erdemaktas@google.com; pgonda@google.com;
>duenwen@google.com; gthelen@google.com;
>wschwartz@amperecomputing.com; dferguson@amperecomputing.com;
>wbs@os.amperecomputing.com; nifan.cxl@gmail.com; tanxiaofei
><tanxiaofei@huawei.com>; Zengtao (B) <prime.zeng@hisilicon.com>; Roberto
>Sassu <roberto.sassu@huawei.com>; kangkang.shen@futurewei.com;
>wanghuiqiang <wanghuiqiang@huawei.com>; Linuxarm
><linuxarm@huawei.com>
>Subject: RE: [PATCH v17 05/18] cxl: Add Get Supported Features command for
>kernel usage
>
>>-----Original Message-----
>>From: Dan Williams <dan.j.williams@intel.com>
>>Sent: 06 December 2024 21:41
>>To: Shiju Jose <shiju.jose@huawei.com>; linux-edac@vger.kernel.org;
>>linux- cxl@vger.kernel.org; linux-acpi@vger.kernel.org;
>>linux-mm@kvack.org; linux- kernel@vger.kernel.org
>>Cc: bp@alien8.de; tony.luck@intel.com; rafael@kernel.org;
>>lenb@kernel.org; mchehab@kernel.org; dan.j.williams@intel.com;
>>dave@stgolabs.net; Jonathan Cameron <jonathan.cameron@huawei.com>;
>>dave.jiang@intel.com; alison.schofield@intel.com;
>>vishal.l.verma@intel.com; ira.weiny@intel.com; david@redhat.com;
>>Vilas.Sridharan@amd.com; leo.duran@amd.com; Yazen.Ghannam@amd.com;
>>rientjes@google.com; jiaqiyan@google.com; Jon.Grimm@amd.com;
>>dave.hansen@linux.intel.com; naoya.horiguchi@nec.com;
>>james.morse@arm.com; jthoughton@google.com;
>somasundaram.a@hpe.com;
>>erdemaktas@google.com; pgonda@google.com; duenwen@google.com;
>>gthelen@google.com; wschwartz@amperecomputing.com;
>>dferguson@amperecomputing.com; wbs@os.amperecomputing.com;
>>nifan.cxl@gmail.com; tanxiaofei <tanxiaofei@huawei.com>; Zengtao (B)
>><prime.zeng@hisilicon.com>; Roberto Sassu <roberto.sassu@huawei.com>;
>>kangkang.shen@futurewei.com; wanghuiqiang <wanghuiqiang@huawei.com>;
>>Linuxarm <linuxarm@huawei.com>; Shiju Jose <shiju.jose@huawei.com>
>>Subject: Re: [PATCH v17 05/18] cxl: Add Get Supported Features command
>>for kernel usage
>>
>>shiju.jose@ wrote:
>>> From: Dave Jiang <dave.jiang@intel.com>
>>>
>>> CXL spec r3.1 8.2.9.6.1 Get Supported Features (Opcode 0500h) The
>>> command retrieve the list of supported device-specific features
>>> (identified by UUID) and general information about each Feature.
>>>
>>> The driver will retrieve the feature entries in order to make checks
>>> and provide information for the Get Feature and Set Feature command.
>>> One of the main piece of information retrieved are the effects a Set
>>> Feature command would have for a particular feature.
>>>
>>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>>> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
>>> Co-developed-by: Shiju Jose <shiju.jose@huawei.com>
>>> Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
>>> ---
>>> drivers/cxl/core/mbox.c | 179 +++++++++++++++++++++++++++++++++++
>>> drivers/cxl/cxlmem.h | 44 +++++++++
>>> drivers/cxl/pci.c | 4 +
>>> include/cxl/mailbox.h | 4 +
>>> include/uapi/linux/cxl_mem.h | 1 +
>>> 5 files changed, 232 insertions(+)
>>
>>Hi Shiju,
>>
>>So I commented yesterday on this patch that is also duplicated in
>>Dave's series have a merge order ordering plan to propose.
>
>Hi Dan,
>
>Thanks for the suggestions.
>I tested your suggestions for CXL features commands in the fwctl series, in the
>EDAC CXL features setup, as replied.

Please find updated patches for your suggestions are shared here.
https://github.com/shijujose4/linux/tree/edac-enhancement-ras-features_for_v18

However next version (v18) of EDAC series will send after receiving feedbacks from Borislav
on v17 EDAC patches.

>>
>>> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index
[...]
>

Thanks,
Shiju