From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9180C3600C for ; Tue, 8 Apr 2025 09:52:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F16BC280002; Tue, 8 Apr 2025 05:52:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC4D8280001; Tue, 8 Apr 2025 05:52:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3E0E280002; Tue, 8 Apr 2025 05:52:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B5573280001 for ; Tue, 8 Apr 2025 05:52:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BD426AD064 for ; Tue, 8 Apr 2025 09:52:26 +0000 (UTC) X-FDA: 83310411492.19.696A9B5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 5BC65C000F for ; Tue, 8 Apr 2025 09:52:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WHv5fXN7; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744105944; a=rsa-sha256; cv=none; b=qmb8xd5jwtbm7ugKcd6d46twsxhIxH0oEVTNaytqWuefNLsMbe3G66I/wA40th7sEvcsMT CRlTZWuZGfa/qOqX2NPzbLa6I7E8mKtJ7HwYt3p3GFGqW9GhpttIbYGI7ce02xpJ4bkFnF OGoESZGSJfWnh6Cjw+k7PUq1giZPSQQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WHv5fXN7; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744105944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5OZHISnONE4t2902PGwoKIvjQlqckwAUXfpsZ5bT8VE=; b=KFA2pVrWpgjzrjYdbCpco9HQkSUWLouFCJAg8txQwPJMyWEZIWCCtw5pN5zYakGHX2vnMu fjeUIeEQqeNi58w552jL4km9vrGm+X2LuxA3wn2eBW0n6QpM//uW4pXFg/oA3GoPkzcQCp to/zCJLst43gDo9nxad3yd/wtMtvjGE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744105943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5OZHISnONE4t2902PGwoKIvjQlqckwAUXfpsZ5bT8VE=; b=WHv5fXN7u0YVP7eRLfdCTTD5Zp4RrYncUC6E3wXZ/cheLbRO9uuXiARy4V3Zyxt0R6y6zZ sBwo1KuWHW0Xjr40LpzkUcjCvEuFB6BTGIlGsnbDZ9N809U9yU3UcwniyXHOj/MkBmcB3d 0d8M78Ir09aILe2Fwv/AMcz6/kPXrjM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-526-pwM0fexAP3yYN8sLeUwKlQ-1; Tue, 08 Apr 2025 05:52:22 -0400 X-MC-Unique: pwM0fexAP3yYN8sLeUwKlQ-1 X-Mimecast-MFC-AGG-ID: pwM0fexAP3yYN8sLeUwKlQ_1744105941 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-39c2da64df9so3546304f8f.0 for ; Tue, 08 Apr 2025 02:52:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744105941; x=1744710741; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=5OZHISnONE4t2902PGwoKIvjQlqckwAUXfpsZ5bT8VE=; b=uttfZMJLheslEF4OGl99APS0tQ5sZG8h3FRGU/G7Mg38kANdhiPlgNlNXO3qTx48KP DE3WPdYAO0554NL7WmE95tJ6fFUrLncB1WDHzcNCQlnuoYTSNtIfSC/N4OVhngEpFrRj 6e1i0gMOtDOSn+vIXq5wTye/wsYHwSQ/d1HbwS6zbDCOePB2DtYsrmdxIAXgP4Vg91K0 3Bb3dJsFc/T/PD69avIVPxnwkxY+lIJxQCykzMHjXXoAiKTo7EeXZs+Jg7IvRfczbjad MN+ZKkMmTrCuppA/vxCEh9qkJ/2Z/uiGLeQjPGB2OBQH+exZhDnfhmfcV89mNXUR2lJf a7sw== X-Forwarded-Encrypted: i=1; AJvYcCUhlPOCt26D2TRM5dnrXfRp7xDgRTdf8rK3BH0G0gDw/OdqsCFobjE2+b8pRwz2i/mBEfjcMfQ3hA==@kvack.org X-Gm-Message-State: AOJu0YzmB2Jvq0hDZopCmQMUKE1PZU1G4fjQD5qdVwfkMc/ZttDGCpCx B98zUp3gP5fZVND4AF+Op3acK5KE3dFG8aYLEu5HUsb+y017EBWir/fJksG4vypPP3z/yax9/wQ mQAN/exZC0SDaOhyRRxBcJaZKExllOzHLmN+vjttUVL+nWwwv X-Gm-Gg: ASbGnctCxVTpUtiirb42Z4CaaSg2F/LaQz3ojaWujwL28T9jyt+2Gex4oVLJO85zPFf tTR1rGRw1PpvAP25C8CX332xeVK3bo0XSvqYjeHclVQAaNwpfsGzgcidjxsz64O3/0oXwH1Gz/r 65kyhOpYVDBMQUNAOOrP2atbsURRkVfaWMnDEAvKDCc8XcOTBcWRARC/QkPUlKWPyvFw4O2SfHG Mji3JliIf35soVz0H9YFu7UFd4XTSglS04PW0oiexcqcTjokCkUkEoS8AVnG0tQqpEQlcgQsMIP 6yESBdr+fRMkFINGH/spd/4wijruToBECIU4Y6mABu9qgGBGZkGuE8Jv4DWNTniHoLlPe4IMYuJ 2uDQJ/ZrWCEGr7COjzXVHDqBfenbl6pSbMyzKPboH X-Received: by 2002:a05:6000:2702:b0:39c:1257:cc28 with SMTP id ffacd0b85a97d-39cbc73213cmr8872981f8f.59.1744105940821; Tue, 08 Apr 2025 02:52:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF2gVGfjfruzCCWFTilzPtgfgunNMxeHGGBQBFO5rsVQP+31PZLP2Be7Tye6UxULUDwvgznqQ== X-Received: by 2002:a05:6000:2702:b0:39c:1257:cc28 with SMTP id ffacd0b85a97d-39cbc73213cmr8872975f8f.59.1744105940450; Tue, 08 Apr 2025 02:52:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:4f00:a44a:5ad6:765a:635? (p200300cbc7074f00a44a5ad6765a0635.dip0.t-ipconnect.de. [2003:cb:c707:4f00:a44a:5ad6:765a:635]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301a727bsm14307091f8f.27.2025.04.08.02.52.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Apr 2025 02:52:20 -0700 (PDT) Message-ID: Date: Tue, 8 Apr 2025 11:52:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] mm/gup: fix wrongly calculated returned value in fault_in_safe_writeable() To: Baoquan He , linux-mm@kvack.org Cc: akpm@linux-foundation.org, osalvador@suse.de, mingo@kernel.org, yanjun.zhu@linux.dev, linux-kernel@vger.kernel.org References: <20250407030306.411977-1-bhe@redhat.com> <20250407030306.411977-2-bhe@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250407030306.411977-2-bhe@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: eV-Aodpgq0pIGDtO5s6yBaPWVdMFCFh5Bj4QXOJ0wvI_1744105941 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5BC65C000F X-Stat-Signature: mixu9w1m7fsyirarb5i9cug153t6fwr4 X-HE-Tag: 1744105944-467146 X-HE-Meta: U2FsdGVkX19wQ9JrWnZTVF7SGqlDcMzrDTaoJIj5yZeTU1+Kv84EAi0KX2SdV1+OP9z8BXDtHWTnHEX+kBvDUN/g/aSVxhu/bv8PJcraxQ5ZH3VAOQaiorQgbp1lF+vVYbDQ3TjZ5kCDeKadLREm6Tzb+DY8q7a5WzG+Nhh1KZe0fpPzLNxDOi7grr4LNFPPX302Wik4kIodKEjBaa9tM9/VbL7NUvMO2X+JGOUe2oQlANEEh/yE7tyymyvH8+nQlWJVzH47rlOmXfYcz7gAo3n4HV83l0gBhGaMUeSVfIPEOmS3nctOksR1FyeZiR6zn/7Ah2Ye9s9yPLuOGJMjTUNAjYMj8c5rLH93/xL6+bxLF9du2sFtKZ5NnOn0XzKeeXPQE4NTD8sEZMNpD7Y+1UZMdK6QcqJmc50YuhjVopfTKGBySkvjK1ZpO6dEfcyjdjlkkBhPbtoLJjETXp+SKw2u3+BLj5irtaa5t7o7wdGq5PI4/8oUYGbJuFsgpFTaUNYZ+IHsLSS3av9xQ91oVf0zJieNQPxq2qNw8L1vkxZ1tUac5s6nO0qD+x4GWeKJtuT5Cx9tOeHuAyE4FY9rpMpxoI/+5nENCwUXQ8SD+aRNmEQT7/9Vuq0ogOL4Wvw7bWBJ5byLYWKOo58Y7fNd8UjMKGVObUaO+t35xLeyKMrpTZB2sEmrfpNIjnFuW/IUgH9Hrzobw6eAXeA6zbUN3lqq+cZugnXuUwvs/ZQIfjRmaAxkYcsTbT1OsTfAd8GTaBl8eRZcre7MelwJ/k2B6zmHiMPrvzJ34ZlXMgaDGnXLzVFAZK4GkjdjENGLlbrb62uF344VDcfPlKa2+zzc5Al+sJcSmwHlyMwAKGvCFv86+l5sX2ZQimDtHJ65q/9eMJ6Nnm153hsJPKvHgIy+qTHomkTlcg7AGfI6VTs/7/EKaTPsuFwkC/MUMLwcaOtXFj4LTo9K1WIkHb5zlTM +8AdVfiw S0rM1iomgNUSwoD2GUY2Oa+ZUs2SXHoTDRpQxyq/iOvCWVgkdeSVaz2/SiVYsDJUKhsoxVZhzAAmPe/qCuSy0gSkIMw90/zTUwXe4EpWibPEb0aEY6cppQfC2TqkzVSfpuI7o3Yhb9jQXIWDOUwExQkfl/Djn/0BYFur3GjMcKqjpwdHa/RJ1elLLvQIb5Cp2Zx6lHZpqdw62UqJlHa3fIf98sdiLc2Al0bzwH5srX7v1svksRqnWzzNpkejz0Vxlefw0j2+GRhuJDxzUEepd2Bqg1knTDRodla1RGP+BQx0V73uwntak74YEWN9EICVimkv1qbHAoKb1LCorCAAiLhFl0WyMqWGHGQr3oLBmlmiR8H3syr5T5MfzznhUIIMwgRZXfTNgUBRJhmvvv6KsMhHntDzE5d53aaQrHSDbLzbaiOCM4hkrmGI6Hv1sup8vpBg8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.04.25 05:03, Baoquan He wrote: > Not like fault_in_readable() or fault_in_writeable(), in > fault_in_safe_writeable() local variable 'start' is increased page > by page to loop till the whole address range is handled. However, > it mistakenly calcalates the size of handled range with 'uaddr - start'. > > Here fix the code bug in fault_in_safe_writeable(), and also adjusting > the codes in fault_in_readable() and fault_in_writeable() to use local > variable 'start' to loop so that codes in these three functions are > consistent. > I probably phrased it poorly in my other reply: the confusing part (to me) is adjusting "start". Maybe we should have unsigned long start,end,cur; Maybe we should really split the "fix" from the cleanups, and tag the fix with a Fixes:. I was wondering if these functions could be simplified a bit. But the overflow handling is a bit nasty. -- Cheers, David / dhildenb