From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C583C27C76 for ; Sun, 22 Jan 2023 11:49:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B24C96B0072; Sun, 22 Jan 2023 06:49:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AACB26B0073; Sun, 22 Jan 2023 06:49:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FFE16B0074; Sun, 22 Jan 2023 06:49:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7D98A6B0072 for ; Sun, 22 Jan 2023 06:49:39 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 583D1801F2 for ; Sun, 22 Jan 2023 11:49:39 +0000 (UTC) X-FDA: 80382265278.01.8281AEA Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by imf20.hostedemail.com (Postfix) with ESMTP id 6096F1C000B for ; Sun, 22 Jan 2023 11:49:37 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=caIlICVg; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf20.hostedemail.com: domain of krzysztof.kozlowski@linaro.org designates 209.85.221.47 as permitted sender) smtp.mailfrom=krzysztof.kozlowski@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674388177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L18XUoVuVYI0pnqHwuAZ/a/gl46rC1ac5Z5pGu4tjjA=; b=cJOOm8XkRyFliMiZLu56U4Uudw3OHKOpf3vFk+tdSO4TOrGm5womy48YDopLDQP3JmVokX keQcl+3zN+ZoeF8t+afxWXyJlMozZ15D6eJjw8woTmlQ5WUWUgOi4L9A79p0LRdEPCoII5 3byvl5cgZci+6Vjn2tyh0uoB7IeIjXE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=caIlICVg; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf20.hostedemail.com: domain of krzysztof.kozlowski@linaro.org designates 209.85.221.47 as permitted sender) smtp.mailfrom=krzysztof.kozlowski@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674388177; a=rsa-sha256; cv=none; b=OcPPKTJaUGP5xXJ935G2VUnWUGDSaUjzvMCKGDSnHKsW0i+J3kbIXB5TtxujRcUmeq9sV+ Xc05WBjLmYzl6ofk87AhPyQsAb5cKkD8jg9GCwe1QYW6+a27VMbBCbaxGGyw9CYHsWuz6R oXLbyXlUxOT1JsR4jfFf236yBgD2iDg= Received: by mail-wr1-f47.google.com with SMTP id d14so4778158wrr.9 for ; Sun, 22 Jan 2023 03:49:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=L18XUoVuVYI0pnqHwuAZ/a/gl46rC1ac5Z5pGu4tjjA=; b=caIlICVgjiM2KQmWSw2+dwCmFwH/QmHP5Tpt6H6wVsFqVFanIJ1vuRkXD5LMYCDALE NRjmF+0baehzfnLLnyNncgVe/LMpVF+yHU61SKAbBoH7z61KGzW5m7flF/bFqihPw1Fn O2fP7zc3nkMy81LxNCpHIWtu94zfu5UQvaOFSsNE8v5AYfQqfr8/s8K8Erb8fkRN+yAG wkyY17RV1LAoGfa7M6MaWtFsVRYyBEJ/Cn1lnFbJ+7C3TkgZU6XRz0KkmJz40bv2YJcl sWZRDoQaWXDOf5NedqV2uevyts9HBVC/g4grs5Il5oF6YrOPf4Yvjvay3LwHgph5/uVF hkvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L18XUoVuVYI0pnqHwuAZ/a/gl46rC1ac5Z5pGu4tjjA=; b=PRvWhgaRU5lDOHcDX2Y01Ntw2gOAVHhoDhQP265kp4xRHlw0po1KGOL9YBbwPQeq5k XlA0gf6hKE74ym3HSu+Rahhzdb5lsncc8i6nkiYJsfAkXzVfVXKE/zvXjQp744/wt10f eFKC3+swC8+KlnIdqwf13IoB3cbJhAKX410Td+ee4cPwC3y/HgvZXmst77xMnMo2uxVO +r5CcaXkc059Bi/cjnGs1s+5y9m4gsVPe3bWVGyNokZF5OaeDGvEFYzN6ETGjsSTdtVu KE7xC53CzmB0MBc8OUj6TrGfjMPJe+DpmtC8FqUa+o/9dzs+/rQ3qsivGeR+NTB7Zx98 yGTg== X-Gm-Message-State: AFqh2kqaN3uUntQegQ7vIFF2UGYy19QStMVLa9wKN+wE7dAUIhpOMgvA 1W597i6snPs9b/6MMNFHM24mtw== X-Google-Smtp-Source: AMrXdXuO4A8xyx6+67tnt5vSccGnQfMst13iHm3i0RgTmN8zIeWyW0hP20D/R/sapznzyBbbSLIUpw== X-Received: by 2002:adf:f606:0:b0:24b:b74d:8012 with SMTP id t6-20020adff606000000b0024bb74d8012mr17321312wrp.18.1674388176056; Sun, 22 Jan 2023 03:49:36 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id m8-20020adfa3c8000000b00236545edc91sm1740479wrb.76.2023.01.22.03.49.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 03:49:35 -0800 (PST) Message-ID: Date: Sun, 22 Jan 2023 12:49:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [RFC PATCH v2 05/31] Documentation: Add binding for kalray,coolidge-itgen Content-Language: en-US To: Yann Sionneau , Arnd Bergmann , Jonathan Corbet , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Will Deacon , Peter Zijlstra , Boqun Feng , Mark Rutland , Eric Biederman , Kees Cook , Oleg Nesterov , Ingo Molnar , Waiman Long , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Paul Moore , Eric Paris , Christian Brauner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jules Maselbas , Guillaume Thouvenin , Clement Leger , Vincent Chardon , =?UTF-8?Q?Marc_Poulhi=c3=a8s?= , Julian Vetter , Samuel Jones , Ashley Lesdalons , Thomas Costis , Marius Gligor , Jonathan Borne , Julien Villette , Luc Michel , Louis Morhet , Julien Hascoet , Jean-Christophe Pince , Guillaume Missonnier , Alex Michon , Huacai Chen , WANG Xuerui , Shaokun Zhang , John Garry , Guangbin Huang , Bharat Bhushan , Bibo Mao , Atish Patra , "Jason A. Donenfeld" , Qi Liu , Jiaxun Yang , Catalin Marinas , Mark Brown , Janosch Frank , Alexey Dobriyan Cc: Benjamin Mugnier , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-audit@redhat.com, linux-riscv@lists.infradead.org, bpf@vger.kernel.org References: <20230120141002.2442-1-ysionneau@kalray.eu> <20230120141002.2442-6-ysionneau@kalray.eu> From: Krzysztof Kozlowski In-Reply-To: <20230120141002.2442-6-ysionneau@kalray.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6096F1C000B X-Stat-Signature: 5bhgfofg6b9fe5dgwg8ajsmdzagsw8qf X-HE-Tag: 1674388177-555584 X-HE-Meta: U2FsdGVkX18iEBkWoNYMVyVfv+7I6tmp0OOk9krro3ZlH+0mRVsTxOmLuwG3Znck5+WbCrFCQCYkGXWiw4RhtIrMhm3g8nJRzsSnI/5BEL7Ex9SUx95LYvZtm6uoQGRLhTb9NwCujuhJXcUUz9tUWlduT+yCHusv4K+Sw7rw2zNN7wGNS+4gQYgEtc6oE67H6AnprUhmFwgGwPoVCEcCm9lNcxTx6cZbSf+XWVSI2MptyfCfO8rOtyggmJeQ2jRY/rhvqjEtqPItJtWT5jePpHAEEboynpZ0Mm+O5u2pdJtAalWnpS3bWhET69fB46s671bV7HL4dfIVujihuYATM+0hNkjUCUAXRbQDzNCbKCmrqvYV+v5WdzZ+461UPMNf7MqqECMPL/XcddZvjkWyxZZCrMjDdsx/gOljJlNNzOgR6uCB6+dP2do0VDNkrRAEaXBhZjxkqBGjoJtU9afj94BBn+7N8z9m+Wj5faruYtt66aWzh9tLMuBbxL6p0SR/Q7aXFhI0yJM3u5UnXqC9lvn3t6OuIJGFc/FsYrrAK7Yg/7/nUB/051OunL/XaozYwc8MflZOh5exdmQhYkx9IDEftkooyBc/c8/k7UEeKOY5hUWo+FIPHV/LyTBh4BgG+ipp0W2qCrB54ljYC9Rc3JUcozl29LYtEcpjz9vPuIaiflL+vwdQY7ZQFbBrQMiHaGzjo8EmWAei3rvp2nokHP57N4GlPE4wWj5Gl3rAUDIiirZu56BW6CW25fXf1LYDbQl8X//yjzsR3mha7Ef89BPQOtU0TT527kn16GNH5SOGh59emywWdf4b3LkArYWzKW0GruM9OfQCtZ6TOEOUfekJb5R8Hanh6G1rNy4P/jQAnrBhWg+KcMWnUtJ9w3iUVPKQl/A73YnGH5hR9avgRoGwmEBfx72U1G5veKROMobt/E8U9Q3jiZWnLsLt11KkH3sAsyGMQA7CIh3JS6D gXGnI3KC 7X+7OKZzbwGg7AQqpjQgfm5YVdzg6LIoLBbYV+cIAONiEUDd5G8FWD2gFCxa7UtUUgDTw2Srnx7HjND42ql5MkEFdNTr6biosyzSUCLgsudf7EHHjrQjsPng+o9OfLC8TCg65eEcv3CEURd1Jf64Feek9giHAJzOKE8xajeV3zHyUkafwSWpWO365GMf3gR3pdAEBiIQLFsE/LHrifYP7sR9gNMSVzn8tXaLp7o1KgH5T5sgDvGz6bUmJSLnHX6Jpowpsk8q5+0a3+LpxqScJvIvdVMq4pO2QiRTtxb287aAH4f3hGZe5FJxdVSUWnH4KvBF3TY7cjXEOUDx3ZAtos9kddCD3WIaC6gIdfe9sMB3fLFBtIzHqgqkIWEBMp50dVZ2toTkELmjP73SokeXL6Qm4eQRTkQEpwpI6Ug1nxK1tfT8ZsnmS25Zq6V7Q2Dta6ZDdLvgrLxSYCr+yF2nnTQiF/QBaaaWjJGWGsl/z4wKOrh9aFL3qpUESrrU9v33eD0nLhvMcBfgNlUnV40nwE/k0VYbrOuiAi6iGH3NUvovOrJw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20/01/2023 15:09, Yann Sionneau wrote: > From: Jules Maselbas > > Add documentation for `kalray,coolidge-itgen` binding. > > Co-developed-by: Jules Maselbas > Signed-off-by: Jules Maselbas > Signed-off-by: Yann Sionneau The same comments apply plus more... > --- > > Notes: > V1 -> V2: new patch > > .../kalray,coolidge-itgen.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/kalray,coolidge-itgen.yaml > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/kalray,coolidge-itgen.yaml b/Documentation/devicetree/bindings/interrupt-controller/kalray,coolidge-itgen.yaml > new file mode 100644 > index 000000000000..47b503bff1d9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/kalray,coolidge-itgen.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license. Checkpatch should complain about this - did you run it? This applies to all your other patches (both, run checkpatch and use proper license). > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/kalray,coolidge-itgen# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Kalray Coolidge SoC Interrupt Generator (ITGEN) > + > +description: | > + The Interrupt Generator (ITGEN) is an interrupt controller block. > + It's purpose is to convert IRQ lines coming from SoC peripherals into writes > + on the AXI bus. The ITGEN intended purpose is to write into the APIC mailboxes. > + > +allOf: > + - $ref: /schemas/interrupt-controller.yaml# > + > +properties: > + compatible: > + const: kalray,coolidge-itgen > + So why suddenly this patch has proper blank lines... Missing reg. > + "#interrupt-cells": > + const: 2 > + description: | > + - 1st cell is for the IRQ number > + - 2nd cell is for the trigger type as defined dt-bindings/interrupt-controller/irq.h > + > + interrupt-controller: true > + > + msi-parent: true > + > +required: > + - compatible > + - reg > + - "#interrupt-cells" > + - interrupt-controller > + - msi-parent > + > +examples: > + - | > + itgen: interrupt-controller@27000000 { > + compatible = "kalray,coolidge-itgen"; > + reg = <0 0x27000000 0 0x1104>; > + #interrupt-cells = <2>; > + interrupt-controller; > + msi-parent = <&apic_mailbox>; > + }; > + > +... Best regards, Krzysztof