From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34263C54E60 for ; Thu, 14 Mar 2024 17:55:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CF60800D5; Thu, 14 Mar 2024 13:55:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8584A800B4; Thu, 14 Mar 2024 13:55:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65CD8800D5; Thu, 14 Mar 2024 13:55:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4C123800B4 for ; Thu, 14 Mar 2024 13:55:23 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1E0AC140634 for ; Thu, 14 Mar 2024 17:55:23 +0000 (UTC) X-FDA: 81896396526.26.4533E59 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf20.hostedemail.com (Postfix) with ESMTP id BE6801C0006 for ; Thu, 14 Mar 2024 17:55:19 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="h/kTP8DD"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=oBntC6lT; dmarc=pass (policy=none) header.from=oracle.com; spf=pass (imf20.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710438920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I0eJ79DAi/CLhnDl0mlpFux7c6/5FKZ3n6oUzEAjxvE=; b=AFggDTLH1xrex/8zMwYmoE3Jpeu0exDXPSP5rz+QGQKZE0U7uxJl1NXFhZS5IhKhc1bmL1 0LgiqOlnqVM3dql4qvo4SdKwyjOJvUYs8AIOY8CC6rOCqadedhHN2aOcWUpxFHqhKsXf3p k1azdiEev04b/XM8rXRQTqzzBu8ECzY= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="h/kTP8DD"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=oBntC6lT; dmarc=pass (policy=none) header.from=oracle.com; spf=pass (imf20.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1710438920; a=rsa-sha256; cv=pass; b=7YDTrXamB+Hr9BcY7gY9nRbMx8HJiQW14F87Dye+9z3Vep7nRY9i2pG3C2bk7WxWiZiSP1 1D6/lNBtD2MKqEZd6uK0Jg0YqnGuiWZRkwg7sZqM4L8WuKTV+I2QexOpHUkxscX9p+RLdh yottx4oAHbDUzANOr8isLl0AUC86wkA= Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42ECLhHC002136; Thu, 14 Mar 2024 17:54:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=I0eJ79DAi/CLhnDl0mlpFux7c6/5FKZ3n6oUzEAjxvE=; b=h/kTP8DD7kuWvTeWk4YnBeNmCAsQaMlVNUoUXefmFQXBCdd2za4B4mqMrZQ3oz7uVgku +rpww4Z3Bt42hTFoO67H4qxIVs65iDxAk996XtRBEdf1I+vfxe2z1vXHTccuMoFwyrvE FULU6houjTdLFZb6okqedOSm7kdSaYWGb4WmQU9qMWVljFIGM5YKAJaYjPB/Qaxzh0GY RVotke7gerA8hBgAtbTuI/P9FGHEn/9L2Dc4306vHcxlsj6wPXmNucHgjR6a4VfMON2O VusV7kQLDs2sp9W3ymyNmL2X1P1OnAu/+KLbO8a3bwqn+zi69c5D2NGoqI+nF3UvklQT Cg== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wv0abrwcx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Mar 2024 17:54:59 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 42EGUUfY004925; Thu, 14 Mar 2024 17:54:58 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3wre7b4gay-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Mar 2024 17:54:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GVvPNRXR+rQtIBcrt7Z4n4Wgi0BXm5pOo7oB1vXbYEthbvzHK8bK+Xpc8SGTF8xL/rM0Jkz1kCRq6yKfMqA1BMSYXQfwPt8doK3OJU6SMcN/Fakrck3qqZIlIheNAQNwy+HdzcDTNlWE8JniuowR5VuThlH51HxBWRdiTdf44bDJY/zJThq2hprGIVcjptS0MPUZjgbR5Eaeyf958rsJQKwzGZqa4KNMJqxLOVGFDVOatEbRk6WbA3sGyos6MCt2n01FiNkynfUnjh9aepVYijRut9Nrp+wmmoJiMKfZ14vNtK//yUL24SNHEoF3H8PPs/iYmD59szfkNMG9ryPxwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I0eJ79DAi/CLhnDl0mlpFux7c6/5FKZ3n6oUzEAjxvE=; b=EbhKZx1oTHVCgoqXZg+9U+s11BVdOhEdSZbAMIyXGDRATaCOKnBdO2KdtJY8+5cTYjJ9HIsA3Qw1O0UNuvVQ3zbV/S5r9V3yLF0iQZNuDEg86AONLs+zAaRRrSr+gbcoAlRA/2HKEo4C0+meDr2D9tVFyOo8gug4MDiGlFcKFVA2qSdVIJsBGYtMwAzknCW+8CA8tXBqYXCSCbJj4sbCle7DrpIOn46yPu6Km6PO4b9AB17qul91QeNiee9HcUs3ZMVzkWV0zAWJwE2E4/Sguy1PTBFNFBmsOqN5i5vq+wUwtZMuzgD3Xk3sQ+dkD3whjzGVPcuei5nJrsbGPiTsEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I0eJ79DAi/CLhnDl0mlpFux7c6/5FKZ3n6oUzEAjxvE=; b=oBntC6lTMBAenB3Fnm1eoDAM1ETlD0mUW8tcRbrpS0jW8AbqHCynSRRID6MdyhjxZ2GV/MZyuiegE9KZ8MbUcxTwfAtTjvO4x4ywve0uVqEnhaLm/icFQacFObwNK1ZCzUQZ+J0gi48VDsJJM8meIiIkokRWpyYcp2qbdaAeBLM= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by CY5PR10MB5939.namprd10.prod.outlook.com (2603:10b6:930:e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36; Thu, 14 Mar 2024 17:54:55 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::210e:eea7:3142:6088]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::210e:eea7:3142:6088%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024 17:54:55 +0000 Message-ID: Date: Thu, 14 Mar 2024 10:54:50 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] mm/memory-failure: Remove fsdax_pgoff argument from __add_to_kill Content-Language: en-US To: Matthew Wilcox Cc: Andrew Morton , ruansy.fnst@fujitsu.com, linux-mm@kvack.org, Miaohe Lin , Naoya Horiguchi , Dan Williams References: <20240229212036.2160900-1-willy@infradead.org> <20240229212036.2160900-2-willy@infradead.org> <35c987d6-e78e-41df-a157-cc764245fa30@oracle.com> <317bf68f-317a-486a-934c-18f2dca5fb2b@oracle.com> From: Jane Chu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PH7PR17CA0042.namprd17.prod.outlook.com (2603:10b6:510:323::21) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|CY5PR10MB5939:EE_ X-MS-Office365-Filtering-Correlation-Id: 0172fdd2-3337-4ae4-22f3-08dc444fdb5f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aMcrYXJ0hyCBYOaKGZ9/SGt6YQYCP9C7nSQndeD+8s/IYx2GOF4YyY8dE0G12xSlHz6yNPKLAx9cSACeyZWb5d+BX1TAVZBmi2H+LUw19PQix7k9Us8t7yN6vCSiKBbiCNMGrpeJSFM3ek5kc3dxTmXXpqYFfEhz+s7YgjnCBBitrR8J3LbTxXLNv7XUnju2mnfKCT2NAhPbyaHSupj3enGcmoHlp6/2DsKbqSZF3KZ7DbyxGRw2qGNruPRvIuanxupPJBixOEm8gVFGEy0foET5YpZ1ZUn1kyQX9q0OTOXT9qb8W47hjBkMloezQPA4ynBr8HzoOk6XEazeJgO2m/fQYOUh6gJVqYPIxGEbW4wsoJmbLneYl519SRIEu/DRV+QRCuJcdFqvfUDGWHHCNQ96tHE+xo1I134LOcd1C35VtMwp6t03J0Dmqur+8iZQcFSFU7VlSb2Br/Nm7y3W57QGZUGwXO6FbcgNjUKQwgVqAmuF/H32BLeYMeeIGgXs6UKvP/oMT+JdJp1SDFa+pkKUEPgoexX6mlMWLKL9tXmqHCYskPJlp/TO2OeA79QS2pW9cKeVPFG6jC4hz59fCQCGw+gafMdLbRB3TuyQTXRiPhVeaE7ZFuW9N7qHIvjML+MeRxP1qZ4DjcyOA0dfLVCfpaovYmUmBg5swe/A6U8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFFxY0pVQjc4MTZUZTF1Qk9lcEtXNUJsNnQ1Y2M3cTVpT09xam50TjduMHE4?= =?utf-8?B?SjdKNFh6TmphV3Y1MGRzSkVKZEhuRmZIQkVSb1BpeUNNNDVqU2JZQmgyOTRo?= =?utf-8?B?bnJzRkVwc1gweGVXQjN5TVlzN3NCK091eVNMSmpHTGdsU0dlSEdPT1VRL2E4?= =?utf-8?B?TncvY29JUjROaEMyU1FGWVpuY2YzK2htajJhVHVsQ0Z1TFRiLzY2SUs3Slhl?= =?utf-8?B?dGJETGlmS3BmWFNGOHhOQm0zSjRwNVBDaU5YYldneHBwWXhLb3o2bDVxQ2Q1?= =?utf-8?B?bnpHVkxIN1dDK2xhTHZvTjRxSFlNWHRtelpBa2IwY3pvQkVYSWNLd0xCL1F6?= =?utf-8?B?ekVINDJRYlVGMFhKVzFsOFhKcTh0bUh2a1dmTmcwZFk5cWtGMzJ2SjRIcThs?= =?utf-8?B?dmx6QmFNUnU2cmVhTldkKzNhSXFKbyswd2hmWkRvbTJhSS9XQXd5R0sybnZC?= =?utf-8?B?T3ZLUC9FcVdXZzFhQkF1UnFhVE15NFZ3anhaZHEzU0Q0T2xmVVNGTVRDcFdT?= =?utf-8?B?VWRIdm5EVXB6OHkzdkxJdWlKK3hZcElUQ1NxNGNyelY1dzRWUFRnM2tmRVpU?= =?utf-8?B?bGJmRng3M0lScnBjVllDRVN6RUNSMlVUNmlPZUtiV1NZbEpDb2RVY21scjZk?= =?utf-8?B?ckd3d0djeGpGb2sveGZXZU1TVUVBOXg3MEJtTHdyZzVJRzlYTm5DRVFtVmIz?= =?utf-8?B?NmNqazBOQ284azRYOW1aRURPbUVpWE8rWnVkUWthV2xEVHgrc1ZhQWhEZ25B?= =?utf-8?B?elBzbzQ3RHBZb2VqMmR4MDVFcFFheENjaFJsdUwyVnpXYnZjci81Yk9mYU1U?= =?utf-8?B?YmhQcmZpL04wYlRJUnRUOG5qQnhITGdxUGdnRGI3dWZzWVJYaE5HaURMc2FH?= =?utf-8?B?T09pRDExUkcxalR5T2JWK1FjQmw0Yzl5a2hYODBnOGlpd1RQYjJYNTNtempj?= =?utf-8?B?K1hmVVd1T2w0RnZWUTNWTVhIYUpZdmNhZ1laejVKK1VhN1IxZjhvaWlEWFlz?= =?utf-8?B?Q3J3S2djQlVGK2ttMTUyZTAyaENXRlpwTmtHUE1KVkR4YXRvQzVUUEpuRHlu?= =?utf-8?B?a05PN0g0ZlI5VXpnMnNWM0hYWnUvMmx6MnhkeXYxSjFWMTJ2dW4zUlY4VTBh?= =?utf-8?B?WDJBMDFsM2p6NGhKSGlNcGg4ZFNndVJNVGZ0azVSNndWTFhnelY1MGVZQXVs?= =?utf-8?B?WGRYbHA1OE1VT0ozOE55WnJKdGdIQnF0Z21QNFZXYmZ0UW9pT2x3S21GWHVS?= =?utf-8?B?M2lSbTlSZVF5b0pHSDlXZElSdUNYOHBvUUo5UGJLUlpTNVZCdk5DWlJIVjZO?= =?utf-8?B?M2hOa2tUVStmWXhsN3MwTGs2Y2QzSlZHSTlPQ3EraDJTM0NZSC9TYS9LTTlx?= =?utf-8?B?WVpxR0VPTGFKRU1tT0gvNjlJcEg1NktZcHUyOTNwWjdWd2ZuTjQ3bGJTTnNl?= =?utf-8?B?Wm5pYVk3emdvREM4TFBNdWtKemFUeHM2a3lFS1F1QjN1dHprMlphQkhSOEtG?= =?utf-8?B?M2VKRlRST1JmNEh1andPZ1BlTXEyckZaK2lnNWFrYWkyWS9yNlJFaVd0TTZy?= =?utf-8?B?RWM0Z2lneGJXQ3RrQWhOUW02Zm1kRHppekgrMm9oeTNYN1hXRlVHbEM1K0JD?= =?utf-8?B?eThKanQ0UEVRNmRGeTN2TVVnVmFFYlZKZHRzekhDdWM5U1g5RUJYS1BYRUtS?= =?utf-8?B?WVBDSzYwRnpCSGdhWXpNZ3VqRFpHNHZaaWFMUW4yMWlnYXdwMXZqWmRnektD?= =?utf-8?B?SjhnSjFYSmM5aUsxTU9DeTRaMmZ0ZGdxd2x6THlyUlQwTjlZMGxxNUNwbFF2?= =?utf-8?B?cUgzWSt3endhdk1HbktXdXJib291RW5WcEM0dEJMcGVOaTNvWGY3bHhhRkV1?= =?utf-8?B?UkV4Sy9HUzVTdk81MmRscmtyUEhZbE9NVTA2b3NTWHpEQm1iVFdBb0RKYzJB?= =?utf-8?B?TzdDdmM5aGgvbGpKRUtqRXR4WW1XdHhpTGF1L2JWb1V5cVFnN1dOUmNMcWJK?= =?utf-8?B?dTUwSk1ZaGNuMWYxNzlDc1pPd1VKUTExWmFxSXRLK1FGdFRjTDVXZFhkQ3FS?= =?utf-8?B?cXRKK1NVSXkyWStndHhKVmNDR1R3SWpNaW85NkxPWFBlRUFRVlFFdFdaYmFZ?= =?utf-8?Q?L+mmcbczmK9/8nk08oL067YLf?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /UX3RvH3S3jJcrKIoVyDx1wksYNiNAgMERgeK3+HB4QOzrhiC/1z6jcuA8cxNozAj1NvIC8fzYhL3j3JvrYb3myF/2NAll4RNMQmJxKsHHvpGillyLo9+rHuxHqYcW8zyhZSChVhFXRVciz88+sQL8rVfGEKcKrJugRBus2LsnivEPLZJYTdT8TNcTKl2l6aRQVtimy1a1IzthgxPFC2Yh3ngnNZDWwq/MpJvyoh6mYZY2sG8/hJF8dlbHV+Wij4tjZw4WQDcO86jKo+RcbbCOq5i8fy2jF6fe0q7YZ5r51ECUcOH2azE49PXcroKiiToDfRlKlKZiDmaDH7QkmogvgEKgRFaGagteDY0Y33wp9I//qWh2igC/EX41EzvYqU/qfAeGyqWj2q3NqEZIaBogRfVGJQg7l9g/QfltwzD3duEX5DUvnXBxgoxcUXiZAaptp9aodMx69tf/eC40Vc0oQk3oQaSnY9j0ubjxwY/JS1MFKrt/TZ2vk0nVxAuEbIZOchG8RaWBdcCxi1vBIf29Kf1OXymGe65Zhq4uRMhWz0XSMLVv4Ve/U/UAOb8ofjVufV0AukAPRtttqLkB28sOMnkhzmdeKkMJs0qGv4BJg= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0172fdd2-3337-4ae4-22f3-08dc444fdb5f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 17:54:55.7767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7qmd2ErXbzhyaXouQFyh/URUn1q2oCxVnrw0mC7So7f2EsOGfunXtRw51XEIOs11QKuCRcreUzuoFu8mM+vpyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB5939 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-14_13,2024-03-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403140136 X-Proofpoint-ORIG-GUID: kfsGV3Y8bfO2LXvVyhWFm1IpUUh4qK4C X-Proofpoint-GUID: kfsGV3Y8bfO2LXvVyhWFm1IpUUh4qK4C X-Rspamd-Queue-Id: BE6801C0006 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: scnmkzdmpy8t6whxriu49nxjpi5ji6cu X-HE-Tag: 1710438919-618355 X-HE-Meta: U2FsdGVkX18ipoNBO+Yocymmf8H/Q6BA8c7EJKJ5CIXBPPna8rknHynlQYYo24iH/s8wixtdUVmdCdotBOoVvLcpJs3UqdJRDMeRSNJa7MrUdLCg0z5bqVPitS9ADWVJs1gEoZUoYG9uX/4muaVUWODUlAG+vuzWoq+zekcGtxNstIOnLmXzXrHAvJGp6PzQs4JyL0or6PeUS3y62bzWu0dRy0/SbIBMTWNxdShB3SnBgTiL5eye8NUWIcGEZjSBhyBuGb5rh5kFLphGcfc+B8ovii/HqMlfVWQQSvKh2rmPEw2S7zS9NO0ZbSfIBvEXSeuJPg15SPwIPjIzBqSYBx3+p80MwG3Krakf0I4zfjn/GM9XWda6bR3Veefh4jV3CEutLM2oEEbBqM+BVD2Y1khMhdJhRwKSp18OGTM0/0GRcDlU4ekvd6Lbzs+h5FDfwgIiwRwPifzQf/v5YuBopK8Ea+IJUF9rmccMuw0pVZOcNazlBk2Oj21IkAVvyzRd14jTYOrrGh8zEzAuL4OiiUZpCDgeK+pN4YZw8ho3GWbKRjqz2xxU98WIrnFscVe/JpMgbmzov6RYAS5T/S9Ihyqr6Gdg87eT/N6fJid2LiTYjW5IyRUZ4fvOjx9X0ADG+FQ32OpnL1vTp0za8JaPVA+4mESv9wPo1ITd3cMumnD3R/vUol4vLm6Bjgv+No3dHp9nLzsP+13SgI3ue0xsi/zbbZ9rfyJ0S+XtKk8onvf5bs9KHutdzMmMclXuGq75zQzxWPMMZNBPGV7QUrM95YzcsFiN5AL9PKcDQIUleeW/69dUO/EZ0rsTmiJ0v5sH+trW5TGPVsMBSrM4ig/mfN6WWGu0eJFdEWs12dwqBpF039wAvm+lkyXkoiuTm5lN24P18oaSRKmI0rYyMFOTC30R1GoM2vG8+8oZ7i97Ep0q3dy4FVwHZCWYG/VGdw4/2Vn6gYg0wDZQKIFONHY ZN2WU4XG q/yOgmB2UNVohTNGoqky4bpI9ZHISII7HU3G8pHAUPbn6WFLYtRZF+XgtwpvoMzpnMpZT+hzwugeuPjMYgzdnOxA/vpxWrVcQvQH30EM8HY9hF2nvAmkA7b7t2VLI3VRsiilW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/13/2024 8:51 PM, Matthew Wilcox wrote: > On Wed, Mar 13, 2024 at 11:11:04AM -0700, Jane Chu wrote: >> On 3/12/2024 8:23 PM, Matthew Wilcox wrote: >>> I don't understand what you're saying is wrong with this patch. >>> All I'm doing (apart from the renaming of ksm_addr to addr) is moving >>> the vma_pgoff_address() call from __add_to_kill() to its caller. >>> Is there some reason this doesn't work? >> Sorry for not being clear.   What I meant to say is that, before the patch, >> page_address_in_vma(p, vma) is the means for determining tk->addr, except >> for fsdax when filesystems made a claim of wanting to participate in the UE >> handling, in that case, vma_pgoff_address(fsdax_pgoff, 1, vma) is used >> instead. The difference between the two means is that, although the former >> eventually calls the latter _if_ vma->vm_file->f_mapping exists and is >> stable, what I am unclear from Shiyang Ruan's earlier patch is that, he >> seems to be concerning a case where f_mapping is not reliable, hence his >> patch went straight to call vma_pgoff_address(fsdax_pgoff, 1, vma), and on >> top of that, providing nr=1 to ignore the address wrap around case. >> >> So I don't know whether removing the fsdax special case is okay. > I don't think I'm removing the fsdax special case, just moving it. > > If I subtract out the renaming from this patch, it looks like: > > tk->addr = addr ? addr : page_address_in_vma(p, vma); > - if (is_zone_device_page(p)) { > - if (fsdax_pgoff != FSDAX_INVALID_PGOFF) > - tk->addr = vma_pgoff_address(fsdax_pgoff, 1, vma); > + if (is_zone_device_page(p)) { > ... > { > - __add_to_kill(tsk, p, vma, to_kill, 0, pgoff); > + unsigned long addr = vma_pgoff_address(pgoff, 1, vma); > + __add_to_kill(tsk, p, vma, to_kill, addr); > } > > So instead of passing in '0' as the addr from add_to_kill_fsdax(), > we do the address lookup in add_to_kill_fsdax() and pass it in. > That means we don't call page_address_in_vma() for DAX because > addr is not 0. You're right!  I overlooked the addr being passed in in fsdax case is different. Thanks for taking the time explaining to me. Reviewed-by: Jane Chu -jane