From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4F23C3DA42 for ; Wed, 10 Jul 2024 19:27:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5777B6B00C5; Wed, 10 Jul 2024 15:27:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 527A96B00C6; Wed, 10 Jul 2024 15:27:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C8F76B00C7; Wed, 10 Jul 2024 15:27:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1F09A6B00C5 for ; Wed, 10 Jul 2024 15:27:31 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D9718A192A for ; Wed, 10 Jul 2024 19:27:30 +0000 (UTC) X-FDA: 82324827060.16.73D6AE6 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by imf08.hostedemail.com (Postfix) with ESMTP id 9BDF9160017 for ; Wed, 10 Jul 2024 19:27:28 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eJzrALxg; spf=pass (imf08.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720639616; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kljb3BjHvpCMu9iNefnZUET6RD2JTZuBd54iemfQytg=; b=VznGwyVwVRKbWEfrZ/nQQqheabOWjgnQcNK9XP/c8X4LjWivScN4psmtUPScf23kl21tz7 1m6JssiJuNtLkLdhgtxjO2Ol2K1q++dqP9+piCapJlFrtLMZc+mNNDNKjhQZT1reh0uIjA E4WQogRLwzC7Ylu3HYHX72Aui3bp1a8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720639616; a=rsa-sha256; cv=none; b=SKGpWqRDOrLf5vm/xjzAoE8MiR1c0WBgsry3s03EcYo5O7O9t7H4lgLki3WMQ7pTc/e2HE pf7GnEVGGLHTQuZhRyzaXs0uxlsAleEadBV/MQFXPh1/e9cNfZ4Q+zNI7I6QagE2TN/t1+ +1LyduVEuQbk8h2mySH52sg6q5q5NZ0= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eJzrALxg; spf=pass (imf08.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720639648; x=1752175648; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wz1T43W9fI2ApkLY0iAxYoCPKKX/ROhTNeF++ORC+5I=; b=eJzrALxgHHVQi90gpjI1xYAbuRUyWQiawrUtttR24F7FBNrCfNrWRzoT tRd46PMws+j60+2UjZQ/+qiz/b3p1R3i6NZWEF3YHfTxXoCSpsS2/Ud2g Zd26zk9bm+paz/V38DRCpyvUSCgQ7WcJtp0LqzZ8np1NyWPx4yCUzNtIt kdcfZb6DT7+GQotI9y/6JaXjGNATqi8pdXQPw+jCSGtIzbHFidQYg81iV kpkjFgZCuChVkizk8dJRnledhh2eajy5SkbTrhq67Yf5D54zAdJq6QdIs F7wQseH4WfqYVcuSWQunz7b7BrmqQXE0/aqntkrTMBQcojmXPxFWUOcKH Q==; X-CSE-ConnectionGUID: AWUdDuHEQ16um+llO2fPKg== X-CSE-MsgGUID: G/45hIafSC+lRpqgUKCsAw== X-IronPort-AV: E=McAfee;i="6700,10204,11129"; a="18121566" X-IronPort-AV: E=Sophos;i="6.09,198,1716274800"; d="scan'208";a="18121566" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2024 12:27:27 -0700 X-CSE-ConnectionGUID: YqrZYSNiSrCxr0ShbrXQ8Q== X-CSE-MsgGUID: 3Uj9siAVQwGIT5LEiuzJzQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,198,1716274800"; d="scan'208";a="48197487" Received: from inaky-mobl1.amr.corp.intel.com (HELO [10.125.109.156]) ([10.125.109.156]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2024 12:27:25 -0700 Message-ID: Date: Wed, 10 Jul 2024 12:27:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 17/21] mm/mmap: Drop arch_unmap() call from all archs To: "Liam R. Howlett" , linux-mm@kvack.org, Andrew Morton Cc: Suren Baghdasaryan , Vlastimil Babka , Lorenzo Stoakes , Matthew Wilcox , sidhartha.kumar@oracle.com, "Paul E . McKenney" , Bert Karwatzki , Jiri Olsa , linux-kernel@vger.kernel.org, Kees Cook , LEROY Christophe , linuxppc-dev@lists.ozlabs.org, Dmitry Safonov , Michael Ellerman References: <20240710192250.4114783-1-Liam.Howlett@oracle.com> <20240710192250.4114783-18-Liam.Howlett@oracle.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240710192250.4114783-18-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9BDF9160017 X-Stat-Signature: sufaeantfuhe6s5uromgaifn8mridcwu X-HE-Tag: 1720639648-676851 X-HE-Meta: U2FsdGVkX1+E8bY2Qi5u92CAwrYsouKlmMdoVFswdeRQGZxfYF2yCU6IM05KzQpFgR9OIQ8vZ76Rj4CkqzAGFLVkc0jsdlifMPuNqyHLOiwLEPjEUKm/dfueqLt130AZqf9bUCN4OPex2Cu8cKozRiwN5/7G5pql97Cx3b03DNZewaM53ebLLqAihhDU/mxmS0RGheQLgLDuzEGxMKWLm4V2JK1lSwackCMfaLRH01YWtVLmI9V8d8inZocaEHLZ9NDtsXHkbGJgSMhgHJx8DgjHbieLwUBndwxKCacZqdFdLtgUgrDlscPwpcUtp+jNa02C1Mnzn4rdam+Z+hMpcvtcn6ePJZu2mDemJGxHcsw9NhTt+QdZL8m/Xl9YtWdGl+oj3msFL+61pL1IJsDyl9vk/wCKd4Bm+SK5kVLGps+rQKSec4brNIzdANrz+qkDVETk7dG3ZzEvUD+XsWzVM/29Rw24bV9O998DzDovvRIKI2CK9kLto0uUbhgMZhMwWK4JJp/3Jak5itDrh4zzUGSgHAm6ASf/gmY1wWxbLshfiHffeR7mTUazEDj+7zsGRdkJgBSsCo0ZWph/EePt2/z7Wipdsw+gNDy3oxPB6zuK2BHMnLbC0BfXBJsWV1riivc3UUBFMTGRpo0efq1fyRhaxJRe0y1Caja+j+6ZYOgmTdbSuGinIm1bpG4f77AilRehtNFYQCt9rBElRZC2Khta43Oc7KeChjGMPkB88qbOdf6bXN9jdQ+pS2emRQNFY45GU7OcTrDPOjvQYpwA0IcZSVbutKWmohWOxXK3q+f22ZEepPT/pLYjMoYT/KbVaSpIaiOvp5tgCAe9ca+D1NfnZ6UxHwfliBU5pjqZ8CxnS6g7yPyLTPl55XQxIJFTRCOEcXZ4C0ZwuJwYmKsObrdWj2K2gx/iazvWl4x/mPSM4M7op3icimB0f+XBu5yhtRGxefDjrhrfbXuOiKH oxx3YJON aDW4nSo0Eq+djuGfpIsHUIe1jta93boT4nLIJUPTE9Q96XFaD7uR0hsxwem8OtCl5EoTABInyZyr96smr2HRICofX0SHfWGZ8a+YQbo5EoSdBMxIIAqzf56osdIZthlP2z1tNDqzBqZ90bNcRH6k92R4BopOob5yMjs0DXaAp6OEUiLvs3rRctHxDdfZ8S7FF67kr9bHfz57mcsY7+RUgK9jojpnO/ovChyGIoU9CTMiNLd2MOnvjSPxGiA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/10/24 12:22, Liam R. Howlett wrote: > The arch_unmap call was previously moved above the rbtree modifications > in commit 5a28fc94c914 ("x86/mpx, mm/core: Fix recursive munmap() > corruption"). The move was motivated by an issue with calling > arch_unmap() after the rbtree was modified. > > Since the above commit, mpx was dropped from the kernel in 45fc24e89b7c > ("x86/mpx: remove MPX from arch/x86"), so the motivation for calling > arch_unmap() prior to modifying the vma tree no longer exists > (regardless of rbtree or maple tree implementations). > > Furthermore, the powerpc implementation is also no longer needed as per > [1] and [2]. So the arch_unmap() function can be completely removed. Thanks for doing this cleanup, Liam! Acked-by: Dave Hansen