From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D878C433F5 for ; Mon, 30 May 2022 09:38:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A54C6B0071; Mon, 30 May 2022 05:38:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 850C86B0072; Mon, 30 May 2022 05:38:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7417B6B0073; Mon, 30 May 2022 05:38:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 651E96B0071 for ; Mon, 30 May 2022 05:38:36 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3213934571 for ; Mon, 30 May 2022 09:38:36 +0000 (UTC) X-FDA: 79521909432.04.44364C8 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf13.hostedemail.com (Postfix) with ESMTP id 0FB5520057 for ; Mon, 30 May 2022 09:38:03 +0000 (UTC) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1653903513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0tAu1yDybljG9v6H3XFTvFlglCilUlg/TAc4Sssj5FY=; b=nb/TIC8Z25okb0Miptwsm4FaawVL2rNW/B9T1O0x0tFfmsH0CSEdbsxRXUnG4LxdbB3pyf SNmmhDVwMyuNGJIHhLB1libYq6Iwt1Oh8nSnW35aQjnDPVOFrt2pJJXWwXJOqFinxElI7Q G/JjfHmMV0OVdoZhyoIdK9HzHvergAo= Date: Mon, 30 May 2022 12:38:28 +0300 MIME-Version: 1.0 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vasily Averin Subject: Re: [PATCH] memcg: enable accounting in keyctl subsys Content-Language: en-US Cc: Yutian Yang , Shakeel Butt , Michal Hocko , David Howells , Roman Gushchin , cgroups@vger.kernel.org, linux-mm@kvack.org, shenwenbo@zju.edu.cn, Johannes Weiner , kernel@openvz.org, Jarkko Sakkinen References: <1626682667-10771-1-git-send-email-nglaive@gmail.com> <0017e4c6-84d8-6d62-2ceb-4851771fec18@linux.dev> To: Andrew Morton In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Rspamd-Queue-Id: 0FB5520057 X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="nb/TIC8Z"; spf=pass (imf13.hostedemail.com: domain of vasily.averin@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=vasily.averin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Stat-Signature: gd9ziazgot8ficau89jz1xku9367d1uz X-Rspamd-Server: rspam05 X-HE-Tag: 1653903483-625001 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Dear Andrew, could you please pick up this patch too? Thank you, Vasily Averin On 5/23/22 23:00, Jarkko Sakkinen wrote: > On Mon, May 23, 2022 at 12:45:09PM +0300, Vasily Averin wrote: >> On 7/19/21 11:17, Yutian Yang wrote: >>> This patch enables accounting for key objects and auth record objects. >>> Allocation of the objects are triggerable by syscalls from userspace. >>> >>> We have written a PoC to show that the missing-charging objects lead to >>> breaking memcg limits. The PoC program takes around 2.2GB unaccounted >>> memory, while it is charged for only 24MB memory usage. We evaluate the >>> PoC on QEMU x86_64 v5.2.90 + Linux kernel v5.10.19 + Debian buster. All >>> the limitations including ulimits and sysctl variables are set as default. >>> Specifically, we set kernel.keys.maxbytes = 20000 and >>> kernel.keys.maxkeys = 200. >>> >>> /*------------------------- POC code ----------------------------*/ >> [skipped] >>> /*-------------------------- end --------------------------------*/ >> >> I experimented with "keyctl request2 user debug: X:Y Z" inside the container >> and found that the problem is still relevant and the proposed patch solves it >> correctly. >> >> I didn't find any complaints about this patch, could someone explain why >> it wasn't applied? If no one objects, I'd like to push it. >> >>> Signed-off-by: Yutian Yang >> Reviewed-by: Vasily Averin >> >> Thank you, >> Vasily Averin >> >> PS. Should I perhaps resend it? >> >>> --- >>> security/keys/key.c | 4 ++-- >>> security/keys/request_key_auth.c | 4 ++-- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/security/keys/key.c b/security/keys/key.c >>> index e282c6179..925d85c2e 100644 >>> --- a/security/keys/key.c >>> +++ b/security/keys/key.c >>> @@ -279,7 +279,7 @@ struct key *key_alloc(struct key_type *type, const char *desc, >>> goto no_memory_2; >>> >>> key->index_key.desc_len = desclen; >>> - key->index_key.description = kmemdup(desc, desclen + 1, GFP_KERNEL); >>> + key->index_key.description = kmemdup(desc, desclen + 1, GFP_KERNEL_ACCOUNT); >>> if (!key->index_key.description) >>> goto no_memory_3; >>> key->index_key.type = type; >>> @@ -1198,7 +1198,7 @@ void __init key_init(void) >>> { >>> /* allocate a slab in which we can store keys */ >>> key_jar = kmem_cache_create("key_jar", sizeof(struct key), >>> - 0, SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL); >>> + 0, SLAB_HWCACHE_ALIGN|SLAB_PANIC|SLAB_ACCOUNT, NULL); >>> >>> /* add the special key types */ >>> list_add_tail(&key_type_keyring.link, &key_types_list); >>> diff --git a/security/keys/request_key_auth.c b/security/keys/request_key_auth.c >>> index 41e973500..ed50a100a 100644 >>> --- a/security/keys/request_key_auth.c >>> +++ b/security/keys/request_key_auth.c >>> @@ -171,10 +171,10 @@ struct key *request_key_auth_new(struct key *target, const char *op, >>> kenter("%d,", target->serial); >>> >>> /* allocate a auth record */ >>> - rka = kzalloc(sizeof(*rka), GFP_KERNEL); >>> + rka = kzalloc(sizeof(*rka), GFP_KERNEL_ACCOUNT); >>> if (!rka) >>> goto error; >>> - rka->callout_info = kmemdup(callout_info, callout_len, GFP_KERNEL); >>> + rka->callout_info = kmemdup(callout_info, callout_len, GFP_KERNEL_ACCOUNT); >>> if (!rka->callout_info) >>> goto error_free_rka; >>> rka->callout_len = callout_len; >> > > > Acked-by: Jarkko Sakkinen > > BR, Jarkko