From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4367CC54731 for ; Tue, 27 Aug 2024 15:11:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B22E46B008C; Tue, 27 Aug 2024 11:11:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAC376B0092; Tue, 27 Aug 2024 11:11:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FE4A6B0093; Tue, 27 Aug 2024 11:11:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6DDFD6B008C for ; Tue, 27 Aug 2024 11:11:24 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F39E941A61 for ; Tue, 27 Aug 2024 15:11:23 +0000 (UTC) X-FDA: 82498364046.15.2C1781D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 78515180012 for ; Tue, 27 Aug 2024 15:11:21 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Rshu4rZ5; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724771384; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xN5S0EC+r1DJgLdkgp4exQFbPC72rPb9JXbImUfXa/Q=; b=IgUI7fROH/VyIdPhgoue+GvEUyLbUOKZd+tSiJBgpq2H/GMbrhQNn6mWr4qR5U/fUsiDFb ocv8v+qGcfKOR4ABZTwXE/MOiAA39vFPg/7IVVBET4gOyOM2p6Ll//FOA8EoWO0ABEq0hU I2YeY2Dm22WbxPdGqQphMw4h1YkbYkI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724771384; a=rsa-sha256; cv=none; b=d0ENtoRLNYJ9kqwXOB8lHNN/6TLglsSNTBCIKsoM2llDI5y29AS4Ga5uxR1OQzpwdiTvO3 AQB7IXRrYf4Y6/u6eOBOjq2dqWW19PxfJNZU04ylAeBR4XTwYLqTt5YNYzQfNcDnz26tnS Y+08ChXb3u+sRYEuwwixx2eI68S1jR4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Rshu4rZ5; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724771480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xN5S0EC+r1DJgLdkgp4exQFbPC72rPb9JXbImUfXa/Q=; b=Rshu4rZ5Q7TakKBekN+UHh19efYNMnLexOktRMd1pEsIiqytsd+RHBhf1ekVf+K19Il5+s 0MuS98HAVGr0pvs/VO88ZS2rlu2mwi/7IgcKEAnwWYmbyT5OCtu5hlFo3HROTnwSHYjF0g 0HXgEyzqAgQS/ay9/aecrjfWOIDomF8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-4AKgqFfEMz2qXedg4ep4eg-1; Tue, 27 Aug 2024 11:11:19 -0400 X-MC-Unique: 4AKgqFfEMz2qXedg4ep4eg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4281b7196bbso51752655e9.0 for ; Tue, 27 Aug 2024 08:11:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724771478; x=1725376278; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xN5S0EC+r1DJgLdkgp4exQFbPC72rPb9JXbImUfXa/Q=; b=aCz9hfMDRNFVSJNugroN4ngLWq6pmuXSrInyIOXdGZizB7n5/Icm1Ng6y3bX4lLKgQ Wj1U4XJEL6Tnr8W6SzDfgrSBewYXjfDN3K82d3Oe/tVVHBGJ0tyW0Wlecn32VX98YFED f6K471Atv9zl0wo84VoaP+msm81JE+jVJl7HQJFf/isTgt1horJINInzAyjEODI8pz3k 9mvQ1Pv/4n5EjuOJ4cQ4W2GkGeXBi5d+El5+QFNjRAt+Wa318ccKT9Ls+id7AET9s/hk RqExlqtfsqLFPYgBmOeQlUGCfu8NKLhzO3fTlIxMbuUVtGCYewa8xQptneWJ+FHxo20/ 0hgA== X-Forwarded-Encrypted: i=1; AJvYcCXhZ0WY/vxDlnW0M/cKjxJaw9+uP2Q+YrqmU1201GBn2QXbGFeBno1ey5NUY2kMgUmstgMyD52/eA==@kvack.org X-Gm-Message-State: AOJu0Yw6T/WMvSl4hFMsKeGdNy7o0kSK87WljtbRp6Dh7Or7xX7chQ0N ouUNHYmf++3kGap+USEMnwwOz6auwbFP/P61jitBKS7mglxRwE5c3YE2LQ2zRa52HABUPK2Pqge b6HCluHwRfAznNuMwqwwBs9ytAamhOd+dE/2nkDm+Kzew9CMc X-Received: by 2002:a05:600c:5102:b0:427:abed:3608 with SMTP id 5b1f17b1804b1-42acc8d519bmr100257055e9.5.1724771478213; Tue, 27 Aug 2024 08:11:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEqLzWL1U8dkV5qBBA1OljSCA4cYzK3np4qE3bSsfS2g1MkllqmxSjo3q1AlYGNgRdjj3vDoQ== X-Received: by 2002:a05:600c:5102:b0:427:abed:3608 with SMTP id 5b1f17b1804b1-42acc8d519bmr100256725e9.5.1724771477343; Tue, 27 Aug 2024 08:11:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c742:a100:9dd2:c523:f5fd:da19? (p200300cbc742a1009dd2c523f5fdda19.dip0.t-ipconnect.de. [2003:cb:c742:a100:9dd2:c523:f5fd:da19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42abed8b8c4sm226718725e9.3.2024.08.27.08.11.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Aug 2024 08:11:16 -0700 (PDT) Message-ID: Date: Tue, 27 Aug 2024 17:11:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] mm: memory_hotplug: check hwpoisoned page firstly in do_migrate_range() To: Miaohe Lin , Kefeng Wang , Andrew Morton Cc: Oscar Salvador , Naoya Horiguchi , linux-mm@kvack.org References: <20240817084941.2375713-1-wangkefeng.wang@huawei.com> <20240817084941.2375713-4-wangkefeng.wang@huawei.com> <5a475005-e670-427c-b3a7-7e1fe7af1ec0@huawei.com> <9c930ecb-7d14-93ec-2fd1-270f935bb1be@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9c930ecb-7d14-93ec-2fd1-270f935bb1be@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 78515180012 X-Stat-Signature: abpjcmbkf84ytxqr3eicesq3sae1qxzi X-Rspam-User: X-HE-Tag: 1724771481-446920 X-HE-Meta: U2FsdGVkX198m5rTA5FRLmuQfONwAs4YZtBeN2imO5jjL3jRJc8/LHM0i+3aFxtUKhkEJj8Q+erJNBo6f4U+CuawQMiHRVvGlH6OnmDF57Nw8u/XsrSRBfS/qWZUpHazXkVZhGtUZOmKDBSEMhy/G63BxQ6rRBn1fWZGHwGS+HYW5FLOghvfqrol/wlgdZB56SfEvSLQoofalYlRJY1ubZndsWdFYtYp0tSspGpLKeUc8VilRuG1HZUVxxyU0ml3+AhaolZgxaAICAe4FW3nWltKaA0sXiglh+i1RQH/TdxYfBsPLkkqoqv5C6zUB3oA01zn/OWlnVgbDwG/YCW3GoV7BTuOYVvPiu1dl3sKsXkj3nxG/Rh2De7X7bwNQwIB8SrVMqiNfCJkvQ54KxM9wj3OJYDSzu3osgCVHRz//+5c3LiyqPvVWeG8ee02+Rc94Pm6qpxUIUt3LQ3YdslpqVfivp7E3SunZjBBrBKjwTziBzxPawdims+7eTaQxbMcDAX/mSGeWSukyfzykEJ9wblhdWqLbaXSTRIkP8x1W3Gd8R2j8Lm/V1iKwOpjTaY16wNALYHoF+vEgg3052gfOjdHneWigWY8kezeNoFfwYCYc6295MWQ9M8kgs6k1QsWmFQVFR/xEdIViT/vVg9KYcIdkYyG3zQ987KOlbqeKdEeCu59lU6gGBGHt0nwW8AvESyPWU8Zp21qGuvuS5r9TwwLQSJP4AzXsTA63ye2RHFLNgrqfi6qPkbxEmQ4zjQQeYIAmNunvZIj6pfawzTYc4E4NofJVCRZR+HIiJQdRpIEWvC9EfDvpNt88BK0ISuR7uNifa/qUJjk1hDPCdzFDYMB/NO3xHz2xNhEVSt3Vm5sVmNKM62j/6fuhZxe8gErVPUJ4jHxiITUYZl38P34nMicmjncztpjhP5XQMqd7xvo5J1YV3bvWHvY7j1P2O/2cxGh37/gUiZHlj3LAGs Jq3Feu8c nn+4Xij+mithMRzkaRUHwxM6mEcJq5uLQiCVzkWUByklcCYug2DxBuEozWHq1yxoyTKWcutODk5K8b5vcifrSgVT/qzCafZgh38j2JjSBU/IlCFqR1e5MgYBjnANolsrthFnD1TfWUiHJRjL+WxcudaMMkIIivivfnMH/8pMm/81O8iN2dnwrbHkTMTsouIG2AqYBW/+SYVb5yhX5b0imZixtH5qJ6bIOq9VGXo/hSigQ19Effk+/QHn2D+U4/qyOHZBLvIzaXipWKogIgS1a25weeC959zaDZ4j2DK1u2mTnj0DFBWfJsy9luj/TPFcifIWMTdSE5mih9CSbuhzNtWwW7fC5odMwCIcH6bwRu6yAHvLQWts5F6mtzifi8wed/lbppL6z/nnj0IbSsbHHiwJ57Ky9OHTHDLRvwyht9y5AMFKF2EKreM3+un17oDWc8sh4CJCgvgres+PnSopD0Y1i9QZtluUvqP1qt+wjFihqvn1hf/qaYBGhHPdU8cAcUDLpZG7XhfA0wb8ZlND4M3Q8BoA/R2uWBHJJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.08.24 04:12, Miaohe Lin wrote: > On 2024/8/27 9:13, Kefeng Wang wrote: >> >> >> On 2024/8/26 22:46, David Hildenbrand wrote: >>> On 17.08.24 10:49, Kefeng Wang wrote: >>>> The commit b15c87263a69 ("hwpoison, memory_hotplug: allow hwpoisoned >>>> pages to be offlined") don't handle the hugetlb pages, the endless >>>> loop still occur if offline a hwpoison hugetlb, luckly, with the >>>> commit e591ef7d96d6 ("mm,hwpoison,hugetlb,memory_hotplug: hotremove >>>> memory section with hwpoisoned hugepage") section with hwpoisoned >>>> hugepage"), the HPageMigratable of hugetlb page will be clear, and >>>> the hwpoison hugetlb page will be skipped in scan_movable_pages(), >>>> so the endless loop issue is fixed. >>>> >>>> However if the HPageMigratable() check passed(without reference and >>>> lock), the hugetlb page may be hwpoisoned, it won't cause issue since >>>> the hwpoisoned page will be handled correctly in the next movable >>>> pages scan loop, and it will be isolated in do_migrate_range() but >>>> fails to migrate. In order to avoid the unnecessary isolation and >>>> unify all hwpoisoned page handling, let's unconditionally check hwpoison >>>> firstly, and if it is a hwpoisoned hugetlb page, try to unmap it as >>>> the catch all safety net like normal page does. >>>> >>>> Signed-off-by: Kefeng Wang >>>> --- >>>>   mm/memory_hotplug.c | 17 +++++++++-------- >>>>   1 file changed, 9 insertions(+), 8 deletions(-) >>>> >>>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >>>> index dc19b0e28fbc..02a0d4fbc3fe 100644 >>>> --- a/mm/memory_hotplug.c >>>> +++ b/mm/memory_hotplug.c >>>> @@ -1793,13 +1793,8 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) >>>>            * but out loop could handle that as it revisits the split >>>>            * folio later. >>>>            */ >>>> -        if (folio_test_large(folio)) { >>>> +        if (folio_test_large(folio)) >>>>               pfn = folio_pfn(folio) + folio_nr_pages(folio) - 1; >>>> -            if (folio_test_hugetlb(folio)) { >>>> -                isolate_hugetlb(folio, &source); >>>> -                continue; >>>> -            } >>>> -        } >>>>           /* >>>>            * HWPoison pages have elevated reference counts so the migration would >>>> @@ -1808,11 +1803,17 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) >>>>            * (e.g. current hwpoison implementation doesn't unmap KSM pages but keep >>>>            * the unmap as the catch all safety net). >>>>            */ >>>> -        if (PageHWPoison(page)) { >>>> +        if (folio_test_hwpoison(folio) || >>>> +            (folio_test_large(folio) && folio_test_has_hwpoisoned(folio))) { >>> >>> We have the exact same check already in mm/shmem.c now. >>> >>> Likely this should be factored out ... but no idea what function name we should use that won't add even more confusion :D >> >> Maybe folio_has_hwpoison(), and Miaohe may have some suggestion, >> but leave it for later. > > Will it be suitable to be named as something like folio_contain_hwpoisoned_page? That sounds much better. "folio_has_hwpoison" is way to similar to "folio_test_has_hwpoisoned". -- Cheers, David / dhildenb