From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2B12C43458 for ; Mon, 6 Jul 2026 18:34:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1A2E6B009D; Mon, 6 Jul 2026 14:34:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F1B56B00B1; Mon, 6 Jul 2026 14:34:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 908006B00C8; Mon, 6 Jul 2026 14:34:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 61CAD6B009D for ; Mon, 6 Jul 2026 14:34:27 -0400 (EDT) Received: from smtpin10.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C6F96C0A20 for ; Mon, 6 Jul 2026 18:34:26 +0000 (UTC) X-FDA: 84959202132.10.4A61999 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf30.hostedemail.com (Postfix) with ESMTP id E60A080008 for ; Mon, 6 Jul 2026 18:34:24 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=E3lad+Vv; spf=pass (imf30.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1783362865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vXyg4ZUkc4uNfSCtADLd0ATogR8529Lag5lnJjDA+r0=; b=ej/S70GE+heLJx2ftUP1v+Sn+HtdyL0OXqkzL45jRwUnUss7JOeXACQDtXCIINWO6MSRu6 MuKQNwB+mXqH1o4yFiTD/KY/dkHk9m3+r/S7XGu1ZJp7cdPrc2NbWrwmius+3PuTrSMBfI 7qytyLco3ljL5q7fzVlSPTDDiOPXXeU= ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1783362865; b=4PjVBRBjuMOOGoXqMhSLPzTmMffyDhXyGn0U8juGZkIOHkerVsQSlCPBlFIOjE1XeySbls SRiCyDolcoJCKPyOkeDV1ZzDayDv9dDN8AY9qbEgMlcv6BBXEpUjt2D9zlv6z3sElyB5nH BdTuzDC8eRaDho/lXnPLwAKWWWuKPF8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=E3lad+Vv; spf=pass (imf30.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id BE2344090E; Mon, 6 Jul 2026 18:34:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AB6C1F000E9; Mon, 6 Jul 2026 18:34:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783362863; bh=vXyg4ZUkc4uNfSCtADLd0ATogR8529Lag5lnJjDA+r0=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=E3lad+VvgRlwue6CbHT8alWSu7Qf1xXpQvr8oSaM13Ba59bcYB0/60FFCOHbacizI OzHPKaCc/zwGhxuFu8Yrsn7RX4FYJE1Rn4UC8xXTEBnsUxjzXY1tVvOyap4oYLaDYB TlxI4WRjU5RdlDLKls5X7AzSGvbHRZM19xny+6eY1TqNpIH3pRn3yu9f6JmLWtQhvn tLuowE8Udrws/gKBJnEJZ59oh4L6iDBeCBU2JYjpAyMnW9aX4S1St2upY5fvq40bJa X7tnpmvYPGvPP92N5njqINYbfmJviNQbY6pPa7vKRgEUyCqeV8TdTr2VQJkFErOihT KW5ekQHZPpqvA== Message-ID: Date: Mon, 6 Jul 2026 20:34:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/9] mm: use enum migrate_reason instead of int for migration reason parameters To: Ye Liu , Muchun Song , Oscar Salvador , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Vlastimil Babka Cc: Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Mathieu Desnoyers , Brendan Jackman , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org References: <20260701061101.344679-1-ye.liu@linux.dev> <20260701061101.344679-4-ye.liu@linux.dev> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20260701061101.344679-4-ye.liu@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E60A080008 X-Stat-Signature: t3ysur1wdjuw1e3tx9nom6hifn4id86y X-HE-Tag: 1783362864-280122 X-HE-Meta: U2FsdGVkX18LYeVkJ9zsGb6Y4vTOgiag18I6hJCod1gJAq+tJz+LWdO5J7lao6KlNEZjdMa76vtrU/n1mcDSHG6MhqrYWSyLbhFWf2wVESDeiqHPDbd1JBrcmPU31tkYrEpm+YVbOwhT9Qto3h24WGOID7Xm1Il3ItT4QaoTZog1I4G0We2+Q021e0n7DSwA0w1PBZfOZBsJJBaav8Zi6oGh7BL8ACVXCQBc0VvB81cBYdDjrEOfJaaVS1N7LKypIKRzA5dpR4MnTyhJsXW+NKsQRd80VgG8AUhDW6RgN3s0PnlqWkax3mki7g1WBJ06hhD30CmzkoBLMFoj0DdgZQ72BiG07zAflIiygAdwnKhirHNysLsJeDQffrEH8rPN9iMTX4DS2Cgu1D9UebJAYYUJ+G7nW2QF4OgRqfslyXz3yoZ6jukJPnSMfd/q4kylZRlX3fv7Efuubl0UV2mqyNmmt+sS1SdIE8LZXcCi9ruO8wtDAA2yB5PNeckQVi95JpVLbXZNy8ZDZiXKxZ6N6asn5B8BI9cu6MbtDsZGRWOKsxfsU84lZFO1Jh9sOLnnzQ5j4wYeOgtNDnCdEIM8BtNMT03eArHZq4rP+irSFf1k2HHUlJn7x2kC3CbsVZEIWpcA1+M8N+91ynKseh8J4bodEw0kE/FQtd1v+WA90uRexXHEWWf11QkYrPOlwVHTbmx8zhiH1epcnjfy1uYoisnVwkMewNL9omFlMH2g6mb3pSZ82x9CNWaHiwUiubmVlJMDjnPTCJxHXdjGUQISm5NSCBmMmK6FdgrDd5wiGUrVUJkn9K4e1poJZ+/D9aCBtmrgFBMv+EUIWrm28QJ1UEa6FQANB8RyuohBnWuSj7XXjTTi7kOy8di8T6RRZlVuBJNpsz4DS1PmNfx1fSud75TpqIhEu1zXRerdczdl5I07Nz3SDHQAJ7mRM4Rg+89gPuYVGAx3QclpuSKbxqI 9VxU06he slsEbM/obzBhxhQoBV65ibqp2DabEcHe4EZsnwZhrwSKOUJIo48ldFxyDwk2urJmWHbbYbpqQ0ilXpbh4CJkRjXs7ucA0NGF554pSWFEAidK4m8mD6jyTsIKXjx2aM75mSwqY5EIVPiLqkxaKljD4N++xel4GSo0ISsEiRgXgfFpscwD1ioKTnDTZKk/JJtiCS5b5u/6l4fjQGByqFY7pgX6V01WroYpgt8V/tQCcGcgAzyEOPRFom9COsAMTPQk7odq/YIqNTrbDOF7A90CB5n6lZVj5kQslPycSr85Yutbg+DeCnhnIVNO3Y540kXbY/GqyaG75CCG9q37Wli4Z0/oTUhIDqWlbKIQzx47u72oHAEyrQW4knDl1MUQ8a/2QD6uxSWParYzfa04MNhPIFILjUZVYd2i3b2MuJ3sATm7x4nU= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/1/26 08:10, Ye Liu wrote: > Replace all 'int reason' function parameters that carry migrate_reason > values with the proper 'enum migrate_reason' type. This makes the > intent explicit and leverages compiler type checking. The affected > subsystems are: > > - page_owner: __folio_set_owner_migrate_reason(), > folio_set_owner_migrate_reason() > - migrate: migrate_pages(), migrate_pages_sync(), > migrate_pages_batch(), migrate_folios_move(), > migrate_hugetlbs(), unmap_and_move_huge_page() > - hugetlb: move_hugetlb_state(), htlb_allow_alloc_fallback() > - trace: mm_migrate_pages and mm_migrate_pages_start events > > The 'short last_migrate_reason' struct field and internal helper > parameter in page_owner are intentionally left as 'short' since they > store per-page metadata where size matters. > > No functional change. > > Signed-off-by: Ye Liu > Reviewed-by: Zi Yan > Reviewed-by: Vlastimil Babka (SUSE) > --- > include/linux/hugetlb.h | 9 +++++---- > include/linux/migrate.h | 6 ++++-- > include/linux/page_owner.h | 7 ++++--- > include/trace/events/migrate.h | 8 ++++---- > mm/hugetlb.c | 3 ++- > mm/migrate.c | 12 ++++++------ > mm/page_owner.c | 2 +- > 7 files changed, 26 insertions(+), 21 deletions(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 2abaf99321e9..fa828232dfcc 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -154,7 +154,8 @@ long hugetlb_unreserve_pages(struct inode *inode, long start, long end, > bool folio_isolate_hugetlb(struct folio *folio, struct list_head *list); > int get_hwpoison_hugetlb_folio(struct folio *folio, bool *hugetlb, bool unpoison); > void folio_putback_hugetlb(struct folio *folio); > -void move_hugetlb_state(struct folio *old_folio, struct folio *new_folio, int reason); > +void move_hugetlb_state(struct folio *old_folio, struct folio *new_folio, > + enum migrate_reason reason); Two tabs indent, applies to all other cases in here as well. Besides the "extern" Lorenzo mentioned, LGTM. -- Cheers, David