From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2868C001B0 for ; Tue, 8 Aug 2023 07:29:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DF536B0071; Tue, 8 Aug 2023 03:29:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 090416B0074; Tue, 8 Aug 2023 03:29:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E715C8D0001; Tue, 8 Aug 2023 03:29:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D445B6B0071 for ; Tue, 8 Aug 2023 03:29:25 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8FF31A03F9 for ; Tue, 8 Aug 2023 07:29:25 +0000 (UTC) X-FDA: 81100111890.22.6626FDF Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf10.hostedemail.com (Postfix) with ESMTP id A589DC0015 for ; Tue, 8 Aug 2023 07:29:23 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=AX5VQvYm; spf=pass (imf10.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691479763; a=rsa-sha256; cv=none; b=JXQeAa/t9+ykCB85Mp5Ef2k5oExVUmpnmM8Yehr7MWlEN/QOhDkXV9gIeeMjG1D50rNA+z A7k4lwN8TQyEy0rnMbKICW/66n6akHN5aYZ9I2fatoqQ4fOgwX54i68jHNGTlB0+MhuGNN jdP1LQvpyles5MTVIuMko1FWgP27aqA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=AX5VQvYm; spf=pass (imf10.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691479763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lysJhQXGNtEOWv4JXhBTYoi8wPVsm0uOHEDBLobVbIk=; b=cqg09mmBv66WKQedp9KJ2sh/Yq/FpSkDGlxvWtdeTIVuEYLjVZsXbJJN7usm3lW5vb2ad9 HY0BVT6rmKNSQ67lsmFwFivkim+WzEoTPLldt+02yjQyp0xSENCM8N6Fqw4UsdUAXKrxij rj42sJwsYSUCQsPwXsBM/ddYGH7gohg= Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3178dd771ceso4601337f8f.2 for ; Tue, 08 Aug 2023 00:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691479762; x=1692084562; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lysJhQXGNtEOWv4JXhBTYoi8wPVsm0uOHEDBLobVbIk=; b=AX5VQvYm0H9ZTcPqPC0Y8MFK/FqvbZyTu4Y2b2JMttSLt4i/Zf2olQ9uXYiOz6fMj1 dEdORxuIGES/RofBij76P6b8WzEqkenGXsLTEmfRuY1hyX+fyQFiEZSnhgH7cWdR9Wej 745U0GHgJlhj+ZhWnitvBjQYAeS+SiqhO6gshZx/Z7ZHg2VcgsR7o+L1j3iS5G50oyIa lrwrFapvEansiNTv2q2x3mT/v2oJqmwZF0gtYw0OfkadXMcoYXjtughxLXvXdugJNJYw WCHizK9A7VhjpVAMTsMZrDSenBIQV/YfjWkw3TT7TKZ0Y11157CEfQJFa8MUr/rj2BK3 PU4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691479762; x=1692084562; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lysJhQXGNtEOWv4JXhBTYoi8wPVsm0uOHEDBLobVbIk=; b=RBLVKHarZROvAm1jPCFYkitEUFAelOsHcM5bp0iBrKyyrwLVQunLV4XqA9oPNFLqld gE5pxSInZa+O78zY7opd2kO1Nzoj3xERjcFhRPcudBNG4R9SRr/xm7FdfOTreMtW3N3a JBiXr1j8s6Owiylwtx/+EGRqGej+tvhJQkV46k9MqePXdia0E0H4Y3FjMDVzHlZOv/Bd 61CDytriKXR39BWi8y6S2i3SXqBDIaFse9pqZMfTBkrGZBVZLb7olRTbHebPJ8BWaYTX qe9z6GT2SWzIMkj0qQwR83D7aSYtiV+F8qn/Duk2kOCqobBQf66EtTyS1Gh+aDQ14h9O SuJA== X-Gm-Message-State: AOJu0Yx8xcnanZHLpHSkLWNoRsG89S1FfWbcIIBc7q2QxXVUX+vNJY6Z l9bBS/4LJPGVR5Zk5NAf5dg= X-Google-Smtp-Source: AGHT+IGsZin9+ncr2tFP2CG1ZCm/ak0OCQEihvB824ZGDcsTUJ620RJHEcI93aBiUVg2hMFSPiUe0w== X-Received: by 2002:a5d:6344:0:b0:317:3b13:94c3 with SMTP id b4-20020a5d6344000000b003173b1394c3mr8509188wrw.41.1691479761813; Tue, 08 Aug 2023 00:29:21 -0700 (PDT) Received: from [192.168.0.103] ([77.126.7.132]) by smtp.gmail.com with ESMTPSA id a2-20020a5d4d42000000b00317ca89f6c5sm12640688wru.107.2023.08.08.00.29.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 00:29:21 -0700 (PDT) Message-ID: Date: Tue, 8 Aug 2023 10:29:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH net-next v10 08/16] tls: Inline do_tcp_sendpages() Content-Language: en-US To: Jakub Kicinski Cc: David Howells , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Boris Pismenny , John Fastabend , Gal Pressman , ranro@nvidia.com, samiram@nvidia.com, drort@nvidia.com, Tariq Toukan References: <4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com> <20230522121125.2595254-1-dhowells@redhat.com> <20230522121125.2595254-9-dhowells@redhat.com> <2267272.1686150217@warthog.procyon.org.uk> <5a9d4ffb-a569-3f60-6ac8-070ab5e5f5ad@gmail.com> <776549.1687167344@warthog.procyon.org.uk> <7337a904-231d-201d-397a-7bbe7cae929f@gmail.com> <20230630102143.7deffc30@kernel.org> <20230705091914.5bee12f8@kernel.org> <20230725173036.442ba8ba@kernel.org> <852cef0c-2c1a-fdcd-4ee9-4a0bca3f54c5@gmail.com> <20230803201212.1d5dd0f9@kernel.org> From: Tariq Toukan In-Reply-To: <20230803201212.1d5dd0f9@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A589DC0015 X-Stat-Signature: qi3st7k6de95aphc57uf959djwscw1y6 X-Rspam-User: X-HE-Tag: 1691479763-565588 X-HE-Meta: U2FsdGVkX19ongCMmxK3F6WT+I4T6NTMk+c5+4D7KaSZYbEuAhcGZakJmkCHFAL4zHYe+x8pjeKZNpG+sbL6GYwyIgp7RxK5aEU2MInnp8K+4kH5V/NgC4J4i3Erx4DoYBJXv4kbfBVZZrYY22pwkDA2Yqe0NZD42BbdviqmgfAA8Bl/AJHlmrkJ+hX1uM1hwo6002q9VxKCMyNItqUDqDNmhS6XDmV56lUj1v8d5BKRpl8TBltc1PwP5BK6ZuboyvGydwigienErm7mhc/x6miNSeza9h9R3fbhoN6HV6f4MHLRPKO7UWkzOMX/SuQhQW79d8jznZmclEE7cqyPS2dUxzyvgaRcBE4Ki3Kva3leAx66/dHVkHcUaxkGgZEbszHauNtFT/7/ZRFyMqwwCZdu9QPHCqbjwDsokxLcS36S6RmkKDJACW8e1srdyOlkIXjefaJ7oZjOpDTfQPyDspG8S3xA1hjgH7k5kSlCJRPKyxcWSXTEHeo3y6YsRSsgbmf1T+nTOwROPth/0ZQfLJWlTAff8AdeNEae3/TjtY0Cjv+pcZn4vtitoYgS7F+SFo+fANoEY/e+VlQJzfXmDTfD0ZppFG3vWg/pZLFYQgBTTgTNV+yPgWSthTDr7Kan9uNS/AlbWPWOWn0RbAeIbA0EvHmyyOvR4ZAKYdb+8IvhTrArqvgH1m2WrH+khmB4kYsEQ6FqRRJCAX1Ko7yKj/QuLMiWT7wwQdyJHRGaM34oeo6bjJVJEBpwlJken/C9B73IhJZJZp0+mN0c/V3xict9Akx0jIaMyl0rm3tspqWTwvZO9svRatDFpF0n16XBdI0uj0ZPw3c4woGS5hWJPfosupvNEemBCeCIe+szZwBdO0UNA2HgEk2qJlM1G5LHjZjOfKO1mtaVo8a4hd0c9DrR9AsSDYSZ/IueE6dcJvtRnouV701so1JClsnRYSf0R6l5Dcwo8bRXKnCawRS DE/pvMC3 LUwiaaGOoVI6YPWF6InM5bglgbXR2CIQcQ9lpI4YeVL86Dbwo/F+3PXJG6Pd8TuO1sKatEsuvUY8E+oVQGS3fMTaVfKGr9lqmfRTjVzm1u117aDAzfdDjmHbHtdpxdqONmsjncBtGDPJy4mg4cRYBCHrLGYisOa9YZq0Rl2taQWg3kzJmjRhZdwt7goWNtJtmpfRBkE/wvGxXjDKS0Ar5eN7X57dQYdXanGTBTIa43sjpjpfHB2JAt+iZEaskPhXeBIlniLEgfl7171dhlDb3u235zcmerrd2uRmTzPh4bvc58dZdNhxrRBZdCzGZnUBFFz7YbXhWitmomf5gUIiLXoFIdYhIhGirm/yqD+R8GMe9dVtYnhO5u5Ad3DAB4focWBwXdZ9BNLSw2rE73j2VwZVQYr457QtUYxEUVKJj/KV+hRyJAdj696/AHrX/2/sWAi50sk0A+avrg/Q7RNyFaSrIqFg+VQHmxqS4BwhTJVpcjRmXJCGi+cr89HjqpqV0Ky1VsKTjLCb4o1fK0nDlaGCMyZ5Gb6tCerVfVjcFhZj+dyLsn4pYN0fJZ1IS9VhWN9YR9YNS7ROADSw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04/08/2023 6:12, Jakub Kicinski wrote: > On Thu, 3 Aug 2023 14:47:35 +0300 Tariq Toukan wrote: >> When applying this patch, repro disappears! :) >> Apparently it is related to the warning. >> Please go on and submit it. > > I have no idea how. I found a different bug, staring at this code > for another hour. But I still don't get how we can avoid UaF on > a page by having the TCP take a ref on it rather than copy it. > > If anything we should have 2 refs on any page in the sg, one because > it's on the sg, and another held by the re-tx handling. > > So I'm afraid we're papering over something here :( We need to keep > digging. Hi Jakub, I'm glad to see that you already nailed the other bug and merged the fix. I can update that we ran comprehensive TLS testing on a branch that contains your proposed fix (net: tls: set MSG_SPLICE_PAGES consistently), and doesn't contain the other fix (net: tls: avoid discarding data on record close). Except for one "known" issue (we'll discuss it in a second), the runs look clean. No more traces or encrypt/decrypt error counters. Your proposed fix seems to work and causes no degradation. How do you suggest proceeding here? One mysterious remaining issue, which I already reported some time ago but couldn't effectively debug due to other TLS bugs, is the increase of TlsDecryptError / TlsEncryptError counters when running kTLS offloaded traffic during bond creation on some other interface. Weird... We should start giving it the needed attention now that the other issues seem to be resolved. Regards, Tariq