From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A313C2BD09 for ; Mon, 1 Jul 2024 07:18:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B48096B0099; Mon, 1 Jul 2024 03:18:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF7816B009A; Mon, 1 Jul 2024 03:18:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BFF06B009B; Mon, 1 Jul 2024 03:18:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7CAE36B0099 for ; Mon, 1 Jul 2024 03:18:19 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2958E1A1990 for ; Mon, 1 Jul 2024 07:18:19 +0000 (UTC) X-FDA: 82290330318.24.87B6768 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf12.hostedemail.com (Postfix) with ESMTP id 6098040012 for ; Mon, 1 Jul 2024 07:18:14 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=FGWVfb7r; spf=pass (imf12.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719818286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+qYOqVuRx1p/w/RsfmQsFnjToFDa0GRo3Rt9tmJb5XQ=; b=6PfvEJxSRHbB+Nfi2H87IzpbxLTCt8vsL0Nl/8kRdTmt8m8ka8LU+Jh6UIwLnDbJeATtAs tyBKgNDHraKhJ4HSH9VnM3tq30X03W0mWGzDziTmzlBdYUEJ1H6nw9MCPWjKRk4ACTolgm VeJgQZkfftTSpjp0MUC/bDaEOxyab08= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=FGWVfb7r; spf=pass (imf12.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719818286; a=rsa-sha256; cv=none; b=EVZszVT73T6wWVCBphjs1UpXdUbG4jm7cwZ81Yaw7LNESHdf5eQLunDW1ZutS3zxcxlU10 bNW3c2vOhqmKm0fED9dw1zgsJBN8eUSXfUQFGBNT182llnPgnxNOeVELyMRjvK/wPZwQ6l MNyCfqkw5qJKZcwJ60OA4uKLR/sERn8= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1719818292; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=+qYOqVuRx1p/w/RsfmQsFnjToFDa0GRo3Rt9tmJb5XQ=; b=FGWVfb7rJr7qMMkFBTOhkMBpGlk/6PgfNyiy/lAiWFLCfocyveMMYUH5MRX9JtGQ7yUj6mGodfgiyVIcF215pPQxduKROt2l87S2/Nctuurpby8HCQRuOD5pz68QSurrmfCLrfd1JP6tTI/hrOfIwSVhGounXfJsHyxNv+A5j50= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R401e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067110;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0W9b2CzI_1719818290; Received: from 30.97.56.67(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W9b2CzI_1719818290) by smtp.aliyun-inc.com; Mon, 01 Jul 2024 15:18:11 +0800 Message-ID: Date: Mon, 1 Jul 2024 15:18:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] support "THPeligible" semantics for mTHP with anonymous shmem To: David Hildenbrand , Bang Li , hughd@google.com, akpm@linux-foundation.org Cc: ryan.roberts@arm.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Barry Song <21cnbao@gmail.com> References: <20240628104926.34209-1-libang.li@antgroup.com> <2972d75a-ab26-4da7-88fa-81bed955cf52@redhat.com> From: Baolin Wang In-Reply-To: <2972d75a-ab26-4da7-88fa-81bed955cf52@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6098040012 X-Stat-Signature: 1te4eoubnr6aez1nbaf118k5gsqxurru X-HE-Tag: 1719818294-864328 X-HE-Meta: U2FsdGVkX1+8JbpU7I2pGiRcWADsNpf7T30syBJ9jnMaqgft4cXSL2fskBJhGOXu4SNJYhESRzeQhTopT5mb07Bl/jri6Sf27sivG3P7TeWGfpxvrBuhxyxdc3RGFN0bcx5q+gnaxs0tmUZreNTDO7KZtOIng1wMG0fs9HLfuyys+4f2zC1dSRgB+RkOqww/oq60FslNVOua//n3qRX1fPyIpXDJEKQ9XDG1kwaUDd/rVf0ZR78uvCx4KL7UhVwW3zbxatxOGE9loMP9u2amJWl/kBedwK1069Vr1CjRoSu32OBRri76PTB2P6MGIEP8yEc1PvxrHilAFaIUM86Cm3u8o3AT+s7yzYN/lEMLCP3xwNVqPQxv90JbVWjrohIhtVrFMdpbImVbZh5Zx1dEg2v/p+SSjcMO6Ki0e5Hysbym64WVnv/YF2ou0GW/CnyFXjCCQHAg49maV6Xe4iATe9WLjsIHRBVZSuD+OroYR7LsnQxGP5KhR2yWQzTAGfCjI/T9W4qEQSeUGoEjtxcKvzjlrOzCtYNTVPmhQi5xmVm9AEcvv8aFIiZJWIHOht/neL5fj2Q4Pq98DNows4Ajj0f3m3RYDm2u2BPZnvRcz0hQhqDbSkGv61btBlmwU3yvh0jqK8Q/gnEFjfUvSD0Aw98qlKTE3qJwzLD/eguyyU7PpzY+oZAkJG0X+eOYfh3R8kSb4TYQBP/DjojczTP1sw+rh61YrpHGPjBzMvzRM0dGllfsfudZUODwme/CjY64tDSJpArBoubAYrr6AYRB0SMG8z9xxqCV1GX7H877+VE1IzGXfz45W5nIbzHiVGYYggkQd1kReuxbb5wkiqYZ0KhaYUJjQaw1R6qsegaFWE0PkaKSLkWwSSTyiS8iwcYQaLHtqCpIdG1tPGQigT2dCw2VTG1OLEdbbCxgwO5s2HzM/r+gbaNyYYPU88kM3/dgJbtuwhuDS4Ti16WN7Mq 9dn2PCp+ 7DxbGV1FT5fQLf61PgHqZlXcZUDQZZ9M0CUNFn59elG6X32p9Nr50m6pijB72nmqmubUm+E4bxcnXWn2FaV5fIDXyeK43NwYxzZ8wSlYv88O0EKZXWByLHuKN1AvnCnitGKNhSwxLNtAl63HIWAQY1PzkZ/k3EW+hh1L/Up/oawO+mUPuNIrQCxQzf70BeiYGei8iJe8pE4RSADvcSjmaxEiQRFoUUNHVa+zQ6Y0mRSXrHFcdGlmDLahvBOZvGERXmhp3Kg0CHwjPoRDdZ60dAD/fQIGr6El6Aohldsypa8wq2C08qrmEWnvzU2J4mGYL/Nzs1SLZMwD1wX4ElWv3K81AgSXaWehXHpRvV3CTRNAcpph08jWYWLjco5x3BOBi/Eg+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/1 14:55, David Hildenbrand wrote: > On 01.07.24 08:47, Baolin Wang wrote: >> CC Barry. >> >> On 2024/6/28 18:49, Bang Li wrote: >>> After the commit 7fb1b252afb5 ("mm: shmem: add mTHP support for >>> anonymous shmem"), we can configure different policies through >>> the multi-size THP sysfs interface for anonymous shmem. But >>> currently "THPeligible" indicates only whether the mapping is >>> eligible for allocating THP-pages as well as the THP is PMD >>> mappable or not for anonymous shmem, we need to support semantics >>> for mTHP with anonymous shmem similar to those for mTHP with >>> anonymous memory. >> >> I did not see a consensus that "THP*" related statistics should contain >> mTHP in previous discussion [1]. >> >> In addition, if we all agree that "THPeligible" should include mTHP >> statistics, you should update the corresponding documentation to keep >> consistency. >> >> [1] >> https://lore.kernel.org/linux-mm/202406262300.iAURISyJ-lkp@intel.com/T/#md7a77056110cebcc2a9b3cd7e4a8d682667f6ba5 >> > > Fortunately, documentation (Documentation/filesystems/proc.rst) says: > > "THPeligible" indicates whether the mapping is eligible for allocating > naturally aligned THP pages of any currently enabled size. 1 if true, 0 > otherwise." > > So that documentation is already pretty clear (we just have to make sure > the other ones are properly documented, for example as raised in reply > to [1]). OK, great. Thanks.