From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6390AC2BD09 for ; Mon, 24 Jun 2024 17:26:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D21EE6B00D8; Mon, 24 Jun 2024 13:26:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD3236B00EA; Mon, 24 Jun 2024 13:26:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFDC86B00DA; Mon, 24 Jun 2024 13:26:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8C7986B0089 for ; Mon, 24 Jun 2024 13:26:47 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1A2CCA3A32 for ; Mon, 24 Jun 2024 17:26:47 +0000 (UTC) X-FDA: 82266462054.09.6ADA8C0 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf04.hostedemail.com (Postfix) with ESMTP id F19FC40009 for ; Mon, 24 Jun 2024 17:26:44 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dtZIiQPV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719249989; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r0zJj0i6Eef+mmmoD7VtRkp40psXLNI3uhnA1z5IfCo=; b=A5jP4u92m3+OhREi/4yPelaEUkD3+htsbA/yOhpS/QSK6viDPy1Jzxm/Bnq/aeqFpAdRVe 5vx0mY4Tw+5XsyTyhqMGmKaKp5yfLVIYOlm4gKkeP77xLqTGNNM8xXCh0oDk4ySbvZeO5m cShAxQyRLFDdszIpVcf5BMcwJI2utbo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719249989; a=rsa-sha256; cv=none; b=YKrasiRN7W+XRWpSaA1MgduE0iR/59Z0V8wsgv7Ww4tjvcJezip0oLW0hK0Oc3Y59mx2Xn 9EQlwrK9tf6JOUkn/SuaIxX0hZ1OMXZFocWmy59NKzHLDcJUxYH8wjhBQ6V5BfSU38ouTQ 5smOnD0IlkHfFHr9ODbQTd2DxeAY3p8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dtZIiQPV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-421a1b834acso37575005e9.3 for ; Mon, 24 Jun 2024 10:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719250003; x=1719854803; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r0zJj0i6Eef+mmmoD7VtRkp40psXLNI3uhnA1z5IfCo=; b=dtZIiQPVyyvmXEhC/0jUNbvAZSCSIgIXkIdM1W7zP9NuVDE1tQREAl3xQ5RHXSS8of WK1XTPIiaDm1LYcquzATIv3rKczUb58r+2NfVJTtmtUXc+hURJQWW0A87of/qsl8e8wx qwOONpMlWrL6oqOuYqfmIPjyuOe2Nw9Tlx12sJW8UWHOZAxW9CtxsY5BZnDOAVGsPkAI jIPFe+W8LuT0wYDLdcWZrTr89tijNcVbcboFpSo3oQcXgijxWPJJHU3b8MaqW7PqKCSf wOzBKhnYLS0YrGgeGKoBMjGVzkOiJW9fHNIrH8KDLnyRoqn7v2ituVWjI2JSqYgv9oJa 6kJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719250003; x=1719854803; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r0zJj0i6Eef+mmmoD7VtRkp40psXLNI3uhnA1z5IfCo=; b=Ocu3ja74nY0PI42GZ61Ime2jqGJme7jztspdAqDYzd890plWavPVO98h4x3jPqNBbN g851zqNjt5PNZN5aoUKZ4ua210P46HtyPekedpF85a11IWqN26n26Y1Y70L7k5R2fJ+v NV1Q07Da47M5ogkRFBawJ7hehT13BvC7so3paBalnlY6MHzu94tZBhCMcKzIcOOPntFH iwdo4uHT/BUOhY6E1IzJSHKee0jF3421to1vf8zG4d1Zt2bf37yDTGM1GJMeqmBVXY7r P23jgVTvomjCLkmg9Harfb5dG+BGwLKmRWCvocvvjc3FeBjXseQKrLZHvUIq6vds8EIt NPjw== X-Forwarded-Encrypted: i=1; AJvYcCW79VqPi+jNE4SRVKjfoMNbs6FzytOgzsDVFOYFDEMC7Xf1WasoIS33vkZQ4Oz8Ayb9oLP3sNeE7JeATS0jNZt77N4= X-Gm-Message-State: AOJu0YyV111yy528lp7FE6SCAUN8tT9ZCeJ0ZgxkVjX2PnrJE8eGoZOQ Gda1rD8YtMVKFkFbWAyxbHFLskf6KZiETVy3Aqfyzs5K6FCpAlvY X-Google-Smtp-Source: AGHT+IGxeNceUKaNcYx2Jxfd1Gj6bqVSWIOz94FDHmzgiaSghAMdf3VqII30KozGWxqHRnwKYMUtJw== X-Received: by 2002:a05:600c:4f96:b0:422:683b:df57 with SMTP id 5b1f17b1804b1-4248cc33ce7mr33926975e9.21.1719250003304; Mon, 24 Jun 2024 10:26:43 -0700 (PDT) Received: from ?IPV6:2001:16a2:df66:b900:46d:aa3:6645:bcd8? ([2001:16a2:df66:b900:46d:aa3:6645:bcd8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d208b3dsm184640765e9.34.2024.06.24.10.26.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jun 2024 10:26:42 -0700 (PDT) Message-ID: Date: Mon, 24 Jun 2024 20:26:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master] [mm] 0fa2857d23: WARNING:at_mm/page_alloc.c:#__alloc_pages_noprof To: Yosry Ahmed , Hugh Dickins Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Chengming Zhou , Nhat Pham , David Hildenbrand , "Huang, Ying" , Johannes Weiner , Matthew Wilcox , Shakeel Butt , Andi Kleen , linux-kernel@vger.kernel.org, "Vlastimil Babka (SUSE)" , Yury Norov , Rasmus Villemoes References: <202406241651.963e3e78-oliver.sang@intel.com> <12fb19d1-3e57-4880-be59-0e83cdc4b7f1@gmail.com> <61d19ec8-2ba7-e156-7bb7-f746dae8e120@google.com> <5b3e732c-d23d-41ef-ae5c-947fa3e866ab@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F19FC40009 X-Stat-Signature: xa485thmtner3ztjfuemawd3peu4o1wn X-Rspam-User: X-HE-Tag: 1719250004-539544 X-HE-Meta: U2FsdGVkX1/N115wf+3FuoLssNRiRAsM5+xXZ6ZzKMpXyyZw7TDJ/qPfrbi8G/Nva0224XAkD6hO9R4eiec+1mpqPlcs3BZCnNzWfsjwXDA+Kyc+DAkRx44YAQKzbNh7RL8608P17lTuq18xXMqW/gMBTWP9m/EE89Hk5dvw2birT74vFjI8OtPwHyt3FpIIYVJMzXY670KM1qaIhqP4KurflhBKiEd/w/1P6Vs0lKfCexdwBKY0+FjhWiPK+Y5U0ESMp2neJ2v+jnWmXMcn4UE1oS4iAhMgla623xujrfBR5RpSxoSoolq2jQc875XJHGaUg+GPW8iwNXc+ZU8XNEsl2HoNCWchztBb8KO08pvYlN/SL8k1kWkYwyVjOflyA4TCc6+gmO2J5Fgsq5eJDdmyTtfrgt5hH+uDi4OsPd/A74M2lR5zZ9I2olpnHT7KQkOp4KQpC9St+NGe2SFcOQiIanBqSbIUJ/5ZGzuSA6XTNSLBgBsdVbF1y066kE5BpPTGzgkgCsSWGylLiOCzFgG1wqG/EUVNZ2BtAwEV0YLtnKQskhWFt64klS9S/UEqAJkvVTesgvrM2yeGeidABPlOi5IChBhXUzFMr/qz/jkkQlZbxALFXc+j+JHoc9QC57hjeX5arO1iBGDwCWIF8AN/NcTP/hcFdNJPin0ultP7xszhSFyMa+qRgcPMRx0BanTHGIgce4rHq2t6AwJSwU04rgbQPAVoTGc/z2Cqo6SWxPin25WH2GSmJF+Vd6DnoAK/2UgEeCOs65hpEejHlbqqf/ewm9N0S1x9I2vbWkp7NayiduhTCCB84rHI5jQFG1m+lXV7TvB2+aJzxhueM2BSgmlp8AxgQEzuIfFjj7Yel2usGhzRm2BijbdNjK8jx0Tq53b2IM3BBOQ2BRpFb3aPdIS/Z8ex6O5ehuRD3Xa26i1Zm41evjRvNrOz5GZU7JfLfIp0HCt0akPgLO+ nb0K8FHb QGR/9Bf2JOzRfcwcFE8OZ1ZF9B6CLEzXoy1ZxhkGEcQhz5f35nVPVCuNgtRDpfPnbkzVRFIMyukDxpmHPSW1+Zyu3qWKyCfP0Sasm05LIlCAx5fDXD/LJWxtcfDqe5XFYFDK9B0DJ59W5PVADE+2r4Y1lOSY6RVwqpaaPhsD0N3su/XNIEAAutiLOgSXUNE1tzWmBpj/xgCbxbHBBRdc0lIq9WVU0HsnSoOxaxwGU4RofUaA40rJjV+T/OP9VDjIponLCWjI9fs7bb4gl/IJho32FxDZSBu+E8CZszpqx3UhhbpXeYmRSTfojYvV73Z5wBpZXbZzyBfQruvbxGf0i1cV1ubMwUKTr3JwRJ8hKxourJ1ygA9jSJT3mn7iVX48JaMoUNEGhQceJ3lHggqeD5qg/WBCr4PDLuYiBOq2S44noRlydZJV8rGj24L8l1QpUv4a6JogkLQ9ZuoKtQgTsusF0gwxHJF3W3n94Nyyppyxhsqz3IF08IxNrDHbPYlEYNWWccz1v6Gqj4K30rAkb4vEDNr1SLe58ZZ9sPzH6ui3dG7mfBP3JAJ3qYQJzptL75EZNXpaTyHqXhVoHPdgqTen6mIgUDFZoeg4F7jdBzVP2kiQG5JXaJ9J5P3e+IR3jTiSHMECtBGWx8RcZ35aukB6/m7FNOwsYchYNcWqIfqB3ARFYx5v3cl4j4w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24/06/2024 19:56, Yosry Ahmed wrote: > [..] >>>> - p->zeromap = bitmap_zalloc(maxpages, GFP_KERNEL); >>>> + p->zeromap = kvzalloc(DIV_ROUND_UP(maxpages, 8), GFP_KERNEL); >>> No, 8 is not right for 32-bit kernels. I think you want >>> p->zeromap = kvzalloc(BITS_TO_LONGS(maxpages), GFP_KERNEL); >>> but please check it carefully, I'm easily confused by such conversions. >>> >>> Hugh >> Ah yes, didnt take into account 32-bit kernel. I think its supposed to be >> >> p->zeromap = kvzalloc(BITS_TO_LONGS(maxpages) * sizeof(unsigned long), >> GFP_KERNEL); > You can do something similar to bitmap_zalloc() and use: > > kvmalloc_array(BITS_TO_LONGS(nbits), sizeof(unsigned long), GFP_KERNEL > | __GFP_ZERO) > > I don't see a kvzalloc_array() variant to use directly, but it should > be trivial to add it. I can see other users of kvmalloc_array() that > pass in __GFP_ZERO (e.g. fs/ntfs3/bitmap.c). > > , or you could take it a step further and add bitmap_kvzalloc(), > assuming the maintainers are open to that. Thanks! bitmap_kvzalloc makes most sense to me. It doesnt make sense that bitmap should only be limited to MAX_PAGE_ORDER size. I can add this patch below at the start of the series and use it in the patch for zeropage swap optimization.     bitmap: add support for virtually contiguous bitmap     The current bitmap_zalloc API limits the allocation to MAX_PAGE_ORDER,     which prevents larger order bitmap allocations. Introduce     bitmap_kvzalloc that will allow larger allocations of bitmap.     kvmalloc_array still attempts to allocate physically contiguous memory,     but upon failure, falls back to non-contiguous (vmalloc) allocation.     Suggested-by: Yosry Ahmed     Signed-off-by: Usama Arif diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h index 8c4768c44a01..881c2ff2e834 100644 --- a/include/linux/bitmap.h +++ b/include/linux/bitmap.h @@ -131,9 +131,11 @@ struct device;   */  unsigned long *bitmap_alloc(unsigned int nbits, gfp_t flags);  unsigned long *bitmap_zalloc(unsigned int nbits, gfp_t flags); +unsigned long *bitmap_kvzalloc(unsigned int nbits, gfp_t flags);  unsigned long *bitmap_alloc_node(unsigned int nbits, gfp_t flags, int node);  unsigned long *bitmap_zalloc_node(unsigned int nbits, gfp_t flags, int node);  void bitmap_free(const unsigned long *bitmap); +void bitmap_kvfree(const unsigned long *bitmap);  DEFINE_FREE(bitmap, unsigned long *, if (_T) bitmap_free(_T)) diff --git a/lib/bitmap.c b/lib/bitmap.c index b97692854966..eabbfb85fb45 100644 --- a/lib/bitmap.c +++ b/lib/bitmap.c @@ -727,6 +727,13 @@ unsigned long *bitmap_zalloc(unsigned int nbits, gfp_t flags)  }  EXPORT_SYMBOL(bitmap_zalloc); +unsigned long *bitmap_kvzalloc(unsigned int nbits, gfp_t flags) +{ +       return kvmalloc_array(BITS_TO_LONGS(nbits), sizeof(unsigned long), +                             flags | __GFP_ZERO); +} +EXPORT_SYMBOL(bitmap_zalloc); +  unsigned long *bitmap_alloc_node(unsigned int nbits, gfp_t flags, int node)  {         return kmalloc_array_node(BITS_TO_LONGS(nbits), sizeof(unsigned long), @@ -746,6 +753,12 @@ void bitmap_free(const unsigned long *bitmap)  }  EXPORT_SYMBOL(bitmap_free); +void bitmap_kvfree(const unsigned long *bitmap) +{ +       kvfree(bitmap); +} +EXPORT_SYMBOL(bitmap_kvfree); +  static void devm_bitmap_free(void *data)  {         unsigned long *bitmap = data; > > The main reason I want to avoid doing the multiplication inline is > because kvmalloc_array() has a check_mul_overflow() check, and I > assume it must have been added for a reason.