From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA895C46CD2 for ; Tue, 30 Jan 2024 08:47:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 591F86B0093; Tue, 30 Jan 2024 03:47:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5414A6B009B; Tue, 30 Jan 2024 03:47:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BBFF6B00A1; Tue, 30 Jan 2024 03:47:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 29ED06B009B for ; Tue, 30 Jan 2024 03:47:04 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id ED44F1C1288 for ; Tue, 30 Jan 2024 08:47:03 +0000 (UTC) X-FDA: 81735347526.02.8081EE0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf26.hostedemail.com (Postfix) with ESMTP id 38DF3140002 for ; Tue, 30 Jan 2024 08:47:02 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706604422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dD9peHogi/iJnm05HnuNn6882VLHmL5cVJQXby5aMJU=; b=4Rus2BLIc7BGcSkGWubba9bnat/1yEOKGAkn0WISjupMDelBVL9E1BuC5MlECXd0q9vWDa esUMPtsdP3HrMVsYuuVpAjOrJ0+7xU9PQ6pB/GuPll3a51ncCS1OUyK2h6RSboF4x9SQNw R37FlM1ShX2lTAkKjNDVaqvAVMCbvsM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706604422; a=rsa-sha256; cv=none; b=YATnwsVgA90F7PNCU+CtkxXlFRIYc/eDREZk9wIRKuek4dfjYcK5wkKLd1/uH7RIA5Yo7u RvrR+Msio7Pvjna9uPLoujx+ex6aFlDFwfzEyTvqOo/ScdvfsEM+QHox3Cf4APvGlulcd1 /su5puwnARIvuc/3MDih5By2v44R5Yw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9C161DA7; Tue, 30 Jan 2024 00:47:42 -0800 (PST) Received: from [10.57.79.54] (unknown [10.57.79.54]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D169F3F738; Tue, 30 Jan 2024 00:46:55 -0800 (PST) Message-ID: Date: Tue, 30 Jan 2024 08:46:55 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/9] mm/memory: factor out zapping of present pte into zap_present_pte() Content-Language: en-GB To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Catalin Marinas , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Michael Ellerman , Christophe Leroy , "Naveen N. Rao" , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Arnd Bergmann , linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org References: <20240129143221.263763-1-david@redhat.com> <20240129143221.263763-2-david@redhat.com> <40e87333-4da9-4497-a117-9885986e376a@arm.com> <8d19d635-2f55-4c0d-958b-0640f99ff0ce@redhat.com> From: Ryan Roberts In-Reply-To: <8d19d635-2f55-4c0d-958b-0640f99ff0ce@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 38DF3140002 X-Rspam-User: X-Stat-Signature: 9dn33a6tbejjxk7nk3ozi584wuskqdum X-Rspamd-Server: rspam03 X-HE-Tag: 1706604422-952553 X-HE-Meta: U2FsdGVkX1/9fQ0TQubeOEmEy+Zp/EU/lc8s7IPq+1XUN/KocYkh5ZvfOb5k6n2+sqU/YVSLTMK4KH1lytQWdgQI8bFF9QMu6we3qNUR7846N/w8dnk5VvikHRk27xQ9o6Bv0TUBeufSy3o5KZoOcIBB/5T4jHyykHjItpoWC9ui2rcF/yGFKq8q6f+01fDJp1XHiXyScIXNe+K/W8/6xN6Gn0P7yNTqox2BgrKapIPPba7nJBS0uYZewg28+GEeGM6S2Jq49RXGAZ8i1dYalSFHyZ0BHWntUrrQPAahqLZ5/GkttDbfnBs5VdvJoaGwVHsdiJlDyxWHELV1Q7RdeehcZltFY3crSv6DkqiynvzVkGiytVKypSPoFcre7ueX3sBNqM6pwPl8h8VqNS/717UODMEKZuJwV/sBXD9qN6qzxlrbLVSEM3h1a9mZjcvDWF0gPwaHQ5UZ8GIuZplO5JDHB+5KEsqISaKlm5+iORBxcyW3AiYI9VZOxE4ZpOPh55AJQ2F5Tvbc/k9QqGb+feS1nIqiRzS6hLsnI6BfvjxOmfcLRIidRw9yoTqdN68ia7wxxX0DhNMoviInEy12Ofl6KmttJ4Uu+pUHVeZyULEQMRvKaHDUerULYhyKinMP24HMjTkfRtEP6lFq3xy/hIC5imeju07Wtx9/EpXSrYdnaBiPOyyrQuYgfaqrT/GquYvrJfCtLczWCfB0uhWJh/IiCCnAXV4nP98fYkpJY12YuLYJWsXSANlDG5YlH9aLqY/Mp+XggJhoB79v1//xx2j4W0IpS3vtyoAZlF/77iD1V2De/rY06XXeY/AO+8xmDpIlkCkNbIf9jdAPHq+6uq+MQ03K6pZXsLHon1A/lKo6ZQ9xeuokahuCqUKO6930n5N4LOrtX7IMIBrDQiG+Ggom6iseuMuebBnr/ioKcizW2WDLoxBBpp1QII3V5NdB6heBvt6LS1XLRHWjpJJ 0DApKcex QWiyd88g8OPhgIKA325L7z55E0m/ORIuypoVWRwfycsmu8CK6BmzPoMlnpUd0T/tq0/a7c88F1CKoIe/yL/yC/mAiGF/+VabyXTLTSH61/RTzbGO/lRuoiiG/grUdDDA9c5dzb2+X/mDKVOLlGuHaKKti6yBoNELv/uM2o8DkZUfcFYzVb5sbxDNUuk7vl7ne7ySW+G+bRDDx4DhJrGswRHDeEg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30/01/2024 08:41, David Hildenbrand wrote: > On 30.01.24 09:13, Ryan Roberts wrote: >> On 29/01/2024 14:32, David Hildenbrand wrote: >>> Let's prepare for further changes by factoring out processing of present >>> PTEs. >>> >>> Signed-off-by: David Hildenbrand >>> --- >>>   mm/memory.c | 92 ++++++++++++++++++++++++++++++----------------------- >>>   1 file changed, 52 insertions(+), 40 deletions(-) >>> >>> diff --git a/mm/memory.c b/mm/memory.c >>> index b05fd28dbce1..50a6c79c78fc 100644 >>> --- a/mm/memory.c >>> +++ b/mm/memory.c >>> @@ -1532,13 +1532,61 @@ zap_install_uffd_wp_if_needed(struct vm_area_struct >>> *vma, >>>       pte_install_uffd_wp_if_needed(vma, addr, pte, pteval); >>>   } >>>   +static inline void zap_present_pte(struct mmu_gather *tlb, >>> +        struct vm_area_struct *vma, pte_t *pte, pte_t ptent, >>> +        unsigned long addr, struct zap_details *details, >>> +        int *rss, bool *force_flush, bool *force_break) >>> +{ >>> +    struct mm_struct *mm = tlb->mm; >>> +    bool delay_rmap = false; >>> +    struct folio *folio; >> >> You need to init this to NULL otherwise its a random value when calling >> should_zap_folio() if vm_normal_page() returns NULL. > > Right, and we can stop setting it to NULL in the original function. Patch #2 > changes these checks, which is why it's only a problem in this patch. Yeah I only noticed that after sending out this reply and moving to the next patch. Still worth fixing this intermediate state I think. > > Will fix, thanks! >