From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DF84C64EC4 for ; Thu, 9 Feb 2023 02:02:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 804DB6B0074; Wed, 8 Feb 2023 21:02:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B47B6B0075; Wed, 8 Feb 2023 21:02:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67C4F6B0078; Wed, 8 Feb 2023 21:02:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 55E4D6B0074 for ; Wed, 8 Feb 2023 21:02:47 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1AC6CAB483 for ; Thu, 9 Feb 2023 02:02:47 +0000 (UTC) X-FDA: 80446104774.07.39B64BB Received: from out-74.mta1.migadu.com (out-74.mta1.migadu.com [95.215.58.74]) by imf21.hostedemail.com (Postfix) with ESMTP id 304EA1C0013 for ; Thu, 9 Feb 2023 02:02:43 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Svg0YGWU; spf=pass (imf21.hostedemail.com: domain of yajun.deng@linux.dev designates 95.215.58.74 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675908164; a=rsa-sha256; cv=none; b=nUPwEyUTPVvnv8/YpspfhmB2mu6m+INqMQ4vxW0J0MsCSXPCaV+wIq0jdjkxQUP/LvViLt Gcqj7zabMnJdGdovDFyaLSjjNRT6a2/QxyBxuZyqoPP8nnrevVYqhKmbCHzQliMapLJXOy mE7TGnHBTRY4fd79kEJ+Bso9WnJSMFg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Svg0YGWU; spf=pass (imf21.hostedemail.com: domain of yajun.deng@linux.dev designates 95.215.58.74 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675908164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iMhZHoaaJdYbb69aTlXe/6pxdfYme2CNDuDKX8yokyM=; b=kFRMobcySuXQlNHTli4SIaNBJQ570GvZb6AL8F70aAm6LOeyO6+8dMrd/5LRieQ7Zkp+MX otXafF4Zl8W3EXyQ60ivwYtFdkNxMh9ymmJkHhLIQbT/VCkg+k9Oh3hSbM8X+KamFsYMse cyMNUWl2ftOuXAVimKHGsDq8GZVGC64= MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1675908161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iMhZHoaaJdYbb69aTlXe/6pxdfYme2CNDuDKX8yokyM=; b=Svg0YGWUzIg4doB+z8KZ08/SERQyshEKpDoKR+FkMd7p+myMMAwTiT096myxZzdKh4GpU6 SF+aERa7tJAv6MfMFtOHVy9Ne/J10qvtTj1PfcqcTVFiq0KQmir4Ppmt+pZVHOMOZC72kf NxecOnC/1tiKF0Rfk5469HyG5UE5OP8= Date: Thu, 09 Feb 2023 02:02:34 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Yajun Deng" Message-ID: Subject: Re: [PATCH] mm/page_alloc: reduce fallbacks to (MIGRATE_PCPTYPES - 1) To: "Vlastimil Babka" , "Andrew Morton" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Zi Yan" , "Mel Gorman" , "David Hildenbrand" , "Mike Rapoport" , "Oscar Salvador" In-Reply-To: References: <20230203100132.1627787-1-yajun.deng@linux.dev> <20230203142324.e5c0652990676ac69a4e5eb1@linux-foundation.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 304EA1C0013 X-Rspamd-Server: rspam01 X-Stat-Signature: ktk44hotuquxfpn57bg1z56qjt81xi9r X-HE-Tag: 1675908163-30064 X-HE-Meta: U2FsdGVkX1/yJUUFIH8WUi4k4DeS7erohNxlr2haXEKvqmVK7CUZxX7wS2pjmIJE/MAto7UpjL6PCtU/T+6sNoJpWCClXTO15xFxSpIAk/AQa+NAYgubSXn2B8GX5TENR3w8aYqPqXlHBJA8QxcNmXI3P1V3rtb8uGnmDd9yEm19BZqeteTpGeLa3AzsxqXdCeqxdFHCh6V7ur7RIzXEeBhznzR3kaTen0JRQuJ0LZxJaPbmAJaWa4zZ64HtPdjHwXDgcfw0BApQg4vnvOBFMYdbcNX0LXHsLdi6BTId80gDsvkOBkH3g81dMRIPyBMzjlAKwXcdSC7jQuLHZuE1e0nniIUGN4uZDXKBOrT5BekpoEGDIOkE/AmvNcpdNbxU+REoy5MA1P6XPgLm6bLqharCSYH+JaGSwoWQXnoPfvATaiviJM5x5O4KRiNgbsQ4dGr9xi/cjDRNdma2IrHEBMEqn/Ws+4WFhqtxpGYD7jb4RcAkeJwwtTxEHT6MT5wH+KbgdHqFuo5n4lw6i2d3H0aCAJRRPfkhKSAPFGsQuZXexKDQJwsXJ5uAaqj2jAcYPzYZEGfyqcC+LXcnJwxZKGi1azLMf5Ex54LSJM0UU4z4a2n4wEL/6bqZnKider6jqSnLO9gH7F3Jdj0GDRUj95xfGKYj2sQ9aG4iBOEMSZaK2+Us5Hq1PgZgl3Aa1zrgBm3SyWBiNcrY09WKaZRGoAm/yVE5MWLf6ax8uz+Gdi2qH7iHCdyPmO59RDYIFdIIfQ190XjhoG6oSCo74/Zsx5eY9zFJ5zIGbU5iGOVcqgACQ1O32/OXxOB7IACEdLiErNOy++KM3bAMXKr95tOC+HeursYaAoQuZev9sE0j2W7xmXFdEo2+JOPjGBiTHFQ0v4M7vvN8uNAlB/62TYsRk/rBy4rlmdBmXKIho/DP5XCoB0eUUCvdohxkWtPtxyD1ND+D7hxNazU/jxHMqfl qPi0ogOe zQv91QsmGE9vA5Ex03ulpcBl4AUzRMsOKxjREvw4b/ykLVmcYSdnmdZhBmXLyYFi1KB89WHT/mXlqk37dU3hDGEFrzO0Jm8EIkrdkF0wl/EWDF3Dt+5Y3U5BFxhJIhlQ7seOZVg3wkEJGxKE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: February 9, 2023 12:07 AM, "Vlastimil Babka" wrote:=0A= =0A> On 2/3/23 23:23, Andrew Morton wrote:=0A> =0A>> On Fri, 3 Feb 2023 1= 8:01:32 +0800 Yajun Deng wrote:=0A>> =0A>>> The co= mmit 1dd214b8f21c ("mm: page_alloc: avoid merging non-fallbackable=0A>>> = pageblocks with others") has removed MIGRATE_CMA and MIGRATE_ISOLATE from= =0A>>> fallbacks list. so there is no need to add an element at the end o= f every=0A>>> type.=0A>>> =0A>>> Reduce fallbacks to (MIGRATE_PCPTYPES - = 1).=0A> =0A> Acked-by: Vlastimil Babka =0A> =0A>> Thanks.= `git log' suggests who should be cc'ed when fixing things...=0A>> =0A>>>= --- a/mm/page_alloc.c=0A>>> +++ b/mm/page_alloc.c=0A>>> @@ -2603,10 +260= 3,10 @@ struct page *__rmqueue_smallest(struct zone *zone, unsigned int o= rder,=0A>>> *=0A>>> * The other migratetypes do not have fallbacks.=0A>>>= */=0A>>> -static int fallbacks[MIGRATE_TYPES][3] =3D {=0A>>> - [MIGRATE_= UNMOVABLE] =3D { MIGRATE_RECLAIMABLE, MIGRATE_MOVABLE, MIGRATE_TYPES },= =0A>>> - [MIGRATE_MOVABLE] =3D { MIGRATE_RECLAIMABLE, MIGRATE_UNMOVABLE, = MIGRATE_TYPES },=0A>>> - [MIGRATE_RECLAIMABLE] =3D { MIGRATE_UNMOVABLE, M= IGRATE_MOVABLE, MIGRATE_TYPES },=0A>>> +static int fallbacks[MIGRATE_TYPE= S][MIGRATE_PCPTYPES - 1] =3D {=0A> =0A> Why not also reduce the first ind= ex size from [MIGRATE_TYPES] to=0A> [MIGRATE_PCPTYPES] ?=0A> =0A=0AI over= looked this. I'll do it in the next patch.=0A=0A>>> + [MIGRATE_UNMOVABLE]= =3D { MIGRATE_RECLAIMABLE, MIGRATE_MOVABLE },=0A>>> + [MIGRATE_MOVABLE] = =3D { MIGRATE_RECLAIMABLE, MIGRATE_UNMOVABLE },=0A>>> + [MIGRATE_RECLAIMA= BLE] =3D { MIGRATE_UNMOVABLE, MIGRATE_MOVABLE },=0A>>> };=0A>>> =0A>>> #i= fdef CONFIG_CMA=0A>>> @@ -2865,11 +2865,8 @@ int find_suitable_fallback(s= truct free_area *area, unsigned int order,=0A>>> return -1;=0A>>> =0A>>> = *can_steal =3D false;=0A>>> - for (i =3D 0;; i++) {=0A>>> + for (i =3D 0;= i < MIGRATE_PCPTYPES - 1 ; i++) {=0A>>> fallback_mt =3D fallbacks[migrat= etype][i];=0A>>> - if (fallback_mt =3D=3D MIGRATE_TYPES)=0A>>> - break;= =0A>>> -=0A>>> if (free_area_empty(area, fallback_mt))=0A>>> continue;=0A= >>> =0A>>> --=0A>>> 2.25.1