From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55896C433DB for ; Wed, 24 Feb 2021 21:05:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C2E2664E20 for ; Wed, 24 Feb 2021 21:05:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2E2664E20 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0BD526B0005; Wed, 24 Feb 2021 16:05:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 06FCA6B0006; Wed, 24 Feb 2021 16:05:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC6126B006C; Wed, 24 Feb 2021 16:05:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id D75706B0005 for ; Wed, 24 Feb 2021 16:05:46 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9D6334DD0 for ; Wed, 24 Feb 2021 21:05:46 +0000 (UTC) X-FDA: 77854393092.24.3357847 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by imf18.hostedemail.com (Postfix) with ESMTP id 766AF2000398 for ; Wed, 24 Feb 2021 21:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:References:Cc:To:From:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=aZXalGwZSAKQIwSjOWmxTwvg1m6thX64kxngN7tNTGw=; b=pldvQ1e4/MOEsmWPNbX7EZZTOq tXTj65wA7uu3m9JZAL54lb6TEnSIyqXg9NcvG1cuy4NFCfxXyK54NUsSt+PmGzDDRthoiJs6XKHOP zHKMXjnA6wp2ltDmGeNp8vezIfh0iwgw5IJ7VjWdnNYFDWowPV47Ztfee2wQW9yV4JQwSxOv0abe8 UlTv0p5ux2R13Y6jrBX+mx6ymCefnDG428DVnwNsbnnhk5H1dUMpE4yK8la8ZhbbSqCd1CSpaN9d8 ee6wWRhsnQhlm41tnew1ifw4ynSfmuTBQvG9D/OdiQ3GT7q0O8dKI0TP7rG4vu2K20IOg8RoupUR6 cL8Bwpag==; Received: from [2601:1c0:6280:3f0::d05b] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1lF1Lt-0008Ts-Az; Wed, 24 Feb 2021 21:05:45 +0000 Subject: Re: [linux-next:master 11942/12503] drivers/video/fbdev/aty/atyfb_base.c:180:6: warning: no previous prototype for function 'aty_st_lcd' From: Randy Dunlap To: Nick Desaulniers Cc: kernel test robot , kbuild-all@lists.01.org, clang-built-linux , Linux Memory Management List , Daniel Vetter References: <202102242016.MJskK6hp-lkp@intel.com> <97716bb9-6aca-d7e6-e390-1b9d3a0b99a8@infradead.org> <3628bb0f-0790-2a18-93e5-be244d32be53@infradead.org> Message-ID: Date: Wed, 24 Feb 2021 13:05:41 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <3628bb0f-0790-2a18-93e5-be244d32be53@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 766AF2000398 X-Stat-Signature: ro6neywdf4oiqxbettebrjjkxeqwzmq6 Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=merlin.infradead.org; client-ip=205.233.59.134 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614200747-894868 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/24/21 1:02 PM, Randy Dunlap wrote: > On 2/24/21 12:42 PM, Nick Desaulniers wrote: >> On Wed, Feb 24, 2021 at 12:03 PM Randy Dunlap wrote: >>> >>> On 2/24/21 4:46 AM, kernel test robot wrote: >>>> Hi Randy, >>>> >>>> FYI, the error/warning still remains. >>>> >>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >>>> head: 577c283560fe8a81a23a95654c6d13e8412d22f1 >>>> commit: bfa5782b9caa26f93f42ad79804e1f75a1ce9f18 [11942/12503] fbdev: atyfb: add stubs for aty_{ld,st}_lcd() >>>> config: arm64-randconfig-r004-20210223 (attached as .config) >>>> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project f14a14dd2564703db02f80c00db8ae492b594f77) >>>> reproduce (this is a W=1 build): >>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>>> chmod +x ~/bin/make.cross >>>> # install arm64 cross compiling tool for clang build >>>> # apt-get install binutils-aarch64-linux-gnu >>>> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=bfa5782b9caa26f93f42ad79804e1f75a1ce9f18 >>>> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >>>> git fetch --no-tags linux-next master >>>> git checkout bfa5782b9caa26f93f42ad79804e1f75a1ce9f18 >>>> # save the attached .config to linux build tree >>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 >>>> >>>> If you fix the issue, kindly add following tag as appropriate >>>> Reported-by: kernel test robot >>>> >>>> All warnings (new ones prefixed by >>): >>>> >>>>>> drivers/video/fbdev/aty/atyfb_base.c:180:6: warning: no previous prototype for function 'aty_st_lcd' [-Wmissing-prototypes] >>>> void aty_st_lcd(int index, u32 val, const struct atyfb_par *par) >>>> ^ >>>> drivers/video/fbdev/aty/atyfb_base.c:180:1: note: declare 'static' if the function is not intended to be used outside of this translation unit >>>> void aty_st_lcd(int index, u32 val, const struct atyfb_par *par) >>>> ^ >>>> static >>>>>> drivers/video/fbdev/aty/atyfb_base.c:183:5: warning: no previous prototype for function 'aty_ld_lcd' [-Wmissing-prototypes] >>>> u32 aty_ld_lcd(int index, const struct atyfb_par *par) >>>> ^ >>>> drivers/video/fbdev/aty/atyfb_base.c:183:1: note: declare 'static' if the function is not intended to be used outside of this translation unit >>>> u32 aty_ld_lcd(int index, const struct atyfb_par *par) >>>> ^ >>>> static >>>> 2 warnings generated. >>>> >>> >>> These 2 functions are also used/usable (depending on CONFIG options) in >>> mach64_ct.c so they can't be static. >>> >>> AFAIK, we don't make functions have different qualifiers depending on >>> config options. >> >> Is there a shared header included by both mach64_ct.c and atyfb_base.c >> you could provide a declaration in, that way should the definition >> change we'd catch such a change in order to not break the callers? >> > > atyfb.h: > > #if defined(CONFIG_PMAC_BACKLIGHT) || defined (CONFIG_FB_ATY_GENERIC_LCD) || \ > defined (CONFIG_FB_ATY_BACKLIGHT) > extern void aty_st_lcd(int index, u32 val, const struct atyfb_par *par); > extern u32 aty_ld_lcd(int index, const struct atyfb_par *par); > #endif > > so it's already there unless the .config did not include those #ifdef CONFIG_s. > I'll recheck that. OK, none of those 3 kconfig symbols is set. I'll check again where the usage is. -- ~Randy