From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DBBDC3ABB2 for ; Wed, 28 May 2025 09:03:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0E056B0096; Wed, 28 May 2025 05:03:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBDE46B0098; Wed, 28 May 2025 05:03:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A87476B0099; Wed, 28 May 2025 05:03:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 896CB6B0096 for ; Wed, 28 May 2025 05:03:47 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 46EEBC06C8 for ; Wed, 28 May 2025 09:03:47 +0000 (UTC) X-FDA: 83491728894.04.927662D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id F41AD18000B for ; Wed, 28 May 2025 09:03:44 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Fo7bfkzP; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748423025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9uc45Svc1W6nrhUpVJMAGcmamvYOihc8Tgxl1943pLA=; b=hC8uiKb2j2/cqQZK/PQrZJGGaKjP+xmBwcmhsj7tmiIj3yOHIlX+h8wSISt7vgiVJMpBti tnU38SVM4KY7hBiLhRYZZkGRtR5IGGPXPquw+e61GbaMb61NjE+6iQfJdnHypg7L7me0Ze XJ4GPQ63A5Zo11kq69tb3u/Ph+033ds= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748423025; a=rsa-sha256; cv=none; b=ycLZg7gIWjKwHL3rcY+iuBLHWQFc4WGeEBa+C7XHrzBCFFOEpMYuXsmjSc1Fvr8APY04n5 lgTkGibRW/7i6cE9SvKIPrq0rr8zC5Z1IvLKnW8vBksImAp9AIyw+iFuGGiuZahDbBrlQu O3bMsplye6KWv4vL9Gq+I5ljUAUzcF0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Fo7bfkzP; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748423023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9uc45Svc1W6nrhUpVJMAGcmamvYOihc8Tgxl1943pLA=; b=Fo7bfkzPHDy+69NYqVAsgQmCtemqkfgX57INUf+ltDKfOhJHOk1Vq20nyKrebK2I2Uj7fE MkZC/CqnNH/GuS/we0lKZrutfaSwgjXQ3R/SR6Z0DEd1vyK/vO+bLoDKmaQ7Czad+3eOh3 R1jiBuTug6Oc1gdjQ6mJIszvD+9m0So= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-322-mNvR_VWHMca54R8-fY_M2w-1; Wed, 28 May 2025 05:03:42 -0400 X-MC-Unique: mNvR_VWHMca54R8-fY_M2w-1 X-Mimecast-MFC-AGG-ID: mNvR_VWHMca54R8-fY_M2w_1748423021 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a35ec8845cso1965383f8f.2 for ; Wed, 28 May 2025 02:03:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748423020; x=1749027820; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9uc45Svc1W6nrhUpVJMAGcmamvYOihc8Tgxl1943pLA=; b=I1+hQR+XhNmOujKjn5120JKyTmMsne8V6YDLVISU/Zzieu9hZ9cCkpLsRapvA59m6O n33tXTigt3VYGJwHac3a8FJURErQcYtd3hNZ2x9Q3pqYGGmmOmYJ2yhwikVgfjkh8wV5 rBLZbYHH+pLfYkRGVJNempEkIoKqMLp8j6hpBsPCi65Kj2lrjmGfAwTZQYfg9jHXdwiV rsmKaMK9D2Rqv7iE1bSDkGDNSmt/jNwfXWpH3BWmgmWoGlaHztQ4h9hjTlDlF1DaRnDz Q+L6MVcVttmH0HM6rZZRY6KcHiavSfsajrM4xRvaUR/XsjGUuu2adoZ3HTu4TWLwt2GO w46w== X-Forwarded-Encrypted: i=1; AJvYcCVA36ZdKJ9JYfu1jOws/MpPtuIGlbs0xoF7yl7whHUUqSZi8vl4FmR69BsYF7jZzIENmESzmMFulg==@kvack.org X-Gm-Message-State: AOJu0YxyqZbMmQze66riMAgeSEDiUOJ5Stc7APW+sbc+ylPfCZVfssLS Li9/pLkfI8R1WYHcq71OBtho/a7Dg1xUWtvUX0rD+/de9ArIpNQEaNszNVVQZieUMvWx76vMUwF nTKdAuNDrOipYTgchFDxJiV58oBH8prP1yBH47Wsh3M2Tgc8ErUWQ X-Gm-Gg: ASbGncsSm7+8rg5YbfeV2uOV3g7TPgAJEazQf467G1mYw06Dp8R5nyHKqFGBBSJcHCl Vcewcyoxf9AmER5MB/ljzlbZeeji+tZ8MsUmx5CG2RKfjRVp8JJRpFuIuqOrSv7CHZATQahRTfG 788QCqCRgcuRD3nzyh8waZytaWFrlB3eU5dY8a0Qna86mTeA7A9pPtmzFEscrjT9JMJxJeUiuir t7Gm6DWP6Qzzu7rvp2sRv+6nOdJBcr2ii94xpjJ12BA7f+wGCQpPXqyLIalEJ/p8TSdXNhIRG9b V0nrbFpvNhM52guUSBf1EwekbhRNPN6GByGJbfILgGfZEzf+pgfRGFH4MPn56+/BkTF4Gfhrp6a QQgCl/O8Yvt8oY/fjLelGZzIE58eSJfKr/dLoXr8= X-Received: by 2002:a05:6000:4312:b0:3a4:dc0a:5c0a with SMTP id ffacd0b85a97d-3a4e957be2dmr1397995f8f.44.1748423020497; Wed, 28 May 2025 02:03:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH/FFPCB6RPiUlD6SK7Uvhb6FaRvTdWdlGF2T5R9hZ0YO2drr0+Pok+YZzB60DfLfzkVn3Uqg== X-Received: by 2002:a05:6000:4312:b0:3a4:dc0a:5c0a with SMTP id ffacd0b85a97d-3a4e957be2dmr1397947f8f.44.1748423020066; Wed, 28 May 2025 02:03:40 -0700 (PDT) Received: from ?IPV6:2003:d8:2f30:ec00:8f7e:58a4:ebf0:6a36? (p200300d82f30ec008f7e58a4ebf06a36.dip0.t-ipconnect.de. [2003:d8:2f30:ec00:8f7e:58a4:ebf0:6a36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4eacd8edfsm886493f8f.79.2025.05.28.02.03.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 May 2025 02:03:39 -0700 (PDT) Message-ID: Date: Wed, 28 May 2025 11:03:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm/mmap: Fix uprobe anon page be overwritten when expanding vma during mremap To: Pu Lehui , Oleg Nesterov Cc: lorenzo.stoakes@oracle.com, mhiramat@kernel.org, peterz@infradead.org, Liam.Howlett@oracle.com, akpm@linux-foundation.org, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com References: <20250521092503.3116340-1-pulehui@huaweicloud.com> <62b5ccf5-f1cd-43c2-b0bc-f542f40c5bdf@redhat.com> <13c5fe73-9e11-4465-b401-fc96a22dc5d1@redhat.com> <4cbc1e43-ea46-44de-9e2b-1c62dcd2b6d5@huaweicloud.com> <20250526154850.GA4156@redhat.com> <06bd94c0-fefe-4bdc-8483-2d9b6703c3d6@redhat.com> <57533126-eb30-4b56-bc4d-2f27514ae5ad@huaweicloud.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <57533126-eb30-4b56-bc4d-2f27514ae5ad@huaweicloud.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pgugKf-1-ehPWGhsJKc8_3IFQhyRHdwspV2Jty3H-4A_1748423021 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F41AD18000B X-Stat-Signature: qxe4akstxwedyjj9petks4w76taegfm9 X-Rspam-User: X-HE-Tag: 1748423024-740675 X-HE-Meta: U2FsdGVkX1/xN/FHP7+Ay1PYcVt7wWHu3b/s2+cr+mCwyUZK4p428M6EW5ie7ZdJvP6mJi/iK8lldlZ5Rf6bGkxCp/cBmHZQ+pk3ewIVmpENQIHhFKeG4IdowR3EfbDWD+6l5zdBsFg+mp7K5+Gg4nmjOX+5A0uNZpQKfKvhj9vEQwVxZUb5Jm2hHd6zi2fecDa1lY5U5HTJronLe2aZ6CnVPTLWU/SIwXG3eknLxBeuZWDicmHCrCGlWkbPySbrJe/v2nnZCEm9yFkt/5PrmRWzPN/mE62rsS6i+zlLlocXQSkd8/0V1P1EcpqAskXQB7n1kvmU4BpSXGMVa/g+aBLPGI6Z+N1op2XugyV1h8G9BiQ+YoEPt96ql2vwzAc1NQ6vcywsrbnarb1bxKMd4oCddCMHlwcT/yj4DeId3H3yF2RAtN9Z8nqS3jjxBBkHgsmPppvdSeKO5WiuPrnrI+7GBT/djEjwwjsyj4YsG7rm7s+42hzb70DkmVmpiGachmAtM5gqA4P9YOT6m60fKsv5tigVNJlZwts2z1UQIOz2zBrK07ivhKLZqKJNLUC0zUONIgqqygmAQOgGcNICcEwaFImp7KO5csQaIgdttdSJPzZKMlVeqZzXEeXCCSpZb1Cdmo/w5B3BEEtRhExjy7iZw8BUnG2/OgZoY1NU/hgLso2dt0Qxz+Bys0lopHQsvF8GTrjDwro/eXKXCBAcaL6P5iUIVzEmcbUChSTaRaGtLQef75iJf1z+W4b7nP0GAzJcLH80LK62mYum9RbTMiInlxwFG+zH25mykQtiTw0IUF89AyCPwu0zsVghnxl6iwH7qUwZCqYBJXHcZBQ+Q6zOU2EBVoR1H5jQaBpUhF/yxqZb3k2eiex0ne7zQbL77HCy7IgUiro82EJeAmxEEpAz4wm8gIyYpcj9LLMRx1l9b94ZgKzbmaNRWfzQuIhMsjJUpawwmxZFcWydXYm q+qVc388 GydGd95zeG2mSvULaTbryBRZ6qnLUqXSLN2jih7j7gEOfn3Cto6MvHJHe5Pcs7K1WKYXqQpooSuExBYM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.05.25 15:38, Pu Lehui wrote: > Hi David, > > On 2025/5/27 2:46, David Hildenbrand wrote: >> On 26.05.25 17:48, Oleg Nesterov wrote: >>> Hi Lehui, >>> >>> As I said, I don't understand mm/, so can't comment, but... >>> >>> On 05/26, Pu Lehui wrote: >>>> >>>> To make things simpler, perhaps we could try post-processing, that is: >>>> >>>> diff --git a/mm/mremap.c b/mm/mremap.c >>>> index 83e359754961..46a757fd26dc 100644 >>>> --- a/mm/mremap.c >>>> +++ b/mm/mremap.c >>>> @@ -240,6 +240,11 @@ static int move_ptes(struct pagetable_move_control >>>> *pmc, >>>>                  if (pte_none(ptep_get(old_pte))) >>>>                          continue; >>>> >>>> +               /* skip move pte when expanded range has uprobe */ >>>> +               if (unlikely(pte_present(*new_pte) && >>>> +                            vma_has_uprobes(pmc->new, new_addr, >>>> new_addr + >>>> PAGE_SIZE))) >>>> +                       continue; >>>> + >>> >>> I was thinking about >>> >>>     WARN_ON(!pte_none(*new_pte)) >>> >>> at the start of the main loop. >>> >>> Obviously not to fix the problem, but rather to make it more explicit. >> >> Yeah, WARN_ON_ONCE(). >> >> We really should fix the code to not install uprobes into the area we >> are moving. > Alright, so let's try this direction. > >> >> Likely, the correct fix will be to pass the range as well to >> uprobe_mmap(), and passing that range to build_probe_list(). > > It will be great. But IIUC, the range we expand to is already included > when entering uprobe_mmap and also build_probe_list. Right, you'd have to communicate that information through all layers (expanded range). As an alternative, maybe we can really call handle_vma_uprobe() after moving the pages. uprobe_write_opcode() should detect that the uprobe is already installed (verify_opcode() will return 0) and just return. -- Cheers, David / dhildenb