From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 802A3C001E0 for ; Wed, 2 Aug 2023 15:30:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 070CE2801B8; Wed, 2 Aug 2023 11:30:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0212B2801AA; Wed, 2 Aug 2023 11:30:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E04332801B8; Wed, 2 Aug 2023 11:30:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D35BF2801AA for ; Wed, 2 Aug 2023 11:30:11 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 669FCA0F1C for ; Wed, 2 Aug 2023 15:30:11 +0000 (UTC) X-FDA: 81079550622.16.61AD451 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 8F1DD18001C for ; Wed, 2 Aug 2023 15:30:06 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cYtnm9y0; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690990207; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zpl8aOOTIJ9mlaQuYNUfJFxKv/U9O46R/LTmVpfLtOc=; b=f9jdISDV67NkyaGhtAVnX7dN5Iuaan4AcO9mZW8WG+IF7cciV6Zv+o6d1/FR7guYJogzbV BKcnqViwjjcMQyld4pI3H5beNH8+uaZyp77dOOVUCAqw9VRTgsj6Hk20ZHPS7WgSZ+ClsV 0xDS/KmLRW4DYHBVBeWGPB4pCIPJGRY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690990207; a=rsa-sha256; cv=none; b=WnIKY7MyAotsrsArr7JQtizDABIUaHXhZS9o5WI6q/8tT6bfKJZ6c/ZF/MKtvwcStYNftW 2xmOe86slBJtsDJ9TOx2ljpBPRkQcSAo7JcPR+bogbVQ2VEDotESTBivxUe9vTpgOpM2z0 pT6XpnIBXJ6fWbknBzxqvr1RkX5pr6w= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cYtnm9y0; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690990203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zpl8aOOTIJ9mlaQuYNUfJFxKv/U9O46R/LTmVpfLtOc=; b=cYtnm9y0lIhD8zIONYVnKMANRqrKGhePhAABJKBAgNl5gc6T/orfcQGpo7yWy74w9RhrKI owK0BFI/uVXHgN0HWoDP7s0uDYkVKMFDwKXRyYyryW5/6UIlmEufqMQ9e1snxes2UCN6VR vNUzUcyjHO/aCeCb48447BgYDMGZz1M= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-xGa0uDmIM5SCukF_SAqF3w-1; Wed, 02 Aug 2023 11:30:00 -0400 X-MC-Unique: xGa0uDmIM5SCukF_SAqF3w-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3175b757bbfso4237822f8f.2 for ; Wed, 02 Aug 2023 08:29:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690990199; x=1691594999; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Zpl8aOOTIJ9mlaQuYNUfJFxKv/U9O46R/LTmVpfLtOc=; b=j/F0R/ZJ/pM+GMNMIqPa+2gZFVz9myhBtH/7+NmR7iJTYtStnWBn1qFjx4Vbcna9RZ 3N8q/DbZBb8DWpwDGIu7ssY/++/wkaIfZRKTiwI8n/MP/f7Zbp9i++dnwHV8EJRpsSQH 8mvNWoIeJ3kYAbYZUmgaj6MAmLujodeUClJG86KJ13gcfWdtBNuwRBOAGFnuHLf3oFbh SgwwkQ/gDjV0EvPbo/uM4vTdD+MOZfPtjfrmyxG5AvLwOTyUHMUA25J4UG9hShl1ORLP mCE3oUkx4xZz+V9HM+u34RjHq4jqvWKtiZnIiykqL8dD33Djv0LGT+yRDrHIqtEZ+fhl zJRw== X-Gm-Message-State: ABy/qLYGzpLNlc1DAz2WWq0cgyIUJV3UJIfLrBPB7/xBFwER5Pu4h+Rs yXNIwILVLAgx7tA/HosESRXpbrSmnL2Pk3EJt+7uryjUwIK/DAwWW1ZwgjT87l1+iw4Z/dFuY1F g8VGEx9oNSDA= X-Received: by 2002:adf:e68b:0:b0:314:824:3788 with SMTP id r11-20020adfe68b000000b0031408243788mr5186035wrm.27.1690990198976; Wed, 02 Aug 2023 08:29:58 -0700 (PDT) X-Google-Smtp-Source: APBJJlGPZ/gSkVfcDR0DyBgF0AO8vuUoscywmniaGjeRDFdrJLQLEfW8GrNw+nUwMNbFo2XQBknSkA== X-Received: by 2002:adf:e68b:0:b0:314:824:3788 with SMTP id r11-20020adfe68b000000b0031408243788mr5186009wrm.27.1690990198551; Wed, 02 Aug 2023 08:29:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:e00:b8a4:8613:1529:1caf? (p200300cbc70b0e00b8a4861315291caf.dip0.t-ipconnect.de. [2003:cb:c70b:e00:b8a4:8613:1529:1caf]) by smtp.gmail.com with ESMTPSA id o20-20020a5d58d4000000b0031762e89f94sm19173032wrf.117.2023.08.02.08.29.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Aug 2023 08:29:58 -0700 (PDT) Message-ID: Date: Wed, 2 Aug 2023 17:29:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 3/8] kvm: explicitly set FOLL_HONOR_NUMA_FAULT in hva_to_pfn_slow() To: Mel Gorman Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Linus Torvalds , liubo , Peter Xu , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard , Mel Gorman , Shuah Khan , Paolo Bonzini References: <20230801124844.278698-1-david@redhat.com> <20230801124844.278698-4-david@redhat.com> <20230802152702.wamtroy3zm7nbtvs@techsingularity.net> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230802152702.wamtroy3zm7nbtvs@techsingularity.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: oqx3sz9imzmndu7azcqghfc3b3ez1f7z X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8F1DD18001C X-Rspam-User: X-HE-Tag: 1690990206-503721 X-HE-Meta: U2FsdGVkX1+3lbZ3XoPKnAsW4fzz3gkJdocb0czZsDOmaB8i7QI6cCRRX0jfvWy4Hg1fW3fDckiMADPCm+9XKJCbNATtpsYlqxacGg5N+8rrpYn1DTC+uSPc40rvAzeo9460H+QOi+18QMt45+vmyd3MbV12E+wTwlN8rob5sXXQQSkqDMLsArf31fraauDw4SEIzmwaKCHXEA4cgeFQDNXXUOt+UC3fspwnUs/d+8z6qnV3F+tB8bISFMl1COqqbV1Z/xC5HZeEl5Mis8TiEeH/wKvtfMmkiLoe3e0Ek3VUT+EDi8y1s5esTPtWtfke68kHqejrwPgd6Y8nR1XUkjw7yRP6h9esJq4mgqBbtmU/atgKtjn+sokOSYAwbpYz8qCrLQqyNZ7Uv5NH5ZwW4A4iEl/NrwScRLuiEXmEsXnFc+taN3n+jLZCUNaZDqKswsBqtQEgIIH0Hmto8LrBCA5iR3zx8iuOCzEDpDQzrEVOyfJxtugB7k5tbD89LcUD9PQ43d7i9DetA4oxHPQR8SW/OdNvjapIRdJUI/twBz2/qcCeTcD3qbV6C6iXEZB5aJPlIPJF/plOL+ONzJO0HwDkW0e6TsBQdJKFRZw1PIBdPPSTTULSLqiIQXna8bbPKn+qDzjXiSxFzm2Q2LrOMMX7i8WsdD7+uPh18eIy0hW/42dQmBgK4qFC4xLkHsPxaXyQBWbd9XvPOMBQLLqckbaUtwMbFm56GC8Pvrx5G/GLnkG7Pa4LPYPTPf0uIQuFQN+VOOfWVYcPZxj7xVMGcWyG8A2+6DizkghxRM0AfPdS5+6NnxJ0Y4FEBrTo1WcJTPefDLyky/FhJOgjaiHY2ZkGsWzlbSvroWfP5aacJOb42KsW33BppXSkrt33+26x4SXtvfgRvUO1cN2WE1XqX4NGfJo+sWP2OemH6uk/8HKu7f1/wQZuhbNdeDxqyAiACosGQHRvLWGzl5mYXOL 7ZzvuAcj fiWzaY9UzibRhxtBEEDBwA3LQDHqJmfhuhVzqarwSBsGHYdyj6Rdg0paFXNFfp7WaKKGEJETQmyv3FGPNjorqUqCKAMjhnBN4QroevnlUF1v2auJZO3QMgihZIiGfBhc4T6XiGAdBxAtTh6dyY9ExS9F4cteHMZ8W1Sp/C6G+qCfwbBRJ5ibcM/OnrQ9/3K7lciCdDGYK06YfKkElFHXimsXJEayjEEYUtDBeoqoHge7ADOmqJ93hUlW9KfMUR/bjBlu963oc5zUtBYaIQWdcp0AvsUOHyQ8kkdJDTmU7h99GOUS5cY94iUJlo7BRVEEqsAKIqD14SlOAaONAZdkcP1nVFSgFbXXC0yCXGrSabJjoi0y7dnkoMtiQ5JygvFonrEl5/Prm4rQ8binB+EK1l9c7vEi/V+RSxJqYnHDaJDHTOnbVeFm8XROxFRuOAONr9YxO1evteDF5nUs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.08.23 17:27, Mel Gorman wrote: > On Tue, Aug 01, 2023 at 02:48:39PM +0200, David Hildenbrand wrote: >> KVM is *the* case we know that really wants to honor NUMA hinting falls. >> As we want to stop setting FOLL_HONOR_NUMA_FAULT implicitly, set >> FOLL_HONOR_NUMA_FAULT whenever we might obtain pages on behalf of a VCPU >> to map them into a secondary MMU, and add a comment why. >> >> Do that unconditionally in hva_to_pfn_slow() when calling >> get_user_pages_unlocked(). >> >> kvmppc_book3s_instantiate_page(), hva_to_pfn_fast() and >> gfn_to_page_many_atomic() are similarly used to map pages into a >> secondary MMU. However, FOLL_WRITE and get_user_page_fast_only() always >> implicitly honor NUMA hinting faults -- as documented for >> FOLL_HONOR_NUMA_FAULT -- so we can limit this change to a single location >> for now. >> >> Don't set it in check_user_page_hwpoison(), where we really only want to >> check if the mapped page is HW-poisoned. >> >> We won't set it for other KVM users of get_user_pages()/pin_user_pages() >> * arch/powerpc/kvm/book3s_64_mmu_hv.c: not used to map pages into a >> secondary MMU. >> * arch/powerpc/kvm/e500_mmu.c: only used on shared TLB pages with userspace >> * arch/s390/kvm/*: s390x only supports a single NUMA node either way >> * arch/x86/kvm/svm/sev.c: not used to map pages into a secondary MMU. >> >> This is a preparation for making FOLL_HONOR_NUMA_FAULT no longer >> implicitly be set by get_user_pages() and friends. >> >> Signed-off-by: David Hildenbrand > > Seems sane but I don't know KVM well enough to know if this is the only > relevant case so didn't ack. Makes sense, some careful eyes from KVM people would be appreciated. At least from kvm_main.c POV, I'm pretty confident that that's it. -- Cheers, David / dhildenb