Re: [PATCH] mm/hotplug: Reorder memblock_[free|remove]() calls in try_remove_memory()

David Hildenbrand
2019-09-23T10:54:37Z

On 23.09.19 12:52, Michal Hocko wrote:
> On Mon 16-09-19 11:17:37, Anshuman Khandual wrote:
>> In add_memory_resource() the memory range to be hot added first gets into
>> the memblock via memblock_add() before arch_add_memory() is called on it.
>> Reverse sequence should be followed during memory hot removal which already
>> is being followed in add_memory_resource() error path. This now ensures
>> required re-order between memblock_[free|remove]() and arch_remove_memory()
>> during memory hot-remove.
>
> This changelog is not really easy to follow. First of all please make
> sure to explain whether there is any actual problem to solve or this is
> an aesthetic matter. Please think of people reading this changelog in
> few years and scratching their heads what you were thinking back then...
>

I think it would make sense to just draft the current call sequence in
the add and the removal path (instead of describing it) - then it
becomes obvious why this is a cosmetic change.

--

Thanks,

David / dhildenb