From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D95EBC001DE for ; Wed, 26 Jul 2023 08:19:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D4CE6B0074; Wed, 26 Jul 2023 04:19:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 585598D0001; Wed, 26 Jul 2023 04:19:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4742B6B0078; Wed, 26 Jul 2023 04:19:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 38BD16B0074 for ; Wed, 26 Jul 2023 04:19:15 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 07CB91C8898 for ; Wed, 26 Jul 2023 08:19:15 +0000 (UTC) X-FDA: 81053063070.16.E4EAFC0 Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) by imf15.hostedemail.com (Postfix) with ESMTP id 00D09A0015 for ; Wed, 26 Jul 2023 08:19:12 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of f.ebner@proxmox.com designates 94.136.29.106 as permitted sender) smtp.mailfrom=f.ebner@proxmox.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690359553; a=rsa-sha256; cv=none; b=dlyLzIfpMfH3Rabr2zk9CxBmR84ghvF2a+dtEqZaqTX3f7XIYYvnEYNgKvMPdKPit44ZAy EEgptTRnBGtviIufYsKkFbkQmrevR9Q3m9lUK0OYkh/7lU1nnAbWQrDTpz8BOWC94Jucnx jlkaON2iK23QmSegZpU1aELYvylaAmo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of f.ebner@proxmox.com designates 94.136.29.106 as permitted sender) smtp.mailfrom=f.ebner@proxmox.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690359553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qUrUjcOqAKjIZ9uY4AqDkUnWcHrJmQiG40boXzTKFBg=; b=SuhajFkDwVY8niS/MYk9j49HWnHh4baxq/iuxluiK7HmSKtFCmXMYZYpbAJQandsr1gO/T NBdBRizyUtDTyHEbran0BlEqUI1RJQJcvVD3ITtnHzUZC2RkdVXv0nUALmcq9w9bCxy4Pf THZGrVyNev5gKjpEocorOC77Qdfgp80= Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9BE1B45369; Wed, 26 Jul 2023 10:19:09 +0200 (CEST) Message-ID: Date: Wed, 26 Jul 2023 10:19:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: segfaults of processes while being killed after commit "mm: make the page fault mmap locking killable" Content-Language: en-US To: Linus Torvalds , "Eric W. Biederman" , Oleg Nesterov Cc: akpm@linux-foundation.org, Thomas Lamprecht , Wolfgang Bumiller , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <8d063a26-43f5-0bb7-3203-c6a04dc159f8@proxmox.com> From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 00D09A0015 X-Stat-Signature: 8prdapnnshhjhtg65w8indritp36sfq7 X-HE-Tag: 1690359552-607130 X-HE-Meta: U2FsdGVkX1/4vkSemCt21PYPcCl2BoDPOwzyZew2TZYjvnC+WHWlYB5ANODccleuRLQSEhMnfO376tfvaZoFCxmp1gqWXYOui2JarASaOEVagLTPbkLD3ZOV414kFqLNUpalJwxETfYSWceHXHpueHvAdt823wKpYg251F8vWEJG5MTEORWVkOUw0dBJjFBRZASr3ZAyS6Zt1bHnS9R8fssDvvytW+4Jh99hYRIIXeMMnb6RyXmMA22tM64uk7lQBhAuagP5DGNJDKSPjsW1aAhI1P0pmrzJXZ7FWBqwuDqFIzpOdf+GDw6tpr4cSGUt4PmgNUz0VYoWXBORDSkjr0YZRtsDFRwaOS5wdC3HB+OMsDpGytaoDaGNXLFx5ceFGc9WgUullcnf62ykqig1e76pUqrZ8SjhO0FdhIdbfKcmm0wCN3GY1JVUHhcJLz+H1ynvaTiRuuLvNEunFl+gMY2SR+/KVUUPUmlUoNuN4/22FnAilzNqwFDCAzt8u13pWHyjctOQ+9E/5rjkDuzNnvhM4uH/j/DHdjz8tTTq+eZFKH+6AgNk43twOkyp/TnbQId0ZYR573ILU7ey1kVUXPYo6pLECVXI5UQHyh8hoLBJQvZbDpzt2eLhYNtn8QT4IH3ROc/Bz7U23dp8yjtqHWr8phuCwIfD6TnajU2xQx2mcKLINLiU7Ju733FrF9E/BT+f3KT+k7rUg5cPwJcfLlSrZHw7HhA5NxIKQmHZLKTxy9t18sKFF6zajdN23Q45Xzp6nUS0An5tDxpJEApiU/kC1J8GRD8Lj144ZGk0wus0oYbkR6NUjDERGtP1GVhZDNrizvmlzQBUL4szl8/yEaGqUHfIKvZqr5f/i7CeX8i5ualde25PEFDOIlnGNYBenV9yqXCR2E9Iq0SE4pSceQW+jhpME2phaOXCPFTolO6AB9kUw8cXxFhosUjF7asDN6/0AuZBAL6FTyBgv09 atbsIaFS gSV/8Je+KZu8a9GxqZqL6ExtZa2JH6t9fSE5Qbz9YuKCyEo1l3lat0gDTnf5FVdvUwZFOc1fGUaYfMKiAwyWZY/xyAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am 25.07.23 um 18:38 schrieb Linus Torvalds: > On Tue, 25 Jul 2023 at 04:16, Fiona Ebner wrote: >> >> will end up without a vma and cause/log the segfault. Of course the >> process is already being killed, but I'd argue it is very confusing to >> users when apparent segfaults from such processes are being logged by >> the kernel. > > Ahh. Yes, that wasn't the intent. A process that is being killed > should exit with the lethal signal, not SIGSEGV. > Checking the status from waitpid, it does show that the process was terminated by signal 9, even if the segfault was logged. > But before we revert it, would you mind trying out the attached > trivial patch instead? > The patch works for me too :) (after adding the missing tsk argument like Thomas pointed out) > I'd also still be interested if the symptoms were anything else than > 'show_unhandled_signals' causing the show_signal_msg() dance, and > resulting in a message something like > > a.out[1567]: segfault at xyz ip [..] likely on CPU X > > in dmesg... > Yes, AFAICS, it is just those messages and nothing else. Best Regards, Fiona