From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Paul Menage <menage@google.com>
Cc: containers@lists.linux-foundation.org, linux-mm@kvack.org,
Li Zefan <lizf@cn.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Pavel Emelyanov <xemul@openvz.org>,
Dan Malek <dan@embeddedalley.com>,
Vladislav Buzov <vbuzov@embeddedalley.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Alexander Shishkin <virtuoso@slind.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/4] cgroup: implement eventfd-based generic API for notifications
Date: Thu, 7 Jan 2010 14:36:29 +0200 [thread overview]
Message-ID: <cc557aab1001070436w446ef85n55dd2af5e733f55e@mail.gmail.com> (raw)
In-Reply-To: <6599ad831001061701x72098dacn7a5d916418396e33@mail.gmail.com>
On Thu, Jan 7, 2010 at 3:01 AM, Paul Menage <menage@google.com> wrote:
> On Wed, Dec 30, 2009 at 7:57 AM, Kirill A. Shutemov
> <kirill@shutemov.name> wrote:
>> +
>> + if (!IS_ERR(efile))
>> + fput(efile);
>
> While this is OK currently, it's a bit fragile. efile starts as NULL,
> and IS_ERR(NULL) is false. So if we jump to fail: before trying to do
> the eventfd_fget() then we'll try to fput(NULL), which will oops. This
> works because we don't currently jump to fail: until after
> eventfd_fget(), but someone could add an extra setup step between the
> kzalloc() and the eventfd_fget() which could fail.
So we need to use IS_ERR_OR_NULL here instread of IS_ERR, don't we?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-07 12:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 15:57 [PATCH v5 0/4] cgroup notifications API and memory thresholds Kirill A. Shutemov
2009-12-30 15:57 ` [PATCH v5 1/4] cgroup: implement eventfd-based generic API for notifications Kirill A. Shutemov
2009-12-30 15:57 ` [PATCH v5 2/4] memcg: extract mem_group_usage() from mem_cgroup_read() Kirill A. Shutemov
2009-12-30 15:57 ` [PATCH v5 3/4] memcg: rework usage of stats by soft limit Kirill A. Shutemov
2009-12-30 15:57 ` [PATCH v5 4/4] memcg: implement memory thresholds Kirill A. Shutemov
2010-01-04 0:00 ` KAMEZAWA Hiroyuki
2010-01-03 23:56 ` [PATCH v5 3/4] memcg: rework usage of stats by soft limit KAMEZAWA Hiroyuki
2010-01-07 1:01 ` [PATCH v5 1/4] cgroup: implement eventfd-based generic API for notifications Paul Menage
2010-01-07 12:36 ` Kirill A. Shutemov [this message]
2010-01-08 0:55 ` Li Zefan
2010-01-08 1:05 ` Paul Menage
2010-01-04 0:36 ` [PATCH v5 0/4] cgroup notifications API and memory thresholds Balbir Singh
2010-01-04 10:15 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc557aab1001070436w446ef85n55dd2af5e733f55e@mail.gmail.com \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=dan@embeddedalley.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=vbuzov@embeddedalley.com \
--cc=virtuoso@slind.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).