From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB8EC43460 for ; Tue, 6 Apr 2021 17:57:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9BA46613C6 for ; Tue, 6 Apr 2021 17:57:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BA46613C6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0BA806B007E; Tue, 6 Apr 2021 13:57:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06BFF6B0080; Tue, 6 Apr 2021 13:57:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E74416B0081; Tue, 6 Apr 2021 13:57:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CA29D6B007E for ; Tue, 6 Apr 2021 13:57:47 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 83E978249980 for ; Tue, 6 Apr 2021 17:57:47 +0000 (UTC) X-FDA: 78002700174.12.3A51BE1 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf07.hostedemail.com (Postfix) with ESMTP id DEA96A000392 for ; Tue, 6 Apr 2021 17:57:46 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DECA4B230; Tue, 6 Apr 2021 17:57:45 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 06 Apr 2021 19:57:41 +0200 From: Oscar Salvador To: Mike Kravetz Cc: Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Roman Gushchin , Shakeel Butt , David Hildenbrand , Muchun Song , David Rientjes , Miaohe Lin , Peter Zijlstra , Matthew Wilcox , HORIGUCHI NAOYA , "Aneesh Kumar K . V" , Waiman Long , Peter Xu , Mina Almasry , Hillf Danton , Joonsoo Kim , Barry Song , Will Deacon , Andrew Morton Subject: Re: [PATCH v4 4/8] hugetlb: create remove_hugetlb_page() to separate functionality In-Reply-To: References: <20210405230043.182734-1-mike.kravetz@oracle.com> <20210405230043.182734-5-mike.kravetz@oracle.com> User-Agent: Roundcube Webmail Message-ID: X-Sender: osalvador@suse.de Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DEA96A000392 X-Stat-Signature: u89wwowfe8a6hdzwzh8t1wr88m6q8udx Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1617731866-726370 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021-04-06 18:49, Mike Kravetz wrote: > > Andrew, can we make this happen? It would require removing Oscar's > series until it can be modified to work on top of this. > There is only one small issue with this series as it originally went > into mmotm. There is a missing conversion of spin_lock to > spin_lock_irq > in patch 7. In addition, there are some suggested changes from Oscar > to > this patch. I do not think they are necessary, but I could make those > as well. Let me know what I can do to help make this happen. I agree that it might not be necesary to make such changes, but I still would like to see an explanation on the points I raised(excluding the list_del() as you already proved that is not necesary), just to be sure I am not missing anything. -- Oscar Salvador SUSE L3