linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Robin Murphy <robin.murphy@arm.com>, linux-mm@kvack.org
Cc: dan.j.williams@intel.com, ira.weiny@intel.com,
	jglisse@redhat.com, oohall@gmail.com, x86@kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 3/3] mm: introduce ARCH_HAS_PTE_DEVMAP
Date: Mon, 15 Apr 2019 17:00:35 +0530	[thread overview]
Message-ID: <cc96cad8-2078-8ee0-9ce7-d073dcc702c8@arm.com> (raw)
In-Reply-To: <25525e4dab6ebc49e233f21f7c29821223431647.1555093412.git.robin.murphy@arm.com>



On 04/13/2019 12:31 AM, Robin Murphy wrote:
> ARCH_HAS_ZONE_DEVICE is somewhat meaningless in itself, and combined
> with the long-out-of-date comment can lead to the impression than an
> architecture may just enable it (since __add_pages() now "comprehends
> device memory" for itself) and expect things to work.
> 
> In practice, however, ZONE_DEVICE users have little chance of
> functioning correctly without __HAVE_ARCH_PTE_DEVMAP, so let's clean
> that up the same way as ARCH_HAS_PTE_SPECIAL and make it the proper
> dependency so the real situation is clearer.
> 
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>


  parent reply	other threads:[~2019-04-15 11:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12 18:55 [PATCH 0/3] Device-memory-related cleanups Robin Murphy
2019-04-12 18:56 ` [PATCH 1/3] mm/memremap: Rename and consolidate SECTION_SIZE Robin Murphy
2019-04-12 19:01   ` [PATCH RESEND " Robin Murphy
2019-04-12 19:12   ` [PATCH " Dan Williams
2019-04-12 18:56 ` [PATCH 2/3] mm: clean up is_device_*_page() definitions Robin Murphy
2019-04-12 19:01   ` [PATCH RESEND " Robin Murphy
2019-04-15 11:25   ` Anshuman Khandual
2019-04-12 18:56 ` [PATCH 3/3] mm: introduce ARCH_HAS_PTE_DEVMAP Robin Murphy
2019-04-12 19:01   ` [PATCH RESEND " Robin Murphy
2019-04-12 19:37   ` Dan Williams
2019-04-12 20:09   ` [PATCH " Ira Weiny
2019-04-15  0:58   ` Oliver
2019-04-15 11:30   ` Anshuman Khandual [this message]
2019-04-12 19:01 ` [PATCH RESEND 0/3] Device-memory-related cleanups Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc96cad8-2078-8ee0-9ce7-d073dcc702c8@arm.com \
    --to=anshuman.khandual@arm.com \
    --cc=dan.j.williams@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=jglisse@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=oohall@gmail.com \
    --cc=robin.murphy@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).