From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCA49C636D4 for ; Thu, 16 Feb 2023 02:04:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C4126B0071; Wed, 15 Feb 2023 21:04:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 074A06B0072; Wed, 15 Feb 2023 21:04:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA52E6B0073; Wed, 15 Feb 2023 21:04:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DAD5C6B0071 for ; Wed, 15 Feb 2023 21:04:41 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AB295A04CC for ; Thu, 16 Feb 2023 02:04:41 +0000 (UTC) X-FDA: 80471511162.11.0B69319 Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) by imf03.hostedemail.com (Postfix) with ESMTP id 06CC32001B for ; Thu, 16 Feb 2023 02:04:37 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf03.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.111 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676513080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Uw47OXKQkwkautin4VkWhtNi72aMbKsrOrARi0SkVlA=; b=TmYcUV/cwSMvemiZXyunMJbSAM6jY3PdNp9CUgEf/IboCzReYsjaoKtN72nluWaYsizz/3 hobGi8fN6LZ46chn0qbpXBgf3L30PUdM8gFBCz8/1IDQrNIBs4+TxpxlkPsq7rwPFrie8K gdSC2r8jJz95S9P07eHDJilc0vAmeoo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf03.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.111 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676513080; a=rsa-sha256; cv=none; b=5bnnc/vMuF2k70PVp5ZY9M/4H5JR+5q7vmOjFuFg6YWshwDcf9OP8r6PtmAF+4gM9ab+vL amNu/VOqSXh8/bqlLl32PQDifDGOV5WkbCQKK73GZS2133tN+Eu/9ilZ/VNNXro1Wkk5IZ SWZV+92LMPAGKf4nvYON8F0zLlbw47M= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0VbmFO5J_1676513068; Received: from 30.97.48.85(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VbmFO5J_1676513068) by smtp.aliyun-inc.com; Thu, 16 Feb 2023 10:04:29 +0800 Message-ID: Date: Thu, 16 Feb 2023 10:04:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v3 3/4] mm: hugetlb: change to return bool for isolate_hugetlb() To: SeongJae Park Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, naoya.horiguchi@nec.com, linmiaohe@huawei.com, david@redhat.com, osalvador@suse.de, mike.kravetz@oracle.com, willy@infradead.org, damon@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230215202548.92462-1-sj@kernel.org> From: Baolin Wang In-Reply-To: <20230215202548.92462-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 06CC32001B X-Stat-Signature: gr773o5nhb6comispjtm4gaxektmx6pw X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676513077-922281 X-HE-Meta: U2FsdGVkX18XgTtnfuUAhqqzNQTHd/29ULELwEARLqx3dJTvJ3KQBb2fBt09x0XWq/dRb0Y2sZ/udXG0DgRHruQaNUMLdAeuDSMjZKgLDy4i/ezSJMrMDe+1cTzr9eTG8MKiBbEthBVtJ/QV1KVTv6Zb/ovvFgUSttCc0XgvD6re1Ka70XNs/aY9YXZgNR49OyauFjfh5kjAXZC5wFTe9fgNcyUbfvXIfUin4svsga9z8C4JFnVBInBTZz3da/jkK7ryuRUwszK/AM+3vs6s2fAQhpImCVaPqNqB7r0NHzAcp3/YbrtZCl5etcMM2ndchWc20CFFIc7s40mwe7FRE2gQVcdjTj6G5Q52WLq2d1eWbuaIZmueDzviFX7Gw/7S0EemZbpz+ivWlIZub+e5aOwRlO8QjyGO1Pbu3NMLscirwrvDsMZfLmlESdDPF0eCaRiq/amPY8hMVEiG5AX9JXPDa2Pm52GfyRSYgAHNp93VrQW9qNWn7sTjGTETJ0XA3KQT6Q9A1BIoGMBt4nmN1wNgiGj2A2OXvkEFve/v9E9Ydk45Uh8It3xHkvwlgMkTxu5ht58635+MNlcR8bnbQwURvFvppxBzvT85y6uZ0d/AIpp3uxPev6sM0Kj+DDo6Cd7XBWT3jct2rfnQ10Llm/n1x9JvMbQC7XdVkBSYkSSJU5wUkt1BFqvMl9MuvjCZXZirBfujVFOwPTPrP4qMDOD+N2fj2Fy8S7K4HwrIpP7b28LErqDeapOckyDetbJrS6TQEcU7cEycrRD+NtT5rh0rHgWvC2oKM0PrqWoafFvzQZMy46UbP0hjp0qlTgx1y08U5UZJe/1AdvpN+CcfjhxuLEE1t+zOsMJYt7FAdI+xU2YAlM44Hg9KW485eyGm7OXjP3NO97PSNeNyxv+N1qVBA9JlWlZIHZBa7SnT1S7GSTSWtF8Xk+Eu9avWQ6PlycPF7Q4RVGnxuPmWNbo bpNFc7/j k6b66BkQD3x5Q+7MRnuk3XXJu4ezinnAsdyeVWe3ghG1t0V+rZf45eTqTGZDVzHqU1mS0BACPQwAVp8RMK+V9H6x7LUf1HBOKOXwUJRPsZFsf0JN/spoRwGLatCnzE+UaAeqDMoypn84W6fTyz5g1uqa9wNYQiCymkizCxxARxI/gwlsmjliHNDDBO7P+hMx25xCQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/16/2023 4:25 AM, SeongJae Park wrote: > On Wed, 15 Feb 2023 18:39:36 +0800 Baolin Wang wrote: > >> Now the isolate_hugetlb() only returns 0 or -EBUSY, and most users did not >> care about the negative value, thus we can convert the isolate_hugetlb() >> to return a boolean value to make code more clear when checking the >> hugetlb isolation state. Moreover converts 2 users which will consider >> the negative value returned by isolate_hugetlb(). >> >> No functional changes intended. >> >> Signed-off-by: Baolin Wang >> Acked-by: David Hildenbrand >> --- > [...] >> include/linux/hugetlb.h | 6 +++--- >> mm/hugetlb.c | 13 ++++++++----- >> mm/memory-failure.c | 2 +- >> mm/mempolicy.c | 2 +- >> mm/migrate.c | 7 +++---- >> 5 files changed, 16 insertions(+), 14 deletions(-) >> > [...] >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index 3a01a9dbf445..16513cd23d5d 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -2925,13 +2925,16 @@ static int alloc_and_dissolve_hugetlb_folio(struct hstate *h, >> */ >> goto free_new; >> } else if (folio_ref_count(old_folio)) { >> + bool isolated; >> + >> /* >> * Someone has grabbed the folio, try to isolate it here. >> * Fail with -EBUSY if not possible. >> */ >> spin_unlock_irq(&hugetlb_lock); >> - ret = isolate_hugetlb(old_folio, list); >> + isolated = isolate_hugetlb(old_folio, list); >> spin_lock_irq(&hugetlb_lock); >> + ret = isolated ? 0 : -EBUSY; >> goto free_new; > > Nit. I'd personally prefer to set 'ret' before entering this critical section > to keep the section short, but this would be just a mean comment that wouldn't > worth request respin. Yes, good catch. And I see Andrew has helped to do this (Thanks Andrew). Thanks for reviewing.