From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA840EB64DA for ; Mon, 26 Jun 2023 14:36:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 386FC8D0002; Mon, 26 Jun 2023 10:36:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 337488D0001; Mon, 26 Jun 2023 10:36:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D8FD8D0002; Mon, 26 Jun 2023 10:36:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0C2558D0001 for ; Mon, 26 Jun 2023 10:36:48 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 76D49C0768 for ; Mon, 26 Jun 2023 14:36:47 +0000 (UTC) X-FDA: 80945150454.01.7B7FC39 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 538A614000A for ; Mon, 26 Jun 2023 14:36:42 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ct4PatFk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of ypodemsk@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=ypodemsk@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687790202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tvcSqXCnz9zVXylEiOugaJe8PBAXaMauU+4YTqF2Kks=; b=BQ2N9u9LOiyWIU3rz2CCpy5E1E51oBWRd667NtSzg9UscfaK8UytDvF6ASTHvAmuSYo2En Z4nZM4PWldGhDhRiqTsdAFvIhuS16xMlCinXctCtBIo5ec+F4yUHE3LQUAlf2xV1e2l+qo AOT/092K/aSLKNsWSxTiDlQI/o2FQfE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ct4PatFk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of ypodemsk@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=ypodemsk@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687790202; a=rsa-sha256; cv=none; b=MwajU96ylTQewrJns+JC1mtuecRvyLdyIr24c4mBK3SAANKJJJ0GQtGKWpXpeLqjIANgeo wpY/7r7SMZ21+t8f4+VQdhPHgUsAGu68v4DHKfc1VCrHtbZuzVf+KBSvFWMgqEYHlQ7Cvo XR9Jq80cH1hzF8xnl5OMs/7zywAn5tI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687790201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tvcSqXCnz9zVXylEiOugaJe8PBAXaMauU+4YTqF2Kks=; b=ct4PatFkbBsjEKIKtSqgEa9zU+ug52tY/jG4bGhtKsOanMOmu9Nk3IjzAlzIg2e3A7CBPx iDLc441UQQT624q3xAc1FcIUXHcIlHV/L1QFcG7kfxAmZg3cjhho8rMEEJ7idFpuZj0+W2 /CNjcxVwhoKClPa0SM2qf8gxj3syXy4= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-414-1jaGY8ufPYSqPZUFez7DoQ-1; Mon, 26 Jun 2023 10:36:38 -0400 X-MC-Unique: 1jaGY8ufPYSqPZUFez7DoQ-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7656cf70228so227193185a.2 for ; Mon, 26 Jun 2023 07:36:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687790198; x=1690382198; h=content-transfer-encoding:mime-version:references:in-reply-to:date :to:from:subject:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tvcSqXCnz9zVXylEiOugaJe8PBAXaMauU+4YTqF2Kks=; b=UNnW16YZ3WqSGNtmiDdUISnTKBlN084pmSbH3oe79ut1hOxcEaMDkSbG81uXKH8zND mee2XvvQz4qxGSkEMp+1RSVQNIpEyGPb16sCLXDJU6mgrEjIMxfTMrre+px2kGnwGbLU IZ8QfKqiTDVBHA9nsyCZTngAwc8WirdN1w/AslOFVq+yZYJF+cpjaGXV0haBEgGcAWxA ouLYPI1bSRBHpv3uT+L3Ai96sTybMn+qsPAKmog0ir/bRJLgyprJwT4s06Alldqyy80z rqy50pz3/WH9j3ZTE2CYrHkGiDdn1KHdQJBAASRvQYlcnAgxDd56JLIzMRn+gKdE4xOa 5P2g== X-Gm-Message-State: AC+VfDzNMVYX3VZ8vDvsW06KrJt6MCkw8WFEKDhACeNchovwve4Ebs4A B4zg00BrQQb+CbNUzin+2/Zkld6I2G281TqWWlL0DL6/579IQHxZnH6YT97/X5YwpJuuT/UskBG 8pPfOI+F4ol0= X-Received: by 2002:a05:620a:2b88:b0:762:5179:5d97 with SMTP id dz8-20020a05620a2b8800b0076251795d97mr26896721qkb.12.1687790197711; Mon, 26 Jun 2023 07:36:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ79/JfP3Hny6V9tnqkHShvsxIy9E8rAkOfBtz9lcAvMdQVNdzhuBr1C3eS+Bxuk3VP5Pg8PBg== X-Received: by 2002:a05:620a:2b88:b0:762:5179:5d97 with SMTP id dz8-20020a05620a2b8800b0076251795d97mr26896682qkb.12.1687790197466; Mon, 26 Jun 2023 07:36:37 -0700 (PDT) Received: from ypodemsk.tlv.csb (IGLD-84-229-250-192.inter.net.il. [84.229.250.192]) by smtp.gmail.com with ESMTPSA id pe34-20020a05620a852200b00765a71e399bsm1204141qkn.55.2023.06.26.07.36.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 07:36:37 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2 2/2] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs From: ypodemsk@redhat.com To: Dave Hansen , mtosatti@redhat.com, ppandit@redhat.com, david@redhat.com, linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, keescook@chromium.org, paulmck@kernel.org, frederic@kernel.org, will@kernel.org, peterz@infradead.org, ardb@kernel.org, samitolvanen@google.com, juerg.haefliger@canonical.com, arnd@arndb.de, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, linus.walleij@linaro.org, akpm@linux-foundation.org, sebastian.reichel@collabora.com, rppt@kernel.org, aneesh.kumar@linux.ibm.com, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Mon, 26 Jun 2023 17:36:28 +0300 In-Reply-To: References: <20230620144618.125703-1-ypodemsk@redhat.com> <20230620144618.125703-3-ypodemsk@redhat.com> <680fadba-9104-3914-5175-e207fd3d9246@intel.com> <79f29f99fa07c46dbaee7b802cdd7b477b2d8dd1.camel@redhat.com> X-Mailer: Evolution 3.28.5 (3.28.5-22.el8) Mime-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 538A614000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: bn85ro8h8uq6gxftyq8w56ntoh9sfrtk X-HE-Tag: 1687790202-200559 X-HE-Meta: U2FsdGVkX1/99HkaC0ZmG2/NRAozg08IryJ+i5F1Yujs0SusVg/Exi3cRUsj0MEUpZQ4aSvS9TgcTNaSMQge/Pe/O7j2jNTh04D86hU85C5JMqvHJa/3e60N33FmBMhyrLJ7QQlr2A+UUzIpTlyeZImZbsF+lnLRMpd5iYTS9H6rLLaay67iuC/3DUlWN5xTlCHSGicFC8ITFt73neiZmsXh873wLhHEc5HXNKvqWFhDOeIVXLgy7CwZIQzJQ3vaiontv/Enr+/0qZKNXama01tUXbm4HVD+Q5/n2d1jaSrkXxJKjEFfzzj+7M0pR7WnZIrD5Aa5RHaIuIH7puRy1Fel9DwQidUCG7QIhIVm6l78Cp9w2Yq/27hUpb2wx5uqxmt/I2dzMYr5bRjSxxpAKb0fZEkI50o++L2fSFo1ktQmngWVDgtQL5t4FfMjjp42lRPc7O/shxpMu2c2EPF4a1R5Ry7ZPYwYFw8elv5HMb34IRwvMhyfzFL4IKF7jn+6ki4KsWMXxuwVocOiXPZPbOI6c+GJznQPAEbf+x2OHcSD75xSzib0nIQCoDKZhK6CWFvrBuQziGfq6F53LpdnzhG9VIMpUDwECglf6j9mM26LxJZ5bd69K+KUpoDnFcuadeBM6VkxeUE8gc4pgNxqZufYGwRRzY20Pxbp7oeHZthO6X1IU1YF0HK5wndwKJLgsWw/iHIhC45120N7x5g46kap1ejSmEPyimi2p265WUocZb1qDgMiE4zH9JYThre/efNzMRYu2IrbmkzNoln2MtlYZyv1bH6JSVNGkx2gdIROb8cW3gdcrH4RIx9Jm693p9a9P6Lt9sNOLDcNMXBbSk0khm7WnC1Pj1etpNClvm1hHvd4u4zs3tFr5ZLlhmBeqfDa2jGNZCCWg7shNYXQ9U9xte2DgyUFJWE3zAd1OYVPONXBnGuQX4VqXI2xPwvECv+2XnLmXzSgSByqV5q d8cbdniR cuRla8hw5PHtBCC1R1eZaqPVgHHnXmIuzY4eLiT63e85IrpV0BQteJFkExT6htSgoAURgfy9QzT+zPkPxTN9ZcmmYqCu6rRUxv4f//ZyKUJlm1Pz9ABJpcMArD74NyurFJKrz2Th64eMtaENSLnl6LKUO/u4DtvvCjF1FFxTWyNI1PVYVkDuZ9kgxMi/429kQbNoOe2YtiCPSOoicsLo/peILg5aZr5XLUOxNunWA8GFFadaANkujtbsJeWVkjnBvhYBgOyfsCTAruKl+cbJL/PpxjS9GyQjzjuBMeN95sJdutcNChQZ+GqWMddCaarytYvFZOioXqGQgYKSHS5hUdE4fOPkqgJdKveNFSTbq/w3THKG/H/JDVr1FKXNmcVLhovTMBdLQE5tcIXH7mYh1thXzAVii3FpAi0ZXR+ZbriDgtYayPFb5OyI2ATb0t+Q2z2gSXQKvsCD8Din+VwL2u2/Vv8d6nIFeLz2vdGavye/bLUAXY4r4/Xv/SgRWf3BWVYz9DnNu3BUMx79LxaQH63nWRc+3BQkxxBJvrWVWkp8VEK8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2023-06-22 at 06:37 -0700, Dave Hansen wrote: > On 6/22/23 06:14, ypodemsk@redhat.com wrote: > > I will send a new version with the local variable as you suggested > > soon. > > As for the config name, what about CONFIG_ARCH_HAS_MM_CPUMASK? > > The confusing part about that name is that mm_cpumask() and > mm->cpu_bitmap[] are defined unconditionally. So, they're *around* > unconditionally but just aren't updated. > I think your right about the config name, How about the CONFIG_ARCH_USE_MM_CPUMASK? This has the right semantic as these archs use the cpumask field of the mm struct. > BTW, it would also be nice to have _some_ kind of data behind this > patch. > > Fewer IPIs are better I guess, but it would still be nice if you > could say: > > Before this patch, /proc/interrupts showed 123 IPIs/hour for an > isolated CPU. After the approach here, it was 0. > > ... or something. This is part of an ongoing effort to remove IPIs and this one was found via code inspection.