From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70FFBD6A22E for ; Thu, 14 Nov 2024 20:45:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD6D06B0085; Thu, 14 Nov 2024 15:45:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D87F66B0089; Thu, 14 Nov 2024 15:45:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C279F6B008C; Thu, 14 Nov 2024 15:45:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A5FBE6B0085 for ; Thu, 14 Nov 2024 15:45:42 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4F5EF1C68B7 for ; Thu, 14 Nov 2024 20:45:42 +0000 (UTC) X-FDA: 82785880926.11.03AFA49 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id C08CC120009 for ; Thu, 14 Nov 2024 20:44:39 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BcAEW0NE; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731616995; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EgFUS4COozi1y1qKjEJIl4ZVts8py+aKqqnIGti4/Bk=; b=Dyc/NoIfJAZBkCiztHBDqMTjdri/INRlh8LU1ZsBHWdWo1xm7XewVG1I9+F7jqQf/LBIBm 90/gmPG2kTsEkOpa8SfKm5Yxi2vTmTIxf3TU1jDe9haYOJCfQt6tESqOL96KnbndRH2efZ Pn9ZPJrwVhwFRNSm6HK+hZg9JkIFg3c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731616995; a=rsa-sha256; cv=none; b=SiI3vEeBt3SQCXw049ZzWMUui4oHiveGC1AsTKGAmuezZP3R14uGkAd6cfaUQlFT0DdH/Y PvgxX144qbtM/JQHLiGOGoV+lIj9/tE14WQFagoxgaW0y9ZhO2FxaoNNXM82V4KnaCS0eU jBdwFW3z0CH5LX+nvHRr1JI7hM/ak5g= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BcAEW0NE; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731617139; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EgFUS4COozi1y1qKjEJIl4ZVts8py+aKqqnIGti4/Bk=; b=BcAEW0NElBziqm3Yms8eMO2AqPQbSkehnZbhtjo6l4NG9ktPQ+9vBnETPhLFPN9AOXkCsk gsx8lHmNh1WAaxLmOMtdRnVSpJQIx/xjEGej5sDb8jM9P/xrWDbR8IH4Pf9tDci4sBPA6A 99oqgejbqbuuqEOOp7k1u/A8/trfMrY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-656-l9rhYBgLNYmKkAdGuP4Mng-1; Thu, 14 Nov 2024 15:45:37 -0500 X-MC-Unique: l9rhYBgLNYmKkAdGuP4Mng-1 X-Mimecast-MFC-AGG-ID: l9rhYBgLNYmKkAdGuP4Mng Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4316655b2f1so133995e9.0 for ; Thu, 14 Nov 2024 12:45:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731617136; x=1732221936; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EgFUS4COozi1y1qKjEJIl4ZVts8py+aKqqnIGti4/Bk=; b=up6KaN2z/TLwoCALjiDfEpKm2BFPptLGjlzMn50tw5ncnHs5dkhdfvWdmyz1Aryn3g g5ocr3ziz2Nd32YpbspOevDV8cm/Bql2hxiOFU34mwmfNSxQYYKFrHQemlL2C311gHGP kzOHK7txgwYHyGWBvWvEKBpI01JoitIQQ6s8XOg/2Ag5yNGX5ZdZ1d5Cv9KjILiDUCp0 Q5darVMIJGp1Bl8geFQBakr3U1Zt3a18q0C1PIBEnpsV+al6M6s8B7VNJkIsfbQ9hvWm DbBigLVq2klld8CFPVpErC6a5wo/kN6cREnzPRG4NbpKnt5G+O7ZpuZNp2xk1cic3kjA K7Mw== X-Gm-Message-State: AOJu0YyM/I3BkcU410z8sWtXPU4KRIDV/KAfTzJ5QeqNn5n1QbrUUEbX n24MmeIRhN5YVhyNC28RZLSeOa+r35IO73B4vTgvdv8nU1va2XwoX857OWSkSuwIpm8p/PdWlO5 MM+HSgoc1BBAdO+gAZU3oohMRjqz6oiIF4JhMbqLc+/QD3Ulb X-Received: by 2002:a05:600c:3b20:b0:431:5f9e:3f76 with SMTP id 5b1f17b1804b1-432df74d896mr1468375e9.16.1731617136504; Thu, 14 Nov 2024 12:45:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IF2dtb5xAy49eWL9mqpexqXPkgdgwxA3jpvgzRIoH341+4YdGRlAOwcfIWRdHysp7JiTvP9nw== X-Received: by 2002:a05:600c:3b20:b0:431:5f9e:3f76 with SMTP id 5b1f17b1804b1-432df74d896mr1468245e9.16.1731617136175; Thu, 14 Nov 2024 12:45:36 -0800 (PST) Received: from ?IPV6:2003:cb:c715:6600:a077:c7da:3362:6896? (p200300cbc7156600a077c7da33626896.dip0.t-ipconnect.de. [2003:cb:c715:6600:a077:c7da:3362:6896]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432dab72184sm31470045e9.2.2024.11.14.12.45.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2024 12:45:35 -0800 (PST) Message-ID: Date: Thu, 14 Nov 2024 21:45:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: PageOffline: refcount, flags and memdesc To: Matthew Wilcox Cc: "linux-mm@kvack.org" , Yu Zhao References: <1239f9a1-81b7-4752-bfa4-d3ec9bd9118f@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WMk5UDAryKFssSLyxbEaVQ50z2K_LE203lRocAVoG0M_1731617136 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C08CC120009 X-Stat-Signature: 43m7etox5kshr51afxxzhrtxsqruo7ai X-HE-Tag: 1731617079-318425 X-HE-Meta: U2FsdGVkX19iQCL1bdkCAM1H56CmQEoNbEcPFm1K2KGa19bdwivPEE3sX7dlWAvSuTv7waF3ri2yYbykei0nL3Fejr5/t5OvaSNn4iKYdfnDh2J4cpTj+zl/K9mjB62jrLZudnDnA4AWwPpVG1kQV0nj8Z0+hHD8n/vO4fyzWXANfr3oN5AwcpFOvxac/wCDv88+9GR3Opf6NGYS4Z7mTc4n8avjZHjbUjVhDl2ZIb5G4iDEUE6GBafP5zOUqv94AOeLjYohkpADJuoG6+/6ZMPX7NhVGHUhSw6WMZRXLzy6bQyIR+BJF8sr7d4LFxjQdvwlJ+ttJYAGXaXRet/Tnnym6J2uTqChjT7rkOWdfBSx/GDT5kec3DgtV+v/6Wg/HSbyivyAvBIuA9N/LaAEcqcnIrqnwzDBC2O1e/FDLxmgOMFRbJTKwelAYDd1NDH3fQ7JOrJ0u6lUpZKOkziLlSIG+Jet2O49wCJMMmT51aOQ47CiBzFdsteCas4/nrpPAGZDYjkgChxZj6zt1ZKFJ14INjUu7tjQrMghPGvXPtOeqSdrUzW2pGiqn79/3UBRxCz8oS5bYAUOUglucieFe3v4azCExpuMy6GpLWBYSzfzbQg2FJCTi0Cg6AvNnyFKHi408vq4b/2UOTlT4P8tKVfQbBSfQBeg6JlSU8G4AVDO/T0BLFjpaSOR2NBiA6NEBpsRgRrIHb8Pg8KfzsQWZm2JuYkJTJ1vc4FCkPcHc6EX62vYzVrksxZouDnvJK28gYgGQg27F+NduIMJ41HHybl49LNF2Cct7lKreS7XT6vXaYJDMxX9mkjfCmX4XFha5zDbdZGfgRVIb8MAbWXRC78BUgwQL4PE21ROIftO3bADZjHDFjDJf0DrcvJNzVrxNmGRc1T0jUfriaHQ42YXgdMs+qCcBTf/n7pAzKNwFGsBZGA1TTd+F+FmTbn4lv3n7nRy4K2PAfBmLLWYKoH eRzg/jZH O63+p/OHJdy2PJoxSK+SJ93Zq3dQdk2SoKXrTXdp8dSeeGluH62CZnlXFAXdawS99rnCXvSeZlAp7xtqn0oSkGwtu4kujeCEFwh77h3bqQ8MBWXZMwaMLz85p9Iyp54MZhmmf8JUB5Q+JqoaIp4qIge+mXWTCyqNgS3AIOc3yEvCnPuGBDN9n9vp4ONdEIuCklvw431/ABgVw8O6h860uuxw57LGaG0SmI6O8dN9v087ODwO0jsBhMMczb62g8v0d8pKCTjZ13J7YZSgV5UJZOJfa+z1PJHojAt7j/mmNaUQY8tpqG129ypF0E+Tp77Mog3R2naShDVFsqypFvRscQkmlbVEo3Xn5cC5uyG6ozMH4e1UnIxo3tgdQ1jRNuOmR43bhRMc8DcVZkylaPGEYGeALcc0sZsAoxYdb415PCTTFOH4fg9onrLplgQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >> Instead of alloc_frozen_pages(), I was wondering if we should have something >> like GFP_FROZEN. For example, for two PG_offline users >> I'd currently also need alloc_contig_frozen_range() and >> alloc_contig_frozen_pages(). Using alloc_contig_range(GFP_FROZEN) >> alloc_contig_pages(GFP_PROZEN) would make that easier. >> >> Did you consider that already? > > I think Yu Zhao's recent patches: > > e98337d11bbd ("mm/contig_alloc: support __GFP_COMP") > 463586e9ff39 ("mm/cma: add cma_{alloc,free}_folio()") > cf54f310d0d3 ("mm/hugetlb: use __GFP_COMP for gigantic folios") > > get us most of the way there. > > What I really want to do is make contig allocation not do anything with > the refcounts. Hoist that into the callers which actually want it > (probably not many), and then we can actually drop the __GFP_COMP > support to alloc_contig_range_noprof(). Right, at least virtio-mem cannot easily support alloc_contig_pages(__GFP_COMP; we'd need splitting support, and it should be a separate effort than reworking PageOffline; and it would all be in vain if we drop __GFP_COMP later again : So regarding the PageOffline refcount rework it would be easier to do it stepwise 1) add GFP_FROZEN support to alloc_contig_* 2) convert the two alloc_contig_*+PageOffline users to use that 3) convert the remaining alloc_contig_* users to GFP_FROZEN 4) make GFP_FROZEN implicit (drop it?) and drop __GFP_COMP 3) is a bigger task, likely too big to do in one shot. -- Cheers, David / dhildenb