From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55735C0015E for ; Fri, 23 Jun 2023 09:52:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D05398D0006; Fri, 23 Jun 2023 05:52:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB51B8D0001; Fri, 23 Jun 2023 05:52:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B56BC8D0006; Fri, 23 Jun 2023 05:52:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A42C38D0001 for ; Fri, 23 Jun 2023 05:52:45 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 764A61A0E4D for ; Fri, 23 Jun 2023 09:52:45 +0000 (UTC) X-FDA: 80933548290.01.33BDF6B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 438391C001E for ; Fri, 23 Jun 2023 09:52:43 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KLwzVmey; spf=pass (imf18.hostedemail.com: domain of pabeni@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pabeni@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687513963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dx+6a1jHVj0oese2JSMAv5oBV7G9+SGWK+vSSjznt1w=; b=q8NuPBItx0CA1Hdq1ONXAuezxWznuncm6qfpEQLuu4FQplVZJqLWNRNUACWlArdrUhOYXE 89aWVZa7bOR2AkoE2pOQf+E+jBH/e2XAtM1oHNYHnccPFk4Uu1PjbVNYtauyL+mqi1mTqL JSuKDHedo79LVtRppURwoBCF41dhvAk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KLwzVmey; spf=pass (imf18.hostedemail.com: domain of pabeni@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pabeni@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687513963; a=rsa-sha256; cv=none; b=E+BbGe3CZ86eS3iB/eDuNQJBILtMbkvNLbHZu09omE4bzZMqe6ETatXyNxr/CPQzeyS7v7 faw/er5p1UVexo1i+REJZ2o7NIdTFjWQsjoUFZnIdDK7pYE7jx+/zUpoeZRw4yL7K8GCed aESaH8vJRQ53NTuMzKeD/2+rDpSO8GQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687513962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dx+6a1jHVj0oese2JSMAv5oBV7G9+SGWK+vSSjznt1w=; b=KLwzVmeyWGG6g+uNAgavhfQqfAqy2qIDCkGn2AjSxFLBwuems5Wcot4t22YIP1ptk0SBJl x0LazAC6bwh3shJVJjLliXUuYGOi2Dh9UZyAMI+ElB/Pn/ra3dXjcVC/FgvhaFmgBU6Rle K2tit8DN3oBopLJZ5Oo5jTOLWwWmyYQ= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-E8BiiMVzN8KtAx76MsK68Q-1; Fri, 23 Jun 2023 05:52:37 -0400 X-MC-Unique: E8BiiMVzN8KtAx76MsK68Q-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-765342b83faso11146385a.1 for ; Fri, 23 Jun 2023 02:52:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687513957; x=1690105957; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1K8pf+Hfv6KUUo11ZRN0TVVBeFzPwTpw80csEV87fZg=; b=BR6W50BwqWuIAhodMWhzwBhhJniZ5zJHuls+fokWd8Jg5Z+l6nkdCj6ROSnZ+wQxtc ByPjKRlYnXlDmDp8ri2CHPk5Y7yWv/4kr0faguWO6xAclG3ArXPxaXxbkRexM9mBQ+Ra mWKC8WAI2FAYjQhbL5Eb8Ig1jUTH7FhjUJGBtWeknsC5UhLtwNKP+RZh9gJGXA52ZS3V YcST5GgbiAE4o+sl1MWCDo1IxV/qzFnElRBE20Inv/ztTzuaybehXiZ0scYAM4rqB6VG t2Or+l+af7Rwy2C9g48EcVu9X0N/RxUBePR4SQqO0tnd0fU95VHjY0t/w1cx77JHE1sn 7Tdg== X-Gm-Message-State: AC+VfDxoB4EmOxjYu2up8rkM7GiPfBDHb50zpyCN1H+bf9OmNkEIgc+y PfBeC89YbqTVsVF+u++ZxpW0M40l3X+eWDmC9U97+k0uUYWUzzknxGptw7yjQcBg/6W7PMpm9aF h8UMw2ExTUAk= X-Received: by 2002:a05:620a:230:b0:763:de4e:2453 with SMTP id u16-20020a05620a023000b00763de4e2453mr6596293qkm.5.1687513957079; Fri, 23 Jun 2023 02:52:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5w+vAckkr1xPsoP/O7YpKV26OqjtuOf30RhWVF7lYD6UuLEXVG0LDzinwCuq9Y4qAX/3DXiw== X-Received: by 2002:a05:620a:230:b0:763:de4e:2453 with SMTP id u16-20020a05620a023000b00763de4e2453mr6596277qkm.5.1687513956793; Fri, 23 Jun 2023 02:52:36 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-231-243.dyn.eolo.it. [146.241.231.243]) by smtp.gmail.com with ESMTPSA id v22-20020a05620a123600b0075cc5e34e48sm4300471qkj.131.2023.06.23.02.52.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 02:52:36 -0700 (PDT) Message-ID: Subject: Re: [PATCH net-next v3 01/18] net: Copy slab data for sendmsg(MSG_SPLICE_PAGES) From: Paolo Abeni To: David Howells , Jakub Kicinski Cc: Eric Dumazet , netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Menglong Dong Date: Fri, 23 Jun 2023 11:52:32 +0200 In-Reply-To: <1969749.1687511298@warthog.procyon.org.uk> References: <20230622191134.54d5cb0b@kernel.org> <20230622132835.3c4e38ea@kernel.org> <20230622111234.23aadd87@kernel.org> <20230620145338.1300897-1-dhowells@redhat.com> <20230620145338.1300897-2-dhowells@redhat.com> <1952674.1687462843@warthog.procyon.org.uk> <1958077.1687474471@warthog.procyon.org.uk> <1969749.1687511298@warthog.procyon.org.uk> User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 438391C001E X-Rspam-User: X-Stat-Signature: 69tgm7uxuy3jekpmokhnqgxjrad6n4i7 X-Rspamd-Server: rspam01 X-HE-Tag: 1687513963-545063 X-HE-Meta: U2FsdGVkX1+gKxfPr+YmDj+EUuNDp1NKFt3JJnytbtrPG89Xc1MRxOX3haMGyrJbEnzDAS8ijihng376yoGs5df7HooFi8FJrCv1Hq8b/xvsvUztd1Jf2Haox3v+nk2/KSs9KwTpDngNxeEM0PP6zZ43X8mJEW1903mwhGab3eSIHSttpm11MsMzirJ5hJhhX29u8/QUcTAeZcLQVf6FRcXkvCUOxMDe688Kt9cTr3Mus71oht2ASjeeHPdophgUHMupvELW+Nx0nqARsJBbTsiupwhLKYNzhR28o4lzeoYTgJocoCu/s3HekVmvp1xBq4nQeiaEBmLGsNLkJgieeetJqC/n35kTMWFptSNDorCAGHFsBdUO7uVG3cAhbbhCQgQFcrBUn7fH0RImNESBDWQqjH24FqBC1Mf/FHPMNtfujsdWjI8oTnaE7LUVH6crv1kwG7a6cAvplmLKNUYwXZNzD9oHJGAGWa6Pgjz0lXmdXlHgvp+T4iF5kjgrxGyBROp+2Ms28K3RelJuu121ZR7Ktl0yNsGA/eoLrWReiSPoc+WJj2H2gMMbAKBpPwpLa1yR/mfdOZR1RPd/7NQSYKpU5jB1q7GBJ32REe9AAPbtdBnEJLm49Qcx/Cz8776xIGIzsdVCieRa6eDLYgSuFo2wtXOG7qYmtAcUgvY20bRHkTfnempg3rjRYTGw4HUP/fAt0LNeTKf5flFRFVgx7nlYvSX0B84nF9AQqhCv0IC5rrqJDYFrY2vvNN0JFwZZgaQfz8wf6qJJLYotAm0taYpl+9+2eOACalETK2F9CknDh7Z5uHIVy3JWQW3YnkWteIaovaWVca3PMxPrKE2jDhTFOK6aycUK1Vz8G5c0i8CLpGsNDA2tpTewgf82gWdbN6tAZEiX7+tXKe1z9bTR5AmEAPuVD1MZxi09TtlXxsQa0TNImh5MOZ+dbCiOpgk50A4uTtaRzYWXr4B5MDN XtbnuQBJ lRITHAZ5uQfpFSrjS6W2bsrxNa0rjbVqazG6Sa+yZwjqWYYQ5Ds2FLoqVqu1KnLuTfw9w6cgvIhQwVa8ESjlv0uHB2Mn0IcdMpDpF9xNC92KI2yUecrdAQC6O8ycyNRUkcmwd2soJm99FJbISwWaeKBOUWazRGt4idBu8JNwEzuNpD3m+dQ0lMzvFIcCQwsqlJCgOw1GS5su6qOzz84UQGrPQpCMuXqk96WGxOk2SGOMN2HAdsDMYOQYX8PGsltM3+fgJt9w4cMtcPhll6pI6f43GZdFgGzozlIzfHAzb/BM9yGEfaLgH4COlEK4m6YnCjNCphMRUi+IiwOV338EjCbh4daytgovq/1RErTL/m1RyZr3LqNECS0av5WkwkToX/KLuXF8PDYB8Vmkqza94adaMjUT3U57/O9gcP7m1DqgOMTq1SeuHaBFljC7rHCujdPfZnKcKusx2/Bl/MvWHQwsr+P/gOZAjGaZimibq+vF/fcRxHWIehaTyUBV2TahAnDTZc+cj0zL+oaIYiEoYAU6I0iHiavs7WtcXhSwKRx/II+Z4Dz1ipHOBFg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2023-06-23 at 10:08 +0100, David Howells wrote: > Jakub Kicinski wrote: >=20 > > If we can't reach instant agreement -- > > can you strategically separate out the minimal set of changes required > > to just kill MSG_SENDPAGE_NOTLAST. IMHO it's worth getting that into > > 6.5. >=20 > Paolo Abeni wrote: >=20 > > Given all the above, and the late stage of the current devel cycle, > > would you consider slicing down this series to just kill > > MSG_SENDPAGE_NOTLAST, as Jakub suggested? >=20 > I could do that. >=20 > There is also another alternative. I could just push the sendpage wrappe= rs up > the stack into the higher-level callers. Basically this: >=20 > int udp_sendpage(struct sock *sk, struct page *page, int offset, > =09=09 size_t size, int flags) > { > =09struct bio_vec bvec; > =09struct msghdr msg =3D { .msg_flags =3D flags | MSG_SPLICE_PAGES }; >=20 > =09if (flags & MSG_SENDPAGE_NOTLAST) > =09=09msg.msg_flags |=3D MSG_MORE; >=20 > =09bvec_set_page(&bvec, page, size, offset); > =09iov_iter_bvec(&msg.msg_iter, ITER_SOURCE, &bvec, 1, size); > =09return udp_sendmsg(sk, &msg, size); > } >=20 > and kill off sendpage and MSG_SENDPAGE_NOTLAST. I'm unsure I follow the above ?!? I *thought* sendpage could be killed even without patch 1/18 and 2/18, leaving some patches in this series unmodified, and mangling those explicitly leveraging 1/18 to use multiple sendmsg()s with different flags? I haven't tried to code the above, but my wild guess/hope is that the delta should be doable - ideally less then the other option. Introducing slab support should still be possible later, with hopefully less work. Cheers, Paolo