From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD9AC001DF for ; Sun, 23 Jul 2023 12:27:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6F166B0075; Sun, 23 Jul 2023 08:27:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1E396B0078; Sun, 23 Jul 2023 08:27:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9982B6B007B; Sun, 23 Jul 2023 08:27:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7F9286B0075 for ; Sun, 23 Jul 2023 08:27:13 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 457DF1206DC for ; Sun, 23 Jul 2023 12:27:13 +0000 (UTC) X-FDA: 81042801546.12.D8CEFF3 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf20.hostedemail.com (Postfix) with ESMTP id 590281C0003 for ; Sun, 23 Jul 2023 12:27:07 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=kQdCaHu6; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf20.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690115230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OYBTJMmbWeXVKKODXiLEP8FQlKlDh8TNFJoQixab028=; b=dCze2pSem9j2dv0csA6tkX4tVLgnnGV9nIydkFT+hsRLCfuc8dwIw8nIF1MNWGtec53Tk0 rJURIPDYe9q/4GKgpRvNjTF+1Vwj3EZsXnXuMg5Vg6tIwvhK4bCA3udwqqwLgAy/cJk581 PM3wFrAje3Pc7NfsN7MXyfFFwNc9buA= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1690115230; a=rsa-sha256; cv=fail; b=n0/sZCercpj+YSKfc1gwL/wNvYGpz0qT4uVrrpgnenRPVKvy31ToTuP7JfAEHMtC3my1OO cUtzlIMPDVkPctz1XGyiGDR8EwMEPiiqWkWqoHhRnq0q5Rfpr00zgGYYpgOPShst086Buu 07A6Lsaf5fynHu6wJzNHdYbyg2jn0Is= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=kQdCaHu6; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf20.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690115228; x=1721651228; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=SQ23Y4RUZ89n/pI1nQ+w4ON0Ls9C52iyCmcof938pvs=; b=kQdCaHu62tpoM2W14OlB3h10SNjysIMyb9QypCbgVCUU2CEpt+dMNOiw FzqVKCOfjI4tG5M799+8XRzexMM/w1RKmh8A9/GliCs5+G/Ium/xM66V2 Xx0Tz6mG2jx7HAupZKD4xCy6ihkdUJQJjElaZMmjY9e4qhweQ3+T30TON WnewxX425fqgL6nDPmikwVKOd7aVbyKdbkeNOv8hf8G69oAdNqa74B3AE G9/Jio9mhrtKGNz6AmqcHWLMdjIo86NjGWZXs48xto5mrHdl8dVm7gj7Y 4OhbkpZT/eNUVcT+Fi1s/wyuboaFzmWeo3l7gfe6i36DkU1QzQ8Ez5yBX Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="352169646" X-IronPort-AV: E=Sophos;i="6.01,226,1684825200"; d="scan'208";a="352169646" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2023 05:27:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="725406491" X-IronPort-AV: E=Sophos;i="6.01,226,1684825200"; d="scan'208";a="725406491" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 23 Jul 2023 05:27:05 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sun, 23 Jul 2023 05:27:05 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Sun, 23 Jul 2023 05:27:05 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Sun, 23 Jul 2023 05:27:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SaW884nHdCiUTn1JJT/uFAKkeNqwRZueSV8uwkVZQWx3SiBY96rAsXklRSEEpQ3/uOvdF/zV3K7hkEx45Y3zDIouSLWmcFyEo+QF9O55olAdGv/W9VBEet1jHZkIomF/8QJDGVNzptYR6rDhMOzAZz5U+XLCRSMSjjV72iBqcEvV4X1Vjv6JuT2+Q/QJnKeXqJgSmTs6/o3o3EvxDYan/NEXwvFxKrafBViRijKEIdEXA2kBLUIQ/26GPOuu7b891ikUcy6nxjOSfQ25KRFpVUdwto0AKbSX1T04n+U7WVCZNWq+ab8p6J1UsAucSHoIL4D0A+JIYpgOeMxThJ9fsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OYBTJMmbWeXVKKODXiLEP8FQlKlDh8TNFJoQixab028=; b=gRQpGpf52D4o1CUuCA9QOFewbZzGBFxhl1kB+i+8SBDi2lm7r6NaxgeFj6kPA2XhDzKepACQhcZyjBmLoBMHIBGueyphX4sAIm73Y83etQd1PLd+Un/gGjGqMxT3ugFZ8cGgfvr70UuW1KqqNH94ffVzNQy4xqjSUwUmtI1E9Z4AOPkOZ038J/boDFwSnMHxbifB2cZmlUAW5Cj5P9ShI/oQcQY7UzPrSUZlzMFft5voZ0HToFEhWkeCQrywbk3TGVgBfN5BijsXNaMp8ZSv+anoJEU516xIxdTRkEFrZ0+4Olskqb+97Cl21M+TJ3T9aLf8tneLTOE0CbKsRqwN2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by CO1PR11MB4964.namprd11.prod.outlook.com (2603:10b6:303:9e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.31; Sun, 23 Jul 2023 12:26:58 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::f4df:c85c:6300:880e]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::f4df:c85c:6300:880e%5]) with mapi id 15.20.6609.031; Sun, 23 Jul 2023 12:26:57 +0000 Message-ID: Date: Sun, 23 Jul 2023 20:26:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v2 1/4] madvise: not use mapcount() against large folio for sharing check To: Yu Zhao CC: , , , , , , , References: <20230721094043.2506691-1-fengwei.yin@intel.com> <20230721094043.2506691-2-fengwei.yin@intel.com> Content-Language: en-US From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SGXP274CA0015.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::27) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|CO1PR11MB4964:EE_ X-MS-Office365-Filtering-Correlation-Id: 9117e471-a6ae-432c-e456-08db8b781b67 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 84XwFFdHHomm3huIC67jGqClNUfEdFex1BzMJgUTEVUj0XbnY9SgHmdRHqB0aqqalh6nCRACYCBD6bat2cfT+tiDiWZTw33bVvoHNO3KVRFn+qJp6iUydOjrMuUg7VE2f61esUUQ+p0mxhG6L/yfaMOLlNjZeQ/ceSRzIPMWW3KiLs6e6CSRPHqGgBVTAv76OTd4ul2VEejhxR+I1k0W+Zd0apz/IhBYnmOMGzqeyoZktsN7w+VwP3Qk+JtgM0Y2r4ErCiUw8ZJnFys9XX/xnLv2W9RvmzCr3mio2rng7JE+Fdgadf9RpsukjUcdLuMgWwlXvMd7QmzNt+8ABDn2fqfEP3FH2am3yBCG8SQJkoQI9PmyK8tiIGKq5RwMQdjrYDJssbFaIyfpsjvHxB9CRSb3m7k3zPFyJpmwv9UnTp0ZQAak0BFFshq4UBiZqlMNX4UjaG3qeaUE3+bVkAsB9E2c4BasJfopk/vo5vRMpq3zCrMH6wDAlcsdv69aCQu9bOPidXz6SWBjD6LkOtPDVriFc16PMdrCJi9knuBljrH4ImNgfb1KX5Q5ytSVbgeGwpUJUm1yaT/35Zav4k1YbLLlIgsEqluWK7LCqEDO5/YLCrdi1oCx2mGlyx2C3gNO4ODNN161+gIWM5dWAxh/5A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(376002)(396003)(39860400002)(366004)(451199021)(83380400001)(38100700002)(36756003)(86362001)(31696002)(82960400001)(2906002)(478600001)(26005)(186003)(6506007)(6666004)(6512007)(6486002)(31686004)(5660300002)(8676002)(8936002)(316002)(41300700001)(66476007)(66946007)(66556008)(6916009)(4326008)(53546011)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nzg2Q3h3L2hhckpuYWczelYvSTJKcWg0VnB6VVh3K0N2VU8rR253TmV4Wm1j?= =?utf-8?B?RGpnbFkybFhmL0UxNDJoZFlOKzFFenh5bW5rK2FUUWVxamsxSlRQRnpzcmZz?= =?utf-8?B?T2dKYW9obklvSGFSYkpPK3RqOStZcW9oWTk3Y0pvYkRDdFJFOE4xNjg1UCta?= =?utf-8?B?N0g5eHU0V2YvSEgyaENjdEk4Z29sTzFyZW1rRmxWcXBTSDdGV2c4d3FFdmVm?= =?utf-8?B?R09GZjJWdDlMWW9NMUNIeGQ2MTV1cVNVNHkzbzV5RGEyKzVnUHZ1WTk5WXEr?= =?utf-8?B?SFhYSnJyclQzamZpMkNRcXREQXFFM05BVmpVd0FJbXFWWnlJOGN2bnpsRk9H?= =?utf-8?B?REQwdmpVazVBbTBFMFV4dksxdFc3U3Y5N1k2eFdEVkF6dndBbTFwczJnQjFR?= =?utf-8?B?Z0JsV25kbVprZm55aDNVRTZDd0JkY2JSeW01ZTlzRVBkdkd4L3N2WWc0NjNz?= =?utf-8?B?T0h0bTMrNjBRNGlvM3hjQWV6bkdxTExlcElZcWMvb0o0V01Jc1IzRENvNHBI?= =?utf-8?B?cWV0bHdTcG5kQXpxTjVRZDJQanVPOW1VcDQwVHZHR29laTI1bm1tMHBLaU1S?= =?utf-8?B?QStIZWdqWVZnVjdMek1LZ1hVQmRJemhZUmhZclh1cjF0KzVOUHNyUWZhLzh4?= =?utf-8?B?ZnB1VGExK0ZWMVUxL042dXZ2ZGF5Q3RyWVpuQmhHL2cxME5nVHpGMW1NZSto?= =?utf-8?B?Z1ZVenBRdG9VNkVoRUtIc2JvM2ZpY0FZamgrQmszYVBUYnZiL2Y3cWFWODNJ?= =?utf-8?B?aXhWMmIzbEt1NHVCMGl6MTVwTTFNSUZxSUI4OUNFM0tnVk13N0o3R3dhYWtj?= =?utf-8?B?anY1UEoyZjR2V3FIeDZqaWNoRUlmR2JnazQ5RUh4a3JKb3R3UUVMYzhpS000?= =?utf-8?B?cG0rMTNEanJMZ3VnYWRIV2lDdmd6MGxPT3J5SW11OEJhVEtVRkZUOGtBR0xS?= =?utf-8?B?Q0ZVWUpoYmRXNnJQWVIzL2NMVlRxdGVqaXA4Sm5sUVEyanF2bGtvYVRWWEpr?= =?utf-8?B?MzZVUDBoNFVrVVNPQU9XcHBqNlh2SmZwY2g4aTFGaEZHaERveGRhQ1VMQmhj?= =?utf-8?B?cElOS2NhSlF2bWsrQkJROWtGSmZMQ3dUb0lUdHUyMXVkWDJCM1Q3K2J6SUVv?= =?utf-8?B?bkJleVc1Z3Z0bGJTU0Rlem15K05SZnF1QU1iR1plQWJFcVBRY08yZDhBUEVX?= =?utf-8?B?T3hIWGNDMVRvUU9icExJQTNUUWVrS05QZ2FCTUtGUGdQdXBRMzZ4V0pCQktw?= =?utf-8?B?eW1ZN2dIU0lONDJrY21JUDh3RFJPN2RRYk1DWTRDUy9ERlZYUVllS0xGUmxK?= =?utf-8?B?VXRqNzVFQ3JJMkNiQkkyWXpsSmxDaGlaMW5CaEZFNy9kQ2FxSWxqdXhDNE9L?= =?utf-8?B?S0Q1MUhSbnFWa0x3V0hUNVNuQnlWMlh6RkdSaEpBTEtuNWk3SVl2OVkxSm5q?= =?utf-8?B?bVhBTEtGNkVLaUFiSHF2Sm9qNGE3VHBGVlp3dXRGakNibmRDQ0ZUcERMdGl0?= =?utf-8?B?SlN1cHVNdXEzWDFaMUNXNTlzejcrZnRxYmpZRFBUQlgyL0J5Q1JjRGh2aUZo?= =?utf-8?B?VGc5NVMrdGVWbFowSjZGblkzWlNEaExQMm40RUhkcEhCTmphV1c5a2RST0xG?= =?utf-8?B?bDFESTRjNDRYNUhWaGwvekxsbVZqdzh2VHZSeG93UDcwMGR1VFFhS2xhaU14?= =?utf-8?B?U3lycnJCVEE3dEFDYVBOcm9kUHVxd2sveXJoemNma2hlM09UOU11SVBhb1Qr?= =?utf-8?B?bnVVdFdGR1V2N3kxdkZMYkRIUTdOakZnK1BvQ3VrS3YxN0NWaXh0bkUvbXJZ?= =?utf-8?B?V0JSZmNVRlhEU0cyR1ozZlVqb0JpMlgwYWtvbUpFNU4xNTdSRDMrdVl1RENa?= =?utf-8?B?VGZWczk5d05kdlVqa0xoclRUdzZsY0N5VCtxdXVXZnd6WGJsanlPUkFQL1lz?= =?utf-8?B?dTBvVXd1d0FMNGZZSUhrSU5YUUpzaklNbjdRVVhlcmlOYkkxemlRcGQzeHEz?= =?utf-8?B?UmIrMEFnN0VrRlc1YjRtVzA0UXVqZzNKbStOS0dWMWo3OENXdWU4ak5YYWVO?= =?utf-8?B?UENSdVZ5djRPZkVoeTBPWDJyRDNFQlFteXUydUpSQjQxWktlbVljYWdXdkN4?= =?utf-8?Q?DPasA/xC4W0SgmVf159exRh9e?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9117e471-a6ae-432c-e456-08db8b781b67 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2023 12:26:57.9010 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: upUNbOqwTar3mqdocH68hU5YkZlg7pqUpKCQ1YtgeLwuvc15pgrqlGwnQDqXSJNdUJAi+JmlwmguCEvFhNq30g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4964 X-OriginatorOrg: intel.com X-Stat-Signature: 1ga8qraf1in78168g4qziizh5mtec3dk X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 590281C0003 X-Rspam-User: X-HE-Tag: 1690115227-368337 X-HE-Meta: U2FsdGVkX1+zct6YfXiqwaW48HBboxEh4Nfa091MCspEEd+BqMMsdHGTKu9ei6cPg6XbTjQYz0mPPXecOUjDGFjEsSozZn6PES3nD7CiZG+yp0pu90OI+s6WDXRSvb9pnqlNPLPEvj9WRVJn3YCLYPtNtPL8WdgMV7BitNEHBGr3R2iOiRtpxqRvS7VvCX7oYvcfzTRBPFmikpaJiep4kTioA2BCxbMTwbDZH3uf/B8c7TZpkV5n4KvkgCM/KrBvtScLvwPQDMvb5Bdz/J3CXKmXuW3vXBF3fmavjcKkQFPEevkIbO79x/UPvdPVVjd0vcSN+re37nIF2n8RftBlY6B+8f9NRkpHYBAKtHS5m4NuQjTuCAEXp8H3Xg8EwgFrYTbyNy6lemwEDIFPcrHHEZT/EnrzDhPml/flzhU0LGFzqZ6WJQZan5eRxyzIiMdokFk/Ul4s/EMRdQr7RJQFPUCBFoHkgXsxNhR7EWysGTUltaH5QWEnW9bS4HQit4FPBZSmEXi1/u0robDWhd66jCEQZhymx/LRgWucYAngjjtLJVZPCsyfJoA51nGtM78Zw2RJFQ0AoEgrqyWdBniVsKsehgrGQwcDcfY+9XYOB+BxIp6srIATatwlaCuwDg5SnBXASjpERwLAKHjhEBfbzDZItqKAWOnjoHWGoQjWc5MOo90i7hQ1q7QK8IKVRnZ7U/VAQHIj05fLzq7Mlif+RAYr1ZWU9FTvcHpnQCgnYErtPY+yFexT6KO3emaQ5TfSVOA9cJyyZK56Xm3dHflW/XQpG/xk7J1hmOhzBuDSGcF+a28HZWufFFNprVKFkAPlYYx1XC3PkJ9LdQs8XPQU2dMc2LZEAVQE6FAfxgmdHctj2Cjw6O6wBjEWwCKwAK9o4zRm3eEf07JJUthuML7XXeUfV9oo97DqkaOgTyKFsxUhlrv86gbh71bM6TFVSViS/RUuooP2+3mx5wiUMId JpV871V5 9R9e7V1F2FNyRId9gJchpHQzSys/L4ZYGOSpSFDczl42yPDX2SMsJVgpi9SpbTRbPTY8of1PY4rr/SLQHN8BqlYmtChKriaZ3JXCCU93MqV/RMbUrT0x59BqFSSOKLOjTZNoQ7mHjU9RH/yWiIjap1JE/lvWXLBjAJrgzHiWpiTA1/dbxoGOsLsSOQr3k9b6T2ff2wSxB4caBx8/ZRDKT0WjAk/3stnJnQ/+EBpOVpcXsXUw2BjSnDVb3Cw5QV0fwG+SHloe7gJEMehCjN/5bZ+BQTIPaMMpGJO9XJ2d9fWvMfRVOySxwhIZTifyy9NKog1JoQ6UGMR6Am3I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/22/2023 2:57 AM, Yu Zhao wrote: > On Fri, Jul 21, 2023 at 3:41 AM Yin Fengwei wrote: >> >> The commit >> 07e8c82b5eff ("madvise: convert madvise_cold_or_pageout_pte_range() to >> use folios") replaced the page_mapcount() with folio_mapcount() to >> check whether the folio is shared by other mapping. >> >> But it's not correct for large folio. folio_mapcount() returns the >> total mapcount of large folio which is not suitable to detect whether >> the folio is shared. >> >> Use folio_estimated_sharers() which returns a estimated number of >> shares. That means it's not 100% correct. But it should be OK for >> madvise case here. >> >> Signed-off-by: Yin Fengwei > > Fixes: > Cc: stable OK > >> @@ -383,7 +383,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, >> folio = pfn_folio(pmd_pfn(orig_pmd)); >> >> /* Do not interfere with other mappings of this folio */ >> - if (folio_mapcount(folio) != 1) >> + if (folio_estimated_sharers(folio) != 1) > > Strictly speaking, this isn't a bug. But it may be ok to include it in > the same patch. OK. I will drop the change for pmd. > >> goto huge_unlock; >> >> if (pageout_anon_only_filter && !folio_test_anon(folio)) >> @@ -459,7 +459,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, >> if (folio_test_large(folio)) { >> int err; >> >> - if (folio_mapcount(folio) != 1) >> + if (folio_estimated_sharers(folio) != 1) >> break; >> if (pageout_anon_only_filter && !folio_test_anon(folio)) >> break; >> @@ -682,7 +682,7 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, > > What about madvise_free_huge_pmd()? Should it be changed as well so > that it's consistent with the first change? Either change both or neither. > >> if (folio_test_large(folio)) { >> int err; >> >> - if (folio_mapcount(folio) != 1) >> + if (folio_estimated_sharers(folio) != 1) > > This is another bug fix and should be in a separate patch. OK. Will split to two patches. > >> break; >> if (!folio_trylock(folio)) >> break; > > Please send two separate fixes, and then: > > Reviewed-by: Yu Zhao Thanks a lot. I will drop the mapcount() change for pmd and sent to patches for madvise_cold_or_pageout_pte_range() and madvise_free_pte_range(). Regards Yin, Fengwei