From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3E5BC4332F for ; Thu, 15 Dec 2022 05:09:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3172E8E0003; Thu, 15 Dec 2022 00:09:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C7608E0002; Thu, 15 Dec 2022 00:09:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11A8E8E0003; Thu, 15 Dec 2022 00:09:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 012CB8E0002 for ; Thu, 15 Dec 2022 00:09:56 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BDB7A80B87 for ; Thu, 15 Dec 2022 05:09:56 +0000 (UTC) X-FDA: 80243363592.14.E51F1DC Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf05.hostedemail.com (Postfix) with ESMTP id A3C94100006 for ; Thu, 15 Dec 2022 05:09:52 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b="S5pMz/np"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=i5oej3VU; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf05.hostedemail.com: domain of sidhartha.kumar@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=sidhartha.kumar@oracle.com; dmarc=pass (policy=none) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671080992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oEwYtMKDimt2ISHRitHvShJugNcXu7ILukZqBTqnX5I=; b=mweMmClI9wrH4+8Zh935qvP3LiR2SCqPfDV9HH/VlOH4+C4kJt+0Q9e3mRza//ToFqupoC rxLBqbwxJ7bZjs4gXYZm9Ao5kTIShmi8jQjUsbJrsnD1CUyzHKJEUegwjVMfWAKgA/bEoQ ANyPtyCEycPMTVEF92wog7JLNXDcQEM= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b="S5pMz/np"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=i5oej3VU; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf05.hostedemail.com: domain of sidhartha.kumar@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=sidhartha.kumar@oracle.com; dmarc=pass (policy=none) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1671080992; a=rsa-sha256; cv=pass; b=be5qn2n5doGjEVwXy1RebdhxKtkzBvAIfI6mBTm0m3rDnsEKh0boXa/NC87PodfaCIQv2G Cbm3tdlDuIn/BA1+o5ylALt9eIuN2T+9/rUBeDOrFLLDSLEshY0KroGJo0eVf2FFuTruuT UKjD53OBrIjQpqR6dg4znourdV7qrYM= Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BF2NeeR006971; Thu, 15 Dec 2022 05:09:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=oEwYtMKDimt2ISHRitHvShJugNcXu7ILukZqBTqnX5I=; b=S5pMz/npa4lgzAKNj0OGIbI9/3DNyGkUQeXYUExk9Qm14CE1lbkFGjIo3Rtf3+mSGW61 U5Zr0aaiLLr8H18rmBUsG7dDEZjI/ogP8/FUSdFcZbiBOh9jJGuHjKxDDQC5kRVbEFUa IZ59o2i3GA4DAV3trMpBFrWIBod0KgLhBbg9QqiVVmarkzEHWpG1z70aFfI016rymHCs 0vIYb+lgGyStlZ+qtIWtlnxYgkviI1xJqY/L2GNCfYbs90tfnXy4wBPmnFHKr2goGS22 kcstR95v8LAlxwJ8qj8TISMVuPqvaDbuwFQ2wma+j4zzHFga2waLsFkdM0Mrz7mOHTSm Pw== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3meyeuc35s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Dec 2022 05:09:49 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2BF47aJE003969; Thu, 15 Dec 2022 05:09:48 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2169.outbound.protection.outlook.com [104.47.56.169]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3meyex3wpe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Dec 2022 05:09:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZQmr1ydfHNY/wZLL63GFvpfIYK67sq3tVGtnUPL+QJ7Bw19W4ohFH4U/uoU1X6Kbje/1Llm/PpolyVBNS0+fq0TtHPqfdmQIx2O/TzzyW6IzOOpXqhKHO9PzkMtLLBYHku4fcsjpOBCFkvxGfMNVzNFp8DODz73HuaS3aOsgw0jEz2Gl+5aaGj3CYzbAFumiOGJUDP3X5o2Ove5CqskSZfoX93fIV5c3DHsREcR/XxqUgB0xNejHNyGt88fN8H7k66pWcw/hr/vnyeqQHoWXuiAbIQ7dgQ5x5sb+gOLzCG2/zxvSondLJ2z8QB7j73t9nMfA/4OXz+k0e+nODGqd1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oEwYtMKDimt2ISHRitHvShJugNcXu7ILukZqBTqnX5I=; b=cn+MYYDzu6x8IYEag1sI43aFW/BiHN2b00sEiap6oj7OyaQ+W5PBpfrhBCJ23sBpilJGJ/tm68Zk4+bGB+GVZuTGPjc/2PN0FmMQZZ63O+xcAu7EeEcQU+ZNTV4VApl1dDXM7uGYTlOVQtLXcRdFN21p3osXySX0sWmuMvHH6xBy3jWAFCI9ATTy880MfT/IBmLen2kOHsJ3TjZ+9PX091mdTSWFx2nuz03XXnQTubSF8GhOmb0L4PWroYtI3fJ8/kBKDO6Pm4vQmVzVHmecYP8a3l5B4bv7gcEBx7hFoWsQRKcqZ/6qDIK3RTM4I3jvAjY9zrDj8smBKDkpxGMpDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oEwYtMKDimt2ISHRitHvShJugNcXu7ILukZqBTqnX5I=; b=i5oej3VU1rwx6CY1yzS4/CYDFTSU8UP1ynp+TL5cLx5CFhxdL9M4GT1/4ni5pUdx/EDJV5Q1oM29y5bIqzNA73TwsfRQaH8riO0Dk+sijv/5M4kMAwDVZh+/h2U0EvlZi3fMp7G2NCwGPV4kG6Q9ecC9gKfVJt91U59px4IYIPY= Received: from CH0PR10MB5113.namprd10.prod.outlook.com (2603:10b6:610:c9::8) by CO1PR10MB4577.namprd10.prod.outlook.com (2603:10b6:303:97::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Thu, 15 Dec 2022 05:09:46 +0000 Received: from CH0PR10MB5113.namprd10.prod.outlook.com ([fe80::51be:1301:5ec3:996f]) by CH0PR10MB5113.namprd10.prod.outlook.com ([fe80::51be:1301:5ec3:996f%5]) with mapi id 15.20.5924.012; Thu, 15 Dec 2022 05:09:45 +0000 Message-ID: Date: Wed, 14 Dec 2022 21:09:43 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH mm-unstable] mm: move folio_set_compound_order() to mm/internal.h Content-Language: en-US To: Muchun Song Cc: linux-kernel@vger.kernel.org, Linux Memory Management List , Andrew Morton , Muchun Song , Mike Kravetz , Matthew Wilcox , John Hubbard References: <20221213212053.106058-1-sidhartha.kumar@oracle.com> <0B650D64-1F64-4695-9365-CF695029C50C@linux.dev> From: Sidhartha Kumar In-Reply-To: <0B650D64-1F64-4695-9365-CF695029C50C@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR13CA0090.namprd13.prod.outlook.com (2603:10b6:a03:2c4::35) To CH0PR10MB5113.namprd10.prod.outlook.com (2603:10b6:610:c9::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH0PR10MB5113:EE_|CO1PR10MB4577:EE_ X-MS-Office365-Filtering-Correlation-Id: 6977345f-6e41-4702-d495-08dade5a9523 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z7kYZgJUHPN0e93/h8ELBF+UYcy9tv6KlZk49WW9sEBVuKnGlDr5J6awMuv6rQl2pWucBePj3T+NW0TSyUotWmUgQo+OhgWr8sviUYeFimtOsaxrGuu0x0A4NCP8iFsgkXRGCHjftKqWu3SROFzg0tJdHgNnNBtNXMa7wDM+qqp3fsZ8tPzaXw3+AKIVzr8HlSB1OdnVe2iSSaJUB/J0MnIPylXZWTwHYP+OKwcSv5bYhN7uUTcCxcacJ3PZ3egSEYD5YeZ8aJrZqsFzWO1gpUZt3PLEJF1fAihpcJxpWfo/b2oE98jzyOeZTTVNpzaEPHRNonVwKwfkDtmlcRgriPV8sQ55typd0cycbuNAhQUuro7r024ILkrF34mPYRzMEI/2pdcCyfjPYG4j5R1N647fFvgzA5PGCtPmx6btoQmoL0txWNeDGCx+U2eLwY8ETrrIVPQjj4icv376rqVc1BZxXI2CVWIBBWe2WzYJlbMtT4PCZ4jURoGnvkfy9mx8bw8yHbX8RK7qzr7aLXajh8jns/qZPH3PRh+22vEVBPqXc+4qBCftxEKLVtG8X/1cwP3HKWmE8Gydv+f63K29uBplbwSKWmY3wmDPIFSsdL30+7EkOCAD5XhG7VzmMpHip2sDam1oJz3fh7zsFzv8wUXZyH+ily39iuNTWEZn5L+vIwy1JZnTj9PFoEtf49JCyYCNQkfXGFNYP2DQTcOWdGDU1E3Z97SkKEciatGqPp9O9TiQgeWkFnkcMZIBFfh/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH0PR10MB5113.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(366004)(136003)(39860400002)(376002)(451199015)(478600001)(31686004)(6486002)(26005)(966005)(186003)(6506007)(53546011)(6512007)(316002)(5660300002)(2906002)(83380400001)(54906003)(36756003)(66946007)(66476007)(4326008)(8676002)(2616005)(6916009)(66556008)(86362001)(44832011)(31696002)(8936002)(41300700001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUwzdjROOXM1UmdqbVJ4amcyVzZKd3ZlMnF2NVJVbkVJVE8vckM4NFZOQkZz?= =?utf-8?B?WUlaOFZwY043L0lHL0ZEbkNnK1lkd3dRQlc5SjdBNTVVcGpjMjRQNjFyeDRL?= =?utf-8?B?QW82VVZtd1pRdlZGMEN5ZDhFRm9zZXRtdE9FWkZXVk1MNDJzMnlMWjMrUVM4?= =?utf-8?B?RXd0ZGZsVnpXSnROenJXZnBPU3ZSRU5mb3h2c0hUQjVuVENMeDhpYytoQlBk?= =?utf-8?B?elFaeXZCbWlvWjFsU2JZck5ZK29VWmRaNmJ6bEpPb3ZjeWhVSzhuOTZhUmRn?= =?utf-8?B?N2p3Nm5GT0E2UHZjRDlDUWJLbERhL2g0NjVpVGVaT1UwbUZMQTYyei9DWnps?= =?utf-8?B?MmhoUUYwQVJod0JYdzViZFBZM2JjbC91Z3d1SXpYT1lqNlR2VFRQVVBSTWxY?= =?utf-8?B?VFFjVFNad0gwYVlwU01LN0dzb0pUL1RUL1kraFc3OFlUU2dqSGNENzlYb3dw?= =?utf-8?B?c2JxZUQwSmNjbmNzYkd1OU9CbW1vSGRvait0aUo5eFgzRDMzSGh6dTg5Q01i?= =?utf-8?B?SE1LaUVjZGlENkpqY3pIcVBsVVNaYTRXRUhINSsvbDZ0WFA4TXBQSHA0d1k0?= =?utf-8?B?QlJTNnlCTndkZjdJWEtIM1NlNjhObXlGWmNMK0Nwb1VKbmQzZWp3N1N2UUdO?= =?utf-8?B?cnFnTFFWK2pDZm1wOCthaXFCQndZMVRwS0tlcEZ6dlNWbi9CM0JMTk4zYlEw?= =?utf-8?B?WExQY3VjTXNEc0wyOER6MCtad290VGNxR3MrdXhZMmtDYlZ4aWd4eWxPS0N2?= =?utf-8?B?SjBOcWNWcTNtV1BaV1pNNmlkMno4UEM5WWhjRFVUWTZ0cm9lQ21rZmZQdGYv?= =?utf-8?B?UHdNSjZtSExyYmRKa0dxVmxnQkc2WkFYVm9wNEwySWhZTVhEdDRPbVkvQTUy?= =?utf-8?B?YkNQVFdINFFxeEh0cldjT0pSTmpwSGd5ekZnM2J3dW1kZ01VZnRSWXpORDlx?= =?utf-8?B?ckxJd1ZDbW1JeTFuUXBxUlpIMkkvSDQ4WHJmQmxPWjBiVUdjeGlzN3VKT0V4?= =?utf-8?B?ZlEyTVZ6VGM4bkh2ZjhFNjMxVThQK20xMnVrL25HL1dXdWQ1WDlKdzJ4d1N1?= =?utf-8?B?eTdNVFZLZGtZNmtZbVdZd3FWekxJZTZ2VVd4WGhhRkQwNlFwZElrQXJpN0dX?= =?utf-8?B?c2N5ejZuVHlDc04yMG9YeE5PRndHYVFBUEFjYUNnYmtTeW9KTGdxQy9ZZHFi?= =?utf-8?B?bnhNTG9ON3R5dXpVbC9tN0wxKy9KVnBWOXlaaTN0QTBQWkJDNDVpNDZXUEpU?= =?utf-8?B?djljZ1YremQ5QTl1VmdqNXRBZ2tCbVFFNHZ3MXoxV2xkQm0vOVVsY0toWDZi?= =?utf-8?B?UWRMWDRPOStkcCtvZTJYd09IdVc2TlNuVHRNdXZKc3dLaUlkQ0JmNDlJVUY4?= =?utf-8?B?aDByS205Unc1Vjh0dWJ1TmhFQituRmZRSHZadS9vbHRzV0R0aWx4aFQrTFAv?= =?utf-8?B?UHlpbDJYaVhRMmtJbWVIaW9FWFEzZTFnUDRVL3NsamoyU0dQNi9vVk0rTGZW?= =?utf-8?B?RGNiY0NpbVJIYmRmV1cwUHVFOFBGTWFYZnAwNldMSjNBTUMva2N0cGE1NUdE?= =?utf-8?B?L1RXaUNxUWpMODdNeGxqa0EzSlJVZnhMQkpqZzkzSEEwOWp0QlA0anVDSWh3?= =?utf-8?B?ZnEwTUUvUWNJdFFpd3prYlZzZEp1NXY3RXpaMDUrcGNUUkgweUlwMmY0a3I3?= =?utf-8?B?bU9aVktjTE51amQ5TWQ2OWUzb3R4aFY1NndvMUdSVDhSUkFBSENXWDFOeWJy?= =?utf-8?B?b3JJcjhpbHI4SVVUbWpGeVBtdHNxMzk0TE1vRGt0UWtDOU9kV3J5N1RWdm5a?= =?utf-8?B?eXdQWHBKYllkOGJxNlBWdDlNbGlvaTF1bDNyZkx3d1hlWUJhYVRMTVl3eHlE?= =?utf-8?B?cVgyeU1hVmFjUVgvN0trS2ljVDFVZDZWQ2tvSVJVd1BLdUhmZ3puZ0JuOEox?= =?utf-8?B?YnlMbXdtMzBRaFNxNm1CRjlzTlVMZXN1Q2NJcXJuNlVDNEcvMUVnVFN0Y25W?= =?utf-8?B?ZjRuWWNjSHJpc0RUbUU2ZmFEZWdFdHlnWFZ6eE5iMDRrdlVlOTJjRHVPcWZv?= =?utf-8?B?czlKckxxdGFZK1Z5RDVjbHZ6SXBuWENDVWZPM2hTMnFyUFJLUmhwVnQ5UjFR?= =?utf-8?B?R0cyZmFHUmJSZ000NDNISTJ6aXdtS0hyZnovQWNab0tzS0lSRXd0a0VMd3Bw?= =?utf-8?B?UWc9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6977345f-6e41-4702-d495-08dade5a9523 X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5113.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2022 05:09:45.9090 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R+jXPBBmdn2qcE3Z/9j5JUxQOnbyb/MNNsS8GMInsYybcbq+WSvtO8gKVhPpgBr4ljpGBUgkLH8WEJkb5c1C+EorCSdHQ5dmvfraDYn/wS8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4577 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-15_02,2022-12-14_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212150038 X-Proofpoint-ORIG-GUID: xQmarWAnti3irWrWTyHXMaRg3XCR1MLY X-Proofpoint-GUID: xQmarWAnti3irWrWTyHXMaRg3XCR1MLY X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A3C94100006 X-Stat-Signature: 7na95ogtosqpfkqrxkxid8oz66p787ey X-Rspam-User: X-HE-Tag: 1671080992-208401 X-HE-Meta: U2FsdGVkX1/sZnlraUzKsrMufHiAifrsI29f4hfFPz6tYkoMPAQEtJCCTxAxevW2D3I9wMl9d2qIL+B+SxVt2xc+oAx2WYw4DMsO+xUtgyIwPOXt5toeuqSNCx0WFedSfuJa6W+dsPLXXMbT+QxXSr74CtpwAKDBWlaLKSUeUHmyaJ4yDzfPZxn9dlxD/JxF3AlYOb7DgsQe6drqMlO6MB9NucY1uyoNQllIcIdCmI2/Mg1BopYjsUyp1iaGNpSK8VRoRAeBhoDws8SgYiDVd9JOXgTmkKMzN9Pr7lTy+Lp1KcC3Ox0bD34k9UTxI+CB9ozr4xvbs8xj7EAECQXzA02kodhsypn6TV4q2o5qHjgtVc+Y8H15bo6AYQ+ymR86IBMkTsw68JrHOc/mN6DdT+0owy6BO8rwDpq6j/hClujaZg6ME4P+hSVtUC/46LJp0Na6aHc9na/lL0H5zYpUEKDlUmT3ELWTiu0boWISmD7KMlWREeTNyaw0KdNo/VD5d5ZI1GeOzfF4A+HWEMxFTIw4i8A63J/nWjxLjTouYP4Ke8nTy3cBGH5Lf3EavMa0aDHgTNi/iRcJKXrSEQYVStPdPrp+5VsDL9KUBxpW66ypNn1UPUuzj+kpPZ0BYHk1HHqlptbv+HuBcBzYk/RX4ZhQ8E+5QMNh6gOELH6lmS/tr5oeH4QT3XNPZQsiqNApi9ulCIunATxmvIZcYjVt2/8uLiDZDHfLgVItu6gT2lLQ2lFr/Sh7OfrdSphP7TCeMerv/OhyFHt2zuH7P8Mpmr73XnNzB294pYQcyvaKTtY6Jm2wvcqn7lzFoNLO90Y0bb8YUhDz7Kj8Vu7Rh9NW374bVT/Bey6eyhH0jye44Kl/YxLr1+soD7Ny3HBrrt555J9JvvTqjaY8n2J6+dynyUxCeV0SZSPHIT26ospTmA0D5/6Z+Nv9vw9zjIYqo5f6VZ5CcmZYz18xZkknDuc cht/vEHL 0bqL6+tPh2DGP3zCQ9QNNWc9rypIloOHo1250OYdmFfFBrwkXL9nUaliZpIePzGzR5fXpkau/MiNxasded4c1jwqNGdOV98OyodvaSA9zyH08Wzs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/14/22 7:44 PM, Muchun Song wrote: > > >> On Dec 14, 2022, at 05:20, Sidhartha Kumar wrote: >> >> folio_set_compound_order() is moved to an mm-internal location so external >> folio users cannot misuse this function. Change the name of the function >> to folio_set_order() and use WARN_ON_ONCE() rather than BUG_ON. Also, >> handle the case if a non-large folio is passed and add clarifying comments >> to the function. >> >> Link: https://lore.kernel.org/lkml/20221207223731.32784-1-sidhartha.kumar@oracle.com/T/ >> Fixes: 9fd330582b2f ("mm: add folio dtor and order setter functions") >> >> Signed-off-by: Sidhartha Kumar >> Suggested-by: Mike Kravetz >> Suggested-by: Muchun Song >> Suggested-by: Matthew Wilcox >> Suggested-by: John Hubbard > > Reviewed-by: Muchun Song Hi Muchun, Does this review include the change from + if (!folio_test_large(folio)) { + WARN_ON_ONCE(order); + return; + } to if (WARN_ON_ONCE(!folio_test_large(folio))) return; discussed in in this thread? Thanks, Sidhartha Kumar > > Thanks.