From: Dev Jain <dev.jain@arm.com>
To: Ryan Roberts <ryan.roberts@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] mm: use ptep_get() instead of directly dereferencing pte_t*
Date: Tue, 11 Mar 2025 11:33:02 +0530 [thread overview]
Message-ID: <cdc19ae8-4b02-44cf-8cfc-4487eea89bca@arm.com> (raw)
In-Reply-To: <20250310140418.1737409-1-ryan.roberts@arm.com>
On 10/03/25 7:34 pm, Ryan Roberts wrote:
> It is best practice for all pte accesses to go via the arch helpers, to
> ensure non-torn values and to allow the arch to intervene where needed
> (contpte for arm64 for example). While in this case it was probably safe
> to directly dereference, let's tidy it up for consistency.
>
> Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
Reviewed-by: Dev Jain <dev.jain@arm.com>
prev parent reply other threads:[~2025-03-11 6:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 14:04 [PATCH v1] mm: use ptep_get() instead of directly dereferencing pte_t* Ryan Roberts
2025-03-10 14:10 ` Lorenzo Stoakes
2025-03-10 15:51 ` Qi Zheng
2025-03-10 16:31 ` Ryan Roberts
2025-03-11 3:14 ` Qi Zheng
2025-03-11 5:28 ` Anshuman Khandual
2025-03-11 6:03 ` Dev Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdc19ae8-4b02-44cf-8cfc-4487eea89bca@arm.com \
--to=dev.jain@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ryan.roberts@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox