From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 794BACE8E67 for ; Thu, 24 Oct 2024 12:10:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED6746B0089; Thu, 24 Oct 2024 08:10:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E87206B008A; Thu, 24 Oct 2024 08:10:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4F6C6B0092; Thu, 24 Oct 2024 08:10:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B52E36B0089 for ; Thu, 24 Oct 2024 08:10:38 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 253B21A12BE for ; Thu, 24 Oct 2024 12:10:05 +0000 (UTC) X-FDA: 82708378410.24.FA7DAEC Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf10.hostedemail.com (Postfix) with ESMTP id 1FDF9C0018 for ; Thu, 24 Oct 2024 12:10:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729771756; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mqC+B6O73OOT94dgWzVNWPkDVHIcXdudHjkBimxXACI=; b=IRnYp1a40fu6g1sEsj1sj+To7I780h6RNADNmF75e8wD/FpWwdSyYyIiasHwjCHE0g4ub1 hNeS0l4BiPBwKZs3gURJJkxliasYBLj0xc7SC4+x/horNwWRlIRvWDZJxPc97LrignUmqX hZB2K0WJphFeCeaGSNr87ag2+fFs/tw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729771756; a=rsa-sha256; cv=none; b=6BN0PK1RPC6s1Im61UNOZ6vraiUrPOmMRPHkmyZbA/XqhAK/nZbj4E2TPBXPaPlV8SA2oY PlzX/PdTaTQX5UlyswYfcFQELRtIcyJ6Q8nRqX1MMUQWPPuwUHbPDb0x7JjMq4316o9FDf r9c5J3m4qi5dN1RrFLiNvUXuK+vfbkk= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BFEB5339; Thu, 24 Oct 2024 05:11:01 -0700 (PDT) Received: from [10.57.88.37] (unknown [10.57.88.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BA3F93F71E; Thu, 24 Oct 2024 05:10:29 -0700 (PDT) Message-ID: Date: Thu, 24 Oct 2024 13:10:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 00/57] Boot-time page size selection for arm64 Content-Language: en-GB To: Petr Tesarik Cc: Thomas Tai , Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Greg Marsden , Ivan Ivanov , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Miroslav Benes , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241017142752.17f2c816@mordecai.tesarici.cz> <20241024134519.18ed4657@mordecai.tesarici.cz> From: Ryan Roberts In-Reply-To: <20241024134519.18ed4657@mordecai.tesarici.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 1FDF9C0018 X-Stat-Signature: p8jihr844dp1r8yha6xib71931m3c9ec X-HE-Tag: 1729771824-218006 X-HE-Meta: U2FsdGVkX19dsBjVKrN32MsYv9pUPUq6vYkyVG7rTVa513BZxVUgm5KNA9j1nXsPq/nxHu3HcGICo47lEyIVJkRP2mMog9D9VQruAC43fYhj3YtMs3qQYWpcn7aqNnES7/XoU/AG7JLDICDXsZEPW4Mg0Ijc22/HE1ICXKEJV+wIDVT46k1B/ZqbxgO/0Bm7GHImnSdoOZodA+stRrTeja+i8BdyA0xf7km3fx2q2pjVXeG+w/z+CDjdl4xtvKpe/BLt6v4s389K7rO2mpHmEFKj9cBUZ4Npn6f6eZidMr24g6E8OOy890so7WieJ4COUlI3lU+kGcyjG/8HF8X/xC2+xx+5nptt0eCzCVkF2W7XZaNLC1PJwZI2orGbrZ8BDJofzelsw5Jig5cFWK9S7B3gLdArwilJL2P/1UcMeEXO6rIo2zLUO8EZsoOg9UVTy1TxWW0GHWTdUuAqp+NsE7NE1h61AFcqODlL5MbXZuHVlySh3D34s7Ds75BFvmLF2/L91dM44F0vXf7PzP5m2WDBXz1CZ976fbBpMGzvbJfwxNByIvyKIB7WOjGkCHLnL29Dd8uBAoHkRazRYZ7i+sTpEA/UfoRm70JyojwjXvaoKI2ZLCUkfvtSiJKkvmY2JqVxRAy4DFE9yM0wt0D4LZC4Ub7Ds+R292hUFkVFWCZbuTAnS+sZ7rdTRj1C+kTqQhewGRP4iwxya0wiQABrn1ikA8j7Kp7X+odlEtSBwjjV52JvueGBm6ykb+C7+yYpG/YOFsmKC9JIJ14sCaFuoW3J7kYbc/61X/JuNru4A/01Y4Wm1sqDgmcqbwmFyoK9HgKKJ8APbqr8Aiu59d9HMqlrdcTM/2kHu4eOpOELXtSS5+gnWeBXCj3JsAhALjakCzSaTtgH6EQBY5+XLReISzI611yZCCzCNJlxf1Q9qe1moFQDL5FbzQqBGjN+AlrZucPxuKRVnlpENMRjhow HkVTiA2l g7bFI+kxyJ1J9YsDOFCdCYqWxGyGt/XHnI8Ns62zCmbXb1T7hChld6hZlbOhNJGH6/8IzP5RJPZJ8HsdJ03vYK5Vk3KIpIkyaWvWOwCqecwiBOPc21f1tqnpEHFllRMKKqG0/rrFzhbrk9GPOvgdClOs+0fKUVgpJ44sIWCx+uumLNBhMp196v3mxjGpPLclKeSry2FxtbwUOmxt4MLDehDcVge+Z8mIL7yRdReqtaVbEBAQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24/10/2024 12:45, Petr Tesarik wrote: > On Thu, 24 Oct 2024 11:48:55 +0100 > Ryan Roberts wrote: > >> On 23/10/2024 22:00, Thomas Tai wrote: >>> >>> On 10/17/2024 8:32 AM, Ryan Roberts wrote: >>>> On 17/10/2024 13:27, Petr Tesarik wrote: >>>>> On Mon, 14 Oct 2024 11:55:11 +0100 >>>>> Ryan Roberts wrote: >>>>> >>>>>> [...] >>>>>> The series is arranged as follows: >>>>>> >>>>>>    - patch 1:       Add macros required for converting non-arch code to support >>>>>>               boot-time page size selection >>>>>>    - patches 2-36:  Remove PAGE_SIZE compile-time constant assumption from all >>>>>>               non-arch code >>>>> I have just tried to recompile the openSUSE kernel with these patches >>>>> applied, and I'm running into this: >>>>> >>>>>    CC      arch/arm64/hyperv/hv_core.o >>>>> In file included from ../arch/arm64/hyperv/hv_core.c:14:0: >>>>> ../include/linux/hyperv.h:158:5: error: variably modified ‘reserved2’ at file >>>>> scope >>>>>    u8 reserved2[PAGE_SIZE - 68]; >>>>>       ^~~~~~~~~ >>>>> >>>>> It looks like one more place which needs a patch, right? >>>> As mentioned in the cover letter, so far I've only converted enough to get the >>>> defconfig *image* building (i.e. no modules). If you are compiling a different >>>> config or compiling the modules for defconfig, you will likely run into these >>>> types of issues. >>> >>> It would be nice if you could provide the defconfig you are using; I also ran >>> into build issues when using the arch/arm64/configs/defconfig. >> >> git clean -xdfq >> make defconfig >> >> # Set CONFIG_ARM64_BOOT_TIME_PAGE_SIZE >> ./scripts/config --disable CONFIG_ARM64_4K_PAGES >> ./scripts/config --disable CONFIG_ARM64_16K_PAGES >> ./scripts/config --disable CONFIG_ARM64_64K_PAGES >> ./scripts/config --disable CONFIG_ARM64_BOOT_TIME_PAGE_SIZE >> ./scripts/config --enable CONFIG_ARM64_BOOT_TIME_PAGE_SIZE >> >> # Set ARM64_VA_BITS_48 >> ./scripts/config --disable ARM64_VA_BITS_36 >> ./scripts/config --disable ARM64_VA_BITS_39 >> ./scripts/config --disable ARM64_VA_BITS_42 >> ./scripts/config --disable ARM64_VA_BITS_47 >> ./scripts/config --disable ARM64_VA_BITS_48 >> ./scripts/config --disable ARM64_VA_BITS_52 >> ./scripts/config --enable ARM64_VA_BITS_48 >> >> # Optional: filesystems known to compile with boot-time page size >> ./scripts/config --enable CONFIG_SQUASHFS_LZ4 >> ./scripts/config --enable CONFIG_SQUASHFS_LZO >> ./scripts/config --enable CONFIG_SQUASHFS_XZ >> ./scripts/config --enable CONFIG_SQUASHFS_ZSTD >> ./scripts/config --enable CONFIG_XFS_FS >> >> # Optional: trace stuff known to compile with boot-time page size >> ./scripts/config --enable CONFIG_FTRACE >> ./scripts/config --enable CONFIG_FUNCTION_TRACER >> ./scripts/config --enable CONFIG_KPROBES >> ./scripts/config --enable CONFIG_HIST_TRIGGERS >> ./scripts/config --enable CONFIG_FTRACE_SYSCALLS >> >> # Optional: misc mm stuff known to compile with boot-time page size >> ./scripts/config --enable CONFIG_PTDUMP_DEBUGFS >> ./scripts/config --enable CONFIG_READ_ONLY_THP_FOR_FS >> ./scripts/config --enable CONFIG_USERFAULTFD >> >> # Optional: mm debug stuff known compile with boot-time page size >> ./scripts/config --enable CONFIG_DEBUG_VM >> ./scripts/config --enable CONFIG_DEBUG_VM_MAPLE_TREE >> ./scripts/config --enable CONFIG_DEBUG_VM_RB >> ./scripts/config --enable CONFIG_DEBUG_VM_PGFLAGS >> ./scripts/config --enable CONFIG_DEBUG_VM_PGTABLE >> ./scripts/config --enable CONFIG_PAGE_TABLE_CHECK >> ./scripts/config --enable CONFIG_PAGE_TABLE_CHECK_ENFORCED >> >> make olddefconfig >> make -s -j`nproc` Image >> >> So I'm explicitly only building and booting the kernel image, not the modules. >> The kernel image contains all the drivers needed to get a VM up and running >> under QEMU/KVM. > > FWIW with the attached patch I was also able to boot the kernel on > Ampere Altra bare metal and using modules. Nice! Thanks for the below. That was already reported and I have a fix in my branch at [1]. That also includes the btrfs patch you sent and the hyper-v patches, as well as other fixups from review. [1] https://gitlab.arm.com/linux-arm/linux-rr/-/tree/features/boot-time-page-size-v2-wip Thanks, Ryan > > Petr T > > diff --git a/arch/arm64/mm/pgtable-geometry.c b/arch/arm64/mm/pgtable-geometry.c > index ba50637f1e9d..4eb074b99654 100644 > --- a/arch/arm64/mm/pgtable-geometry.c > +++ b/arch/arm64/mm/pgtable-geometry.c > @@ -15,8 +15,14 @@ > */ > > int ptg_page_shift __read_mostly; > +EXPORT_SYMBOL_GPL(ptg_page_shift); > + > int ptg_pmd_shift __read_mostly; > +EXPORT_SYMBOL_GPL(ptg_pmd_shift); > + > int ptg_pud_shift __read_mostly; > +EXPORT_SYMBOL_GPL(ptg_pud_shift); > + > int ptg_p4d_shift __read_mostly; > int ptg_pgdir_shift __read_mostly; > int ptg_cont_pte_shift __read_mostly;