From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AE42D0BB4B for ; Thu, 24 Oct 2024 00:45:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 818786B0088; Wed, 23 Oct 2024 20:44:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A13B6B0089; Wed, 23 Oct 2024 20:44:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6422E6B008A; Wed, 23 Oct 2024 20:44:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 42AF36B0088 for ; Wed, 23 Oct 2024 20:44:59 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A3667C0F88 for ; Thu, 24 Oct 2024 00:44:39 +0000 (UTC) X-FDA: 82706650152.09.7753231 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) by imf02.hostedemail.com (Postfix) with ESMTP id 267DF8000E for ; Thu, 24 Oct 2024 00:44:22 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=i7IfyvoY; spf=pass (imf02.hostedemail.com: domain of martin.lau@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=martin.lau@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729730494; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4U5Grdy9U7IEXbPXIYSkeQV5LOqLXNssTe9EsB9reiA=; b=G9DjqfFf6EmRsbjraQK91EARC/P+qFiWv6u/O69rdKa7DdIY7OG2UgP/7lL1xoFJxS31SK 5GI68QQjUINLrt1jTL0Oj7X4FlUxe653oB6DR1aA6h7GBIwp3hqoGCsW0S3LLmB7fMhUKk V/YuYUsSpFQioVZBcOFN02KFYI5Atnk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=i7IfyvoY; spf=pass (imf02.hostedemail.com: domain of martin.lau@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=martin.lau@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729730494; a=rsa-sha256; cv=none; b=v1YEDX/9UDUoun0+vfZ2Zae24eCTSsRSZ0mt3f8JiqWlRDolikShVCw2+GhnYMpshCuXdz nn7Wg2i9cR0uvtnzhrt/Y3HNPF5D/mEVZeb8OyLrzrZnP1tJ6bS/HXK/lVxwmJ34LoIAjd GaDoQ+AB/OEFs7be0sEzEVWhHd21o3s= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729730694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4U5Grdy9U7IEXbPXIYSkeQV5LOqLXNssTe9EsB9reiA=; b=i7IfyvoYvEu+bReDQmHHJ8Gblr7SZceNBzgW6M8lXfaM/uONt2tkWht78OXkWY1MOhidYs eZhUNi/Y/wSCv8WlfFEQP0V8kTErkpOAxrC0Bpr6HnHWDOuYSwOVDKzMbe9v81C1TsqXHe UJFATi3G8SnLFG1PZ8soOW0wEjznQEM= Date: Wed, 23 Oct 2024 17:44:48 -0700 MIME-Version: 1.0 Subject: Re: [PATCH v5 bpf-next 06/12] bpf: Add uptr support in the map_value of the task local storage. To: Shakeel Butt Cc: bpf@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Kui-Feng Lee , kernel-team@meta.com, linux-mm@kvack.org References: <20241015005008.767267-1-martin.lau@linux.dev> <20241015005008.767267-7-martin.lau@linux.dev> <2ngvjjbgow7bhsr5bpcyosxrzkbaux6mrvtvh2ru6wrzujtoki@7vpyhef5vux5> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau Content-Language: en-US In-Reply-To: <2ngvjjbgow7bhsr5bpcyosxrzkbaux6mrvtvh2ru6wrzujtoki@7vpyhef5vux5> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 267DF8000E X-Stat-Signature: 594zwz1getpyyegm8m6gsibbnyfizqfy X-Rspam-User: X-HE-Tag: 1729730662-496153 X-HE-Meta: U2FsdGVkX19vP/YBJl0V0yKavfPbneqGD4AxPNz359vwmealpQdWzblz0u0hjPKuqgXwVgpLt24h/X6NYh8+pJhQfVsEpYe9JrX1bCXu1P6cajzrnV3aJP9hMTY6r/qgpwNi+GumLbPcOcGzgKE7HKQ5vTI1GPcE3V4g4NoQsuMAUWeuxJrVx4WAPgv0nWjGiDcw8RqrzUPfKpOJaBi+Iy4StGm6WtFXF3mlpxQETzH5yswQ4FWkXeY1v0LT48UFWoKTL2HXn4U3q3Byrzl5YZ3XKb74wgoTf6xYEzuYWuB3rYExfPMnh8r8Y3C5pCOOAzbcmEfnmxh9XPFL8MD80xofQHBNgr4ct38SkrPPIpRlPblOIb/qj5LY1zfe5cHzC0LDQD3eGJsHmNdcye8SI8zWaPSBSRKhi+BxA4gFKZEupzHfTCTnwJWKRL7p5eMTAGqyWDy23NWJvmIJqM9GEGyGQYnEkg+dgW4fl7ycdB97fzizaq4T6zSHaRXmfvkzrkaLqZMNjbDdQsDzzZthjNeL1nEL6zQhvZg8IcelVp3tOj6Qm0ICaUteQmTJCCdS+K4rAVBRZw1DEwzdU3cHk9NAu49k+TcE96cjBgpygpWjCbzkVoZVsl06jgfpw7+wmD6wHIt1PpW3TIBoo3BFG4kpxl6JD5CLuuqxpSXusFPUOgqNvU0VnBB/2leS0rXlDZSSbAht+naF50p4nO8300SrcUNfTTsYaBmzBjTCtT/8uy4WiAR2HPQqpgvLuit8rA/dd5bOgiVG0ujsh5gby2ewRyUowH7g/6Eo7obt0mm9Id0b58S7STSbRd66ktO5L71Su2CeRUEYNUTzRRDzI8M3hB0K9g18CN55oS0z4bbobpnSv6gbHpgUWzzuZRauyc+widK8ZR67JT2I3KCntTLTMN+W415DIpAX4Lio1CNjbzxGbxtylgUPk9qlFrm/xpfot8pQR6fCJJDvwcN hJ9mQ/w4 XXNeEHITudapJK7fMZB+KMUlwi+rmxIlHUCF1m8JK5w4F4itxaoi1ANoH9bSvbXI52ksOtREYeY/FODJxfKNYet69hQIdDKVfy2e5tmbj7DPWLGpv0mTa19C2l438GGWpkVdmChawwBepxP5ZzzzK/JvGX4Joa4VstSGAkNArX8WxsZU36tM6hoQhUWRL3Zm088Mq1VYMXkNpjf8PituEC9Z6QaixZmfyoI9MOY2cMevyT3yAzSWTRxoMV9jjkJlnMOh+gxPLp8k7jJfNdGtnKE8Qbuf8nl7bKFmY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/22/24 5:57 PM, Shakeel Butt wrote: > On Tue, Oct 22, 2024 at 04:07:50PM GMT, Shakeel Butt wrote: >> On Mon, Oct 14, 2024 at 05:49:56PM GMT, Martin KaFai Lau wrote: >>> From: Martin KaFai Lau > [...] >>> + >>> + err = pin_user_pages_fast(start, 1, FOLL_LONGTERM | FOLL_WRITE, &page); >>> + if (err != 1) >>> + goto unpin_all; >>> + >>> + *uptr_addr = page_address(page) + offset_in_page(start); >> >> Please use kmap(page) instead of page_address(page) and then you will >> need to kunmap(kptr) on the unpin side. >> > > This is needed only if you plan to support your feature for HIGHMEM > kernels though. Otherwise you can error out for PageHighMem(page). I just posted v6 with the PageHighMem(page). Thanks for the review.