From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 504ABC4451B for ; Mon, 20 Jul 2026 09:27:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F1DE6B0096; Mon, 20 Jul 2026 05:26:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C9B66B0098; Mon, 20 Jul 2026 05:26:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DF386B0099; Mon, 20 Jul 2026 05:26:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1DF266B0096 for ; Mon, 20 Jul 2026 05:26:55 -0400 (EDT) Received: from smtpin15.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A5448C070A for ; Mon, 20 Jul 2026 09:26:54 +0000 (UTC) X-FDA: 85008625548.15.EDC9712 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf10.hostedemail.com (Postfix) with ESMTP id C9AEDC0009 for ; Mon, 20 Jul 2026 09:26:52 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=awQg76Rh; spf=pass (imf10.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1784539612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M2jhTjNXwT/wFHT3j8aQ9cD9kDlxoHh0XcpFGsMlw9Q=; b=xCu/cznH7R014PomEjeRYGQeE3lgezg8j+xK+YoIzvxZGXnD4kogZmI/fG4dNheGLiymCd T08ShviWp94WQdQQsZjIp81MS5Z6Ohbo2wUzrI+g9o3PPDpWifF15X8oTo2mNlBefRans4 8WGol/66fri1CU1OlCDmPtjx7B3kB88= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=awQg76Rh; spf=pass (imf10.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1784539612; b=OEUKIyXvQLoYby+nnfygvsmiOZpwNB5RWsheo0rYUsSoo3kfRzpBJjg7a9Si69jZ0BC1GD Jyu+voN7dr/s256YfYGTbGp3y7cqWCdAsZqGWc8VM6cwX4yfcPJ0s7/DUUsWg+cDA53AhA lvq5P5ZoVnOYcMasYIjEhNlJNrxROpA= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 2814440BDC; Mon, 20 Jul 2026 09:26:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AC961F000E9; Mon, 20 Jul 2026 09:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784539612; bh=M2jhTjNXwT/wFHT3j8aQ9cD9kDlxoHh0XcpFGsMlw9Q=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=awQg76Rhu854IUVSU11q+je5cYfo8bHNwWQgLLF/pO852ZBP/q+a3Q1lKWb1bjV8M 8I0BROcNAXpXWI3FIDE4eGGwxYsPswRkfPQ7x4h7F5jiGxs/IVAdn2k/qWJoxCeIjo 1QjAuuGxatG2efRL5M95Vf0ph7C2/ZyqRvix8wh4RljauAWb/C4y9GZC2Ute+gVk/J 0rZAFfqqrgXg402EdkMcjxwScIH6cKK55du6etmMXDM8pjwygZP3NnbmbDMXDPf+Lu bbS35ZaV4AfU09i6XyyoPq6Or72MusRfpJmMbyvrRULwttjHXTcQUC8bJgJ+hwzggF OFkYz7Apy0H8g== Message-ID: Date: Mon, 20 Jul 2026 10:26:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/6] mm: mincore: remove special handling for VM_PFNMAP To: Kefeng Wang , Andrew Morton Cc: linux-mm@kvack.org, "Liam R . Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato , Zi Yan References: <20260717091347.1144789-1-wangkefeng.wang@huawei.com> <20260717091347.1144789-3-wangkefeng.wang@huawei.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20260717091347.1144789-3-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C9AEDC0009 X-Stat-Signature: dwki6cj3wwaursx9d8pfeh7a8sy1rbqc X-HE-Tag: 1784539612-690720 X-HE-Meta: U2FsdGVkX1/RRnvjLT612BPVEJpn7BJ7eOsVF3rIU4eLtGvPSDhYifGUvOSJSacrtlhtOk5B/DoQGvcbo82VhvE9SIcNSTBYml5JR0Cki22xjRBJuL5gYHbBE6vyMaPSiskzRHo30Dtg+6E2Yec444BlIVvQWE4tnAIC+Sl2zcKIRGeEvATMYCUKMdt3RY4XPPdoE2nm3KkOtsG1UV61/HV+zQxrV5aQyV3MBPZjjKRHoT929ywhiMwVgVRMMxDh+69xLe+OavIEchw4mbmPq0ohAiHsJRFxdvP6n8jsFNU6IIe1UANfSzQ/KpBmv4TIFf/2xOunkmxc6f7TqhGsRfUHp+GlbGET625cI85ZoROPc67mk5qsBKTHb+450v6Ged2ktWNi9e5+ymZ4BVH9dgtNl5batd1NmdUrBxtSjQnOA0k2sF9SSPV4gHM5ffAzuGQJk/wl4BVqkZaB+lShYiXUkOoxxcLn0AtJXhDd/UNxPgfXzst2ZKK+z2po71ELY6vMir2rKIEXWdg7LvjEEdG23YvoSH75yiL4zVEkX9qZLlJ3XgkM4fAxtmjs3x+O8AASsasSnylkcDbV7W+f94/Lw5+MQ4Bf515Ld2jwx/ZWX/ozCR/cF8hcib214fsYfaqiQ8ywV0A9dmNBdZNoY2YAGSNmg/7IztItNFJGF5CuWw+2wB/3fBDXsLZ8KR8aa+YV/kgXl/iXk0EDmFD87X743E1l5zOenHecJiALS7FwnIDxUYEU35yo5+apsdGvzKEu3vkyAoIVnkalzBrlLzGbIHv5fpYkxcBxXPnAC1ljfutepG/dD5tjXVa4IPrs+0Ytbv0c76hOe8u0c20vUsqLN4fEnYK2XCxeZ++K8z1R2T7gAo7vJ5fJcpmUbAvyHxJc3ERhMtk0ZEv8oPLkic0wd2hqTHKatYQ9LDX9/pOow6n/5JsWHEYcQ/QeVxEgOgBaAVR65LKK3Pt8r8z VpT65uGZ VKr1YRtd84j9Ri8Xx/WOv46Jg6HFo47v2Fh4Ko5KWJWIVLZAoiqXrk668YjNVSz7DlZOQl6jifOSCQo1FrkgUkn7CRrFHtZMV+9YU6eNoAwK6RCB1iGOx3rkhJGmbLJu6g5MWLDr3leIDQeOI0aqGnDov6RcJcx07PKjNW9WdSpbwvkSNxbw4A9nYBpcWxlDeT+3yjN6yn6QsOCs+jEXjfMdQ9t3JZA8saMSyGcx1qnlYZAmUQK5QO9TP0uFHff532fIN/FVsX6YsyQJGFJx5FZm1T+G6cxGrznj2wb5ytaWwpBkknUaqfFmawhaodhAmPFx9MrbxKqwsIr7zqK4/4CKahB+kD2wVbkfD6KFZMxntSP1uUqCDuK2PKduCTe8ProRS Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/17/26 10:13, Kefeng Wang wrote: > As David pointed out, "it’s hard to believe that someone depends > on pages in VM_PFNMAP to *not* be present", so remove the historical > behavior that always reports VM_PFNMAP pages as non-resident. > > Adding mincore_pud_range() allows the page table walker to traverse > the full page table hierarchy without splitting a huge PUD, enabling > much more precise identification of resident pages in PFNMAP VMAs. > > Link: https://lore.kernel.org/linux-mm/0e619d71-1c3d-4534-8376-2982c7348c31@kernel.org/ > Suggested-by: David Hildenbrand (Arm) > Signed-off-by: Kefeng Wang > --- > mm/mincore.c | 24 ++++++++++++++++-------- > 1 file changed, 16 insertions(+), 8 deletions(-) > > diff --git a/mm/mincore.c b/mm/mincore.c > index 53b982803771..3fccaa5c96f8 100644 > --- a/mm/mincore.c > +++ b/mm/mincore.c > @@ -160,6 +160,21 @@ static int mincore_unmapped_range(unsigned long addr, unsigned long end, > return 0; > } > > +static int mincore_pud_range(pud_t *pudp, unsigned long addr, unsigned long end, > + struct mm_walk *walk) > +{ > + if (pud_is_huge(pudp_get(pudp))) { > + int nr = (end - addr) >> PAGE_SHIFT; Ah, and best to use an unsigned long here for consistency. -- Cheers, David