From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E47CC433F5 for ; Fri, 22 Oct 2021 09:22:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BF598610CB for ; Fri, 22 Oct 2021 09:22:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BF598610CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 54EF5900003; Fri, 22 Oct 2021 05:22:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FEA6900002; Fri, 22 Oct 2021 05:22:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C650900003; Fri, 22 Oct 2021 05:22:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id 2B6A4900002 for ; Fri, 22 Oct 2021 05:22:30 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DF17F2BA85 for ; Fri, 22 Oct 2021 09:22:29 +0000 (UTC) X-FDA: 78723532818.01.AFC06C5 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf09.hostedemail.com (Postfix) with ESMTP id 060643000104 for ; Fri, 22 Oct 2021 09:22:26 +0000 (UTC) Received: by mail-ed1-f47.google.com with SMTP id r4so4371082edi.5 for ; Fri, 22 Oct 2021 02:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=8wRakYYkxElrlaPhMN+8m3gMM0Ofd4s2CuL6BRUXvDg=; b=Ek+biRSv3O/qpa+FWdKUcAZraqR5s1HBhR6mdRXfJ4HHquUO2xiApOLTlxDeBaU9kM /g9txSdLG9fjqogY8NOlllRSg9ZrQNyozBBobR5yTzqIwHRQkLV/IfiH+Iyh5I72MOkL z96dGco0XKWw3z0hWxi8QOoqqK6aAPN5kUeFJMxIyEUNE0doDhRC4B1EaI4/9jWBRftY YZExPyG9ySS+dNW3GlCs2LFFvIVsebA0ippVa0xlWC9ZZ6AXYyF6wBYVebVHrlpH5jay WV8D9vAgy0zXGMApypzfHvVfwmwGdr7zakcQVH7feMW5A491MCxfN5UGyTeQL4bn819m mxlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=8wRakYYkxElrlaPhMN+8m3gMM0Ofd4s2CuL6BRUXvDg=; b=ZB20uYf4PXnJLgAh+rzXBE85V8A6LsxbUZ814uwceLJpar/eSFjjPCn8GrOMuM3rbl d2j7S51f1SYKVWy5pdqgkKfzxclkD1je9VHB6RviNLv7U1DqkGDfKWNAUozA6Vukl3tJ PFdRMAWo8+5dTL/UOxygxPKrkKBVw+VMkFWue5sPzM11xKbIva6U91mXSg/CzRQfh9Ji KoNpqLfHHjgTv+jAq8CzjxcGunRsGUPfEgkleOEEUnEq3WfiIMdCrOKHFG/jmpN+MquX ZwuwETlAZ0YpFe37cfzPSRvXDUT3O2knvLe6hqYdu5Xrg9G1dvk9hAeHCXUrjQGU3CGt IWwA== X-Gm-Message-State: AOAM5321Tty4lLYLMFyFV32Fvfe8q7K0CR0IOJEIVjEZ1MX6mte7P99n rXgRqykHX7DX0S3aBP73ttE= X-Google-Smtp-Source: ABdhPJxqBmr5FAEZ2PoX3cXSIj5DNGJdKaGG2ygmftNBfkNh29V9Xqkw0DSi8xp96ScR62uKQQNJ2g== X-Received: by 2002:a17:906:912:: with SMTP id i18mr13903323ejd.131.1634894548338; Fri, 22 Oct 2021 02:22:28 -0700 (PDT) Received: from [192.168.8.198] ([148.252.133.195]) by smtp.gmail.com with ESMTPSA id o25sm691981ejc.22.2021.10.22.02.22.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Oct 2021 02:22:28 -0700 (PDT) Message-ID: Date: Fri, 22 Oct 2021 10:22:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 1/2] percpu_ref: percpu_ref_tryget_live() version holding RCU Content-Language: en-US To: Dennis Zhou Cc: linux-block@vger.kernel.org, Jens Axboe , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Lameter , Tejun Heo References: <3066500d7a6eb3e03f10adf98b87fdb3b1c49db8.1634822969.git.asml.silence@gmail.com> From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 9b8ccez94ds33tuiz4k8dpmhb6aj9th8 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ek+biRSv; spf=pass (imf09.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 060643000104 X-HE-Tag: 1634894546-549654 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/21/21 15:01, Dennis Zhou wrote: > Hello, > > On Thu, Oct 21, 2021 at 02:30:51PM +0100, Pavel Begunkov wrote: >> Add percpu_ref_tryget_live_rcu(), which is a version of >> percpu_ref_tryget_live() but the user is responsible for enclosing it in >> a RCU read lock section. >> >> Signed-off-by: Pavel Begunkov >> --- >> include/linux/percpu-refcount.h | 33 +++++++++++++++++++++++---------- >> 1 file changed, 23 insertions(+), 10 deletions(-) >> [...] >> + >> /** >> * percpu_ref_tryget_live - try to increment a live percpu refcount >> * @ref: percpu_ref to try-get > > Nit: it's dumb convention at this point, but do you mind copying this > guy up. I like consistency. Looks Jens already took it. If you still want it moved, do you mind it in a separate patch? And I'm not sure I follow where you want it to be, currently it's right before percpu_ref_tryget_live, which uses it. -- Pavel Begunkov