Re: [PATCH 3/4] mm: mlock: use walk_page_range_vma() in mlock_vma_pages_range()

["David Hildenbrand (Arm)" <david@kernel.org>]

On 6/17/26 10:26, Kefeng Wang wrote:
> The mlock_vma_pages_range() uses walk_page_range() to walk the
> page table. Fortunately, the caller always passes start/end that
> falls within a single VMA, apply_vma_lock_flags() iterates per-VMA,
> and apply_mlockall_flags() passes the whole VMA.
> 
> Since there is no .test_walk in mlock_walk_ops and VM_PFNMAP has
> been filtered by vma_supports_mlock(), it's safely replace
> walk_page_range() with walk_page_range_vma() to eliminates an
> unnecessary find_vma() lookup.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  mm/mlock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/mlock.c b/mm/mlock.c
> index 8c227fefa2df..97e49038d8d3 100644
> --- a/mm/mlock.c
> +++ b/mm/mlock.c
> @@ -446,7 +446,7 @@ static void mlock_vma_pages_range(struct vm_area_struct *vma,
>  	vma_flags_reset_once(vma, new_vma_flags);
>  
>  	lru_add_drain();
> -	walk_page_range(vma->vm_mm, start, end, &mlock_walk_ops, NULL);
> +	walk_page_range_vma(vma, start, end, &mlock_walk_ops, NULL);
>  	lru_add_drain();
>  
>  	if (vma_flags_test(new_vma_flags, VMA_IO_BIT)) {

Acked-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David