From: David Hildenbrand <david@redhat.com>
To: Jinjiang Tu <tujinjiang@huawei.com>,
akpm@linux-foundation.org, dev.jain@arm.com,
catalin.marinas@arm.com, lorenzo.stoakes@oracle.com,
thiago.bauermann@linaro.org, superman.xpt@gmail.com,
christophe.leroy@csgroup.eu, brahmajit.xyz@gmail.com,
andrii@kernel.org, avagin@gmail.com,
baolin.wang@linux.alibaba.com, ryan.roberts@arm.com,
hughd@google.com, rientjes@google.com, mhocko@suse.com,
joern@logfs.org
Cc: linux-mm@kvack.org, wangkefeng.wang@huawei.com
Subject: Re: [PATCH v2 1/3] mm/smaps: fix race between smaps_hugetlb_range and migration
Date: Thu, 24 Jul 2025 18:27:25 +0200 [thread overview]
Message-ID: <ce7e8f4e-a8e7-4d79-b4d5-8d82d98e6951@redhat.com> (raw)
In-Reply-To: <20250724090958.455887-2-tujinjiang@huawei.com>
On 24.07.25 11:09, Jinjiang Tu wrote:
> smaps_hugetlb_range() handles the pte without holdling ptl, and may be
> concurrenct with migration, leaing to BUG_ON in pfn_swap_entry_to_page().
> The race is as follows.
>
> smaps_hugetlb_range migrate_pages
> huge_ptep_get
> remove_migration_ptes
> folio_unlock
> pfn_swap_entry_folio
> BUG_ON
>
> To fix it, hold ptl lock in smaps_hugetlb_range().
>
> Fixes: 25ee01a2fca0 ("mm: hugetlb: proc: add hugetlb-related fields to /proc/PID/smaps")
> Signed-off-by: Jinjiang Tu <tujinjiang@huawei.com>
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-07-24 16:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 9:09 [PATCH v2 0/3] hold PTL for several .hugetlb_entry callbacks Jinjiang Tu
2025-07-24 9:09 ` [PATCH v2 1/3] mm/smaps: fix race between smaps_hugetlb_range and migration Jinjiang Tu
2025-07-24 16:27 ` David Hildenbrand [this message]
2025-07-24 9:09 ` [PATCH v2 2/3] fs/proc/task_mmu: hold PTL in pagemap_hugetlb_range and gather_hugetlb_stats Jinjiang Tu
2025-07-24 16:27 ` David Hildenbrand
2025-07-24 9:09 ` [PATCH v2 3/3] mm/mincore: hold PTL in mincore_hugetlb Jinjiang Tu
2025-07-24 16:29 ` David Hildenbrand
2025-07-24 16:26 ` [PATCH v2 0/3] hold PTL for several .hugetlb_entry callbacks David Hildenbrand
2025-07-25 2:02 ` Jinjiang Tu
2025-07-25 3:31 ` [PATCH] mm/memory-failure: hold PTL in hwpoison_hugetlb_range Jinjiang Tu
2025-07-25 15:48 ` David Hildenbrand
2025-07-25 23:29 ` Andrew Morton
2025-07-26 0:28 ` Jinjiang Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce7e8f4e-a8e7-4d79-b4d5-8d82d98e6951@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=avagin@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=brahmajit.xyz@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=joern@logfs.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
--cc=ryan.roberts@arm.com \
--cc=superman.xpt@gmail.com \
--cc=thiago.bauermann@linaro.org \
--cc=tujinjiang@huawei.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).