From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C14BC4345F for ; Thu, 25 Apr 2024 19:06:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C679B6B0089; Thu, 25 Apr 2024 15:06:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C177B6B008A; Thu, 25 Apr 2024 15:06:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB6D56B008C; Thu, 25 Apr 2024 15:06:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 92F0B6B0089 for ; Thu, 25 Apr 2024 15:06:32 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1FF104060C for ; Thu, 25 Apr 2024 19:06:32 +0000 (UTC) X-FDA: 82048985424.10.89A1BB1 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf13.hostedemail.com (Postfix) with ESMTP id BAA9520023 for ; Thu, 25 Apr 2024 19:06:29 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=0YexNYzM; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=R0862Li9; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=0YexNYzM; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=R0862Li9; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf13.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714071990; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rUU8UU5PmZ6BAV0nPdW+zP5OGRgEga5RTqlWW2DOGPQ=; b=IPyLIPP1cARz5RdDAv8QECuKzns6DU4NTGmz8XQlrywCdxGcCur/bn7sVeU1N/yEqKmE+6 Nx0R/gxz4/MelLIHQpEuENjfIe0lkm6SXbVTGxqGkR3cqFdjDHbBWRbh3gm1+Hu5G+YwMe mljzHgq9gRrrPYlJzYCZji+e5ejdYWI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=0YexNYzM; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=R0862Li9; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=0YexNYzM; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=R0862Li9; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf13.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714071990; a=rsa-sha256; cv=none; b=YlAO3WAHfjaH6s3pnnnskbNXOsTZDQawaGFkzU+HaOQb7PlaiTpAbdXr0v7HlOjBva5idK ZODJp//qpXogPSai/9fVCtUJQjTmK69axF2nCXL0HLybszmrJMot5ocjrj8Gqyj4z1x6+2 L2JQS66fuDP12BsVuKkqundA5z9H238= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0B09B5C463; Thu, 25 Apr 2024 19:06:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714071988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rUU8UU5PmZ6BAV0nPdW+zP5OGRgEga5RTqlWW2DOGPQ=; b=0YexNYzMdVdVK6KmKFtKlW0tW5Dh0SMn5zGqEWv9/O6wOTW/qJyf5eGl0BHjvfhrvN2mlw 8B/oGzzvET4QEmByIUz7L9ZDs3NgB/IhQtfycV1vcw9V/4lXPZ5DoLddMDQBb2unCEZTax Yt4qEaenWnwFjJCcYmbP4Q9iVZ2mb6s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714071988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rUU8UU5PmZ6BAV0nPdW+zP5OGRgEga5RTqlWW2DOGPQ=; b=R0862Li9JnV/Bdzls9zTqffI4a7o2VCOTXah+q+zMjt8x0nyv7sbZr97W2bvhGPK3baLZY MFonjPwCihMBqACw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714071988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rUU8UU5PmZ6BAV0nPdW+zP5OGRgEga5RTqlWW2DOGPQ=; b=0YexNYzMdVdVK6KmKFtKlW0tW5Dh0SMn5zGqEWv9/O6wOTW/qJyf5eGl0BHjvfhrvN2mlw 8B/oGzzvET4QEmByIUz7L9ZDs3NgB/IhQtfycV1vcw9V/4lXPZ5DoLddMDQBb2unCEZTax Yt4qEaenWnwFjJCcYmbP4Q9iVZ2mb6s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714071988; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rUU8UU5PmZ6BAV0nPdW+zP5OGRgEga5RTqlWW2DOGPQ=; b=R0862Li9JnV/Bdzls9zTqffI4a7o2VCOTXah+q+zMjt8x0nyv7sbZr97W2bvhGPK3baLZY MFonjPwCihMBqACw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AB16D1393C; Thu, 25 Apr 2024 19:05:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id aaj6EompKmYATAAAD6G6ig (envelope-from ); Thu, 25 Apr 2024 19:05:45 +0000 Message-ID: Date: Thu, 25 Apr 2024 21:04:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/11] filemap: allocate mapping_min_order folios in the page cache Content-Language: en-US To: "Pankaj Raghav (Samsung)" , willy@infradead.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, p.raghav@samsung.com References: <20240425113746.335530-1-kernel@pankajraghav.com> <20240425113746.335530-4-kernel@pankajraghav.com> From: Hannes Reinecke In-Reply-To: <20240425113746.335530-4-kernel@pankajraghav.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: BAA9520023 X-Stat-Signature: exwgpphjj85xr1a17e64kww1ozeask7u X-HE-Tag: 1714071989-3232 X-HE-Meta: U2FsdGVkX1+Y5mPYkbIuzyezGkZYaz7oRlXaZrpaOxvCiGygjKrF8760D3wZcF+6DRHFui4N37gVJn7prCG64aiRDZfOlsqo4oEmykVE5vrgSq5v8eh5II7b3uNmZbTRlNfkxIteUKPnw0OpN/q/Qv67aK2vkf3NzIGRQzFr2xryFwIht5CgkT3X1rgviBC00Z4F2Z6ftaZ0/oQEcsdNfx41pEQ3RAasxOaCYTXUyvMEK2fpETLaZOWrYJ7CBVldEAXlAJ/ICxdpmwTCpsGTtXCUToGyUPwSTui/tmZI4/06ZjYhzH9llKiMHAmH0g/rP1VkB8TZi0vCExaFmaejmAmNUWL4Bry6Xs7Ggk/981DcYHmqG7vVJa047Sn8RV4MRZSShevHzXx9leGPs2C+odtOObonjtdgG0Tw8qcPVuC3lNakPlt6gwTuL9pQza+SqmmeXdO0xHtkahrs7VKzXCyji9jlQYHgmh5HUt5zREP2A7SIME0FP+j1riLfdk3QMF/UZI4PzULRIt0V4g4ieyiczwyTePDrYOqnhzfYBtj8z+SlR3s1vbfeYZi5CrvWyqOfN/oKJ8tb/AFykSBOIldgW/47gOB43Igx9DjxdyPO5YsOsuFZu6JGjimqzjJ3snoCT8yOMrhynk7T+2v9FwuHh2u4zVj7CGBnadaY2v185IgHVoFKGwa5UFtbTBYAkpiFiP6fyd0rSwn1Fied2p4FqPGHiK3yAN8ucsoF5HX1fmouOcJCixwiC718l0DrBIPIcKG+n3fIHINtDF3fxkMIIkMn34QHoUuhyU2mmtjhv7JKmNeuSnPZYv5p4fPtkFV0lt4ut2OjsozXdyD9PKX1hn7Sjk5KkkaG86zM9AYpy25Bhjzv/NumH88FkU8I98++fNcdSIChMe3PiLV+KCxYkFng9+uYLO3EtF6zkE/qNABJ8Vp0A/pEm+5g0iNaNcQICILX3t4YF5fZaX6 vCgm2ztv 2UXkr52WhuzKD2/cfn4O7GNsg3Zjj1NRj+CE4tjRipLAoU8Vkmej1kkjJdMoYXn/HAhnzA0axzMvWjVy/6JAJ8UDPSNRNQ714GP9mgrXr8z91LEukjuxzEBV8ZTjXhbI7k39ZYklFiz6bJDL8D/pe32uIa5VZDUipzSPv6QARAZAxa7Y0CYlaGMkNyQXL1jW1t2LmtRQ2VLYz5mfIvP4t+Z4O/0Acb0di8jpbWxMGTASv2qeFcV6dSUjcaTuiDAyZUmBRHlEms7xoNluqLllYdHihinYzPw98BHKYDA5RV8FUkjhRFnWFEYbpbllyhj6csl8tfVE2zaFgQ4Xy2s4mgKq33yiEpVBfiLDos2itmAcUnQbx19Uav/teM9wcY2xThgGzL1lT9P8eAxiHv5gw3nVVyzCqx/pR+cfedcQ77hVE/6BsRwIZj68Udg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/25/24 13:37, Pankaj Raghav (Samsung) wrote: > From: Luis Chamberlain > > filemap_create_folio() and do_read_cache_folio() were always allocating > folio of order 0. __filemap_get_folio was trying to allocate higher > order folios when fgp_flags had higher order hint set but it will default > to order 0 folio if higher order memory allocation fails. > > Supporting mapping_min_order implies that we guarantee each folio in the > page cache has at least an order of mapping_min_order. When adding new > folios to the page cache we must also ensure the index used is aligned to > the mapping_min_order as the page cache requires the index to be aligned > to the order of the folio. > > Signed-off-by: Luis Chamberlain > Co-developed-by: Pankaj Raghav > Signed-off-by: Pankaj Raghav > --- > mm/filemap.c | 24 +++++++++++++++++------- > 1 file changed, 17 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich