From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40187C47258 for ; Wed, 31 Jan 2024 10:21:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6D076B008A; Wed, 31 Jan 2024 05:21:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF5616B008C; Wed, 31 Jan 2024 05:21:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96F246B0092; Wed, 31 Jan 2024 05:21:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8375C6B008A for ; Wed, 31 Jan 2024 05:21:53 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 22B10A21F6 for ; Wed, 31 Jan 2024 10:21:53 +0000 (UTC) X-FDA: 81739215306.17.19289F2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id DE3BA18000B for ; Wed, 31 Jan 2024 10:21:50 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qd9wuoH1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706696511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=73RrgumU4dTEdpu7qb4tr6nfAzM+QJQ7avPpro2/7XU=; b=mn76XmZPo3AQFNeFBEP11hnAid4lrO5yEQYynwfXc8fb5LzgRdbeuB+f2abChsbBfEhNvt 9d9ugF/x2kNIq5gAIwlDHQXfRisyjMwPhfyqqBcfCihv8lq1iyEX3pT031Fpuyk1mQMwv+ j5mT6lwGd6KwwXg7gWXLdtJ4sXlZf34= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qd9wuoH1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706696511; a=rsa-sha256; cv=none; b=DOPFqdZAtGYfQv9QwDUrqvwHHA41ORRMLzcQGxPJcNNoy1vMkf+PQ4Rvzd1A0K84ummXKg w005iIif6NYvZFJXSGtEV+gEOd49Mj0wHv+voP86feiX+dfezJAEOLHqs/nD7QJJXhPD2L bh+Zf26FUeKkQRaxDoZHxUyPYCw4hlI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706696510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=73RrgumU4dTEdpu7qb4tr6nfAzM+QJQ7avPpro2/7XU=; b=Qd9wuoH1QbGg/9Ad1QAdYwfCY7XlEqMrDOY4p9DHtpn0M77lEdLuPpI5DmC/QsKteknj1h mLjRcr6yH9BYNU2YTxo357Thx6/6oNIxPpeXxvkAeGiWdgZxr1eV7u3E2TNjMQSuSZ1b0B wU2KSKEuePbOzSOn0JWbRVn6zj4Ebds= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-360--iHbsIcpPmq9b1pJfP3j9g-1; Wed, 31 Jan 2024 05:21:48 -0500 X-MC-Unique: -iHbsIcpPmq9b1pJfP3j9g-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40e74860cb0so35612915e9.3 for ; Wed, 31 Jan 2024 02:21:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706696507; x=1707301307; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=73RrgumU4dTEdpu7qb4tr6nfAzM+QJQ7avPpro2/7XU=; b=B3FWEryxv5PUnUnaIYWce4bC7ATWHUzihcMMZ7D0g67Qaval8SpdEZphBvF7RoKj66 wY3Q6owJiB1OKqcPz69jcfsHtkZfJeJzb3r7nrS7O2hltHLnOWGqxxrOyMsTOK5Dm4v4 3aHPhzOeJjs/+8Or8VXMysa3sgWCwvR2/eMiyIMeevtNXUfUESqi+AQEy6rwbTcHHKDj Jzj/v5l/bjVwHPI/8t6ioipaUZI/4bIh7IXn8AYkP9IAtyYXSpsM+shVxq2mywh8nvMc 0E9RJ4vQD9e6fbIw6qLxlSfWNBCP0ElWxsgxX7st2BWWlS/9phRbDLniwP/OZvoVsvRI 3LcA== X-Gm-Message-State: AOJu0Yw9Bt+aMzkY+uo7tVUtsI07zbgEEX44ni8mknfBGPuJprlnxKML +LrJZLL3ZrgMHfDOCkoIEkjGaPW5PHodb5eAWDcigPn/KZBkpDXdthPaQ7eckoGEia6lhdPAYnq 4hkz+qXW9jJDQCweh9xpiMgtgDioT0aFaNzdGfwWd0Q8HcFJZ X-Received: by 2002:a05:600c:a52:b0:40e:fb93:96a8 with SMTP id c18-20020a05600c0a5200b0040efb9396a8mr1025149wmq.34.1706696507307; Wed, 31 Jan 2024 02:21:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IHm8H+S0GPo4hPZwIvn/3ceJOMxesbZa0lUxz7PX3mJ9EcmFB1akenvSvaaMhwHJInvhGC5ww== X-Received: by 2002:a05:600c:a52:b0:40e:fb93:96a8 with SMTP id c18-20020a05600c0a5200b0040efb9396a8mr1025123wmq.34.1706696506931; Wed, 31 Jan 2024 02:21:46 -0800 (PST) Received: from [10.32.64.237] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id j23-20020a05600c489700b0040e4733aecbsm1134749wmp.15.2024.01.31.02.21.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jan 2024 02:21:46 -0800 (PST) Message-ID: Date: Wed, 31 Jan 2024 11:21:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 9/9] mm/memory: optimize unmap/zap with PTE-mapped THP To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Catalin Marinas , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Michael Ellerman , Christophe Leroy , "Naveen N. Rao" , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Arnd Bergmann , linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org References: <20240129143221.263763-1-david@redhat.com> <20240129143221.263763-10-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DE3BA18000B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gjccqji73fzjx66mwkxeder4kboiqbfi X-HE-Tag: 1706696510-82761 X-HE-Meta: U2FsdGVkX1+DKnOZgCIwgVlOjUcMygR0JrBapdpD6yUb19qIx/q81n/CfUqc0LZeT3biyL34XJWfOGJYOjAq2t732iFHvXCh0tTzmHKElh7u+X/Kd5Opem90i+WWgPy3cZ+YdeUs7MBHIl3fmLmh7H5lR+30DvJ6l8f51f9LqyZgw1axzj+ZzBYbZ6tumnea9hMVGhHqmm/kQZHXdzHh0w4BsMsPBJWwsKUdOo0U9yHi/51RJaYzvW97J1LoJuuo2HRIZh89PnS10z8m/VKOVFtZtkltgXKAME2B7RIAYHJzndznupB65umpGhL6Pde3Y+6FuechfzkSGFxK64vax6J18HBHxSiKq0UiEsZitp1xZXF1UfAVyFH3/f1afVdwJ2qLefsf9NJjx1ZiF4QqWiM4kLDVxUDJN1CGNy3+SBG1heu6D+3A3UuSSKob7el/qmoOcIOAHewfWgR40T4/M9EOvtXah5ww6ueOK+n34QZ8lEp8tiLvFa+mlj3uCWPLHdlaHK6vcdPRNXa9TsVs7fI42WzCtFuh7FdnwKkwWk52i90KFq6fnyO7yrLY+az7D9Cv/swTKZjLJhrS/ZgLjyEQwp4Ddd4AK2yZAJwdiMs+0hOOxjhDitmlIN61i0jFPfB2WzxH8Dy0r95cMi5j2+wf4OzB5gq3fGt6cLzn72t/Ju/ar08tZAcW7zG4RcMi2ZYpe8TRaifPr3oUeFTiVLGbK3AG2hWzD6c9c7OXdWqOjgoYVJSB47Ho+Hg/tiq8jb8/8G+YoUTTM7gFfqvhNY3j713vA8MckGmNJZRrnumqHdec8RCB7wGzDwCQxWOpJLpQUz6cEf8n0SCbwzHeOWt4O3Ymuwljvrk/hwrxezKc/ExCcX/HqfqtMx1i6jdN/d3EffwI389qrDMtG7mTR7cHpbVaWOGDp9U8ogz95UISKFOfHSrghF9TJwRI9bS0jF+ml895LR0RiDmjLwt H8RZJ+HF KBPUq36JdrUw0v5fYELtlFmz7itZByEVwyasXc72US6HumLFncg8eXxSX2Zjf5WcXF3DU0n2mN2if7oUI+v8+PI9fxmcFbzoWwXjV1rFNtLnUv3HZzm7gKugJAuw3vJzbSMzAz9/mz/hZlB24hcUZ8jvp8THhJIuHCoRrsJuszvQT0RcG/uF78CTnFAv8oskOunD6B8CSAjJqlNQOklulLDl2aGgotyslUxw6fViXeoFrbu2/WTmwxGIFwvNmomAZLNGSIDK/szqkoHUOh04RDgRwPT2LAyZ3Dod0HKE57dDeMznrJChSM0Zxvy85ye8BOf0zBAI67S2q48UdFkbg/phJ4lIldbXOt5OcWgUgcwOXyeWAJMv8jPIW2loY4ftZbqXnNoCK/GQbQuYEF7ojYYaVmoiBY+zGM8DvC+dlUw9P99cdrJWIj5xmxC6mc23hUo61 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> + >> +#ifndef clear_full_ptes >> +/** >> + * clear_full_ptes - Clear PTEs that map consecutive pages of the same folio. > > I know its implied from "pages of the same folio" (and even more so for the > above variant due to mention of access/dirty), but I wonder if its useful to > explicitly state that "all ptes being cleared are present at the time of the call"? "Clear PTEs" -> "Clear present PTEs" ? That should make it clearer. [...] >> if (!delay_rmap) { >> - folio_remove_rmap_pte(folio, page, vma); >> + folio_remove_rmap_ptes(folio, page, nr, vma); >> + >> + /* Only sanity-check the first page in a batch. */ >> if (unlikely(page_mapcount(page) < 0)) >> print_bad_pte(vma, addr, ptent, page); > > Is there a case for either removing this all together or moving it into > folio_remove_rmap_ptes()? It seems odd to only check some pages. > I really wanted to avoid another nasty loop here. In my thinking, for 4k folios, or when zapping subpages of large folios, we still perform the exact same checks. Only when batching we don't. So if there is some problem, there are ways to get it triggered. And these problems are barely ever seen. folio_remove_rmap_ptes() feels like the better place -- especially because the delayed-rmap handling is effectively unchecked. But in there, we cannot "print_bad_pte()". [background: if we had a total mapcount -- iow cheap folio_mapcount(), I'd check here that the total mapcount does not underflow, instead of checking per-subpage] > >> } >> - if (unlikely(__tlb_remove_page(tlb, page, delay_rmap))) { >> + if (unlikely(__tlb_remove_folio_pages(tlb, page, nr, delay_rmap))) { >> *force_flush = true; >> *force_break = true; >> } >> } >> >> -static inline void zap_present_pte(struct mmu_gather *tlb, >> +/* >> + * Zap or skip one present PTE, trying to batch-process subsequent PTEs that map > > Zap or skip *at least* one... ? Ack -- Cheers, David / dhildenb