From: "Arnd Bergmann" <arnd@arndb.de>
To: "Vincenzo Frascino" <vincenzo.frascino@arm.com>,
linux-kernel@vger.kernel.org,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-mm@kvack.org
Cc: "Andy Lutomirski" <luto@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Naveen N Rao" <naveen@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, "Theodore Ts'o" <tytso@mit.edu>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH 3/9] x86: vdso: Introduce asm/vdso/page.h
Date: Wed, 04 Sep 2024 14:52:21 +0000 [thread overview]
Message-ID: <cfb5ea05-0322-492b-815d-17a4aad4da99@app.fastmail.com> (raw)
In-Reply-To: <20240903151437.1002990-4-vincenzo.frascino@arm.com>
On Tue, Sep 3, 2024, at 15:14, Vincenzo Frascino wrote:
> diff --git a/arch/x86/include/asm/vdso/page.h b/arch/x86/include/asm/vdso/page.h
> new file mode 100644
> index 000000000000..b0af8fbef27c
> --- /dev/null
> +++ b/arch/x86/include/asm/vdso/page.h
> @@ -0,0 +1,15 @@
> +
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __ASM_VDSO_PAGE_H
> +#define __ASM_VDSO_PAGE_H
> +
> +#ifndef __ASSEMBLY__
> +
> +#include <asm/page_types.h>
> +
> +#define VDSO_PAGE_MASK PAGE_MASK
> +#define VDSO_PAGE_SIZE PAGE_SIZE
> +
> +#endif /* !__ASSEMBLY__ */
> +
> +#endif /* __ASM_VDSO_PAGE_H */
I don't get this one: the x86 asm/page_types.h still includes other
headers outside of the vdso namespace, but you seem to only need these
two definitions that are the same across everything.
Why not put PAGE_MASK and PAGE_SIZE into a global vdso/page.h
header? I did spend a lot of time a few months ago ensuring that
we can have a single definition for all architectures based on
CONFIG_PAGE_SHIFT, so all the extra copies should just go away.
Arnd
next prev parent reply other threads:[~2024-09-04 14:52 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 15:14 [PATCH 0/9] vdso: Use only headers from the vdso/ namespace Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 1/9] x86: vdso: Introduce asm/vdso/mman.h Vincenzo Frascino
2024-09-03 15:16 ` Jason A. Donenfeld
2024-09-03 15:23 ` Vincenzo Frascino
2024-09-04 16:56 ` Christophe Leroy
2024-09-06 10:55 ` Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 2/9] vdso: Introduce vdso/mman.h Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 3/9] x86: vdso: Introduce asm/vdso/page.h Vincenzo Frascino
2024-09-04 14:52 ` Arnd Bergmann [this message]
2024-09-04 15:05 ` Christophe Leroy
2024-09-06 11:26 ` Vincenzo Frascino
2024-09-06 11:20 ` Vincenzo Frascino
2024-09-06 19:19 ` Arnd Bergmann
2024-09-06 18:40 ` Christophe Leroy
2024-09-08 20:48 ` Arnd Bergmann
2024-09-10 12:28 ` Christophe Leroy
2024-09-10 15:05 ` Arnd Bergmann
2024-09-04 17:14 ` Christophe Leroy
2024-09-03 15:14 ` [PATCH 4/9] vdso: Introduce vdso/page.h Vincenzo Frascino
2024-09-04 17:16 ` Christophe Leroy
2024-09-06 11:35 ` Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 5/9] vdso: Split linux/minmax.h Vincenzo Frascino
2024-09-04 17:17 ` Christophe Leroy
2024-09-04 17:23 ` Arnd Bergmann
2024-09-06 11:41 ` Vincenzo Frascino
2024-09-08 19:58 ` David Laight
2024-09-03 15:14 ` [PATCH 6/9] vdso: Split linux/array_size.h Vincenzo Frascino
2024-09-04 17:18 ` Christophe Leroy
2024-09-06 11:42 ` Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 7/9] x86: vdso: Modify asm/vdso/getrandom.h to include datapage Vincenzo Frascino
2024-09-04 17:19 ` Christophe Leroy
2024-09-06 11:48 ` Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 8/9] vdso: Modify vdso/getrandom.h to include the asm header Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 9/9] vdso: Modify getrandom to include the correct namespace Vincenzo Frascino
2024-09-04 17:26 ` Christophe Leroy
2024-09-06 11:52 ` Vincenzo Frascino
2024-09-06 12:04 ` Christophe Leroy
2024-09-06 12:40 ` Vincenzo Frascino
2024-09-06 12:49 ` Christophe Leroy
2024-09-06 12:51 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfb5ea05-0322-492b-815d-17a4aad4da99@app.fastmail.com \
--to=arnd@arndb.de \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).